runger_style 5.1.0 → 5.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dccf9a541e8c8fecee3ac2e58f2af64712b64b42d26082a03fe200d0bc8ca3a8
-  data.tar.gz: 864f847dc6eaaf64f9b5dc1c7688fc6b8c77b7b19ac439e53da6bccacd9d4d54
+  metadata.gz: cfa5836d617c931ac21c4cf90752707f525f5c6a876970e3ec39704fc1a39167
+  data.tar.gz: ba7b9d92318e2f52259b9e65db0a21426aa7b52c30a9fc22eb4e9162284d3e3d
 SHA512:
-  metadata.gz: 18aeee3a6f58039e1d00bbf3a73eeea93331e3dddf35e85e7838edb98f4d82ccbb089f546de08bede5e48c697d380794f8fb471f4ed9c35887f05055e5885d47
-  data.tar.gz: c98d787a96ce2043a713d98d93cbe9e4f316c289e01852b0c901fc15216d014bc6a6260376e2449ffa22743b5ab743123894f5bcf590391dbb50c02b41f48078
+  metadata.gz: b98075603c5d6b27cb87f4c357ce8097c76f405a4794a07d2e3e9273b71d38fa63a9d0b963eb28714ac3add2524a0fb5c9587d2704f26fa3785bb9a1aa9eb298
+  data.tar.gz: 484693246b8168a40f4407d195d65614b4f2e3f8aa79cfe0d48e6d61988524b10aacf52e639a0bec7ef3350b4d657837de705dce162638cbaae707233d2a0c05

data/.ruby-version

@@ -1 +1 @@
-3.4.1
+3.4.2

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## v5.3.0 (2025-02-16)
+- Disable `Rails/Delegate` cop.
+- Register `rubocop-rails` as a plugin (rather than requiring it).
+- Register `rubocop-performance` and `rubocop-rake` as plugins (rather than requiring them).
+
+## v5.2.0 (2025-02-16)
+- Disable `Metrics/CyclomaticComplexity` cop.
+- Monkeypatch `RuboCop::Cop::MultilineExpressionIndentation` to require (via `Layout/MultilineMethodCallIndentation`) the indentation of a chained multiline method call used as a method argument.
+- Change `Layout/MultilineMethodCallIndentation` `EnforcedStyle` from `indented` to `indented_relative_to_receiver`, monkeypatch `RuboCop::Cop::Layout::MultilineMethodCallIndentation`, and further monkeypatch `RuboCop::Cop::MultilineExpressionIndentation` in order to avoid undesirable `Layout/MultilineMethodCallIndentation` autocorrections.
+
 ## v5.1.0 (2025-02-12)
 - Monkeypatch `RuboCop::Cop::MultilineElementLineBreaks` so that arrays will be considered multiline if the array brackets are on separate lines (even if all elements are on a single line).
 

data/Gemfile.lock

@@ -9,9 +9,9 @@ GIT
 PATH
   remote: .
   specs:
-    runger_style (5.1.0)
+    runger_style (5.3.0)
       prism (>= 0.24.0)
-      rubocop (>= 1.68.0)
+      rubocop (>= 1.72.0)
 
 GEM
   remote: https://rubygems.org/
@@ -37,7 +37,7 @@ GEM
     concurrent-ruby (1.3.5)
     connection_pool (2.5.0)
     date (3.4.1)
-    diff-lcs (1.5.1)
+    diff-lcs (1.6.0)
     drb (2.2.1)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
@@ -48,7 +48,8 @@ GEM
       reline (>= 0.4.2)
     json (2.10.1)
     language_server-protocol (3.17.0.4)
-    logger (1.6.5)
+    lint_roller (1.1.0)
+    logger (1.6.6)
     memo_wise (1.10.0)
     method_source (1.1.0)
     minitest (5.25.4)
@@ -88,9 +89,10 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.2)
-    rubocop (1.71.2)
+    rubocop (1.72.1)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
@@ -104,16 +106,19 @@ GEM
       rubocop (~> 1.41)
     rubocop-factory_bot (2.26.1)
       rubocop (~> 1.61)
-    rubocop-performance (1.23.1)
-      rubocop (>= 1.48.1, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rails (2.29.1)
+    rubocop-performance (1.24.0)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rails (2.30.0)
       activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.52.0, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rake (0.6.0)
-      rubocop (~> 1.0)
+      rubocop (>= 1.72.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
     rubocop-rspec (3.4.0)
       rubocop (~> 1.61)
     rubocop-rspec_rails (2.30.0)
@@ -130,7 +135,7 @@ GEM
       slop (~> 4.8)
     securerandom (0.4.1)
     slop (4.10.1)
-    stringio (3.1.2)
+    stringio (3.1.3)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (3.1.4)
@@ -168,14 +173,15 @@ CHECKSUMS
   concurrent-ruby (1.3.5) sha256=813b3e37aca6df2a21a3b9f1d497f8cbab24a2b94cab325bffe65ee0f6cbebc6
   connection_pool (2.5.0) sha256=233b92f8d38e038c1349ccea65dd3772727d669d6d2e71f9897c8bf5cd53ebfc
   date (3.4.1) sha256=bf268e14ef7158009bfeaec40b5fa3c7271906e88b196d958a89d4b408abe64f
-  diff-lcs (1.5.1) sha256=273223dfb40685548436d32b4733aa67351769c7dea621da7d9dd4813e63ddfe
+  diff-lcs (1.6.0) sha256=a1e7f7b272962f8fc769358ad00001b87cdcf32ba349d6c70c6b544613d2da2e
   drb (2.2.1) sha256=e9d472bf785f558b96b25358bae115646da0dbfd45107ad858b0bc0d935cb340
   i18n (1.14.7) sha256=ceba573f8138ff2c0915427f1fc5bdf4aa3ab8ae88c8ce255eb3ecf0a11a5d0f
   io-console (0.8.0) sha256=cd6a9facbc69871d69b2cb8b926fc6ea7ef06f06e505e81a64f14a470fddefa2
   irb (1.15.1) sha256=d9bca745ac4207a8b728a52b98b766ca909b86ff1a504bcde3d6f8c84faae890
   json (2.10.1) sha256=ddc88ad91a1baf3f0038c174f253af3b086d30dc74db17ca4259bbde982f94dc
   language_server-protocol (3.17.0.4) sha256=c484626478664fd13482d8180947c50a8590484b1258b99b7aedb3b69df89669
-  logger (1.6.5) sha256=c3cfe56d01656490ddd103d38b8993d73d86296adebc5f58cefc9ec03741e56b
+  lint_roller (1.1.0) sha256=2c0c845b632a7d172cb849cc90c1bce937a28c5c8ccccb50dfd46a485003cc87
+  logger (1.6.6) sha256=dd618d24e637715472732e7eed02e33cfbdf56deaad225edd0f1f89d38024017
   memo_wise (1.10.0) sha256=ae40ff8e7799697ff5d59d739b8766f76be22eba69c7c8468edb42ab83c94c3f
   method_source (1.1.0) sha256=181301c9c45b731b4769bc81e8860e72f9161ad7d66dd99103c9ab84f560f5c5
   minitest (5.25.4) sha256=9cf2cae25ac4dfc90c988ebc3b917f53c054978b673273da1bd20bcb0778f947
@@ -199,29 +205,29 @@ CHECKSUMS
   rspec-expectations (3.13.3) sha256=0e6b5af59b900147698ea0ff80456c4f2e69cac4394fbd392fbd1ca561f66c58
   rspec-mocks (3.13.2) sha256=2327335def0e1665325a9b617e3af9ae20272741d80ac550336309a7c59abdef
   rspec-support (3.13.2) sha256=cea3a2463fd9b84b9dcc9685efd80ea701aa8f7b3decb3b3ce795ed67737dbec
-  rubocop (1.71.2) sha256=9a7b7501aac661a338ed7ff2a5eba78e581759e1f0d3c82362b2ca217ed3f97f
+  rubocop (1.72.1) sha256=4306ae64c6e7e1026d2a90ed755a113c7b9bf0ac21037b8046fbc826a87daaa5
   rubocop-ast (1.38.0) sha256=4fdf6792fe443a9a18acb12dbc8225d0d64cd1654e41fedb30e79c18edbb26ae
   rubocop-capybara (2.21.0) sha256=5d264efdd8b6c7081a3d4889decf1451a1cfaaec204d81534e236bc825b280ab
   rubocop-factory_bot (2.26.1) sha256=8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa
-  rubocop-performance (1.23.1) sha256=f22f86a795f5e6a6180aac2c6fc172534b173a068d6ed3396d6460523e051b82
-  rubocop-rails (2.29.1) sha256=41c2fcf48d5d62f4a5f574d5f1c97bbaf4cba88ee367936c98b3422d047b17aa
-  rubocop-rake (0.6.0) sha256=56b6f22189af4b33d4f4e490a555c09f1281b02f4d48c3a61f6e8fe5f401d8db
+  rubocop-performance (1.24.0) sha256=e5bd39ff3e368395b9af886927cc37f5892f43db4bd6c8526594352d5b4440b5
+  rubocop-rails (2.30.0) sha256=37d475c2cab768d1dfb07bee908ebdbc4814cfaa62f906d3e7adbcd7be01a33d
+  rubocop-rake (0.7.1) sha256=3797f2b6810c3e9df7376c26d5f44f3475eda59eb1adc38e6f62ecf027cbae4d
   rubocop-rspec (3.4.0) sha256=8721c13b6a8c9530a7ac481cea9423022f946fcf72428bda8289f8b57e4d4885
   rubocop-rspec_rails (2.30.0) sha256=888112e83f9d7ef7ad2397e9d69a0b9614a4bae24f072c399804a180f80c4c46
   ruby-progressbar (1.13.0) sha256=80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33
   runger_byebug (11.4.0) sha256=569e22ba2215f57e7f69e145fcb63be401e29fcd312f7936d813e12d0c7bbee6
   runger_release_assistant (2.0.0) sha256=f4f5708291eaeef1b881208f87a494877fe768739d6e96b7293fc335b28a3865
-  runger_style (5.1.0)
+  runger_style (5.3.0)
   securerandom (0.4.1) sha256=cc5193d414a4341b6e225f0cb4446aceca8e50d5e1888743fac16987638ea0b1
   slop (4.10.1) sha256=844322b5ffcf17ed4815fdb173b04a20dd82b4fd93e3744c88c8fafea696d9c7
-  stringio (3.1.2) sha256=204f1828f85cdb39d57cac4abc6dc44b04505a223f131587f2e20ae3729ba131
+  stringio (3.1.3) sha256=1eedb8369ee99a9a0edfdacea95c72d647feb8ce844427c150bd641e1797abc8
   tzinfo (2.0.6) sha256=8daf828cc77bcf7d63b0e3bdb6caa47e2272dcfaf4fbfe46f8c3a9df087a829b
   unicode-display_width (3.1.4) sha256=8caf2af1c0f2f07ec89ef9e18c7d88c2790e217c482bfc78aaa65eadd5415ac1
   unicode-emoji (4.0.4) sha256=2c2c4ef7f353e5809497126285a50b23056cc6e61b64433764a35eff6c36532a
   uri (1.0.2) sha256=b303504ceb7e5905771fa7fa14b649652fa949df18b5880d69cfb12494791e27
 
 RUBY VERSION
-   ruby 3.4.1p0
+   ruby 3.4.2p28
 
 BUNDLED WITH
-   2.6.2
+   2.6.3

data/bin/rspec

@@ -8,12 +8,12 @@
 # this file is here to facilitate running it.
 #
 
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
 
-bundle_binstub = File.expand_path("bundle", __dir__)
+bundle_binstub = File.expand_path('bundle', __dir__)
 
 if File.file?(bundle_binstub)
-  if File.read(bundle_binstub, 300).include?("This file was generated by Bundler")
+  if File.read(bundle_binstub, 300).include?('This file was generated by Bundler')
     load(bundle_binstub)
   else
     abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
@@ -21,7 +21,7 @@ Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this
   end
 end
 
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
-load Gem.bin_path("rspec-core", "rspec")
+load Gem.bin_path('rspec-core', 'rspec')

data/lib/runger_style/cops/multiline_method_arguments_line_breaks.rb

@@ -8,7 +8,6 @@ module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
     MSG = 'Each argument in a multi-line method call must start on a separate line.'
 
     # rubocop:disable Metrics/PerceivedComplexity
-    # rubocop:disable Metrics/CyclomaticComplexity
     def on_send(node)
       if node.arguments? && multiline_method_call?(node)
         # When a method call uses keyword arguments without braces,
@@ -35,7 +34,6 @@ module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
         end
       end
     end
-    # rubocop:enable Metrics/CyclomaticComplexity
     # rubocop:enable Metrics/PerceivedComplexity
 
     private

data/lib/runger_style/monkeypatches/multiline_expression_indentation.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module RungerStyle::MultilineExpressionIndentationPatches
+  private
+
+  def left_hand_side(lhs)
+    while (
+      lhs.parent&.call_type? &&
+      lhs.parent.loc.dot &&
+      !lhs.parent.assignment_method? &&
+      !(lhs.parent.parenthesized_call? && lhs.parent.arguments.include?(lhs))
+    )
+      lhs = lhs.parent
+    end
+
+    lhs
+  end
+
+  # Modified from https://github.com/rubocop/rubocop/blob/v1.72.1/lib/rubocop/cop/mixin/multiline_expression_indentation.rb#L194-L198.
+  def not_for_this_cop?(node)
+    node.ancestors.any? do |ancestor|
+      grouped_expression?(ancestor)
+    end
+  end
+end
+
+RuboCop::Cop::MultilineExpressionIndentation.prepend(
+  RungerStyle::MultilineExpressionIndentationPatches,
+)
+
+module RungerStyle::MultilineMethodCallIndentationPatches
+  private
+
+  def alignment_base(node, rhs, given_style)
+    case given_style
+    when :aligned
+      semantic_alignment_base(node, rhs) || syntactic_alignment_base(node, rhs)
+    when :indented
+      nil
+    when :indented_relative_to_receiver
+      if ([node] + node.ancestors).any? { |node| !node.parenthesized_call? }
+        nil
+      else
+        receiver_alignment_base(node)
+      end
+    end
+  end
+end
+
+RuboCop::Cop::Layout::MultilineMethodCallIndentation.prepend(
+  RungerStyle::MultilineMethodCallIndentationPatches,
+)

data/lib/runger_style/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RungerStyle
-  VERSION = '5.1.0'
+  VERSION = '5.3.0'
 end

data/rulesets/default.yml

@@ -56,7 +56,7 @@ Layout/LineLength:
     - !ruby/regexp /^ *(context|describe|it) ['"].*['"].* do$/
   Max: 100
 Layout/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
+  EnforcedStyle: indented_relative_to_receiver
 Layout/MultilineOperationIndentation:
   EnforcedStyle: indented
 Layout/RedundantLineBreak:
@@ -84,6 +84,8 @@ Metrics/BlockLength:
   Enabled: false
 Metrics/ClassLength:
   Enabled: false
+Metrics/CyclomaticComplexity:
+  Enabled: false
 Metrics/MethodLength:
   Max: 30
 Metrics/ModuleLength:

data/rulesets/performance.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-performance
 
 Performance/ChainArrayAllocation:

data/rulesets/rails.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-rails
 
 AllCops:
@@ -16,6 +16,8 @@ Rails/CreateTableWithTimestamps:
   Exclude:
     - !ruby/regexp /db/migrate/201[1-9].*\.rb\z/
     - db/schema.rb
+Rails/Delegate:
+  Enabled: false
 Rails/EnvironmentVariableAccess:
   AllowReads: true
 Rails/I18nLocaleTexts:

data/rulesets/rake.yml

@@ -1,2 +1,2 @@
-require:
+plugins:
   - rubocop-rake

data/runger_style.gemspec

@@ -34,5 +34,5 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = ">= #{required_ruby_version}"
 
   spec.add_dependency('prism', '>= 0.24.0')
-  spec.add_dependency('rubocop', '>= 1.68.0')
+  spec.add_dependency('rubocop', '>= 1.72.0')
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: runger_style
 version: !ruby/object:Gem::Version
-  version: 5.1.0
+  version: 5.3.0
 platform: ruby
 authors:
 - David Runger
 bindir: bin
 cert_chain: []
-date: 2025-02-13 00:00:00.000000000 Z
+date: 2025-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: prism
@@ -29,14 +29,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.68.0
+        version: 1.72.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.68.0
+        version: 1.72.0
 description: Shared rubocop rules for the preferred Ruby coding style of @davidrunger
 email:
 - davidjrunger@gmail.com
@@ -73,6 +73,7 @@ files:
 - lib/runger_style/cops/require_all_custom_cops.rb
 - lib/runger_style/cops/require_all_monkeypatches.rb
 - lib/runger_style/monkeypatches/multiline_element_line_breaks.rb
+- lib/runger_style/monkeypatches/multiline_expression_indentation.rb
 - lib/runger_style/version.rb
 - rulesets/capybara.yml
 - rulesets/default.yml
@@ -105,7 +106,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.3
 specification_version: 4
 summary: Shared rubocop rules for the preferred Ruby coding style of @davidrunger
 test_files: []