runger_style 5.1.0 → 5.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dccf9a541e8c8fecee3ac2e58f2af64712b64b42d26082a03fe200d0bc8ca3a8
-  data.tar.gz: 864f847dc6eaaf64f9b5dc1c7688fc6b8c77b7b19ac439e53da6bccacd9d4d54
+  metadata.gz: 5c1a9e8956388dd4c7bc41db41aecca76e135a97b5336b2fe8d80f746d739ae4
+  data.tar.gz: c66efecdc5226372bc5e793c4724455bbd3092e9105dd2ca484047e9cc8d2fcc
 SHA512:
-  metadata.gz: 18aeee3a6f58039e1d00bbf3a73eeea93331e3dddf35e85e7838edb98f4d82ccbb089f546de08bede5e48c697d380794f8fb471f4ed9c35887f05055e5885d47
-  data.tar.gz: c98d787a96ce2043a713d98d93cbe9e4f316c289e01852b0c901fc15216d014bc6a6260376e2449ffa22743b5ab743123894f5bcf590391dbb50c02b41f48078
+  metadata.gz: 1788c21bc096a894b9db2224036743be18127a3829d5b4aacd541ff12b8b049b6fe7e69ba47efe2c4222b91cee83575818f3c5a1224ba47c0ecc3574520dbffd
+  data.tar.gz: 335d216ad40429163a7c5aae3490be47f418798ec4a6c0a490b2aba85001af29296f11826c588180953925c0b302826688ea3297f5db50c1dacdb2c2fcd7d076

data/.ruby-version

@@ -1 +1 @@
-3.4.1
+3.4.2

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## v5.2.0 (2025-02-16)
+- Disable `Metrics/CyclomaticComplexity` cop.
+- Monkeypatch `RuboCop::Cop::MultilineExpressionIndentation` to require (via `Layout/MultilineMethodCallIndentation`) the indentation of a chained multiline method call used as a method argument.
+- Change `Layout/MultilineMethodCallIndentation` `EnforcedStyle` from `indented` to `indented_relative_to_receiver`, monkeypatch `RuboCop::Cop::Layout::MultilineMethodCallIndentation`, and further monkeypatch `RuboCop::Cop::MultilineExpressionIndentation` in order to avoid undesirable `Layout/MultilineMethodCallIndentation` autocorrections.
+
 ## v5.1.0 (2025-02-12)
 - Monkeypatch `RuboCop::Cop::MultilineElementLineBreaks` so that arrays will be considered multiline if the array brackets are on separate lines (even if all elements are on a single line).
 

data/Gemfile.lock

@@ -9,7 +9,7 @@ GIT
 PATH
   remote: .
   specs:
-    runger_style (5.1.0)
+    runger_style (5.2.0)
       prism (>= 0.24.0)
       rubocop (>= 1.68.0)
 
@@ -37,7 +37,7 @@ GEM
     concurrent-ruby (1.3.5)
     connection_pool (2.5.0)
     date (3.4.1)
-    diff-lcs (1.5.1)
+    diff-lcs (1.6.0)
     drb (2.2.1)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
@@ -48,7 +48,7 @@ GEM
       reline (>= 0.4.2)
     json (2.10.1)
     language_server-protocol (3.17.0.4)
-    logger (1.6.5)
+    logger (1.6.6)
     memo_wise (1.10.0)
     method_source (1.1.0)
     minitest (5.25.4)
@@ -130,7 +130,7 @@ GEM
       slop (~> 4.8)
     securerandom (0.4.1)
     slop (4.10.1)
-    stringio (3.1.2)
+    stringio (3.1.3)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (3.1.4)
@@ -168,14 +168,14 @@ CHECKSUMS
   concurrent-ruby (1.3.5) sha256=813b3e37aca6df2a21a3b9f1d497f8cbab24a2b94cab325bffe65ee0f6cbebc6
   connection_pool (2.5.0) sha256=233b92f8d38e038c1349ccea65dd3772727d669d6d2e71f9897c8bf5cd53ebfc
   date (3.4.1) sha256=bf268e14ef7158009bfeaec40b5fa3c7271906e88b196d958a89d4b408abe64f
-  diff-lcs (1.5.1) sha256=273223dfb40685548436d32b4733aa67351769c7dea621da7d9dd4813e63ddfe
+  diff-lcs (1.6.0) sha256=a1e7f7b272962f8fc769358ad00001b87cdcf32ba349d6c70c6b544613d2da2e
   drb (2.2.1) sha256=e9d472bf785f558b96b25358bae115646da0dbfd45107ad858b0bc0d935cb340
   i18n (1.14.7) sha256=ceba573f8138ff2c0915427f1fc5bdf4aa3ab8ae88c8ce255eb3ecf0a11a5d0f
   io-console (0.8.0) sha256=cd6a9facbc69871d69b2cb8b926fc6ea7ef06f06e505e81a64f14a470fddefa2
   irb (1.15.1) sha256=d9bca745ac4207a8b728a52b98b766ca909b86ff1a504bcde3d6f8c84faae890
   json (2.10.1) sha256=ddc88ad91a1baf3f0038c174f253af3b086d30dc74db17ca4259bbde982f94dc
   language_server-protocol (3.17.0.4) sha256=c484626478664fd13482d8180947c50a8590484b1258b99b7aedb3b69df89669
-  logger (1.6.5) sha256=c3cfe56d01656490ddd103d38b8993d73d86296adebc5f58cefc9ec03741e56b
+  logger (1.6.6) sha256=dd618d24e637715472732e7eed02e33cfbdf56deaad225edd0f1f89d38024017
   memo_wise (1.10.0) sha256=ae40ff8e7799697ff5d59d739b8766f76be22eba69c7c8468edb42ab83c94c3f
   method_source (1.1.0) sha256=181301c9c45b731b4769bc81e8860e72f9161ad7d66dd99103c9ab84f560f5c5
   minitest (5.25.4) sha256=9cf2cae25ac4dfc90c988ebc3b917f53c054978b673273da1bd20bcb0778f947
@@ -211,17 +211,17 @@ CHECKSUMS
   ruby-progressbar (1.13.0) sha256=80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33
   runger_byebug (11.4.0) sha256=569e22ba2215f57e7f69e145fcb63be401e29fcd312f7936d813e12d0c7bbee6
   runger_release_assistant (2.0.0) sha256=f4f5708291eaeef1b881208f87a494877fe768739d6e96b7293fc335b28a3865
-  runger_style (5.1.0)
+  runger_style (5.2.0)
   securerandom (0.4.1) sha256=cc5193d414a4341b6e225f0cb4446aceca8e50d5e1888743fac16987638ea0b1
   slop (4.10.1) sha256=844322b5ffcf17ed4815fdb173b04a20dd82b4fd93e3744c88c8fafea696d9c7
-  stringio (3.1.2) sha256=204f1828f85cdb39d57cac4abc6dc44b04505a223f131587f2e20ae3729ba131
+  stringio (3.1.3) sha256=1eedb8369ee99a9a0edfdacea95c72d647feb8ce844427c150bd641e1797abc8
   tzinfo (2.0.6) sha256=8daf828cc77bcf7d63b0e3bdb6caa47e2272dcfaf4fbfe46f8c3a9df087a829b
   unicode-display_width (3.1.4) sha256=8caf2af1c0f2f07ec89ef9e18c7d88c2790e217c482bfc78aaa65eadd5415ac1
   unicode-emoji (4.0.4) sha256=2c2c4ef7f353e5809497126285a50b23056cc6e61b64433764a35eff6c36532a
   uri (1.0.2) sha256=b303504ceb7e5905771fa7fa14b649652fa949df18b5880d69cfb12494791e27
 
 RUBY VERSION
-   ruby 3.4.1p0
+   ruby 3.4.2p28
 
 BUNDLED WITH
-   2.6.2
+   2.6.3

data/lib/runger_style/cops/multiline_method_arguments_line_breaks.rb

@@ -8,7 +8,6 @@ module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
     MSG = 'Each argument in a multi-line method call must start on a separate line.'
 
     # rubocop:disable Metrics/PerceivedComplexity
-    # rubocop:disable Metrics/CyclomaticComplexity
     def on_send(node)
       if node.arguments? && multiline_method_call?(node)
         # When a method call uses keyword arguments without braces,
@@ -35,7 +34,6 @@ module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
         end
       end
     end
-    # rubocop:enable Metrics/CyclomaticComplexity
     # rubocop:enable Metrics/PerceivedComplexity
 
     private

data/lib/runger_style/monkeypatches/multiline_expression_indentation.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module RungerStyle::MultilineExpressionIndentationPatches
+  private
+
+  def left_hand_side(lhs)
+    while (
+      lhs.parent&.call_type? &&
+      lhs.parent.loc.dot &&
+      !lhs.parent.assignment_method? &&
+      !(lhs.parent.parenthesized_call? && lhs.parent.arguments.include?(lhs))
+    )
+      lhs = lhs.parent
+    end
+
+    lhs
+  end
+
+  # Modified from https://github.com/rubocop/rubocop/blob/v1.72.1/lib/rubocop/cop/mixin/multiline_expression_indentation.rb#L194-L198.
+  def not_for_this_cop?(node)
+    node.ancestors.any? do |ancestor|
+      grouped_expression?(ancestor)
+    end
+  end
+end
+
+RuboCop::Cop::MultilineExpressionIndentation.prepend(
+  RungerStyle::MultilineExpressionIndentationPatches,
+)
+
+module RungerStyle::MultilineMethodCallIndentationPatches
+  private
+
+  def alignment_base(node, rhs, given_style)
+    case given_style
+    when :aligned
+      semantic_alignment_base(node, rhs) || syntactic_alignment_base(node, rhs)
+    when :indented
+      nil
+    when :indented_relative_to_receiver
+      if ([node] + node.ancestors).any? { |node| !node.parenthesized_call? }
+        nil
+      else
+        receiver_alignment_base(node)
+      end
+    end
+  end
+end
+
+RuboCop::Cop::Layout::MultilineMethodCallIndentation.prepend(
+  RungerStyle::MultilineMethodCallIndentationPatches,
+)

data/lib/runger_style/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RungerStyle
-  VERSION = '5.1.0'
+  VERSION = '5.2.0'
 end

data/rulesets/default.yml

@@ -56,7 +56,7 @@ Layout/LineLength:
     - !ruby/regexp /^ *(context|describe|it) ['"].*['"].* do$/
   Max: 100
 Layout/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
+  EnforcedStyle: indented_relative_to_receiver
 Layout/MultilineOperationIndentation:
   EnforcedStyle: indented
 Layout/RedundantLineBreak:
@@ -84,6 +84,8 @@ Metrics/BlockLength:
   Enabled: false
 Metrics/ClassLength:
   Enabled: false
+Metrics/CyclomaticComplexity:
+  Enabled: false
 Metrics/MethodLength:
   Max: 30
 Metrics/ModuleLength:

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: runger_style
 version: !ruby/object:Gem::Version
-  version: 5.1.0
+  version: 5.2.0
 platform: ruby
 authors:
 - David Runger
 bindir: bin
 cert_chain: []
-date: 2025-02-13 00:00:00.000000000 Z
+date: 2025-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: prism
@@ -73,6 +73,7 @@ files:
 - lib/runger_style/cops/require_all_custom_cops.rb
 - lib/runger_style/cops/require_all_monkeypatches.rb
 - lib/runger_style/monkeypatches/multiline_element_line_breaks.rb
+- lib/runger_style/monkeypatches/multiline_expression_indentation.rb
 - lib/runger_style/version.rb
 - rulesets/capybara.yml
 - rulesets/default.yml
@@ -105,7 +106,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.3
 specification_version: 4
 summary: Shared rubocop rules for the preferred Ruby coding style of @davidrunger
 test_files: []