runger_style 4.3.0 → 4.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e83262958db2e0d64aadbcb73ef166f767b69fdd411eeb08eb371c2d7d7eaa51
-  data.tar.gz: 9c78194fa3d0ec4cdc1401f76c1ca59a891d85dcdaa84259aa7184f6b9888209
+  metadata.gz: 7d93a58f1dc8dee8c45abc512c7b8cd6a76d2172b082c37ad0ac52436d53fa67
+  data.tar.gz: 154aed25e45f7d058343a082417d9085f54ac7600c6aa5b5ee310a306e4d6a02
 SHA512:
-  metadata.gz: 295c0dd93cb6203ced06556f166ddb7892ffa80cc0a39e464f4bf2f8b62db1d0583f345e9dc3d820c4630e87ac7c09447464e14f6d3486d259a048dcc1e6412f
-  data.tar.gz: 45dd01f6b850082ca2f9a63e5b0d6171f6e6f6fa0b3e689566ea6b12d1045164b5bdeeca16ebddaa8776d3a4978ddd3b89b8f46638439c0dd0103f502d592ae9
+  metadata.gz: de62008658319ebd6394e456a008bdf7f5499dec8014cac640de4dca6d242a215d66e64a74136084a2943fd5b66b11c5fb78c86c175658f14429867647c891df
+  data.tar.gz: cbfe82fdf632ef416680f39aa92fc2330c3b9a2f795c21bf47c1b6b7efb082364be5887b6d51513287533eff0fcc57123b9906ae16dae734002be8d6d2883e0c

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## v4.4.0 (2025-02-09)
+- Fix false negative for `RungerStyle/MultilineMethodArgumentsLineBreaks` with keyword arguments.
+- Disable `Style/Next`.
+
 ## v4.3.0 (2025-01-31)
 - Specify `EnforcedShorthandSyntax: always` for `Style/HashSyntax`.
 

data/Gemfile

@@ -9,6 +9,7 @@ gemspec
 group :development, :test do
   gem 'bundler'
   gem 'irb'
+  gem 'pry-byebug', github: 'davidrunger/pry-byebug'
   gem 'rake'
   gem 'rubocop'
   gem 'rubocop-performance'

data/Gemfile.lock

@@ -1,7 +1,15 @@
+GIT
+  remote: https://github.com/davidrunger/pry-byebug.git
+  revision: 3ac27ef70a1b16a461db9f7572d3fe1a205effd4
+  specs:
+    pry-byebug (3.10.1)
+      pry (>= 0.13)
+      runger_byebug (>= 11.0)
+
 PATH
   remote: .
   specs:
-    runger_style (4.3.0)
+    runger_style (4.4.0)
       prism (>= 0.24.0)
       rubocop (>= 1.68.0)
 
@@ -25,6 +33,7 @@ GEM
     base64 (0.2.0)
     benchmark (0.4.0)
     bigdecimal (3.1.9)
+    coderay (1.1.3)
     concurrent-ruby (1.3.5)
     connection_pool (2.5.0)
     date (3.4.1)
@@ -41,23 +50,27 @@ GEM
     language_server-protocol (3.17.0.4)
     logger (1.6.5)
     memo_wise (1.10.0)
+    method_source (1.1.0)
     minitest (5.25.4)
     parallel (1.26.3)
-    parser (3.3.7.0)
+    parser (3.3.7.1)
       ast (~> 2.4.1)
       racc
     pp (0.6.2)
       prettyprint
     prettyprint (0.2.0)
     prism (1.3.0)
+    pry (0.15.2)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
     psych (5.2.3)
       date
       stringio
     racc (1.8.1)
-    rack (3.1.8)
+    rack (3.1.9)
     rainbow (3.1.1)
     rake (13.2.1)
-    rdoc (6.11.0)
+    rdoc (6.12.0)
       psych (>= 4.0.0)
     regexp_parser (2.10.0)
     reline (0.6.0)
@@ -66,7 +79,7 @@ GEM
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.2)
+    rspec-core (3.13.3)
       rspec-support (~> 3.13.0)
     rspec-expectations (3.13.3)
       diff-lcs (>= 1.2.0, < 2.0)
@@ -75,14 +88,14 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.2)
-    rubocop (1.71.0)
+    rubocop (1.71.2)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.36.2, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
     rubocop-ast (1.38.0)
@@ -107,7 +120,10 @@ GEM
       rubocop (~> 1.61)
       rubocop-rspec (~> 3, >= 3.0.1)
     ruby-progressbar (1.13.0)
-    runger_release_assistant (1.0.0)
+    runger_byebug (11.4.0)
+      irb
+      reline
+    runger_release_assistant (2.0.0)
       activesupport (>= 6)
       memo_wise (>= 1.7)
       rainbow (>= 3.0)
@@ -128,6 +144,7 @@ PLATFORMS
 DEPENDENCIES
   bundler
   irb
+  pry-byebug!
   rake
   rspec
   rubocop
@@ -147,6 +164,7 @@ CHECKSUMS
   base64 (0.2.0) sha256=0f25e9b21a02a0cc0cea8ef92b2041035d39350946e8789c562b2d1a3da01507
   benchmark (0.4.0) sha256=0f12f8c495545e3710c3e4f0480f63f06b4c842cc94cec7f33a956f5180e874a
   bigdecimal (3.1.9) sha256=2ffc742031521ad69c2dfc815a98e426a230a3d22aeac1995826a75dabfad8cc
+  coderay (1.1.3) sha256=dc530018a4684512f8f38143cd2a096c9f02a1fc2459edcfe534787a7fc77d4b
   concurrent-ruby (1.3.5) sha256=813b3e37aca6df2a21a3b9f1d497f8cbab24a2b94cab325bffe65ee0f6cbebc6
   connection_pool (2.5.0) sha256=233b92f8d38e038c1349ccea65dd3772727d669d6d2e71f9897c8bf5cd53ebfc
   date (3.4.1) sha256=bf268e14ef7158009bfeaec40b5fa3c7271906e88b196d958a89d4b408abe64f
@@ -159,26 +177,29 @@ CHECKSUMS
   language_server-protocol (3.17.0.4) sha256=c484626478664fd13482d8180947c50a8590484b1258b99b7aedb3b69df89669
   logger (1.6.5) sha256=c3cfe56d01656490ddd103d38b8993d73d86296adebc5f58cefc9ec03741e56b
   memo_wise (1.10.0) sha256=ae40ff8e7799697ff5d59d739b8766f76be22eba69c7c8468edb42ab83c94c3f
+  method_source (1.1.0) sha256=181301c9c45b731b4769bc81e8860e72f9161ad7d66dd99103c9ab84f560f5c5
   minitest (5.25.4) sha256=9cf2cae25ac4dfc90c988ebc3b917f53c054978b673273da1bd20bcb0778f947
   parallel (1.26.3) sha256=d86babb7a2b814be9f4b81587bf0b6ce2da7d45969fab24d8ae4bf2bb4d4c7ef
-  parser (3.3.7.0) sha256=7449011771e3e7881297859b849de26a6f4fccd515bece9520a87e7d2116119b
+  parser (3.3.7.1) sha256=7dbe61618025519024ac72402a6677ead02099587a5538e84371b76659e6aca1
   pp (0.6.2) sha256=947ec3120c6f92195f8ee8aa25a7b2c5297bb106d83b41baa02983686577b6ff
   prettyprint (0.2.0) sha256=2bc9e15581a94742064a3cc8b0fb9d45aae3d03a1baa6ef80922627a0766f193
   prism (1.3.0) sha256=b11620829831b1cb7e6c9b46c81ff8a6e36ccb3f888f164485eb7351f386273a
+  pry (0.15.2) sha256=12d54b8640d3fa29c9211dd4ffb08f3fd8bf7a4fd9b5a73ce5b59c8709385b6b
+  pry-byebug (3.10.1)
   psych (5.2.3) sha256=84a54bb952d14604fea22d99938348814678782f58b12648fcdfa4d2fce859ee
   racc (1.8.1) sha256=4a7f6929691dbec8b5209a0b373bc2614882b55fc5d2e447a21aaa691303d62f
-  rack (3.1.8) sha256=d3fbcbca43dc2b43c9c6d7dfbac01667ae58643c42cea10013d0da970218a1b1
+  rack (3.1.9) sha256=3d0a390444dcc753ced32978159463f92ac920ae28d7058b6fd633abb9dd349d
   rainbow (3.1.1) sha256=039491aa3a89f42efa1d6dec2fc4e62ede96eb6acd95e52f1ad581182b79bc6a
   rake (13.2.1) sha256=46cb38dae65d7d74b6020a4ac9d48afed8eb8149c040eccf0523bec91907059d
-  rdoc (6.11.0) sha256=bec66fb9b019be64f7ba7d2cd2aecb283a3a01fef23a95b33e2349c6d1aa0040
+  rdoc (6.12.0) sha256=7d6f706e070bffa5d18a448f24076cbfb34923a99c1eab842aa18e6ca69f56e0
   regexp_parser (2.10.0) sha256=cb6f0ddde88772cd64bff1dbbf68df66d376043fe2e66a9ef77fcb1b0c548c61
   reline (0.6.0) sha256=57620375dcbe56ec09bac7192bfb7460c716bbf0054dc94345ecaa5438e539d2
   rspec (3.13.0) sha256=d490914ac1d5a5a64a0e1400c1d54ddd2a501324d703b8cfe83f458337bab993
-  rspec-core (3.13.2) sha256=94fbda6e4738e478f1c7532b7cc241272fcdc8b9eac03a97338b1122e4573300
+  rspec-core (3.13.3) sha256=25136507f4f9cf2e8977a2851e64e438b4331646054e345998714108745cdfe4
   rspec-expectations (3.13.3) sha256=0e6b5af59b900147698ea0ff80456c4f2e69cac4394fbd392fbd1ca561f66c58
   rspec-mocks (3.13.2) sha256=2327335def0e1665325a9b617e3af9ae20272741d80ac550336309a7c59abdef
   rspec-support (3.13.2) sha256=cea3a2463fd9b84b9dcc9685efd80ea701aa8f7b3decb3b3ce795ed67737dbec
-  rubocop (1.71.0) sha256=e19679efd447346ac476122313d3788ae23c38214790bcf660e984c747608bf0
+  rubocop (1.71.2) sha256=9a7b7501aac661a338ed7ff2a5eba78e581759e1f0d3c82362b2ca217ed3f97f
   rubocop-ast (1.38.0) sha256=4fdf6792fe443a9a18acb12dbc8225d0d64cd1654e41fedb30e79c18edbb26ae
   rubocop-capybara (2.21.0) sha256=5d264efdd8b6c7081a3d4889decf1451a1cfaaec204d81534e236bc825b280ab
   rubocop-factory_bot (2.26.1) sha256=8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa
@@ -188,8 +209,9 @@ CHECKSUMS
   rubocop-rspec (3.4.0) sha256=8721c13b6a8c9530a7ac481cea9423022f946fcf72428bda8289f8b57e4d4885
   rubocop-rspec_rails (2.30.0) sha256=888112e83f9d7ef7ad2397e9d69a0b9614a4bae24f072c399804a180f80c4c46
   ruby-progressbar (1.13.0) sha256=80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33
-  runger_release_assistant (1.0.0) sha256=03b7a57db1907765a443d321ad1805705067012046f78f87e18260a379565286
-  runger_style (4.3.0)
+  runger_byebug (11.4.0) sha256=569e22ba2215f57e7f69e145fcb63be401e29fcd312f7936d813e12d0c7bbee6
+  runger_release_assistant (2.0.0) sha256=f4f5708291eaeef1b881208f87a494877fe768739d6e96b7293fc335b28a3865
+  runger_style (4.4.0)
   securerandom (0.4.1) sha256=cc5193d414a4341b6e225f0cb4446aceca8e50d5e1888743fac16987638ea0b1
   slop (4.10.1) sha256=844322b5ffcf17ed4815fdb173b04a20dd82b4fd93e3744c88c8fafea696d9c7
   stringio (3.1.2) sha256=204f1828f85cdb39d57cac4abc6dc44b04505a223f131587f2e20ae3729ba131

data/lib/runger_style/cops/multiline_method_arguments_line_breaks.rb

@@ -7,28 +7,42 @@ module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
 
     MSG = 'Each argument in a multi-line method call must start on a separate line.'
 
+    # rubocop:disable Metrics/PerceivedComplexity
+    # rubocop:disable Metrics/CyclomaticComplexity
     def on_send(node)
-      return if node.arguments.size <= 1
-      return unless node.parenthesized?
-      return unless multiline_parentheses?(node)
-
-      node.arguments.each_cons(2) do |arg1, arg2|
-        next unless same_line?(arg1, arg2)
-
-        separator = separator_range(arg1, arg2)
-
-        add_offense(separator, message: MSG) do |corrector|
-          base_indent = base_indentation(arg1)
-          replacement = ",\n#{base_indent}"
-          corrector.replace(separator, replacement)
+      if node.arguments? && multiline_method_call?(node)
+        # When a method call uses keyword arguments without braces,
+        # the parser produces a single hash node. In that case, inspect its pairs.
+        arguments =
+          if node.arguments.one? &&
+              node.arguments.first.hash_type? &&
+              !node.arguments.first.braces?
+            node.arguments.first.pairs
+          else
+            node.arguments
+          end
+
+        arguments.each_cons(2) do |arg1, arg2|
+          if same_line?(arg1, arg2)
+            separator = separator_range(arg1, arg2)
+
+            add_offense(separator, message: MSG) do |corrector|
+              base_indent = base_indentation(arg1)
+              replacement = ",\n#{base_indent}"
+              corrector.replace(separator, replacement)
+            end
+          end
         end
       end
     end
+    # rubocop:enable Metrics/CyclomaticComplexity
+    # rubocop:enable Metrics/PerceivedComplexity
 
     private
 
-    def multiline_parentheses?(node)
-      node.loc.begin.line != node.loc.end.line
+    def multiline_method_call?(node)
+      # Compare the line of the method name (selector) to the end line of the last argument.
+      node.loc.selector.line != node.arguments.last.loc.last_line
     end
 
     def same_line?(arg1, arg2)
@@ -40,9 +54,7 @@ module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
     end
 
     def separator_range(arg1, arg2)
-      end_pos = arg1.source_range.end.end_pos
-      begin_pos = arg2.source_range.begin.begin_pos
-      range_between(end_pos, begin_pos)
+      range_between(arg1.source_range.end_pos, arg2.source_range.begin_pos)
     end
   end
 end

data/lib/runger_style/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RungerStyle
-  VERSION = '4.3.0'
+  VERSION = '4.4.0'
 end

data/rulesets/default.yml

@@ -218,6 +218,8 @@ Style/MultilineMethodSignature:
   Enabled: false
 Style/NegatedIf:
   Enabled: false
+Style/Next:
+  Enabled: false
 Style/NumericPredicate:
   Enabled: false
 Style/ParenthesesAroundCondition:

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: runger_style
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 4.4.0
 platform: ruby
 authors:
 - David Runger
 bindir: bin
 cert_chain: []
-date: 2025-01-31 00:00:00.000000000 Z
+date: 2025-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: prism