rundoc 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: da3a985092d1a4964518696470e3caffbccfa38fb4c77babd3bb9db3019574f8
-  data.tar.gz: b10a337ee209e1b915b2bbd806c5e20a39919bb4768e015f3cd3b9ced7690608
+  metadata.gz: 0e767697a50da725490c5a2af1dd2a8ef894c9fa79e8260230ec2a41000ffefa
+  data.tar.gz: b682ac2f59204b1a62edd00f46817c27a63c58a95c87fd312803d42a6dd7b668
 SHA512:
-  metadata.gz: 67f0fc97aabfb49844520018ec31b94ffa9d99472115a1c4d32f19a9f4d352c2474e5b3120769000322b042fb7ac8ea302170c0fc6632e178f2760b1d4ef6ae3
-  data.tar.gz: 04bf8538b5087638a5ff731154ea5c5c3c189bd8ea321d0d2b7690acb604e4a7120dd1adf0f9566fe91c225b9a7e0a634cb642de16e0919c3fedf43e893c12b6
+  metadata.gz: cee0548716aa1cd4bb14f1eb21541dc010f5d8c706de49240b9e3245d847fbdfc08c34858a5ba7755d45d091671f3c712bd02a4d91e561927cae3b114780fd7f
+  data.tar.gz: aa340da522f964e0daeb3e7fd3b03bb340ecbe062a18c456474f00392ce660d0f28afdf427c99812013d4765b362e1bc11d1585330c8653118d1b8d0edd97d76

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## master
 
+## 1.1.1
+
+- Fix log read race condition (https://github.com/schneems/rundoc/pull/25)
+
 ## 1.1.0
 
 - Pipe logic is now implemented through a parser (https://github.com/schneems/rundoc/pull/22)

data/lib/rundoc/code_command/background/process_spawn.rb

@@ -48,9 +48,9 @@ class Rundoc::CodeCommand::Background
     def initialize(command , timeout: 5, log: Tempfile.new("log"), out: "2>&1")
       @command = command
       @timeout_value = timeout
-      @log           = log
+      @log_reference = log # https://twitter.com/schneems/status/1285289971083907075
 
-      @log = Pathname.new(@log)
+      @log = Pathname.new(log)
       @log.dirname.mkpath
       FileUtils.touch(@log)
 

data/lib/rundoc/code_command/background/start.rb

@@ -26,9 +26,6 @@ class Rundoc::CodeCommand::Background
       @spawn.wait(@wait)
       @spawn.check_alive! unless @allow_fail
 
-      # WTF BBQ SAUCE
-      FileUtils.touch(@spawn.log)
-
       @spawn.log.read
     end
 

data/lib/rundoc/version.rb

@@ -1,3 +1,3 @@
 module Rundoc
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/test/rundoc/code_commands/background_test.rb

@@ -1,6 +1,32 @@
 require 'test_helper'
 
 class BackgroundTest < Minitest::Test
+  def test_process_spawn_gc
+    Dir.mktmpdir do |dir|
+      Dir.chdir(dir) do
+        file = "foo.txt"
+        `echo 'foo' >> #{file}`
+
+        background_start = Rundoc::CodeCommand::Background::Start.new("tail -f #{file}",
+          name: "tail2",
+          wait: "f"
+        )
+
+        GC.start
+
+        output = background_start.call
+
+        assert_match("foo", output)
+        assert_equal(true, background_start.alive?)
+
+        background_stop = Rundoc::CodeCommand::Background::Stop.new(name: "tail2")
+        background_stop.call
+
+        assert_equal(false, background_start.alive?)
+      end
+    end
+  end
+
   def test_background_start
     Dir.mktmpdir do |dir|
       Dir.chdir(dir) do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rundoc
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Richard Schneeman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-19 00:00:00.000000000 Z
+date: 2020-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor