runcoderun-gem_sync 1.3.3 → 1.4.0

data/VERSION

@@ -1 +1 @@
-1.3.3
+1.4.0

data/examples/rcr/gem_sync_example.rb

@@ -154,16 +154,17 @@ EOL
   
   describe "read gem list" do
     it "should read the gem list" do
-      gem_sync = Rcr::GemSync.new(["--github"])
+      gem_sync = Rcr::GemSync.new(["--github"]) 
       gem_sync.expects(:open).with(Rcr::GemSync::RCR_GITHUB_GEM_LIST).returns(StringIO.new)
       gem_sync.read_gem_list
     end
   end
   
-  describe "wtf" do
-    it "installs versions of stuff" do
+  describe "regressions" do
+    it "installs specific version of rails, even if there is that specific version installed for a different gem" do
       gem_sync = Rcr::GemSync.new(["--github"])
       installed_gems = <<EOL
+some-other-gem (2.2.2)
 rails (2.3.4, 2.3.2, 2.1.2, 2.1.1, 2.1.0, 2.0.4, 2.0.2, 1.2.6, 1.2.5, 1.2.2, 1.2.1)
 relevance-multi_rails (0.0.8)
 remarkable_rails (3.1.10)

data/gem_sync.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{gem_sync}
-  s.version = "1.3.3"
+  s.version = "1.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Rob Sanheim"]

data/lib/rcr/gem_sync.rb

@@ -62,17 +62,17 @@ module Rcr
       install_from_rubyforge(rubygem) || install_from_github(rubygem)
     end
     
-    def gem_installed?(name)
-      installed_gems.any? { |installed| installed.name == name }
+    def gem_installed?(requested)
+      installed_gems.any? { |installed| installed.name == requested.name }
     end
     
-    def gem_version_installed?(version)
-      return true if version.nil?
-      installed_gems.any? { |installed| installed.version == version }
+    def gem_version_installed?(requested)
+      return true if requested.version.nil?
+      installed_gems.select { |gem| gem.name == requested.name }.any? { |gem| gem.version == requested.version }
     end
     
     def installed?(requested)
-      result = gem_installed?(requested.name) && gem_version_installed?(requested.version)
+      result = gem_installed?(requested) && gem_version_installed?(requested)
       puts "Skipping installation of #{requested.name} #{requested.version}, as its already installed" if verbose? && result
       result
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: runcoderun-gem_sync
 version: !ruby/object:Gem::Version 
-  version: 1.3.3
+  version: 1.4.0
 platform: ruby
 authors: 
 - Rob Sanheim