runcible 1.2.0 → 1.3.0

data/lib/runcible/extensions/yum_repo_metadata_file.rb

@@ -21,15 +21,12 @@
 # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-
 module Runcible
   module Extensions
     class YumRepoMetadataFile < Runcible::Extensions::Unit
-
       def self.content_type
         'yum_repo_metadata_file'
       end
-
     end
   end
 end

data/lib/runcible/instance.rb

@@ -23,14 +23,14 @@
 
 module Runcible
   class Instance
-
+    # rubocop:disable Style/ClassVars
     def self.resource_classes
-      @@resource_classes ||= gather_classes("resources")
+      @@resource_classes ||= gather_classes('resources')
       @@resource_classes
     end
 
     def self.extension_classes
-      @@extension_classes ||= gather_classes("extensions")
+      @@extension_classes ||= gather_classes('extensions')
       @@extension_classes
     end
 
@@ -46,22 +46,22 @@ module Runcible
     # @option config [String]  :url  Scheme and hostname for the pulp server e.g. https://localhost/
     # @option config [String]  :api_path URL path for the api e.g. pulp/api/v2/
     # @option config [String]  :timeout Timeout in seconds for the connection (defaults to rest client's default)
-    # @option config [String]  :open_timeout timeout in seconds for the connection to open(defaults to rest client's default)
+    # @option config [String]  :open_timeout timeout in seconds for the connection
+    #                           to open(defaults to rest client's default)
     # @option config [Hash]    :http_auth Needed when using simple http auth
     # @option http_auth [String] :password The password to use for simple auth
-    def initialize(config={})
+    def initialize(config = {})
       @config = {
-              :api_path   => '/pulp/api/v2/',
-              :url        => 'https://localhost',
-              :user       => '',
-              :http_auth  => {:password => {} },
-              :headers    => {:content_type => 'application/json',
-                              :accept       => 'application/json'},
-              :logging    => {}
-            }.merge(config).with_indifferent_access
-
-
-      initialize_wrappers(config)
+        :api_path   => '/pulp/api/v2/',
+        :url        => 'https://localhost',
+        :user       => '',
+        :http_auth  => {:password => {} },
+        :headers    => {:content_type => 'application/json',
+                        :accept       => 'application/json'},
+        :logging    => {}
+      }.merge(config).with_indifferent_access
+
+      initialize_wrappers
     end
 
     # Update an existing config value
@@ -71,13 +71,11 @@ module Runcible
       @config[key] = value
     end
 
-    def config
-      @config
-    end
+    attr_reader :config
 
     private
 
-    def initialize_wrappers(config)
+    def initialize_wrappers
       self.resources = Wrapper.new('resources')
       self.extensions = Wrapper.new('extensions')
 
@@ -95,22 +93,20 @@ module Runcible
     def accessible_class(class_object)
       #converts a class (Runcible::Resources::ConsumerGroup) to a user friendly name:
       #  (e.g. consumer_group)
-      class_object.name.split("::").last.underscore
+      class_object.name.split('::').last.underscore
     end
 
     def self.gather_classes(type)
       const = Runcible
       const = const.const_get(type.camelize)
       path = File.dirname(__FILE__) + "/#{type}/*.rb"
-      base_names = Dir.glob(path).collect{|f| File.basename(f, '.rb')  }
-      classes = base_names.collect{|name| const.const_get(name.camelize)}
+      base_names = Dir.glob(path).map { |f| File.basename(f, '.rb')  }
+      base_names.map { |name| const.const_get(name.camelize) }
     end
-
   end
 
   #Wrapper class to provide access to instances
   class Wrapper
-
     def initialize(name)
       @name = name
       @methods = []
@@ -122,9 +118,7 @@ module Runcible
     end
 
     def to_s
-      "#{@name} - #{@methods.uniq.sort.to_s}"
+      "#{@name} - #{@methods.uniq.sort}"
     end
   end
-
 end
-

data/lib/runcible/models/distributor.rb

@@ -29,10 +29,10 @@ module Runcible
     class Distributor
       attr_accessor 'auto_publish', 'id'
 
-      def initialize(params={})
+      def initialize(params = {})
         @auto_publish = false
-        id = params[:id] || SecureRandom.hex(10)
-        params.each{|k,v| send("#{k.to_s}=",v)}
+        self.id = params[:id] || SecureRandom.hex(10)
+        params.each { |k, v| send("#{k}=", v) }
       end
 
       # Distributor Type id
@@ -43,9 +43,8 @@ module Runcible
       end
 
       def self.type_id
-        raise NotImplementedError("self.type_id")
+        fail NotImplementedError('self.type_id')
       end
-
     end
   end
 end

data/lib/runcible/models/docker_distributor.rb

@@ -28,10 +28,10 @@ module Runcible
   module Models
     class DockerDistributor < Distributor
       #optional
-      attr_accessor "docker_publish_directory", "protected",
-                    "redirect_url",  "repo_registry_id"
+      attr_accessor 'docker_publish_directory', 'protected',
+                    'redirect_url',  'repo_registry_id'
 
-      def initialize(params={})
+      def initialize(params = {})
         super(params)
       end
 
@@ -47,4 +47,4 @@ module Runcible
       end
     end
   end
-end
+end

data/lib/runcible/models/docker_importer.rb

@@ -27,8 +27,8 @@ module Runcible
       ID = 'docker_importer'
       REPO_TYPE = 'docker-repo'
 
-      attr_accessor 'feed', 'max_speed','max_downloads', 'upstream_name',
-                    'proxy_port', 'proxy_password', 'proxy_username', "mask_id"
+      attr_accessor 'feed', 'max_speed', 'max_downloads', 'upstream_name',
+                    'proxy_port', 'proxy_password', 'proxy_username', 'mask_id'
 
       def id
         DockerImporter::ID

data/lib/runcible/models/export_distributor.rb

@@ -28,7 +28,7 @@ module Runcible
   module Models
     class ExportDistributor < Distributor
       #required
-      attr_accessor "http", "https"
+      attr_accessor 'http', 'https'
 
       # Instantiates a export distributor
       #

data/lib/runcible/models/importer.rb

@@ -24,17 +24,14 @@
 require 'active_support/core_ext/hash'
 require 'active_support/json'
 
-
 module Runcible
   module Models
-
-    # Generic class to represent Pulp Importers 
+    # Generic class to represent Pulp Importers
     # Child classes should supply id & config methods
     class Importer
-      def initialize(params={})
-        params.each{|k,v| send("#{k.to_s}=",v)}
+      def initialize(params = {})
+        params.each { |k, v| send("#{k}=", v) }
       end
     end
-
   end
 end

data/lib/runcible/models/iso_distributor.rb

@@ -28,17 +28,17 @@ module Runcible
   module Models
     class IsoDistributor < Distributor
       #required
-      attr_accessor "serve_http", "serve_https"
+      attr_accessor 'serve_http', 'serve_https'
 
       # Instantiates an iso distributor
       #
       # @param  [boolean]         http  serve the contents over http
       # @param  [boolean]         https serve the contents over https
       # @return [Runcible::Extensions::IsoDistributor]
-      def initialize(http, https)
+      def initialize(http, https, options = {})
         @serve_http = http
         @serve_https = https
-        super({})
+        super(options)
       end
 
       # Distributor Type id

data/lib/runcible/models/iso_importer.rb

@@ -41,7 +41,7 @@ module Runcible
       #
       # @return [Hash]
       def config
-          as_json
+        as_json
       end
     end
   end

data/lib/runcible/models/nodes_http_distributor.rb

@@ -27,7 +27,6 @@ require 'securerandom'
 module Runcible
   module Models
     class NodesHttpDistributor < Distributor
-
       # Instantiates an nodes distributor
       #
       # @param  [Hash]         params  Distributor options

data/lib/runcible/models/puppet_distributor.rb

@@ -29,7 +29,7 @@ module Runcible
     class PuppetDistributor < Distributor
       attr_accessor 'serve_http', 'serve_https', 'http_dir', 'https_dir', 'absolute_path'
 
-      def initialize(absolute_path, http, https, params={})
+      def initialize(absolute_path, http, https, params = {})
         @absolute_path = absolute_path
         @serve_http = http
         @serve_https = https
@@ -48,4 +48,4 @@ module Runcible
       end
     end
   end
-end
+end

data/lib/runcible/models/yum_clone_distributor.rb

@@ -29,11 +29,10 @@ module Runcible
     # Requires the pulp-katello-plugins
     #  https://github.com/Katello/pulp-katello-plugins
     class YumCloneDistributor < Distributor
-
       #optional
-      attr_accessor "source_repo_id", "source_distributor_id", "destination_distributor_id"
+      attr_accessor 'source_repo_id', 'source_distributor_id', 'destination_distributor_id'
 
-      def initialize(params={})
+      def initialize(params = {})
         super(params)
       end
 
@@ -49,4 +48,4 @@ module Runcible
       end
     end
   end
-end
+end

data/lib/runcible/models/yum_distributor.rb

@@ -28,14 +28,14 @@ module Runcible
   module Models
     class YumDistributor < Distributor
       #required
-      attr_accessor "relative_url", "http", "https"
+      attr_accessor 'relative_url', 'http', 'https'
       #optional
-      attr_accessor "protected", "auth_cert", "auth_ca",
-                    "https_ca", "gpgkey", "generate_metadata",
-                    "checksum_type", "skip", "https_publish_dir", "http_publish_dir"
+      attr_accessor 'protected', 'auth_cert', 'auth_ca',
+                    'https_ca', 'gpgkey', 'generate_metadata',
+                    'checksum_type', 'skip', 'https_publish_dir', 'http_publish_dir'
 
-      def initialize(relative_url, http, https, params={})
-        @relative_url=relative_url
+      def initialize(relative_url, http, https, params = {})
+        @relative_url = relative_url
         @http = http
         @https = https
         super(params)
@@ -53,4 +53,4 @@ module Runcible
       end
     end
   end
-end
+end

data/lib/runcible/models/yum_importer.rb

@@ -24,26 +24,26 @@
 module Runcible
   module Models
     class YumImporter < Importer
-        ID = 'yum_importer'
-        REPO_TYPE = 'rpm-repo'
+      ID = 'yum_importer'
+      REPO_TYPE = 'rpm-repo'
 
-        #https://github.com/pulp/pulp/blob/master/rpm-support/plugins/importers/yum_importer/importer.py
-        attr_accessor 'feed', 'ssl_verify', 'ssl_ca_cert', 'ssl_client_cert', 'ssl_client_key',
-                      'proxy_url', 'proxy_port', 'proxy_pass', 'proxy_user',
-                      'max_speed', 'verify_size', 'verify_checksum', 'num_threads',
-                      'newest', 'remove_old', 'num_old_packages', 'purge_orphaned', 'skip', 'checksum_type',
-                      'num_retries', 'retry_delay'
-        def id
-          YumImporter::ID
-        end
+      #https://github.com/pulp/pulp/blob/master/rpm-support/plugins/importers/yum_importer/importer.py
+      attr_accessor 'feed', 'ssl_verify', 'ssl_ca_cert', 'ssl_client_cert', 'ssl_client_key',
+                    'proxy_url', 'proxy_port', 'proxy_pass', 'proxy_user',
+                    'max_speed', 'verify_size', 'verify_checksum', 'num_threads',
+                    'newest', 'remove_old', 'num_old_packages', 'purge_orphaned', 'skip', 'checksum_type',
+                    'num_retries', 'retry_delay'
+      def id
+        YumImporter::ID
+      end
 
-        def repo_type
-          YumImporter::REPO_TYPE
-        end
+      def repo_type
+        YumImporter::REPO_TYPE
+      end
 
-        def config
-          as_json
-        end
+      def config
+        as_json
       end
+    end
   end
 end

data/lib/runcible/resources/consumer.rb

@@ -21,18 +21,16 @@
 # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-
 module Runcible
   module Resources
     # @see https://pulp-dev-guide.readthedocs.org/en/latest/rest-api/consumer/index.html
     class Consumer < Runcible::Base
-
       # Generates the API path for Consumers
       #
       # @param  [String]  id  the ID of the consumer
       # @return [String]      the consumer path, may contain the id if passed
-      def self.path(id=nil)
-        (id == nil) ? "consumers/" : "consumers/#{id}/"
+      def self.path(id = nil)
+        (id.nil?) ? 'consumers/' : "consumers/#{id}/"
       end
 
       # Creates a consumer
@@ -40,7 +38,7 @@ module Runcible
       # @param  [String]                id        the ID of the consumer
       # @param  [Hash]                  optional  container for all optional parameters
       # @return [RestClient::Response]
-      def create(id, optional={})
+      def create(id, optional = {})
         required = required_params(binding.send(:local_variables), binding)
         call(:post, path, :payload => { :required => required, :optional => optional })
       end
@@ -58,7 +56,7 @@ module Runcible
       # @param  [String]                id        the ID of the consumer
       # @param  [Hash]                  optional  container for all optional parameters
       # @return [RestClient::Response]
-      def update(id, optional={})
+      def update(id, optional = {})
         call(:put, path(id), :payload => { :delta => optional })
       end
 
@@ -77,7 +75,7 @@ module Runcible
       # @param  [Hash]                  profile       hash representing the consumer profile
       # @return [RestClient::Response]
       def upload_profile(id, content_type, profile)
-        required = required_params(binding.send(:local_variables), binding, ["id"])
+        required = required_params(binding.send(:local_variables), binding, ['id'])
         call(:post, path("#{id}/profiles/"), :payload => { :required => required })
       end
 
@@ -115,9 +113,9 @@ module Runcible
       # @param  [String]                distributor_id  the ID of the distributor
       # @param  [Hash]                  optional optional parameters
       # @return [RestClient::Response]
-      def bind(id, repo_id, distributor_id, optional={})
-        required = required_params(binding.send(:local_variables), binding, ["id"])
-        call(:post, path("#{id}/bindings/"), :payload => { :required => required, :optional=>optional })
+      def bind(id, repo_id, distributor_id, optional = {})
+        required = required_params(binding.send(:local_variables), binding, ['id'])
+        call(:post, path("#{id}/bindings/"), :payload => { :required => required, :optional => optional })
       end
 
       # Unbind a consumer to a repository for a given distributor
@@ -136,8 +134,8 @@ module Runcible
       # @param  [Array]                 units   array of units to install
       # @param  [Hash]                  options hash of install options
       # @return [RestClient::Response]
-      def install_units(id, units, options={})
-        required = required_params(binding.send(:local_variables), binding, ["id"])
+      def install_units(id, units, options = {})
+        required = required_params(binding.send(:local_variables), binding, ['id'])
         call(:post, path("#{id}/actions/content/install/"), :payload => { :required => required })
       end
 
@@ -147,8 +145,8 @@ module Runcible
       # @param  [Array]                 units   array of units to update
       # @param  [Hash]                  options hash of update options
       # @return [RestClient::Response]
-      def update_units(id, units, options={})
-        required = required_params(binding.send(:local_variables), binding, ["id"])
+      def update_units(id, units, options = {})
+        required = required_params(binding.send(:local_variables), binding, ['id'])
         call(:post, path("#{id}/actions/content/update/"), :payload => { :required => required })
       end
 
@@ -158,8 +156,8 @@ module Runcible
       # @param  [Array]                 units   array of units to uninstall
       # @param  [Hash]                  options hash of uninstall options
       # @return [RestClient::Response]
-      def uninstall_units(id, units, options={})
-        required = required_params(binding.send(:local_variables), binding, ["id"])
+      def uninstall_units(id, units, options = {})
+        required = required_params(binding.send(:local_variables), binding, ['id'])
         call(:post, path("#{id}/actions/content/uninstall/"), :payload => { :required => required })
       end
 
@@ -168,17 +166,16 @@ module Runcible
       # @param [Hash]                 options payload representing criteria
       # @return [RestClient::Response]
       def regenerate_applicability(options = {})
-        call(:post, path("actions/content/regenerate_applicability/"), :payload => { :required => options})
+        call(:post, path('actions/content/regenerate_applicability/'), :payload => { :required => options})
       end
 
       # retrieve the applicability for some set of consumers
       #
       # @param  [Hash]                  options hash representing criteria
       # @return [RestClient::Response]
-      def applicability(options={})
-        call(:post, path + "content/applicability/", :payload => { :required => options })
+      def applicability(options = {})
+        call(:post, path + 'content/applicability/', :payload => { :required => options })
       end
-
     end
   end
 end