rummageable 0.1.3 → 0.3.0

data/lib/rummageable/fake.rb

@@ -6,6 +6,9 @@ module Rummageable
     def delete(link)
     end
 
+    def commit
+    end
+
     def validate_structure(hash, parents=[])
     end
   end

data/lib/rummageable/implementation.rb

@@ -12,9 +12,18 @@ module Rummageable
       end
     end
 
+    def amend(link, amendments)
+      validate_structure amendments
+      RestClient.post url_for(link), amendments
+    end
+
     def delete(link)
-      url = Rummageable.rummager_host + Rummageable.path_prefix + "/documents/" + CGI.escape(link)
-      RestClient.delete url, content_type: :json, accept: :json
+      RestClient.delete url_for(link), content_type: :json, accept: :json
+    end
+
+    def commit
+      url = Rummageable.rummager_host + Rummageable.path_prefix + "/commit"
+      RestClient.post url, {}
     end
 
     def validate_structure(hash, parents=[])
@@ -32,5 +41,13 @@ module Rummageable
         end
       end
     end
+
+  private
+    def url_for(link)
+      [
+        Rummageable.rummager_host, Rummageable.path_prefix,
+        "/documents/", CGI.escape(link)
+      ].join("")
+    end
   end
 end

data/lib/rummageable/version.rb

@@ -1,3 +1,3 @@
 module Rummageable
-  VERSION = "0.1.3"
-end
+  VERSION = "0.3.0"
+end

data/lib/rummageable.rb

@@ -41,6 +41,14 @@ module Rummageable
     implementation.delete(link)
   end
 
+  def amend(link, amendments)
+    implementation.amend(link, amendments)
+  end
+
+  def commit
+    implementation.commit
+  end
+
   VALID_KEYS = [
     %w[title],
     %w[description],
@@ -49,6 +57,7 @@ module Rummageable
     %w[subsection],
     %w[link],
     %w[indexable_content],
+    %w[boost_phrases],
     %w[additional_links title],
     %w[additional_links link],
     %w[additional_links link_order],

data/test/rummageable_test.rb

@@ -15,6 +15,7 @@ class RummageableTest < MiniTest::Unit::TestCase
       "subsection" => "NAME OF SUBSECTION",
       "link" => "/link",
       "indexable_content" => "TEXT",
+      "boost_phrases" => "BOOST",
       "additional_links" => [
         {"title" => "LINK1", "link" => "/link1"},
         {"title" => "LINK2", "link" => "/link2"},
@@ -93,21 +94,51 @@ class RummageableTest < MiniTest::Unit::TestCase
   def test_should_delete_a_document_by_its_link
     link = "http://example.com/foo"
 
-    stub_request(:delete, "#{API}/documents/http%3A%2F%2Fexample.com%2Ffoo").
+    stub_request(:delete, "#{API}/documents/http:%2F%2Fexample.com%2Ffoo").
       to_return(status: 200, body: '{"status":"OK"}')
 
     Rummageable.delete(link)
   end
 
+  def test_should_post_amendments
+    stub_request(:post, "#{API}/documents/%2Ffoobang").
+      with(body: {"title" => "Cheese", "indexable_content" => "Blah"}).
+      to_return(status: 200, body: '{"status":"OK"}')
+
+    Rummageable.amend("/foobang", {"title" => "Cheese", "indexable_content" => "Blah"})
+  end
+
+  def test_should_reject_unknown_amendments
+    stub_request(:post, "#{API}/documents/%2Ffoobang").
+      to_return(status: 200, body: '{"status":"OK"}')
+
+    assert_raises Rummageable::InvalidDocument do
+      Rummageable.amend("/foobang", {"title" => "Cheese", "face" => "Blah"})
+    end
+
+    assert_not_requested :any, "#{API}/documents/%2Ffoobang"
+  end
+
+  def test_should_fail_amendments_with_symbols
+    stub_request(:post, "#{API}/documents/%2Ffoobang").
+      to_return(status: 200, body: '{"status":"OK"}')
+
+    assert_raises Rummageable::InvalidDocument do
+      Rummageable.amend("/foobang", {title: "Cheese"})
+    end
+
+    assert_not_requested :any, "#{API}/documents/%2Ffoobang"
+  end
+
   def test_should_delete_to_rummageable_host_determined_by_rummager_service_name
     link = "http://example.com/foo"
-    stub_request(:delete, "#{API}/documents/http%3A%2F%2Fexample.com%2Ffoo")
-    stub_request(:delete, "http://whitehall-search.test.alphagov.co.uk/documents/http%3A%2F%2Fexample.com%2Ffoo")
+    stub_request(:delete, "#{API}/documents/http:%2F%2Fexample.com%2Ffoo")
+    stub_request(:delete, "http://whitehall-search.test.alphagov.co.uk/documents/http:%2F%2Fexample.com%2Ffoo")
     with_rummager_service_name("whitehall-search") do
       Rummageable.delete(link)
     end
-    assert_not_requested(:delete, "#{API}/#{API}/documents/http%3A%2F%2Fexample.com%2Ffoo")
-    assert_requested(:delete, "http://whitehall-search.test.alphagov.co.uk/documents/http%3A%2F%2Fexample.com%2Ffoo")
+    assert_not_requested(:delete, "#{API}/#{API}/documents/http:%2F%2Fexample.com%2Ffoo")
+    assert_requested(:delete, "http://whitehall-search.test.alphagov.co.uk/documents/http:%2F%2Fexample.com%2Ffoo")
   end
 
   def test_should_defer_to_plek_for_the_location_of_the_rummager_host
@@ -121,6 +152,13 @@ class RummageableTest < MiniTest::Unit::TestCase
       Rummageable.rummager_host = nil
   end
 
+  def test_should_commit_to_rummmageable_host
+    stub_request(:post, "#{API}/commit").
+      to_return(status: 200, body: '{"result":"OK"}')
+
+    Rummageable.commit
+  end
+
   private
 
   def with_rummager_service_name(service_name)

metadata

@@ -2,7 +2,7 @@
 name: rummageable
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.1.3
+  version: 0.3.0
 platform: ruby
 authors: 
 - GovUK Beta Team
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-01-17 00:00:00 Z
+date: 2012-06-27 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: json
@@ -67,6 +67,17 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: *id005
+- !ruby/object:Gem::Dependency 
+  name: gem_publisher
+  requirement: &id006 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: *id006
 description: Mediator for apps that want their content to be in the search index
 email: 
 executables: []
@@ -76,10 +87,10 @@ extensions: []
 extra_rdoc_files: []
 
 files: 
-- lib/rummageable/fake.rb
+- lib/rummageable.rb
 - lib/rummageable/implementation.rb
 - lib/rummageable/version.rb
-- lib/rummageable.rb
+- lib/rummageable/fake.rb
 - test/rummageable_test.rb
 homepage: https://github.com/alphagov/rummageable
 licenses: []
@@ -94,7 +105,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 127333834740720783
+      hash: 3837460675569533093
       segments: 
       - 0
       version: "0"
@@ -103,14 +114,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 127333834740720783
+      hash: 3837460675569533093
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.13
+rubygems_version: 1.8.12
 signing_key: 
 specification_version: 3
 summary: Mediator for apps that want their content to be in the search index