rumeme 0.4.0 → 0.4.1

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    YzVhMzE2MWM3MzFjYzY5N2U5Y2MxNmEwZGU4MTEyMjdjMDBmZjY3YQ==
+  data.tar.gz: !binary |-
+    YTE5MDZjYzAyMWVkMGFjMTAxN2U3YzljZDAyMWZlMzZiODhkOGEyYQ==
+!binary "U0hBNTEy":
+  metadata.gz: !binary |-
+    NjQ3MDZiYjFkN2IzOWYwZWFlYzg0NTcxN2M5MWY5Yzg5YjEwODUxYjk0OTI4
+    NjJkYWZmYTNmZWMxMjUxY2JlN2RiN2U5NDkwNjU1ZThhM2Y4YmY0NWM3NDI4
+    YjdiY2Q0N2U2M2EzNjA2YzI3OWI4YTJmMTg1YTk5ZWQ0MmY0MDc=
+  data.tar.gz: !binary |-
+    MTRmZjliZGU1Mzg2NGNlZTc1MjZlYTc5MjliNWZhMWFjZWZlZjBmNzdiMmIy
+    ZDAwMGIwMmVlZDU5OGM4OTJkNWI5YzZhNDJjMGExOTNmZmM0ZGQzZjk1OTdi
+    MGJkYTQwYmQ2YmViN2IwYTQ0NWQ3YzgxYjY5MWExMDNlMmQ0N2E=

data/.gitignore

@@ -1,3 +1,2 @@
-.idea
-run_simple_test.rb
-pkg
+pkg
+Gemfile.lock

data/CHANGELOG

@@ -1,13 +1,36 @@
+Version 0.4.1 - 2013-05-09
+===============================================================================
+
+Anatoliy Plastinin (11):
+      Merge pull request #4 from rafaelmagu/master
+      remove commented logging
+      update readme
+      Merge PR #5 into master
+      clenaup
+      update gitignore
+      small code readability changes
+      other small fixes
+
+Rafael Fonseca (1):
+      Commented out some debugging output. Fixed return value order in strip_invalid.
+
+Stan Carver (15):
+      corrected strip_invalid method-logic test for nil was backwards.
+      simplified unescape method for readibility.
+      corrected changed resp variable name to response. corrected pass by reference change to data variable. removed unneeded print statements.
+      added more test coverage.
+
+
 Version 0.4.0 - 2012-10-30
 ===============================================================================
 
 Stan Carver II (6):
       changed send_messages to return true or false instead of raising an error
-			added send_messages! to raise an error
-			change inverted if not conditionals to unless
-			refactored message_id_sign out of create_login_string
-			consolidated self references with a << self block
-			added my name to the credits as a contributor
+      added send_messages! to raise an error
+      change inverted if not conditionals to unless
+      refactored message_id_sign out of create_login_string
+      consolidated self references with a << self block
+      added my name to the credits as a contributor
 
 
 Version 0.3.0 - 2012-02-17
@@ -87,14 +110,3 @@ antlypls (5):
       update gitignore
       add maintaince tasks to rake
 
-
-
-
-
-
-
-
-
-
-
-

data/Gemfile

@@ -1,4 +1,3 @@
 source 'http://rubygems.org'
 
-# Specify your gem's dependencies in requeues-next.gemspec
 gemspec

data/README.md

@@ -0,0 +1,71 @@
+RuMeMe
+======
+
+Ruby SDK for Message Media SMS Gateway API.
+Since Message Media doesn't provide any ruby projects support, we decided to port it from available SDKs (mainly from PHP SDK; and some .NET usage).
+For more information checkout [Message Media SMS APIs](http://www.message-media.com/sms-gateway.html).
+
+Help
+====
+
+Installation
+------------
+
+Just execute
+
+    gem install rumeme
+
+Usage
+-----
+
+First, add Rumeme initialization
+
+```ruby
+Rumeme.configure do |config|
+  config.username = 'xxx'
+  config.password = 'yyy'
+  config.use_message_id = true
+  config.secure = true
+ config.allow_splitting = false
+  config.allow_long_messages = true
+end
+```
+
+Where xxx and yyy is your username and password consequently.
+Then you can use SmsInterface class to add and send messages.
+
+```ruby
+si = SmsInterface.new
+
+si.add_message :phone_number => 'xxxxxxxxxxx', :message => 'Message text 1'
+si.add_message :phone_number => 'xxxxxxxxxxx', :message => 'Message text 2'
+si.add_message :phone_number => 'xxxxxxxxxxx', :message => 'Message text 3'
+si.add_message :phone_number => 'xxxxxxxxxxx', :message => 'Message text 4'
+si.add_message :phone_number => 'xxxxxxxxxxx', :message => 'Message text 5'
+
+si.send_messages
+```
+
+Where xxxxxxxxxxx is phone number.
+
+To Do
+=====
+
+* Refactoring to make api more rubyish,
+* Add unit tests,
+
+Credits
+=======
+
+RuMeMe is maintained by Anatoliy Plastinin, and is funded by [Cloud Castle, LLC](http://cloudcastlegroup.com/).
+
+Contributors
+============
+
+* Stan Carver II
+* Rafael Fonseca
+
+License
+=======
+
+Still looking for license. But the software is provided "as is", without warranty of any kind.

data/Rakefile

@@ -2,6 +2,8 @@ require 'rake'
 require 'rake/testtask'
 require 'bundler/gem_tasks'
 
+require 'date'
+
 desc 'Test the rumeme gem'
 Rake::TestTask.new(:test) do |t|
   t.libs << 'lib'
@@ -9,9 +11,11 @@ Rake::TestTask.new(:test) do |t|
   t.verbose = true
 end
 
+task :default => [:test]
+
 desc "Bumps the version by a minor or patch version, depending on what was passed in."
 task :bump, :part do |t, args|
-  if Rumeme::VERSION  =~ /^(\d+)\.(\d+)\.(\d+)(?:\.(.*?))?$/
+  if Rumeme::VERSION =~ /^(\d+)\.(\d+)\.(\d+)(?:\.(.*?))?$/
     major = $1.to_i
     minor = $2.to_i
     patch = $3.to_i
@@ -59,7 +63,7 @@ Version #{version} - #{Date.today}
 EOF
   end
 
-  editor = ENV["EDITOR"] || 'mvim'
+  editor = ENV["EDITOR"] || 'vim'
 
   system ["#{editor} #{file}",
         "git commit -aqm '#{message}'",

data/lib/rumeme.rb

@@ -12,8 +12,8 @@ module Rumeme
     def configure
       @configuration ||= Configuration.new
       yield @configuration
-      
+
       raise 'unknown long_messages_strategy' unless [:split, :send, :cut].include?(@configuration.long_messages_strategy)
     end
   end
-end
+end

data/lib/rumeme/configuration.rb

@@ -11,7 +11,7 @@ module Rumeme
     # possible values
     # :send - sends messages as is without any modification
     # :split - splits messages into small (less than 160 ch) messages
-    # :cut - sends only first 160 symbols 
+    # :cut - sends only first 160 symbols
     attr_accessor :long_messages_strategy
 
     def initialize

data/lib/rumeme/message_status.rb

@@ -6,4 +6,4 @@ module Rumeme
     DELIVERED = 2
     FAILED = 3
   end
-end
+end

data/lib/rumeme/sms_interface.rb

@@ -64,7 +64,7 @@ module Rumeme
     def open_server_connection server
       port, use_ssl = @secure ? [443, true] : [80, false]
 
-      http_connection =  Net::HTTP.new(server, port)
+      http_connection = Net::HTTP.new(server, port)
       http_connection.verify_mode = OpenSSL::SSL::VERIFY_NONE
       http_connection.use_ssl = use_ssl
       http_connection
@@ -132,7 +132,7 @@ module Rumeme
       end
 
       def split_message_internal message
-        list =[]
+        list = []
         sizes = Enumerator.new {|yielder| yielder << 152; yielder << 155 while true}
 
         until message.nil? do
@@ -152,10 +152,10 @@ module Rumeme
 
       # Strip invalid characters from the phone number.
       def strip_invalid phone
-        phone.nil? ? "+#{phone.gsub(/[^0-9]/, '')}" : nil
+        "+#{phone.gsub(/[^0-9]/, '')}" if phone
       end
     end
-    
+
     def process_long_message message
       return [message] if message.length <= 160
       @long_messages_processor.call(message)
@@ -164,28 +164,23 @@ module Rumeme
     def message_id_sign
       @use_message_id ? '#' : ''
     end
-    
+
     def create_login_string # can be calculate once at initialization
       "m4u\r\nUSER=#{@username}#{message_id_sign}\r\nPASSWORD=#{@password}\r\nVER=PHP1.0\r\n"
     end
 
     def post_data_to_server data
-      puts 'post_data_to_server'
-
       http_connection = open_server_connection(@server_list[0])
       text_buffer = create_login_string + data
 
-      puts "buffer: #{text_buffer}"
       headers = {'Content-Length' => text_buffer.length.to_s}
 
       path = '/'
 
       resp = http_connection.post(path, text_buffer, headers)
       data = resp.body
-      p resp
-      p data
-      
-      raise BadServerResponse.new('http response code != 200') unless response.code.to_i == 200
+
+      raise BadServerResponse.new('http response code != 200') unless resp.code.to_i == 200
 
       if data =~ /^.+<TITLE>(.+)<\/TITLE>.+<BODY>(.+)<\/BODY>.+/m
         parsed_title, parsed_body = $1, $2
@@ -197,13 +192,10 @@ module Rumeme
 
       response_message = parsed_body.strip
 
-      response_message.match /^(\d+)\s+/
+      response_message.match(/^(\d+)\s+/)
       response_code = $1.to_i
 
-      puts "latest response code: #{response_code}"
-      puts "response: #{response_message }"
-
       [response_message, response_code]
     end
   end
-end
+end

data/lib/rumeme/sms_message.rb

@@ -15,9 +15,9 @@ module Rumeme
 
       @message = @message.gsub("\n",'\n').gsub("\r",'\r').gsub("\\",'\\\\')
     end
-    
+
     def post_string
       "#{@message_id} #{@phone_number} #{@delay} #{@validity_period} #{@delivery_report ? 1 : 0} #{@message}\r\n"
     end
   end
-end
+end

data/lib/rumeme/sms_reply.rb

@@ -11,7 +11,7 @@ module Rumeme
     class << self
       # Unescape any escaped characters in the string.
       def unescape line
-        line.nil? ? nil : line.gsub('\n', "\n").gsub('\r', "\r").gsub('\\\\', "\\")
+        line.gsub('\n', "\n").gsub('\r', "\r").gsub('\\\\', "\\") if line
       end
 
       # Parse a reply from a string.
@@ -20,7 +20,7 @@ module Rumeme
       # Or if delivery receipt: messageID messageStatus when /(\d+)\s(\d)\s(\d+)/
       # current implementation ignores use_message_id setting (as original code)
       def parse line
-        p "parsing line: #{line}"
+        # p "parsing line: #{line}"
 
         message_id, status, message, phone, when_ = case line
           when /^(\d+)\s(\d)\s(\d+)/
@@ -44,4 +44,4 @@ module Rumeme
       @status != MessageStatus::NONE
     end
   end
-end
+end

data/lib/rumeme/validity_period.rb

@@ -11,4 +11,4 @@ module Rumeme
       ONE_WEEK = 173
       MAXIMUM = 255
   end
-end
+end

data/lib/rumeme/version.rb

@@ -1,3 +1,3 @@
 module Rumeme
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

data/rumeme.gemspec

@@ -16,14 +16,11 @@ Gem::Specification.new do |s|
   s.summary = "Ruby SDK for Message Media SMS Gateway API"
   s.description = "Ruby SDK for Message Media SMS Gateway API"
 
-
   s.add_development_dependency 'shoulda'
 
-
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.require_paths = %W(lib)
-  s.extra_rdoc_files = ["README.rdoc"]
-  s.rdoc_options = ["--line-numbers", "--main", "README.rdoc"]
-
+  s.extra_rdoc_files = ["README.md"]
+  s.rdoc_options = ["--line-numbers", "--main", "README.md"]
 end

data/test/configuration_test.rb

@@ -0,0 +1,39 @@
+$LOAD_PATH.unshift File.expand_path(File.join(File.dirname(__FILE__), "..", "lib"))
+require 'test/unit'
+require "rubygems"
+require 'shoulda'
+require "rumeme"
+
+include Rumeme
+
+class ConfigurationTest < Test::Unit::TestCase
+  context "has attributes" do
+    setup do
+      @rumeme_configuration = Configuration.new
+    end
+
+    should "have username attribute" do
+      assert_respond_to @rumeme_configuration, :username
+    end
+
+    should "have password attribute" do
+      assert_respond_to @rumeme_configuration, :password
+    end
+
+    should "have use_message_id attribute" do
+      assert_respond_to @rumeme_configuration, :use_message_id
+    end
+
+    should "have secure attribute" do
+      assert_respond_to @rumeme_configuration, :secure
+    end
+
+    should "have replies_auto_confirm attribute" do
+      assert_respond_to @rumeme_configuration, :replies_auto_confirm
+    end
+
+    should "have long_messages_strategy attribute" do
+      assert_respond_to @rumeme_configuration, :long_messages_strategy
+    end
+  end
+end

data/test/message_status_test.rb

@@ -0,0 +1,14 @@
+$LOAD_PATH.unshift File.expand_path(File.join(File.dirname(__FILE__), "..", "lib"))
+require 'test/unit'
+require "rubygems"
+require 'shoulda'
+require "rumeme"
+
+class MessageStatusTest < Test::Unit::TestCase
+  should "correctly assign MessageStatus constants" do
+    assert_equal Rumeme::MessageStatus::NONE, 0
+    assert_equal Rumeme::MessageStatus::PENDING, 1
+    assert_equal Rumeme::MessageStatus::DELIVERED, 2
+    assert_equal Rumeme::MessageStatus::FAILED, 3
+  end
+end

data/test/sms_interface_test.rb

@@ -0,0 +1,11 @@
+$LOAD_PATH.unshift File.expand_path(File.join(File.dirname(__FILE__), "..", "lib"))
+require 'test/unit'
+require "rubygems"
+require 'shoulda'
+require "rumeme"
+
+include Rumeme
+
+class SmsInterfaceTest < Test::Unit::TestCase
+
+end

data/test/version_test.rb

@@ -0,0 +1,12 @@
+$LOAD_PATH.unshift File.expand_path(File.join(File.dirname(__FILE__), "..", "lib"))
+require 'test/unit'
+require "rubygems"
+require 'shoulda'
+require "rumeme"
+require "rumeme/version"
+
+class VersionTest < Test::Unit::TestCase
+  should "have Version constant" do
+    assert Rumeme.const_defined? :VERSION
+  end
+end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rumeme
 version: !ruby/object:Gem::Version
-  version: 0.4.0
-  prerelease: 
+  version: 0.4.1
 platform: ruby
 authors:
 - Anatoliy Plastinin, Cloud Castle LLC
@@ -10,12 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-01 00:00:00.000000000 Z
+date: 2013-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: shoulda
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -23,7 +21,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -35,13 +32,12 @@ email:
 executables: []
 extensions: []
 extra_rdoc_files:
-- README.rdoc
+- README.md
 files:
 - .gitignore
 - CHANGELOG
 - Gemfile
-- Gemfile.lock
-- README.rdoc
+- README.md
 - Rakefile
 - lib/rumeme.rb
 - lib/rumeme/configuration.rb
@@ -52,35 +48,42 @@ files:
 - lib/rumeme/validity_period.rb
 - lib/rumeme/version.rb
 - rumeme.gemspec
+- test/configuration_test.rb
+- test/message_status_test.rb
+- test/sms_interface_test.rb
 - test/sms_message_test.rb
 - test/sms_reply_test.rb
+- test/version_test.rb
 homepage: http://github.com/programmable/rumeme
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options:
 - --line-numbers
 - --main
-- README.rdoc
+- README.md
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Ruby SDK for Message Media SMS Gateway API
 test_files:
+- test/configuration_test.rb
+- test/message_status_test.rb
+- test/sms_interface_test.rb
 - test/sms_message_test.rb
 - test/sms_reply_test.rb
+- test/version_test.rb

data/Gemfile.lock

@@ -1,7 +0,0 @@
-GEM
-  specs:
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES

data/README.rdoc

@@ -1,49 +0,0 @@
-= RuMeMe
-Ruby SDK for Message Media SMS Gateway API.
-Since Message Media doesn't provide any ruby projects support, we decided to port it from available SDKs (mainly from PHP SDK; and some .NET usage). 
-For more information checkout {Message Media SMS APIs}[http://www.message-media.com/sms-gateway.html].
-
-= Help
-== Installation
-Just execute
- gem install rumeme
-
-== Usage
-First, add Rumeme initialization
-
- Rumeme.configure do |config|
-   config.username = 'xxx'
-   config.password = 'yyy'
-   config.use_message_id = true
-   config.secure = true
-   config.allow_splitting = false
-   config.allow_long_messages = true
- end
-
-Where xxx and yyy is your username and password consequently.
-Then you can use SmsInterface class to add and send messages.
-
-  si = SmsInterface.new
-
-  si.add_message :phone_number => 'xxxxxxxxxxx', :message => 'Message text 1'
-  si.add_message :phone_number => 'xxxxxxxxxxx', :message => 'Message text 2'
-  si.add_message :phone_number => 'xxxxxxxxxxx', :message => 'Message text 3'
-  si.add_message :phone_number => 'xxxxxxxxxxx', :message => 'Message text 4'
-  si.add_message :phone_number => 'xxxxxxxxxxx', :message => 'Message text 5'
-
-  si.send_messages
-
-Where xxxxxxxxxxx is phone number.
-
-= To Do
-* Refactoring to make api more rubyish,
-* Add unit tests,
-
-= Credits
-RuMeMe is maintained by Anatoliy Plastinin, and is funded by {Cloud Castle, LLC}[http://cloudcastlegroup.com/].
-
-= Contributors
-Stan Carver II
-
-= License
-Still looking for license. But the software is provided "as is", without warranty of any kind.