rules_engine 0.1.6 → 0.1.7

data/rails_generators/templates/spec/lib/rules/simple_spec.rb

@@ -144,11 +144,15 @@ describe RulesEngine::Rule::Simple do
     end
   end
   
-  describe "after a rule is created" do
+  describe "before a rule is created" do
     # xit "There is nothing to do here"
   end
   
-  describe "after a rule is created" do
+  describe "before a rule is updated" do
+    # xit "There is nothing to do here"
+  end
+  
+  describe "before a rule is destroyed" do
     # xit "There is nothing to do here"
   end
   
@@ -164,48 +168,50 @@ end
 describe ReWorkflowRulesController, :type => :controller  do
   integrate_views
   
-  before(:each) do
-    controller.instance_eval { flash.stub!(:sweep) }
+  describe "RulesEngine::Rule::Simple" do
+  
+    before(:each) do
+      controller.instance_eval { flash.stub!(:sweep) }
 
-    RulesEngine::Discovery.discover!
+      RulesEngine::Discovery.discover!
         
-    controller.stub!(:rules_engine_reader_access_required).and_return(true)
-    controller.stub!(:rules_engine_editor_access_required).and_return(true)
+      controller.stub!(:rules_engine_reader_access_required).and_return(true)
+      controller.stub!(:rules_engine_editor_access_required).and_return(true)
 
-    @re_workflow = ReWorkflow.make
-    ReWorkflow.stub!(:find).and_return(@re_workflow)
-  end  
+      @re_workflow = ReWorkflow.make
+      ReWorkflow.stub!(:find).and_return(@re_workflow)
+    end  
   
-  describe "help" do
-    it "should assign the <%=rule_name%> rule class" do
-      get :help, :rule_class_name => "RulesEngine::Rule::Simple"
-      assigns[:rule_class].should == RulesEngine::Rule::Simple
+    describe "help" do
+      it "should assign the <%=rule_name%> rule class" do
+        get :help, :rule_class_name => "RulesEngine::Rule::Simple"
+        assigns[:rule_class].should == RulesEngine::Rule::Simple
+      end
     end
-  end
 
-  describe "new" do
-    it "show the new form" do
-      get :new, :rule_class_name => "RulesEngine::Rule::Simple"
-      response.should have_tag("form#re_rule_new_form") do
-        with_tag("input#<%=rule_name%>_title")
-        with_tag("input#<%=rule_name%>_description")      
-      end  
+    describe "new" do
+      it "show the new form" do
+        get :new, :rule_class_name => "RulesEngine::Rule::Simple"
+        response.should have_tag("form#re_rule_new_form") do
+          with_tag("input#<%=rule_name%>_title")
+          with_tag("input#<%=rule_name%>_description")      
+        end  
+      end
     end
-  end
   
-  describe "edit" do
-    it "show the edit form" do
-      re_rule = ReRule.make(:re_workflow_id => @re_workflow.id, 
-                            :rule_class_name => "RulesEngine::Rule::Simple",
-                            :data => valid_<%=rule_name%>_rule_data)
-      ReRule.stub!(:find).and_return(re_rule)
+    describe "edit" do
+      it "show the edit form" do
+        re_rule = ReRule.make(:re_workflow_id => @re_workflow.id, 
+                              :rule_class_name => "RulesEngine::Rule::Simple",
+                              :data => valid_<%=rule_name%>_rule_data)
+        ReRule.stub!(:find).and_return(re_rule)
       
-      get :edit, :re_workflow_id => @re_workflow.id, :re_rule_id => 1001, :rule_class_name => "RulesEngine::Rule::Simple"
-      response.should have_tag("form#re_rule_edit_form") do
-        with_tag("input#<%=rule_name%>_title", :value => 'Rule Title')     
-        with_tag("input#<%=rule_name%>_description", :value => 'Rule Description')     
-      end  
+        get :edit, :re_workflow_id => @re_workflow.id, :re_rule_id => 1001, :rule_class_name => "RulesEngine::Rule::Simple"
+        response.should have_tag("form#re_rule_edit_form") do
+          with_tag("input#<%=rule_name%>_title", :value => 'Rule Title')     
+          with_tag("input#<%=rule_name%>_description", :value => 'Rule Description')     
+        end  
+      end
     end
   end
-  
 end

data/rails_generators/templates/spec/models/re_rule_spec.rb

@@ -18,7 +18,6 @@ describe ReRule do
     @rule.stub!(:before_create)
     @rule.stub!(:before_update)
     @rule.stub!(:before_destroy)
-    @rule.stub!(:expected_outcomes).and_return([])
     @rule.stub!(:valid?).and_return(true)
     @rule_class = mock("MockRuleClass")
     @rule_class.stub!(:new).and_return(@rule)      
@@ -34,7 +33,6 @@ describe ReRule do
   end
   
   should_belong_to :re_workflow
-  should_have_many :re_rule_expected_outcomes
   should_validate_presence_of :rule_class_name
 
   describe "validate the rule" do
@@ -142,15 +140,6 @@ describe ReRule do
         @re_rule.save
         @re_rule.data.should == "rule data"      
       end      
-      
-      it "should set the expected outcomes to the expected outcomes generated by the rule" do
-        re_rule_expected_outcome = ReRuleExpectedOutcome.new
-        ReRuleExpectedOutcome.should_receive(:new).with(:outcome => 101, :workflow_code => "one").and_return(re_rule_expected_outcome)
-        ReRuleExpectedOutcome.should_receive(:new).with(:outcome => 202, :workflow_code => "two").and_return(re_rule_expected_outcome)
-        @rule.stub(:expected_outcomes).and_return([{:outcome => 101, :workflow_code => "one"}, {:outcome => 202, :workflow_code => "two"}])
-        @re_rule.save
-        @re_rule.re_rule_expected_outcomes.should == [re_rule_expected_outcome, re_rule_expected_outcome]
-      end      
     end    
   end
   
@@ -186,44 +175,6 @@ describe ReRule do
     end  
   end
   
-  describe "rule outcomes available" do
-    before(:each) do
-      @re_rule = ReRule.new      
-    end
-    
-    it "should return the first outcome that is a OUTCOME_NEXT" do
-      outcome_1 = ReRuleExpectedOutcome.new(:outcome => RulesEngine::Rule::Outcome::NEXT)
-      outcome_2 = ReRuleExpectedOutcome.new(:outcome => RulesEngine::Rule::Outcome::NEXT)
-      @re_rule.re_rule_expected_outcomes << outcome_1
-      @re_rule.re_rule_expected_outcomes << outcome_2
-      @re_rule.re_rule_expected_outcome_next.should == outcome_1
-    end
-  
-    it "should return the first outcome that is a OUTCOME_STOP_SUCCESS" do
-      outcome_1 = ReRuleExpectedOutcome.new(:outcome => RulesEngine::Rule::Outcome::STOP_SUCCESS)
-      outcome_2 = ReRuleExpectedOutcome.new(:outcome => RulesEngine::Rule::Outcome::STOP_SUCCESS)
-      @re_rule.re_rule_expected_outcomes << outcome_1
-      @re_rule.re_rule_expected_outcomes << outcome_2
-      @re_rule.re_rule_expected_outcome_success.should == outcome_1
-    end
-  
-    it "should return the first outcome that is a OUTCOME_STOP_FAILURE" do
-      outcome_1 = ReRuleExpectedOutcome.new(:outcome => RulesEngine::Rule::Outcome::STOP_FAILURE)
-      outcome_2 = ReRuleExpectedOutcome.new(:outcome => RulesEngine::Rule::Outcome::STOP_FAILURE)
-      @re_rule.re_rule_expected_outcomes << outcome_1
-      @re_rule.re_rule_expected_outcomes << outcome_2
-      @re_rule.re_rule_expected_outcome_failure.should == outcome_1
-    end
-  
-    it "should return all outcomes that are a OUTCOME_START_WORKFLOW" do
-      outcome_1 = ReRuleExpectedOutcome.new(:outcome => RulesEngine::Rule::Outcome::START_WORKFLOW)
-      outcome_2 = ReRuleExpectedOutcome.new(:outcome => RulesEngine::Rule::Outcome::START_WORKFLOW)
-      @re_rule.re_rule_expected_outcomes << outcome_1
-      @re_rule.re_rule_expected_outcomes << outcome_2
-      @re_rule.re_rule_expected_outcomes_start_workflow.should == [outcome_1, outcome_2]
-    end
-  end
-  
   describe "checking for rule errors" do
     before(:each) do
       @rule = mock("Rule", :valid? => true)
@@ -237,32 +188,20 @@ describe ReRule do
       @re_rule.rule_error.should == "class MockRuleClass missing"
     end
     
-    it "should ignore outcomes where the workflow_code is nil" do
-      re_rule_expected_outcome = mock_model(ReRuleExpectedOutcome, :workflow_code => nil)
-      @re_rule.stub!(:re_rule_expected_outcomes).and_return([re_rule_expected_outcome])
-      @re_rule.rule_error.should be_nil
-    end
-  
-    it "should validate the workflow is present and activated" do
-      re_rule_expected_outcome = mock_model(ReRuleExpectedOutcome, :workflow_code => "mock_workflow_code", :outcome => RulesEngine::Rule::Outcome::START_WORKFLOW)
-      ReWorkflow.should_receive(:find_by_code).and_return(mock("ReWorkflow", :workflow_error => nil))      
-      @re_rule.stub!(:re_rule_expected_outcomes).and_return([re_rule_expected_outcome])
-      @re_rule.rule_error.should be_nil
-    end
+    # it "should validate the workflow is present and published" do
+    #   ReWorkflow.should_receive(:find_by_code).and_return(mock("ReWorkflow", :workflow_error => nil))      
+    #   @re_rule.rule_error.should be_nil
+    # end
       
-    it "should return '[workflow_code] missing' if the required workflow is missing" do
-      re_rule_expected_outcome = mock_model(ReRuleExpectedOutcome, :workflow_code => "mock_workflow_code", :outcome => RulesEngine::Rule::Outcome::START_WORKFLOW)
-      ReWorkflow.should_receive(:find_by_code).and_return(nil)
-      @re_rule.stub!(:re_rule_expected_outcomes).and_return([re_rule_expected_outcome])
-      @re_rule.rule_error.should == "mock_workflow_code missing"
-    end
+    # it "should return '[workflow_code] missing' if the required workflow is missing" do
+    #   ReWorkflow.should_receive(:find_by_code).and_return(nil)
+    #   @re_rule.rule_error.should == "mock_workflow_code missing"
+    # end
     
-    it "should return '[workflow_code] invalid' if the required workflow has errors" do
-      re_rule_expected_outcome = mock_model(ReRuleExpectedOutcome, :workflow_code => "mock_workflow_code", :outcome => RulesEngine::Rule::Outcome::START_WORKFLOW)
-      ReWorkflow.should_receive(:find_by_code).and_return(mock("ReWorkflow", :workflow_error => "workflow error"))      
-      @re_rule.stub!(:re_rule_expected_outcomes).and_return([re_rule_expected_outcome])
-      @re_rule.rule_error.should == "mock_workflow_code invalid"
-    end
+    # it "should return '[workflow_code] invalid' if the required workflow has errors" do
+    #   ReWorkflow.should_receive(:find_by_code).and_return(mock("ReWorkflow", :workflow_error => "workflow error"))      
+    #   @re_rule.rule_error.should == "mock_workflow_code invalid"
+    # end
     
   end
   
@@ -305,7 +244,6 @@ describe ReRule do
 
     it "should set the rule based on the data" do
       re_rule = ReRule.new
-      RulesEngine::Discovery.should_receive(:rule_class).with('mock_rule_class_name').and_return(@rule_class)      
       
       re_rule.revert!({
         "rule_class_name" => 'mock_rule_class_name',

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rules_engine
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: false
   segments: 
   - 0
   - 1
-  - 6
-  version: 0.1.6
+  - 7
+  version: 0.1.7
 platform: ruby
 authors: 
 - Chris Douglas
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-07-24 00:00:00 +10:00
+date: 2010-07-29 00:00:00 +10:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -86,7 +86,6 @@ files:
 - rails_generators/templates/app/models/re_plan.rb
 - rails_generators/templates/app/models/re_plan_workflow.rb
 - rails_generators/templates/app/models/re_rule.rb
-- rails_generators/templates/app/models/re_rule_expected_outcome.rb
 - rails_generators/templates/app/models/re_workflow.rb
 - rails_generators/templates/app/rules/complex.rb
 - rails_generators/templates/app/rules/simple.rb
@@ -101,6 +100,8 @@ files:
 - rails_generators/templates/app/views/re_plan_workflow_rules/new.js.erb
 - rails_generators/templates/app/views/re_plan_workflow_rules/update.js.erb
 - rails_generators/templates/app/views/re_plan_workflows/change.html.erb
+- rails_generators/templates/app/views/re_plan_workflows/copy.html.erb
+- rails_generators/templates/app/views/re_plan_workflows/copy.js.erb
 - rails_generators/templates/app/views/re_plan_workflows/edit.html.erb
 - rails_generators/templates/app/views/re_plan_workflows/edit.js.erb
 - rails_generators/templates/app/views/re_plan_workflows/new.html.erb
@@ -108,6 +109,7 @@ files:
 - rails_generators/templates/app/views/re_plan_workflows/show.html.erb
 - rails_generators/templates/app/views/re_plan_workflows/update.js.erb
 - rails_generators/templates/app/views/re_plans/_change.html.erb
+- rails_generators/templates/app/views/re_plans/_copy.html.erb
 - rails_generators/templates/app/views/re_plans/_edit.html.erb
 - rails_generators/templates/app/views/re_plans/_empty.html.erb
 - rails_generators/templates/app/views/re_plans/_index.html.erb
@@ -119,6 +121,8 @@ files:
 - rails_generators/templates/app/views/re_plans/_workflow_preview.html.erb
 - rails_generators/templates/app/views/re_plans/_workflow_show.html.erb
 - rails_generators/templates/app/views/re_plans/change.html.erb
+- rails_generators/templates/app/views/re_plans/copy.html.erb
+- rails_generators/templates/app/views/re_plans/copy.js.erb
 - rails_generators/templates/app/views/re_plans/create.js.erb
 - rails_generators/templates/app/views/re_plans/edit.html.erb
 - rails_generators/templates/app/views/re_plans/edit.js.erb
@@ -168,6 +172,7 @@ files:
 - rails_generators/templates/app/views/re_workflow_rules/update.js.erb
 - rails_generators/templates/app/views/re_workflows/_add_prepare.html.erb
 - rails_generators/templates/app/views/re_workflows/_add_update.html.erb
+- rails_generators/templates/app/views/re_workflows/_copy.html.erb
 - rails_generators/templates/app/views/re_workflows/_edit.html.erb
 - rails_generators/templates/app/views/re_workflows/_empty.html.erb
 - rails_generators/templates/app/views/re_workflows/_index.html.erb
@@ -184,6 +189,8 @@ files:
 - rails_generators/templates/app/views/re_workflows/add.html.erb
 - rails_generators/templates/app/views/re_workflows/add.js.erb
 - rails_generators/templates/app/views/re_workflows/change.html.erb
+- rails_generators/templates/app/views/re_workflows/copy.html.erb
+- rails_generators/templates/app/views/re_workflows/copy.js.erb
 - rails_generators/templates/app/views/re_workflows/create.js.erb
 - rails_generators/templates/app/views/re_workflows/edit.html.erb
 - rails_generators/templates/app/views/re_workflows/edit.js.erb
@@ -226,6 +233,7 @@ files:
 - rails_generators/templates/public/javascripts/rules_engine/re_workflow_new.js
 - rails_generators/templates/public/javascripts/rules_engine/re_workflow_plan.js
 - rails_generators/templates/public/javascripts/rules_engine/re_workflow_preview.js
+- rails_generators/templates/public/javascripts/rules_engine/re_workflow_show.js
 - rails_generators/templates/public/stylesheets/blueprint/ie.css
 - rails_generators/templates/public/stylesheets/blueprint/plugins/buttons/icons/cross.png
 - rails_generators/templates/public/stylesheets/blueprint/plugins/buttons/icons/key.png
@@ -316,6 +324,7 @@ files:
 - rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_common/status-verify-25.png
 - rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_plan/alert-25.png
 - rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_plan/change-25.png
+- rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_plan/copy-25.png
 - rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_plan/delete-25.png
 - rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_plan/edit-25.png
 - rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_plan/list-25.png
@@ -358,6 +367,7 @@ files:
 - rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_workflow/alert-25.png
 - rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_workflow/change-18.png
 - rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_workflow/change-25.png
+- rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_workflow/copy-25.png
 - rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_workflow/delete-25.png
 - rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_workflow/edit-25.png
 - rails_generators/templates/public/stylesheets/rules_engine/images/rules_engine/re_workflow/is-default-18.png
@@ -379,7 +389,6 @@ files:
 - rails_generators/templates/spec/lib/rules/simple_spec.rb
 - rails_generators/templates/spec/models/re_plan_spec.rb
 - rails_generators/templates/spec/models/re_plan_workflow_spec.rb
-- rails_generators/templates/spec/models/re_rule_expected_outcome_spec.rb
 - rails_generators/templates/spec/models/re_rule_spec.rb
 - rails_generators/templates/spec/models/re_workflow_spec.rb
 - rails_generators/templates/spec/support/rules_engine_blueprints.rb

data/rails_generators/templates/app/models/re_rule_expected_outcome.rb

@@ -1,14 +0,0 @@
-class ReRuleExpectedOutcome < ActiveRecord::Base
-  belongs_to :re_rule
-
-  validates_associated  :re_rule
-  validates_presence_of :outcome  
-
-  def validate    
-    if outcome == RulesEngine::Rule::Outcome::START_WORKFLOW && workflow_code.blank?
-      errors.add(:workflow_code, "workflow code required")
-    else
-      true  
-    end
-  end
-end

data/rails_generators/templates/spec/models/re_rule_expected_outcome_spec.rb

@@ -1,29 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe ReRuleExpectedOutcome do
-  def valid_attributes
-    {
-      :outcome => RulesEngine::Rule::Outcome::NEXT
-    }
-  end
-  
-  it "should be valid with valid attributes" do
-    ReRuleExpectedOutcome.new(valid_attributes).should be_valid
-  end
-  
-  should_validate_presence_of :outcome
-
-  describe "START WORKFLOW" do
-    it "should be invalid when the outcome workflow code is blank" do
-      re_rule_expected_outcome = ReRuleExpectedOutcome.new(:outcome => RulesEngine::Rule::Outcome::START_WORKFLOW)
-      re_rule_expected_outcome.should_not be_valid
-      re_rule_expected_outcome.errors.on(:workflow_code).should_not be_blank
-    end      
-  
-    it "should be valid when outcome workflow code is present" do
-      re_rule_expected_outcome = ReRuleExpectedOutcome.new(:outcome => RulesEngine::Rule::Outcome::START_WORKFLOW, :workflow_code => "mock code")
-      re_rule_expected_outcome.should be_valid
-    end      
-  end
-
-end