rules_engine 0.1.4 → 0.1.5

data/rails_generators/templates/spec/lib/rules/complex_spec.rb

@@ -1,10 +1,14 @@
 require File.dirname(__FILE__) + '/../../spec_helper'
 
+def valid_<%=rule_name%>_rule_data
+  '["Rule Title", ["word one", "word two"], "start_workflow", "Other Workflow"]'
+end
+
 describe RulesEngine::Rule::<%=rule_class%> do
 
   def valid_attributes
     {
-      :<%=rule_name%>_title => 'Valid Title',
+      :<%=rule_name%>_title => 'Another Title',
       :<%=rule_name%>_words => {
                     "1" => { "word" => 'first word'  },
                     "2" => { "word" => 'second word' }
@@ -12,10 +16,6 @@ describe RulesEngine::Rule::<%=rule_class%> do
     }
   end
   
-  def valid_json_data
-    '["Rule Title", ["one", "two"], "start_workflow", "Other Pipeline"]'
-  end
-  
   it "should be discoverable" do
     RulesEngine::Discovery.rule_class("RulesEngine::Rule::<%=rule_class%>").should == RulesEngine::Rule::<%=rule_class%>
   end
@@ -45,7 +45,7 @@ describe RulesEngine::Rule::<%=rule_class%> do
   describe "setting the rule data" do
     before(:each) do
       @<%=rule_name%> = RulesEngine::Rule::<%=rule_class%>.new
-      @<%=rule_name%>.data = valid_json_data
+      @<%=rule_name%>.data = valid_<%=rule_name%>_rule_data
     end  
     
     describe "the json data is valid" do
@@ -58,7 +58,7 @@ describe RulesEngine::Rule::<%=rule_class%> do
       end
 
       it "should set the words" do
-        @<%=rule_name%>.words.should == ["one", "two"]
+        @<%=rule_name%>.words.should == ["word one", "word two"]
       end
 
       it "should set the workflow_action" do
@@ -66,7 +66,7 @@ describe RulesEngine::Rule::<%=rule_class%> do
       end
 
       it "should set the workflow" do
-        @<%=rule_name%>.workflow.should == "Other Pipeline"
+        @<%=rule_name%>.workflow.should == "Other Workflow"
       end        
     end
 
@@ -114,11 +114,11 @@ describe RulesEngine::Rule::<%=rule_class%> do
   describe "the data" do
     it "should be converted to a json string" do
       <%=rule_name%> = RulesEngine::Rule::<%=rule_class%>.new
-      <%=rule_name%>.should_receive(:title).and_return(["mock title"])
+      <%=rule_name%>.should_receive(:title).and_return("mock title")
       <%=rule_name%>.should_receive(:words).and_return(["one", "two"])
-      <%=rule_name%>.should_receive(:workflow_action).and_return(["workflow action"])
-      <%=rule_name%>.should_receive(:workflow).and_return(["workflow"])
-      <%=rule_name%>.data.should == '[["mock title"],["one","two"],["workflow action"],["workflow"]]'
+      <%=rule_name%>.should_receive(:workflow_action).and_return("workflow action")
+      <%=rule_name%>.should_receive(:workflow).and_return("workflow")
+      <%=rule_name%>.data.should == '["mock title",["one","two"],"workflow action","workflow"]'
     end
   end
   
@@ -169,7 +169,7 @@ describe RulesEngine::Rule::<%=rule_class%> do
     describe "setting the <%=rule_name%>_title" do
       it "should set the title" do
         @<%=rule_name%>.attributes = valid_attributes
-        @<%=rule_name%>.title.should == 'Valid Title'
+        @<%=rule_name%>.title.should == 'Another Title'
       end            
     
       it "should not be valid if the '<%=rule_name%>_title' attribute is missing" do
@@ -329,3 +329,57 @@ describe RulesEngine::Rule::<%=rule_class%> do
     end    
   end
 end
+
+describe ReWorkflowRulesController, :type => :controller  do
+  integrate_views
+  
+  before(:each) do
+    controller.instance_eval { flash.stub!(:sweep) }
+    
+    RulesEngine::Discovery.discover!
+    
+    controller.stub!(:rules_engine_reader_access_required).and_return(true)
+    controller.stub!(:rules_engine_editor_access_required).and_return(true)
+
+    @re_workflow = ReWorkflow.make
+    ReWorkflow.stub!(:find).and_return(@re_workflow)
+  end  
+  
+  describe "<%=rule_name%> rule help" do
+    it "should assign the <%=rule_name%> rule class" do
+      get :help, :rule_class_name => "RulesEngine::Rule::<%=rule_class%>"
+      assigns[:rule_class].should == RulesEngine::Rule::<%=rule_class%>
+    end
+  end
+  
+  describe "new" do
+    it "show the new form" do
+      get :new, :rule_class_name => "RulesEngine::Rule::<%=rule_class%>"
+      response.should have_tag("form#re_rule_new_form") do
+        with_tag("input#<%=rule_name%>_title")     
+        with_tag("input#<%=rule_name%>_words_0_word")
+        with_tag("select#<%=rule_name%>_workflow_action")
+        with_tag("input#<%=rule_name%>_workflow")
+      end  
+    end
+  end
+
+  describe "edit" do
+    it "show the edit form" do
+      re_rule = ReRule.make(:re_workflow_id => @re_workflow.id, 
+                            :rule_class_name => "RulesEngine::Rule::<%=rule_class%>",
+                            :data => valid_<%=rule_name%>_rule_data)
+      ReRule.stub!(:find).and_return(re_rule)
+      
+      get :edit, :re_workflow_id => @re_workflow.id, :re_rule_id => 1001, :rule_class_name => "RulesEngine::Rule::<%=rule_class%>"
+      response.should have_tag("form#re_rule_edit_form") do
+        with_tag("input#<%=rule_name%>_title", :value => 'Rule Title')     
+        with_tag("input#<%=rule_name%>_words_0_word", :value => 'word one')
+        with_tag("input#<%=rule_name%>_words_1_word", :value => 'word two')
+        with_tag("select#<%=rule_name%>_workflow_action", :value => 'start_workflow')
+        with_tag("input#<%=rule_name%>_workflow", :value => 'Other Workflow')
+      end  
+    end
+  end
+  
+end

data/rails_generators/templates/spec/lib/rules/simple_spec.rb

@@ -1,18 +1,18 @@
 require File.dirname(__FILE__) + '/../../spec_helper'
 
+def valid_<%=rule_name%>_rule_data
+  '["Rule Title", "Rule Description"]'
+end
+  
 describe RulesEngine::Rule::Simple do
 
   def valid_attributes
     {
-      :rule_<%=rule_name%>_title => 'Valid Title'
-      # :rule_<%=rule_name%>_description => 'Valid Description'
+      :<%=rule_name%>_title => 'Rule Title',
+      :<%=rule_name%>_description => 'Rule Description'
     }
   end
   
-  def valid_json_data
-    '["Valid Title", "Valid Description"]'
-  end
-  
   it "should be discoverable" do
     RulesEngine::Discovery.rule_class("RulesEngine::Rule::Simple").should == RulesEngine::Rule::Simple
   end
@@ -26,50 +26,50 @@ describe RulesEngine::Rule::Simple do
       RulesEngine::Rule::Simple.options[:display_name].should == "Simple"
     end
 
-    it "should have the help template of '/re_rule_definitions/rule_<%=rule_name%>/help'" do
-      RulesEngine::Rule::Simple.options[:help_partial].should == '/re_rule_definitions/rule_<%=rule_name%>/help'
+    it "should have the help template of '/re_rule_definitions/<%=rule_name%>/help'" do
+      RulesEngine::Rule::Simple.options[:help_partial].should == '/re_rule_definitions/<%=rule_name%>/help'
     end
 
-    it "should have the new template of '/re_rule_definitions/rule_<%=rule_name%>/new'" do
-      RulesEngine::Rule::Simple.options[:new_partial].should == '/re_rule_definitions/rule_<%=rule_name%>/new'
+    it "should have the new template of '/re_rule_definitions/<%=rule_name%>/new'" do
+      RulesEngine::Rule::Simple.options[:new_partial].should == '/re_rule_definitions/<%=rule_name%>/new'
     end
 
-    it "should have the edit view partial template of '/re_rule_definitions/rule_<%=rule_name%>/edit'" do
-      RulesEngine::Rule::Simple.options[:edit_partial].should == '/re_rule_definitions/rule_<%=rule_name%>/edit'
+    it "should have the edit view partial template of '/re_rule_definitions/<%=rule_name%>/edit'" do
+      RulesEngine::Rule::Simple.options[:edit_partial].should == '/re_rule_definitions/<%=rule_name%>/edit'
     end
   end
   
   describe "setting the rule data" do
     before(:each) do
-      @rule_<%=rule_name%> = RulesEngine::Rule::Simple.new
-      @rule_<%=rule_name%>.data = valid_json_data
+      @<%=rule_name%> = RulesEngine::Rule::Simple.new
+      @<%=rule_name%>.data = valid_<%=rule_name%>_rule_data
     end  
     
     describe "the data is valid" do
       it "should be valid" do
-        @rule_<%=rule_name%>.should be_valid
+        @<%=rule_name%>.should be_valid
       end
             
       it "should set the title" do
-        @rule_<%=rule_name%>.title.should == "Valid Title"        
+        @<%=rule_name%>.title.should == "Rule Title"        
       end
 
       it "should set the description" do
-        @rule_<%=rule_name%>.description.should == "Valid Description"        
+        @<%=rule_name%>.description.should == "Rule Description"        
       end
     end
 
     describe "the data is nil" do
       it "should set the title to nil" do
-        @rule_<%=rule_name%>.title.should_not be_nil
-        @rule_<%=rule_name%>.data = nil
-        @rule_<%=rule_name%>.title.should be_nil
+        @<%=rule_name%>.title.should_not be_nil
+        @<%=rule_name%>.data = nil
+        @<%=rule_name%>.title.should be_nil
       end
 
       it "should set the description to nil" do
-        @rule_<%=rule_name%>.title.should_not be_nil
-        @rule_<%=rule_name%>.data = nil
-        @rule_<%=rule_name%>.description.should be_nil
+        @<%=rule_name%>.title.should_not be_nil
+        @<%=rule_name%>.data = nil
+        @<%=rule_name%>.description.should be_nil
       end
     end
   end
@@ -77,69 +77,69 @@ describe RulesEngine::Rule::Simple do
   describe "the summary" do
     describe "description set" do
       it "should be the rule description" do
-        rule_<%=rule_name%> = RulesEngine::Rule::Simple.new
-        rule_<%=rule_name%>.should_receive(:description).and_return("mock description")
-        rule_<%=rule_name%>.summary.should == "mock description"
+        <%=rule_name%> = RulesEngine::Rule::Simple.new
+        <%=rule_name%>.should_receive(:description).and_return("mock description")
+        <%=rule_name%>.summary.should == "mock description"
       end
     end
     describe "description not set" do
       it "should be Does Nothing" do
-        rule_<%=rule_name%> = RulesEngine::Rule::Simple.new
-        rule_<%=rule_name%>.should_receive(:description).and_return(nil)
-        rule_<%=rule_name%>.summary.should == "Does Nothing"
+        <%=rule_name%> = RulesEngine::Rule::Simple.new
+        <%=rule_name%>.should_receive(:description).and_return(nil)
+        <%=rule_name%>.summary.should == "Does Nothing"
       end
     end
   end
 
   describe "the data" do
     it "should be converted to a json string" do
-      rule_<%=rule_name%> = RulesEngine::Rule::Simple.new
-      rule_<%=rule_name%>.should_receive(:title).and_return("mock title")
-      rule_<%=rule_name%>.should_receive(:description).and_return("mock description")
-      rule_<%=rule_name%>.data.should == '["mock title","mock description"]'
+      <%=rule_name%> = RulesEngine::Rule::Simple.new
+      <%=rule_name%>.should_receive(:title).and_return("mock title")
+      <%=rule_name%>.should_receive(:description).and_return("mock description")
+      <%=rule_name%>.data.should == '["mock title","mock description"]'
     end
   end
   
   describe "the expected_outcomes" do
     it "should be outcome next" do
-      rule_<%=rule_name%> = RulesEngine::Rule::Simple.new
-      rule_<%=rule_name%>.expected_outcomes.should == [:outcome => RulesEngine::Rule::Outcome::NEXT]
+      <%=rule_name%> = RulesEngine::Rule::Simple.new
+      <%=rule_name%>.expected_outcomes.should == [:outcome => RulesEngine::Rule::Outcome::NEXT]
     end
   end
   
   describe "setting the rule attributes" do
     before(:each) do
-      @rule_<%=rule_name%> = RulesEngine::Rule::Simple.new
+      @<%=rule_name%> = RulesEngine::Rule::Simple.new
     end  
     
     it "should be valid with valid attributes" do
-      @rule_<%=rule_name%>.attributes = valid_attributes
-      @rule_<%=rule_name%>.should be_valid
+      @<%=rule_name%>.attributes = valid_attributes
+      @<%=rule_name%>.should be_valid
     end            
   
-    describe "setting the rule_<%=rule_name%>_title" do
+    describe "setting the <%=rule_name%>_title" do
       it "should set the title" do
-        @rule_<%=rule_name%>.attributes = valid_attributes
-        @rule_<%=rule_name%>.title.should == 'Valid Title'
+        @<%=rule_name%>.attributes = valid_attributes
+        @<%=rule_name%>.title.should == 'Rule Title'
       end            
     
-      it "should not be valid if the 'rule_<%=rule_name%>_title' attribute is missing" do
-        @rule_<%=rule_name%>.attributes = valid_attributes.except(:rule_<%=rule_name%>_title)
-        @rule_<%=rule_name%>.should_not be_valid
-        @rule_<%=rule_name%>.errors.should include(:rule_<%=rule_name%>_title)
+      it "should not be valid if the '<%=rule_name%>_title' attribute is missing" do
+        @<%=rule_name%>.attributes = valid_attributes.except(:<%=rule_name%>_title)
+        @<%=rule_name%>.should_not be_valid
+        @<%=rule_name%>.errors.should include(:<%=rule_name%>_title)
       end            
     
-      it "should not be valid if the 'rule_<%=rule_name%>_title' attribute is blank" do
-        @rule_<%=rule_name%>.attributes = valid_attributes.merge(:rule_<%=rule_name%>_title => "")
-        @rule_<%=rule_name%>.should_not be_valid
-        @rule_<%=rule_name%>.errors.should include(:rule_<%=rule_name%>_title)
+      it "should not be valid if the '<%=rule_name%>_title' attribute is blank" do
+        @<%=rule_name%>.attributes = valid_attributes.merge(:<%=rule_name%>_title => "")
+        @<%=rule_name%>.should_not be_valid
+        @<%=rule_name%>.errors.should include(:<%=rule_name%>_title)
       end                
     end
 
-    describe "setting the rule_<%=rule_name%>_description" do
+    describe "setting the <%=rule_name%>_description" do
       it "should set the description" do
-        @rule_<%=rule_name%>.attributes = valid_attributes.merge(:rule_<%=rule_name%>_description => 'Valid Description')
-        @rule_<%=rule_name%>.description.should == 'Valid Description'
+        @<%=rule_name%>.attributes = valid_attributes.merge(:<%=rule_name%>_description => 'Rule Description')
+        @<%=rule_name%>.description.should == 'Rule Description'
       end            
     end
   end
@@ -154,8 +154,58 @@ describe RulesEngine::Rule::Simple do
   
   describe "processing the rule" do
     it "should do nothing" do
-      @rule_<%=rule_name%> = RulesEngine::Rule::Simple.new
-      @rule_<%=rule_name%>.process(1001, {}).outcome.should == RulesEngine::Rule::Outcome::NEXT
+      @<%=rule_name%> = RulesEngine::Rule::Simple.new
+      @<%=rule_name%>.process(1001, {}).outcome.should == RulesEngine::Rule::Outcome::NEXT
     end        
   end
 end
+
+
+describe ReWorkflowRulesController, :type => :controller  do
+  integrate_views
+  
+  before(:each) do
+    controller.instance_eval { flash.stub!(:sweep) }
+
+    RulesEngine::Discovery.discover!
+        
+    controller.stub!(:rules_engine_reader_access_required).and_return(true)
+    controller.stub!(:rules_engine_editor_access_required).and_return(true)
+
+    @re_workflow = ReWorkflow.make
+    ReWorkflow.stub!(:find).and_return(@re_workflow)
+  end  
+  
+  describe "help" do
+    it "should assign the <%=rule_name%> rule class" do
+      get :help, :rule_class_name => "RulesEngine::Rule::Simple"
+      assigns[:rule_class].should == RulesEngine::Rule::Simple
+    end
+  end
+
+  describe "new" do
+    it "show the new form" do
+      get :new, :rule_class_name => "RulesEngine::Rule::Simple"
+      response.should have_tag("form#re_rule_new_form") do
+        with_tag("input#<%=rule_name%>_title")
+        with_tag("input#<%=rule_name%>_description")      
+      end  
+    end
+  end
+  
+  describe "edit" do
+    it "show the edit form" do
+      re_rule = ReRule.make(:re_workflow_id => @re_workflow.id, 
+                            :rule_class_name => "RulesEngine::Rule::Simple",
+                            :data => valid_<%=rule_name%>_rule_data)
+      ReRule.stub!(:find).and_return(re_rule)
+      
+      get :edit, :re_workflow_id => @re_workflow.id, :re_rule_id => 1001, :rule_class_name => "RulesEngine::Rule::Simple"
+      response.should have_tag("form#re_rule_edit_form") do
+        with_tag("input#<%=rule_name%>_title", :value => 'Rule Title')     
+        with_tag("input#<%=rule_name%>_description", :value => 'Rule Description')     
+      end  
+    end
+  end
+  
+end

data/rails_generators/templates/spec/models/re_plan_spec.rb

@@ -4,7 +4,7 @@ describe RePlan do
   def valid_attributes
     {
       :code => "AA MOCK",
-      :title => "Mock Title"
+      :title => "Rule Title"
     }
   end
 

data/rails_generators/templates/spec/models/re_rule_spec.rb

@@ -4,7 +4,7 @@ describe ReRule do
   def valid_attributes
     {
       :rule_class_name => "MockRuleClass",
-      :title => "Mock Title",      
+      :title => "Rule Title",      
       :summary => "Mock Summary",
       :data => '["Rule Title", ["one", "two"], "start_workflow", "Other Pipeline"]'
     }
@@ -15,8 +15,9 @@ describe ReRule do
     @rule.stub!(:title=)
     @rule.stub!(:summary=)
     @rule.stub!(:data=)
-    @rule.stub!(:after_add_to_workflow)
-    @rule.stub!(:before_remove_from_workflow)
+    @rule.stub!(:before_create)
+    @rule.stub!(:before_update)
+    @rule.stub!(:before_destroy)
     @rule.stub!(:expected_outcomes).and_return([])
     @rule.stub!(:valid?).and_return(true)
     @rule_class = mock("MockRuleClass")
@@ -153,31 +154,35 @@ describe ReRule do
     end    
   end
   
-  describe "after saving a re_rule" do
+  describe "after creating a re_rule" do
     it "should notify the rule" do
       re_rule = ReRule.new(valid_attributes)
       re_rule.stub!(:re_workflow).and_return(@re_workflow)
 
-      @re_workflow.stub!(:code).and_return('1001')
-      re_rule.stub!(:rule).and_return(@rule)
-
-      updated_code = nil
-      @rule.should_receive(:after_add_to_workflow) do |re_workflow_code|
-        updated_code = re_workflow_code
-      end
+      @rule.should_receive(:before_create) 
+      re_rule.save
+    end  
+  end
+  
+  describe "after updating a re_rule" do
+    it "should notify the rule" do
+      re_rule = ReRule.new(valid_attributes)
+      re_rule.stub!(:re_workflow).and_return(@re_workflow)
+      re_rule.save
+      
+      re_rule.title = "New Title"
+      @rule.should_receive(:before_update) 
       re_rule.save
-      updated_code.should == '1001'
     end  
   end
   
   describe "before destroying a re_rule" do
     it "should notify the rule" do
-      @re_workflow = mock('re_workflow', :code => "1001", :valid? => true)
-      @re_rule = ReRule.new(valid_attributes)
-      @re_rule.stub!(:re_workflow).and_return(@re_workflow)
+      re_rule = ReRule.new(valid_attributes)
+      re_rule.stub!(:re_workflow).and_return(@re_workflow)
 
-      @rule.should_receive(:before_remove_from_workflow).with("1001")
-      @re_rule.destroy
+      @rule.should_receive(:before_destroy)
+      re_rule.destroy
     end  
   end
   
@@ -263,7 +268,7 @@ describe ReRule do
   
   describe "moving items in a list" do
     it "should move a rule down in the list" do
-      re_workflow = ReWorkflow.create!(:code => "AA-MOCK",:title => "Mock Title")
+      re_workflow = ReWorkflow.create!(:code => "AA-MOCK",:title => "Rule Title")
       
       re_rule_1 = ReRule.new(valid_attributes)
       re_rule_2 = ReRule.new(valid_attributes)