rugged 0.28.4 → 0.28.4.1

data/vendor/libgit2/src/attr_file.h

@@ -14,7 +14,7 @@
 #include "vector.h"
 #include "pool.h"
 #include "buffer.h"
-#include "futils.h"
+#include "fileops.h"
 
 #define GIT_ATTR_FILE			".gitattributes"
 #define GIT_ATTR_FILE_INREPO	"attributes"
@@ -32,17 +32,19 @@
 #define GIT_ATTR_FNMATCH_MATCH_ALL	(1U << 8)
 #define GIT_ATTR_FNMATCH_ALLOWNEG   (1U << 9)
 #define GIT_ATTR_FNMATCH_ALLOWMACRO (1U << 10)
+#define GIT_ATTR_FNMATCH_LEADINGDIR (1U << 11)
+#define GIT_ATTR_FNMATCH_NOLEADINGDIR (1U << 12)
 
 #define GIT_ATTR_FNMATCH__INCOMING \
-	(GIT_ATTR_FNMATCH_ALLOWSPACE | GIT_ATTR_FNMATCH_ALLOWNEG | GIT_ATTR_FNMATCH_ALLOWMACRO)
+	(GIT_ATTR_FNMATCH_ALLOWSPACE | GIT_ATTR_FNMATCH_ALLOWNEG | \
+	 GIT_ATTR_FNMATCH_ALLOWMACRO | GIT_ATTR_FNMATCH_NOLEADINGDIR)
 
 typedef enum {
 	GIT_ATTR_FILE__IN_MEMORY   = 0,
 	GIT_ATTR_FILE__FROM_FILE   = 1,
 	GIT_ATTR_FILE__FROM_INDEX  = 2,
-	GIT_ATTR_FILE__FROM_HEAD   = 3,
 
-	GIT_ATTR_FILE_NUM_SOURCES  = 4
+	GIT_ATTR_FILE_NUM_SOURCES  = 3
 } git_attr_file_source;
 
 extern const char *git_attr__true;
@@ -132,8 +134,7 @@ extern int git_attr_get_many_with_session(
 typedef int (*git_attr_file_parser)(
 	git_repository *repo,
 	git_attr_file *file,
-	const char *data,
-	bool allow_macros);
+	const char *data);
 
 /*
  * git_attr_file API
@@ -152,8 +153,7 @@ int git_attr_file__load(
 	git_attr_session *attr_session,
 	git_attr_file_entry *ce,
 	git_attr_file_source source,
-	git_attr_file_parser parser,
-	bool allow_macros);
+	git_attr_file_parser parser);
 
 int git_attr_file__load_standalone(
 	git_attr_file **out, const char *path);
@@ -162,7 +162,7 @@ int git_attr_file__out_of_date(
 	git_repository *repo, git_attr_session *session, git_attr_file *file);
 
 int git_attr_file__parse_buffer(
-	git_repository *repo, git_attr_file *attrs, const char *data, bool allow_macros);
+	git_repository *repo, git_attr_file *attrs, const char *data);
 
 int git_attr_file__clear_rules(
 	git_attr_file *file, bool need_lock);

data/vendor/libgit2/src/attrcache.c

@@ -33,7 +33,12 @@ GIT_INLINE(void) attr_cache_unlock(git_attr_cache *cache)
 GIT_INLINE(git_attr_file_entry *) attr_cache_lookup_entry(
 	git_attr_cache *cache, const char *path)
 {
-	return git_strmap_get(cache->files, path);
+	size_t pos = git_strmap_lookup_index(cache->files, path);
+
+	if (git_strmap_valid_index(cache->files, pos))
+		return git_strmap_value_at(cache->files, pos);
+	else
+		return NULL;
 }
 
 int git_attr_cache__alloc_file_entry(
@@ -54,7 +59,7 @@ int git_attr_cache__alloc_file_entry(
 			cachesize++;
 	}
 
-	ce = git_pool_mallocz(pool, cachesize);
+	ce = git_pool_mallocz(pool, (uint32_t)cachesize);
 	GIT_ERROR_CHECK_ALLOC(ce);
 
 	if (baselen) {
@@ -75,16 +80,18 @@ int git_attr_cache__alloc_file_entry(
 static int attr_cache_make_entry(
 	git_attr_file_entry **out, git_repository *repo, const char *path)
 {
+	int error = 0;
 	git_attr_cache *cache = git_repository_attr_cache(repo);
 	git_attr_file_entry *entry = NULL;
-	int error;
 
-	if ((error = git_attr_cache__alloc_file_entry(&entry, git_repository_workdir(repo),
-						      path, &cache->pool)) < 0)
-		return error;
+	error = git_attr_cache__alloc_file_entry(
+		&entry, git_repository_workdir(repo), path, &cache->pool);
 
-	if ((error = git_strmap_set(cache->files, entry->path, entry)) < 0)
-		return error;
+	if (!error) {
+		git_strmap_insert(cache->files, entry->path, entry, &error);
+		if (error > 0)
+			error = 0;
+	}
 
 	*out = entry;
 	return error;
@@ -208,8 +215,7 @@ int git_attr_cache__get(
 	git_attr_file_source source,
 	const char *base,
 	const char *filename,
-	git_attr_file_parser parser,
-	bool allow_macros)
+	git_attr_file_parser parser)
 {
 	int error = 0;
 	git_attr_cache *cache = git_repository_attr_cache(repo);
@@ -222,7 +228,7 @@ int git_attr_cache__get(
 
 	/* load file if we don't have one or if existing one is out of date */
 	if (!file || (error = git_attr_file__out_of_date(repo, attr_session, file)) > 0)
-		error = git_attr_file__load(&updated, repo, attr_session, entry, source, parser, allow_macros);
+		error = git_attr_file__load(&updated, repo, attr_session, entry, source, parser);
 
 	/* if we loaded the file, insert into and/or update cache */
 	if (updated) {
@@ -259,15 +265,19 @@ bool git_attr_cache__is_cached(
 	const char *filename)
 {
 	git_attr_cache *cache = git_repository_attr_cache(repo);
-	git_attr_file_entry *entry;
 	git_strmap *files;
+	size_t pos;
+	git_attr_file_entry *entry;
 
 	if (!cache || !(files = cache->files))
 		return false;
 
-	if ((entry = git_strmap_get(files, filename)) == NULL)
+	pos = git_strmap_lookup_index(files, filename);
+	if (!git_strmap_valid_index(files, pos))
 		return false;
 
+	entry = git_strmap_value_at(files, pos);
+
 	return entry && (entry->file[source] != NULL);
 }
 
@@ -390,8 +400,8 @@ int git_attr_cache__init(git_repository *repo)
 	/* allocate hashtable for attribute and ignore file contents,
 	 * hashtable for attribute macros, and string pool
 	 */
-	if ((ret = git_strmap_new(&cache->files)) < 0 ||
-	    (ret = git_strmap_new(&cache->macros)) < 0)
+	if ((ret = git_strmap_alloc(&cache->files)) < 0 ||
+		(ret = git_strmap_alloc(&cache->macros)) < 0)
 		goto cancel;
 
 	git_pool_init(&cache->pool, 1);
@@ -425,43 +435,35 @@ void git_attr_cache_flush(git_repository *repo)
 int git_attr_cache__insert_macro(git_repository *repo, git_attr_rule *macro)
 {
 	git_attr_cache *cache = git_repository_attr_cache(repo);
-	git_attr_rule *preexisting;
-	bool locked = false;
-	int error = 0;
-
-	/*
-	 * Callers assume that if we return success, that the
-	 * macro will have been adopted by the attributes cache.
-	 * Thus, we have to free the macro here if it's not being
-	 * added to the cache.
-	 *
-	 * TODO: generate warning log if (macro->assigns.length == 0)
-	 */
-	if (macro->assigns.length == 0) {
-		git_attr_rule__free(macro);
-		goto out;
-	}
-
-	if ((error = attr_cache_lock(cache)) < 0)
-		goto out;
-	locked = true;
+	git_strmap *macros = cache->macros;
+	int error;
 
-	if ((preexisting = git_strmap_get(cache->macros, macro->match.pattern)) != NULL)
-	    git_attr_rule__free(preexisting);
+	/* TODO: generate warning log if (macro->assigns.length == 0) */
+	if (macro->assigns.length == 0)
+		return 0;
 
-	if ((error = git_strmap_set(cache->macros, macro->match.pattern, macro)) < 0)
-	    goto out;
+	if (attr_cache_lock(cache) < 0) {
+		git_error_set(GIT_ERROR_OS, "unable to get attr cache lock");
+		error = -1;
+	} else {
+		git_strmap_insert(macros, macro->match.pattern, macro, &error);
+		git_mutex_unlock(&cache->lock);
+	}
 
-out:
-	if (locked)
-		attr_cache_unlock(cache);
-	return error;
+	return (error < 0) ? -1 : 0;
 }
 
 git_attr_rule *git_attr_cache__lookup_macro(
 	git_repository *repo, const char *name)
 {
 	git_strmap *macros = git_repository_attr_cache(repo)->macros;
+	size_t pos;
 
-	return git_strmap_get(macros, name);
+	pos = git_strmap_lookup_index(macros, name);
+
+	if (!git_strmap_valid_index(macros, pos))
+		return NULL;
+
+	return (git_attr_rule *)git_strmap_value_at(macros, pos);
 }
+

data/vendor/libgit2/src/attrcache.h

@@ -34,8 +34,7 @@ extern int git_attr_cache__get(
 	git_attr_file_source source,
 	const char *base,
 	const char *filename,
-	git_attr_file_parser parser,
-	bool allow_macros);
+	git_attr_file_parser parser);
 
 extern bool git_attr_cache__is_cached(
 	git_repository *repo,

data/vendor/libgit2/src/blame.c

@@ -204,7 +204,7 @@ static int normalize_options(
 	memcpy(out, in, sizeof(git_blame_options));
 
 	/* No newest_commit => HEAD */
-	if (git_oid_is_zero(&out->newest_commit)) {
+	if (git_oid_iszero(&out->newest_commit)) {
 		if (git_reference_name_to_id(&out->newest_commit, repo, "HEAD") < 0) {
 			return -1;
 		}
@@ -268,7 +268,7 @@ static git_blame_hunk *split_hunk_in_vector(
 static int index_blob_lines(git_blame *blame)
 {
     const char *buf = blame->final_buf;
-    size_t len = blame->final_buf_size;
+    git_off_t len = blame->final_buf_size;
     int num = 0, incomplete = 0, bol = 1;
     size_t *i;
 
@@ -335,15 +335,8 @@ static int blame_internal(git_blame *blame)
 	if ((error = load_blob(blame)) < 0 ||
 	    (error = git_blame__get_origin(&o, blame, blame->final, blame->path)) < 0)
 		goto cleanup;
-
-	if (git_blob_rawsize(blame->final_blob) > SIZE_MAX) {
-		git_error_set(GIT_ERROR_NOMEMORY, "blob is too large to blame");
-		error = -1;
-		goto cleanup;
-	}
-
 	blame->final_buf = git_blob_rawcontent(blame->final_blob);
-	blame->final_buf_size = (size_t)git_blob_rawsize(blame->final_blob);
+	blame->final_buf_size = git_blob_rawsize(blame->final_blob);
 
 	ent = git__calloc(1, sizeof(git_blame__entry));
 	GIT_ERROR_CHECK_ALLOC(ent);
@@ -415,7 +408,7 @@ on_error:
 
 static bool hunk_is_bufferblame(git_blame_hunk *hunk)
 {
-	return git_oid_is_zero(&hunk->final_commit_id);
+	return git_oid_iszero(&hunk->final_commit_id);
 }
 
 static int buffer_hunk_cb(
@@ -531,14 +524,9 @@ int git_blame_buffer(
 	return 0;
 }
 
-int git_blame_options_init(git_blame_options *opts, unsigned int version)
+int git_blame_init_options(git_blame_options *opts, unsigned int version)
 {
 	GIT_INIT_STRUCTURE_FROM_TEMPLATE(
 		opts, version, git_blame_options, GIT_BLAME_OPTIONS_INIT);
 	return 0;
 }
-
-int git_blame_init_options(git_blame_options *opts, unsigned int version)
-{
-	return git_blame_options_init(opts, version);
-}

data/vendor/libgit2/src/blame.h

@@ -84,7 +84,7 @@ struct git_blame {
 	git_blame__entry *ent;
 	int num_lines;
 	const char *final_buf;
-	size_t final_buf_size;
+	git_off_t final_buf_size;
 };
 
 git_blame *git_blame__alloc(

data/vendor/libgit2/src/blame_git.c

@@ -219,7 +219,7 @@ static void dup_entry(git_blame__entry *dst, git_blame__entry *src)
  * split_overlap() divided an existing blame e into up to three parts in split.
  * Adjust the linked list of blames in the scoreboard to reflect the split.
  */
-static int split_blame(git_blame *blame, git_blame__entry *split, git_blame__entry *e)
+static void split_blame(git_blame *blame, git_blame__entry *split, git_blame__entry *e)
 {
 	git_blame__entry *new_entry;
 
@@ -229,13 +229,11 @@ static int split_blame(git_blame *blame, git_blame__entry *split, git_blame__ent
 
 		/* The last part -- me */
 		new_entry = git__malloc(sizeof(*new_entry));
-		GIT_ERROR_CHECK_ALLOC(new_entry);
 		memcpy(new_entry, &(split[2]), sizeof(git_blame__entry));
 		add_blame_entry(blame, new_entry);
 
 		/* ... and the middle part -- parent */
 		new_entry = git__malloc(sizeof(*new_entry));
-		GIT_ERROR_CHECK_ALLOC(new_entry);
 		memcpy(new_entry, &(split[1]), sizeof(git_blame__entry));
 		add_blame_entry(blame, new_entry);
 	} else if (!split[0].suspect && !split[2].suspect) {
@@ -248,19 +246,15 @@ static int split_blame(git_blame *blame, git_blame__entry *split, git_blame__ent
 		/* me and then parent */
 		dup_entry(e, &split[0]);
 		new_entry = git__malloc(sizeof(*new_entry));
-		GIT_ERROR_CHECK_ALLOC(new_entry);
 		memcpy(new_entry, &(split[1]), sizeof(git_blame__entry));
 		add_blame_entry(blame, new_entry);
 	} else {
 		/* parent and then me */
 		dup_entry(e, &split[1]);
 		new_entry = git__malloc(sizeof(*new_entry));
-		GIT_ERROR_CHECK_ALLOC(new_entry);
 		memcpy(new_entry, &(split[2]), sizeof(git_blame__entry));
 		add_blame_entry(blame, new_entry);
 	}
-
-	return 0;
 }
 
 /*
@@ -278,7 +272,7 @@ static void decref_split(git_blame__entry *split)
  * Helper for blame_chunk(). blame_entry e is known to overlap with the patch
  * hunk; split it and pass blame to the parent.
  */
-static int blame_overlap(
+static void blame_overlap(
 		git_blame *blame,
 		git_blame__entry *e,
 		size_t tlno,
@@ -290,11 +284,8 @@ static int blame_overlap(
 
 	split_overlap(split, e, tlno, plno, same, parent);
 	if (split[1].suspect)
-		if (split_blame(blame, split, e) < 0)
-			return -1;
+		split_blame(blame, split, e);
 	decref_split(split);
-
-	return 0;
 }
 
 /*
@@ -302,7 +293,7 @@ static int blame_overlap(
  * e and its parent. Find and split the overlap, and pass blame to the
  * overlapping part to the parent.
  */
-static int blame_chunk(
+static void blame_chunk(
 		git_blame *blame,
 		size_t tlno,
 		size_t plno,
@@ -318,12 +309,9 @@ static int blame_chunk(
 		if (same <= e->s_lno)
 			continue;
 		if (tlno < e->s_lno + e->num_lines) {
-			if (blame_overlap(blame, e, tlno, plno, same, parent) < 0)
-				return -1;
+			blame_overlap(blame, e, tlno, plno, same, parent);
 		}
 	}
-
-	return 0;
 }
 
 static int my_emit(
@@ -333,8 +321,7 @@ static int my_emit(
 {
 	blame_chunk_cb_data *d = (blame_chunk_cb_data *)cb_data;
 
-	if (blame_chunk(d->blame, d->tlno, d->plno, start_b, d->target, d->parent) < 0)
-		return -1;
+	blame_chunk(d->blame, d->tlno, d->plno, start_b, d->target, d->parent);
 	d->plno = start_a + count_a;
 	d->tlno = start_b + count_b;
 
@@ -413,8 +400,7 @@ static int pass_blame_to_parent(
 		return -1;
 
 	/* The reset (i.e. anything after tlno) are the same as the parent */
-	if (blame_chunk(blame, d.tlno, d.plno, last_in_target, target, parent) < 0)
-		return -1;
+	blame_chunk(blame, d.tlno, d.plno, last_in_target, target, parent);
 
 	return 0;
 }

data/vendor/libgit2/src/blob.c

@@ -25,18 +25,18 @@ const void *git_blob_rawcontent(const git_blob *blob)
 		return git_odb_object_data(blob->data.odb);
 }
 
-git_object_size_t git_blob_rawsize(const git_blob *blob)
+git_off_t git_blob_rawsize(const git_blob *blob)
 {
 	assert(blob);
 	if (blob->raw)
 		return blob->data.raw.size;
 	else
-		return (git_object_size_t)git_odb_object_size(blob->data.odb);
+		return (git_off_t)git_odb_object_size(blob->data.odb);
 }
 
 int git_blob__getbuf(git_buf *buffer, git_blob *blob)
 {
-	git_object_size_t size = git_blob_rawsize(blob);
+	git_off_t size = git_blob_rawsize(blob);
 
 	GIT_ERROR_CHECK_BLOBSIZE(size);
 	return git_buf_set(buffer, git_blob_rawcontent(blob), (size_t)size);
@@ -70,7 +70,7 @@ int git_blob__parse(void *_blob, git_odb_object *odb_obj)
 	return 0;
 }
 
-int git_blob_create_from_buffer(
+int git_blob_create_frombuffer(
 	git_oid *id, git_repository *repo, const void *buffer, size_t len)
 {
 	int error;
@@ -91,13 +91,13 @@ int git_blob_create_from_buffer(
 }
 
 static int write_file_stream(
-	git_oid *id, git_odb *odb, const char *path, git_object_size_t file_size)
+	git_oid *id, git_odb *odb, const char *path, git_off_t file_size)
 {
 	int fd, error;
 	char buffer[FILEIO_BUFSIZE];
 	git_odb_stream *stream = NULL;
 	ssize_t read_len = -1;
-	git_object_size_t written = 0;
+	git_off_t written = 0;
 
 	if ((error = git_odb_open_wstream(
 			&stream, odb, file_size, GIT_OBJECT_BLOB)) < 0)
@@ -129,7 +129,7 @@ static int write_file_stream(
 
 static int write_file_filtered(
 	git_oid *id,
-	git_object_size_t *size,
+	git_off_t *size,
 	git_odb *odb,
 	const char *full_path,
 	git_filter_list *fl)
@@ -184,7 +184,7 @@ int git_blob__create_from_paths(
 	int error;
 	struct stat st;
 	git_odb *odb = NULL;
-	git_object_size_t size;
+	git_off_t size;
 	mode_t mode;
 	git_buf path = GIT_BUF_INIT;
 
@@ -263,13 +263,13 @@ done:
 	return error;
 }
 
-int git_blob_create_from_workdir(
+int git_blob_create_fromworkdir(
 	git_oid *id, git_repository *repo, const char *path)
 {
 	return git_blob__create_from_paths(id, NULL, repo, NULL, path, 0, true);
 }
 
-int git_blob_create_from_disk(
+int git_blob_create_fromdisk(
 	git_oid *id, git_repository *repo, const char *path)
 {
 	int error;
@@ -325,7 +325,7 @@ static int blob_writestream_write(git_writestream *_stream, const char *buffer,
 	return git_filebuf_write(&stream->fbuf, buffer, len);
 }
 
-int git_blob_create_from_stream(git_writestream **out, git_repository *repo, const char *hintpath)
+int git_blob_create_fromstream(git_writestream **out, git_repository *repo, const char *hintpath)
 {
 	int error;
 	git_buf path = GIT_BUF_INIT;
@@ -364,7 +364,7 @@ cleanup:
 	return error;
 }
 
-int git_blob_create_from_stream_commit(git_oid *out, git_writestream *_stream)
+int git_blob_create_fromstream_commit(git_oid *out, git_writestream *_stream)
 {
 	int error;
 	blob_writestream *stream = (blob_writestream *) _stream;
@@ -389,7 +389,7 @@ cleanup:
 int git_blob_is_binary(const git_blob *blob)
 {
 	git_buf content = GIT_BUF_INIT;
-	git_object_size_t size;
+	git_off_t size;
 
 	assert(blob);
 
@@ -400,40 +400,25 @@ int git_blob_is_binary(const git_blob *blob)
 	return git_buf_text_is_binary(&content);
 }
 
-int git_blob_filter(
+int git_blob_filtered_content(
 	git_buf *out,
 	git_blob *blob,
 	const char *path,
-	git_blob_filter_options *given_opts)
+	int check_for_binary_data)
 {
 	int error = 0;
 	git_filter_list *fl = NULL;
-	git_blob_filter_options opts = GIT_BLOB_FILTER_OPTIONS_INIT;
-	git_filter_flag_t flags = GIT_FILTER_DEFAULT;
 
 	assert(blob && path && out);
 
 	git_buf_sanitize(out);
 
-	GIT_ERROR_CHECK_VERSION(
-		given_opts, GIT_BLOB_FILTER_OPTIONS_VERSION, "git_blob_filter_options");
-
-	if (given_opts != NULL)
-		memcpy(&opts, given_opts, sizeof(git_blob_filter_options));
-
-	if ((opts.flags & GIT_BLOB_FILTER_CHECK_FOR_BINARY) != 0 &&
-	    git_blob_is_binary(blob))
+	if (check_for_binary_data && git_blob_is_binary(blob))
 		return 0;
 
-	if ((opts.flags & GIT_BLOB_FILTER_NO_SYSTEM_ATTRIBUTES) != 0)
-		flags |= GIT_FILTER_NO_SYSTEM_ATTRIBUTES;
-
-	if ((opts.flags & GIT_BLOB_FILTER_ATTTRIBUTES_FROM_HEAD) != 0)
-		flags |= GIT_FILTER_ATTRIBUTES_FROM_HEAD;
-
 	if (!(error = git_filter_list_load(
 			&fl, git_blob_owner(blob), blob, path,
-			GIT_FILTER_TO_WORKTREE, flags))) {
+			GIT_FILTER_TO_WORKTREE, GIT_FILTER_DEFAULT))) {
 
 		error = git_filter_list_apply_to_blob(out, fl, blob);
 
@@ -442,52 +427,3 @@ int git_blob_filter(
 
 	return error;
 }
-
-/* Deprecated functions */
-
-int git_blob_create_frombuffer(
-	git_oid *id, git_repository *repo, const void *buffer, size_t len)
-{
-	return git_blob_create_from_buffer(id, repo, buffer, len);
-}
-
-int git_blob_create_fromworkdir(git_oid *id, git_repository *repo, const char *relative_path)
-{
-	return git_blob_create_from_workdir(id, repo, relative_path);
-}
-
-int git_blob_create_fromdisk(git_oid *id, git_repository *repo, const char *path)
-{
-	return git_blob_create_from_disk(id, repo, path);
-}
-
-int git_blob_create_fromstream(
-    git_writestream **out,
-    git_repository *repo,
-    const char *hintpath)
-{
-	return  git_blob_create_from_stream(out, repo, hintpath);
-}
-
-int git_blob_create_fromstream_commit(
-	git_oid *out,
-	git_writestream *stream)
-{
-	return git_blob_create_from_stream_commit(out, stream);
-}
-
-int git_blob_filtered_content(
-	git_buf *out,
-	git_blob *blob,
-	const char *path,
-	int check_for_binary_data)
-{
-	git_blob_filter_options opts = GIT_BLOB_FILTER_OPTIONS_INIT;
-
-	if (check_for_binary_data)
-		opts.flags |= GIT_BLOB_FILTER_CHECK_FOR_BINARY;
-	else
-		opts.flags &= ~GIT_BLOB_FILTER_CHECK_FOR_BINARY;
-
-	return git_blob_filter(out, blob, path, &opts);
-}