rugged 0.17.0b2 → 0.17.0.b6

data/vendor/libgit2/src/transports/git.c

@@ -0,0 +1,245 @@
+/*
+ * Copyright (C) 2009-2012 the libgit2 contributors
+ *
+ * This file is part of libgit2, distributed under the GNU GPL v2 with
+ * a Linking Exception. For full terms see the included COPYING file.
+ */
+
+#include "git2/net.h"
+#include "git2/common.h"
+#include "git2/types.h"
+#include "git2/errors.h"
+#include "git2/net.h"
+#include "git2/revwalk.h"
+
+#include "vector.h"
+#include "transport.h"
+#include "pkt.h"
+#include "common.h"
+#include "netops.h"
+#include "filebuf.h"
+#include "repository.h"
+#include "fetch.h"
+#include "protocol.h"
+
+typedef struct {
+	git_transport parent;
+	char buff[1024];
+#ifdef GIT_WIN32
+	WSADATA wsd;
+#endif
+} transport_git;
+
+/*
+ * Create a git procol request.
+ *
+ * For example: 0035git-upload-pack /libgit2/libgit2\0host=github.com\0
+ */
+static int gen_proto(git_buf *request, const char *cmd, const char *url)
+{
+	char *delim, *repo;
+	char default_command[] = "git-upload-pack";
+	char host[] = "host=";
+	size_t len;
+
+	delim = strchr(url, '/');
+	if (delim == NULL) {
+		giterr_set(GITERR_NET, "Malformed URL");
+		return -1;
+	}
+
+	repo = delim;
+
+	delim = strchr(url, ':');
+	if (delim == NULL)
+		delim = strchr(url, '/');
+
+	if (cmd == NULL)
+		cmd = default_command;
+
+	len = 4 + strlen(cmd) + 1 + strlen(repo) + 1 + strlen(host) + (delim - url) + 1;
+
+	git_buf_grow(request, len);
+	git_buf_printf(request, "%04x%s %s%c%s",
+		(unsigned int)(len & 0x0FFFF), cmd, repo, 0, host);
+	git_buf_put(request, url, delim - url);
+	git_buf_putc(request, '\0');
+
+	if (git_buf_oom(request))
+		return -1;
+
+	return 0;
+}
+
+static int send_request(git_transport *t, const char *cmd, const char *url)
+{
+	int error;
+	git_buf request = GIT_BUF_INIT;
+
+	error = gen_proto(&request, cmd, url);
+	if (error < 0)
+		goto cleanup;
+
+	error = gitno_send(t, request.ptr, request.size, 0);
+
+cleanup:
+	git_buf_free(&request);
+	return error;
+}
+
+/*
+ * Parse the URL and connect to a server, storing the socket in
+ * out. For convenience this also takes care of asking for the remote
+ * refs
+ */
+static int do_connect(transport_git *t, const char *url)
+{
+	char *host, *port;
+	const char prefix[] = "git://";
+
+	if (!git__prefixcmp(url, prefix))
+		url += strlen(prefix);
+
+	if (gitno_extract_host_and_port(&host, &port, url, GIT_DEFAULT_PORT) < 0)
+		return -1;
+
+	if (gitno_connect((git_transport *)t, host, port) < 0)
+		goto on_error;
+
+	if (send_request((git_transport *)t, NULL, url) < 0)
+		goto on_error;
+
+	git__free(host);
+	git__free(port);
+
+	return 0;
+
+on_error:
+	git__free(host);
+	git__free(port);
+	gitno_close(t->parent.socket);
+	return -1;
+}
+
+/*
+ * Since this is a network connection, we need to parse and store the
+ * pkt-lines at this stage and keep them there.
+ */
+static int git_connect(git_transport *transport, int direction)
+{
+	transport_git *t = (transport_git *) transport;
+
+	if (direction == GIT_DIR_PUSH) {
+		giterr_set(GITERR_NET, "Pushing over git:// is not supported");
+		return -1;
+	}
+
+	t->parent.direction = direction;
+
+	/* Connect and ask for the refs */
+	if (do_connect(t, transport->url) < 0)
+		return -1;
+
+	gitno_buffer_setup(transport, &transport->buffer, t->buff, sizeof(t->buff));
+
+	t->parent.connected = 1;
+	if (git_protocol_store_refs(transport, 1) < 0)
+		return -1;
+
+	if (git_protocol_detect_caps(git_vector_get(&transport->refs, 0), &transport->caps) < 0)
+		return -1;
+
+	return 0;
+}
+
+static int git_negotiation_step(struct git_transport *transport, void *data, size_t len)
+{
+	return gitno_send(transport, data, len, 0);
+}
+
+static int git_close(git_transport *t)
+{
+	git_buf buf = GIT_BUF_INIT;
+
+	if (git_pkt_buffer_flush(&buf) < 0)
+		return -1;
+	/* Can't do anything if there's an error, so don't bother checking  */
+	gitno_send(t, buf.ptr, buf.size, 0);
+	git_buf_free(&buf);
+
+	if (gitno_close(t->socket) < 0) {
+		giterr_set(GITERR_NET, "Failed to close socket");
+		return -1;
+	}
+
+	t->connected = 0;
+
+#ifdef GIT_WIN32
+	WSACleanup();
+#endif
+
+	return 0;
+}
+
+static void git_free(git_transport *transport)
+{
+	transport_git *t = (transport_git *) transport;
+	git_vector *refs = &transport->refs;
+	unsigned int i;
+
+	for (i = 0; i < refs->length; ++i) {
+		git_pkt *p = git_vector_get(refs, i);
+		git_pkt_free(p);
+	}
+	git_vector_free(refs);
+
+	refs = &transport->common;
+	for (i = 0; i < refs->length; ++i) {
+		git_pkt *p = git_vector_get(refs, i);
+		git_pkt_free(p);
+	}
+	git_vector_free(refs);
+
+	git__free(t->parent.url);
+	git__free(t);
+}
+
+int git_transport_git(git_transport **out)
+{
+	transport_git *t;
+#ifdef GIT_WIN32
+	int ret;
+#endif
+
+	t = git__malloc(sizeof(transport_git));
+	GITERR_CHECK_ALLOC(t);
+
+	memset(t, 0x0, sizeof(transport_git));
+	if (git_vector_init(&t->parent.common, 8, NULL))
+		goto on_error;
+
+	if (git_vector_init(&t->parent.refs, 16, NULL) < 0)
+		goto on_error;
+
+	t->parent.connect = git_connect;
+	t->parent.negotiation_step = git_negotiation_step;
+	t->parent.close = git_close;
+	t->parent.free = git_free;
+
+	*out = (git_transport *) t;
+
+#ifdef GIT_WIN32
+	ret = WSAStartup(MAKEWORD(2,2), &t->wsd);
+	if (ret != 0) {
+		git_free(*out);
+		giterr_set(GITERR_NET, "Winsock init failed");
+		return -1;
+	}
+#endif
+
+	return 0;
+
+on_error:
+	git__free(t);
+	return -1;
+}

data/{ext/rugged/vendor/libgit2-dist → vendor/libgit2}/src/transports/http.c

@@ -29,11 +29,8 @@ enum last_cb {
 
 typedef struct {
 	git_transport parent;
-	git_protocol proto;
-	git_vector refs;
-	git_vector common;
+	http_parser_settings settings;
 	git_buf buf;
-	git_remote_head **heads;
 	int error;
 	int transfer_finished :1,
 		ct_found :1,
@@ -46,7 +43,7 @@ typedef struct {
 	char *host;
 	char *port;
 	char *service;
-	git_transport_caps caps;
+	char buffer[4096];
 #ifdef GIT_WIN32
 	WSADATA wsd;
 #endif
@@ -183,17 +180,6 @@ static int on_headers_complete(http_parser *parser)
 	return 0;
 }
 
-static int on_body_store_refs(http_parser *parser, const char *str, size_t len)
-{
-	transport_http *t = (transport_http *) parser->data;
-
-	if (parser->status_code == 404) {
-		return git_buf_put(&t->buf, str, len);
-	}
-
-	return git_protocol_store_refs(&t->proto, str, len);
-}
-
 static int on_message_complete(http_parser *parser)
 {
 	transport_http *t = (transport_http *) parser->data;
@@ -208,51 +194,64 @@ static int on_message_complete(http_parser *parser)
 	return 0;
 }
 
-static int store_refs(transport_http *t)
+static int on_body_fill_buffer(http_parser *parser, const char *str, size_t len)
 {
-	http_parser_settings settings;
-	char buffer[1024];
-	gitno_buffer buf;
-	git_pkt *pkt;
-	int ret;
+	git_transport *transport = (git_transport *) parser->data;
+	transport_http *t = (transport_http *) parser->data;
+	gitno_buffer *buf = &transport->buffer;
 
-	http_parser_init(&t->parser, HTTP_RESPONSE);
-	t->parser.data = t;
-	memset(&settings, 0x0, sizeof(http_parser_settings));
-	settings.on_header_field = on_header_field;
-	settings.on_header_value = on_header_value;
-	settings.on_headers_complete = on_headers_complete;
-	settings.on_body = on_body_store_refs;
-	settings.on_message_complete = on_message_complete;
+	if (buf->len - buf->offset < len) {
+		giterr_set(GITERR_NET, "Can't fit data in the buffer");
+		return t->error = -1;
+	}
+
+	memcpy(buf->data + buf->offset, str, len);
+	buf->offset += len;
+
+	return 0;
+}
 
-	gitno_buffer_setup((git_transport *)t, &buf, buffer, sizeof(buffer));
+static int http_recv_cb(gitno_buffer *buf)
+{
+	git_transport *transport = (git_transport *) buf->cb_data;
+	transport_http *t = (transport_http *) transport;
+	size_t old_len;
+	gitno_buffer inner;
+	char buffer[2048];
+	int error;
 
-	while(1) {
-		size_t parsed;
+	if (t->transfer_finished)
+		return 0;
 
-		if ((ret = gitno_recv(&buf)) < 0)
-			return -1;
+	gitno_buffer_setup(transport, &inner, buffer, sizeof(buffer));
 
-		parsed = http_parser_execute(&t->parser, &settings, buf.data, buf.offset);
-		/* Both should happen at the same time */
-		if (parsed != buf.offset || t->error < 0)
-			return t->error;
+	if ((error = gitno_recv(&inner)) < 0)
+		return -1;
 
-		gitno_consume_n(&buf, parsed);
+	old_len = buf->offset;
+	http_parser_execute(&t->parser, &t->settings, inner.data, inner.offset);
+	if (t->error < 0)
+		return t->error;
 
-		if (ret == 0 || t->transfer_finished)
-			return 0;
-	}
+	return buf->offset - old_len;
+}
 
-	pkt = git_vector_get(&t->refs, 0);
-	if (pkt == NULL || pkt->type != GIT_PKT_COMMENT) {
-		giterr_set(GITERR_NET, "Invalid HTTP response");
-		return t->error = -1;
-	} else {
-		git_vector_remove(&t->refs, 0);
-	}
+/* Set up the gitno_buffer so calling gitno_recv() grabs data from the HTTP response */
+static void setup_gitno_buffer(git_transport *transport)
+{
+	transport_http *t = (transport_http *) transport;
 
-	return 0;
+	http_parser_init(&t->parser, HTTP_RESPONSE);
+	t->parser.data = t;
+	t->transfer_finished = 0;
+	memset(&t->settings, 0x0, sizeof(http_parser_settings));
+	t->settings.on_header_field = on_header_field;
+	t->settings.on_header_value = on_header_value;
+	t->settings.on_headers_complete = on_headers_complete;
+	t->settings.on_body = on_body_fill_buffer;
+	t->settings.on_message_complete = on_message_complete;
+
+	gitno_buffer_setup_callback(transport, &transport->buffer, t->buffer, sizeof(t->buffer), http_recv_cb, t);
 }
 
 static int http_connect(git_transport *transport, int direction)
@@ -263,6 +262,7 @@ static int http_connect(git_transport *transport, int direction)
 	const char *service = "upload-pack";
 	const char *url = t->parent.url, *prefix_http = "http://", *prefix_https = "https://";
 	const char *default_port;
+	git_pkt *pkt;
 
 	if (direction == GIT_DIR_PUSH) {
 		giterr_set(GITERR_NET, "Pushing over HTTP is not implemented");
@@ -270,8 +270,6 @@ static int http_connect(git_transport *transport, int direction)
 	}
 
 	t->parent.direction = direction;
-	if (git_vector_init(&t->refs, 16, NULL) < 0)
-		return -1;
 
 	if (!git__prefixcmp(url, prefix_http)) {
 		url = t->parent.url + strlen(prefix_http);
@@ -304,302 +302,61 @@ static int http_connect(git_transport *transport, int direction)
 	if (gitno_send(transport, request.ptr, request.size, 0) < 0)
 		goto cleanup;
 
-	ret = store_refs(t);
-
-cleanup:
-	git_buf_free(&request);
-	git_buf_clear(&t->buf);
-
-	return ret;
-}
-
-static int http_ls(git_transport *transport, git_headlist_cb list_cb, void *opaque)
-{
-	transport_http *t = (transport_http *) transport;
-	git_vector *refs = &t->refs;
-	unsigned int i;
-	git_pkt_ref *p;
-
-	git_vector_foreach(refs, i, p) {
-		if (p->type != GIT_PKT_REF)
-			continue;
-
-		if (list_cb(&p->head, opaque) < 0) {
-			giterr_set(GITERR_NET, "The user callback returned error");
-			return -1;
-		}
-	}
-
-	return 0;
-}
-
-static int on_body_parse_response(http_parser *parser, const char *str, size_t len)
-{
-	transport_http *t = (transport_http *) parser->data;
-	git_buf *buf = &t->buf;
-	git_vector *common = &t->common;
-	int error;
-	const char *line_end, *ptr;
-
-	if (len == 0) { /* EOF */
-		if (git_buf_len(buf) != 0) {
-			giterr_set(GITERR_NET, "Unexpected EOF");
-			return t->error = -1;
-		} else {
-			return 0;
-		}
-	}
-
-	git_buf_put(buf, str, len);
-	ptr = buf->ptr;
-	while (1) {
-		git_pkt *pkt;
-
-		if (git_buf_len(buf) == 0)
-			return 0;
-
-		error = git_pkt_parse_line(&pkt, ptr, &line_end, git_buf_len(buf));
-		if (error == GIT_EBUFS) {
-			return 0; /* Ask for more */
-		}
-		if (error < 0)
-			return t->error = -1;
-
-		git_buf_consume(buf, line_end);
-
-		if (pkt->type == GIT_PKT_PACK) {
-			git__free(pkt);
-			t->pack_ready = 1;
-			return 0;
-		}
-
-		if (pkt->type == GIT_PKT_NAK) {
-			git__free(pkt);
-			return 0;
-		}
-
-		if (pkt->type != GIT_PKT_ACK) {
-			git__free(pkt);
-			continue;
-		}
-
-		if (git_vector_insert(common, pkt) < 0)
-			return -1;
-	}
-
-	return error;
-
-}
-
-static int parse_response(transport_http *t)
-{
-	int ret = 0;
-	http_parser_settings settings;
-	char buffer[1024];
-	gitno_buffer buf;
-
-	http_parser_init(&t->parser, HTTP_RESPONSE);
-	t->parser.data = t;
-	t->transfer_finished = 0;
-	memset(&settings, 0x0, sizeof(http_parser_settings));
-	settings.on_header_field = on_header_field;
-	settings.on_header_value = on_header_value;
-	settings.on_headers_complete = on_headers_complete;
-	settings.on_body = on_body_parse_response;
-	settings.on_message_complete = on_message_complete;
-
-	gitno_buffer_setup((git_transport *)t, &buf, buffer, sizeof(buffer));
-
-	while(1) {
-		size_t parsed;
-
-		if ((ret = gitno_recv(&buf)) < 0)
-			return -1;
-
-		parsed = http_parser_execute(&t->parser, &settings, buf.data, buf.offset);
-		/* Both should happen at the same time */
-		if (parsed != buf.offset || t->error < 0)
-			return t->error;
-
-		gitno_consume_n(&buf, parsed);
+	setup_gitno_buffer(transport);
+	if ((ret = git_protocol_store_refs(transport, 2)) < 0)
+		goto cleanup;
 
-		if (ret == 0 || t->transfer_finished || t->pack_ready) {
-			return 0;
-		}
+	pkt = git_vector_get(&transport->refs, 0);
+	if (pkt == NULL || pkt->type != GIT_PKT_COMMENT) {
+		giterr_set(GITERR_NET, "Invalid HTTP response");
+		return t->error = -1;
+	} else {
+		/* Remove the comment and flush pkts */
+		git_vector_remove(&transport->refs, 0);
+		git__free(pkt);
+		pkt = git_vector_get(&transport->refs, 0);
+		git_vector_remove(&transport->refs, 0);
+		git__free(pkt);
 	}
 
-	return ret;
-}
-
-static int http_negotiate_fetch(git_transport *transport, git_repository *repo, const git_vector *wants)
-{
-	transport_http *t = (transport_http *) transport;
-	int ret;
-	unsigned int i;
-	char buff[128];
-	gitno_buffer buf;
-	git_revwalk *walk = NULL;
-	git_oid oid;
-	git_pkt_ack *pkt;
-	git_vector *common = &t->common;
-	git_buf request = GIT_BUF_INIT, data = GIT_BUF_INIT;
-
-	gitno_buffer_setup(transport, &buf, buff, sizeof(buff));
-
-	if (git_vector_init(common, 16, NULL) < 0)
-		return -1;
-
-	if (git_fetch_setup_walk(&walk, repo) < 0)
-		return -1;
-
-	do {
-		if ((ret = do_connect(t, t->host, t->port)) < 0)
-			goto cleanup;
-
-		if ((ret = git_pkt_buffer_wants(wants, &t->caps, &data)) < 0)
-			goto cleanup;
-
-		/* We need to send these on each connection */
-		git_vector_foreach (common, i, pkt) {
-			if ((ret = git_pkt_buffer_have(&pkt->oid, &data)) < 0)
-				goto cleanup;
-		}
-
-		i = 0;
-		while ((i < 20) && ((ret = git_revwalk_next(&oid, walk)) == 0)) {
-			if ((ret = git_pkt_buffer_have(&oid, &data)) < 0)
-				goto cleanup;
-
-			i++;
-		}
-
-		git_pkt_buffer_done(&data);
-
-		if ((ret = gen_request(&request, t->path, t->host, "POST", "upload-pack", data.size, 0)) < 0)
-			goto cleanup;
-
-		if ((ret = gitno_send(transport, request.ptr, request.size, 0)) < 0)
-			goto cleanup;
-
-		if ((ret = gitno_send(transport, data.ptr, data.size, 0)) < 0)
-			goto cleanup;
-
-		git_buf_clear(&request);
-		git_buf_clear(&data);
-
-		if (ret < 0 || i >= 256)
-			break;
-
-		if ((ret = parse_response(t)) < 0)
-			goto cleanup;
-
-		if (t->pack_ready) {
-			ret = 0;
-			goto cleanup;
-		}
-
-	} while(1);
+	if (git_protocol_detect_caps(git_vector_get(&transport->refs, 0), &transport->caps) < 0)
+		return t->error = -1;
 
 cleanup:
 	git_buf_free(&request);
-	git_buf_free(&data);
-	git_revwalk_free(walk);
-	return ret;
-}
-
-typedef struct {
-	git_indexer_stream *idx;
-	git_indexer_stats *stats;
-	transport_http *transport;
-} download_pack_cbdata;
-
-static int on_message_complete_download_pack(http_parser *parser)
-{
-	download_pack_cbdata *data = (download_pack_cbdata *) parser->data;
-
-	data->transport->transfer_finished = 1;
-
-	return 0;
-}
-static int on_body_download_pack(http_parser *parser, const char *str, size_t len)
-{
-	download_pack_cbdata *data = (download_pack_cbdata *) parser->data;
-	transport_http *t = data->transport;
-	git_indexer_stream *idx = data->idx;
-	git_indexer_stats *stats = data->stats;
+	git_buf_clear(&t->buf);
 
-	return t->error = git_indexer_stream_add(idx, str, len, stats);
+	return ret;
 }
 
-/*
- * As the server is probably using Transfer-Encoding: chunked, we have
- * to use the HTTP parser to download the pack instead of giving it to
- * the simple downloader. Furthermore, we're using keep-alive
- * connections, so the simple downloader would just hang.
- */
-static int http_download_pack(git_transport *transport, git_repository *repo, git_off_t *bytes, git_indexer_stats *stats)
+static int http_negotiation_step(struct git_transport *transport, void *data, size_t len)
 {
 	transport_http *t = (transport_http *) transport;
-	git_buf *oldbuf = &t->buf;
-	int recvd;
-	http_parser_settings settings;
-	char buffer[1024];
-	gitno_buffer buf;
-	git_indexer_stream *idx = NULL;
-	download_pack_cbdata data;
-
-	gitno_buffer_setup(transport, &buf, buffer, sizeof(buffer));
-
-	if (memcmp(oldbuf->ptr, "PACK", strlen("PACK"))) {
-		giterr_set(GITERR_NET, "The pack doesn't start with a pack signature");
-		return -1;
-	}
+	git_buf request = GIT_BUF_INIT;
+	int ret;
 
-	if (git_indexer_stream_new(&idx, git_repository_path(repo)) < 0)
+	/* First, send the data as a HTTP POST request */
+	if ((ret = do_connect(t, t->host, t->port)) < 0)
 		return -1;
 
-	/*
-	 * This is part of the previous response, so we don't want to
-	 * re-init the parser, just set these two callbacks.
-	 */
-	memset(stats, 0, sizeof(git_indexer_stats));
-	data.stats = stats;
-	data.idx = idx;
-	data.transport = t;
-	t->parser.data = &data;
-	t->transfer_finished = 0;
-	memset(&settings, 0x0, sizeof(settings));
-	settings.on_message_complete = on_message_complete_download_pack;
-	settings.on_body = on_body_download_pack;
-	*bytes = git_buf_len(oldbuf);
-
-	if (git_indexer_stream_add(idx, git_buf_cstr(oldbuf), git_buf_len(oldbuf), stats) < 0)
+	if ((ret = gen_request(&request, t->path, t->host, "POST", "upload-pack", len, 0)) < 0)
 		goto on_error;
 
-	gitno_buffer_setup(transport, &buf, buffer, sizeof(buffer));
-
-	do {
-		size_t parsed;
-
-		if ((recvd = gitno_recv(&buf)) < 0)
-			goto on_error;
+	if ((ret = gitno_send(transport, request.ptr, request.size, 0)) < 0)
+		goto on_error;
 
-		parsed = http_parser_execute(&t->parser, &settings, buf.data, buf.offset);
-		if (parsed != buf.offset || t->error < 0)
-			goto on_error;
+	if ((ret = gitno_send(transport, data, len, 0)) < 0)
+		goto on_error;
 
-		*bytes += recvd;
-		gitno_consume_n(&buf, parsed);
-	} while (recvd > 0 && !t->transfer_finished);
+	git_buf_free(&request);
 
-	if (git_indexer_stream_finalize(idx, stats) < 0)
-		goto on_error;
+	/* Then we need to set up the buffer to grab data from the HTTP response */
+	setup_gitno_buffer(transport);
 
-	git_indexer_stream_free(idx);
 	return 0;
 
 on_error:
-	git_indexer_stream_free(idx);
+	git_buf_free(&request);
 	return -1;
 }
 
@@ -622,8 +379,8 @@ static int http_close(git_transport *transport)
 static void http_free(git_transport *transport)
 {
 	transport_http *t = (transport_http *) transport;
-	git_vector *refs = &t->refs;
-	git_vector *common = &t->common;
+	git_vector *refs = &transport->refs;
+	git_vector *common = &transport->common;
 	unsigned int i;
 	git_pkt *p;
 
@@ -644,8 +401,6 @@ static void http_free(git_transport *transport)
 	}
 	git_vector_free(common);
 	git_buf_free(&t->buf);
-	git_buf_free(&t->proto.buf);
-	git__free(t->heads);
 	git__free(t->content_type);
 	git__free(t->host);
 	git__free(t->port);
@@ -664,13 +419,15 @@ int git_transport_http(git_transport **out)
 	memset(t, 0x0, sizeof(transport_http));
 
 	t->parent.connect = http_connect;
-	t->parent.ls = http_ls;
-	t->parent.negotiate_fetch = http_negotiate_fetch;
-	t->parent.download_pack = http_download_pack;
+	t->parent.negotiation_step = http_negotiation_step;
 	t->parent.close = http_close;
 	t->parent.free = http_free;
-	t->proto.refs = &t->refs;
-	t->proto.transport = (git_transport *) t;
+	t->parent.rpc = 1;
+
+	if (git_vector_init(&t->parent.refs, 16, NULL) < 0) {
+		git__free(t);
+		return -1;
+	}
 
 #ifdef GIT_WIN32
 	/* on win32, the WSA context needs to be initialized
@@ -693,7 +450,7 @@ int git_transport_https(git_transport **out)
 	if (git_transport_http((git_transport **)&t) < 0)
 		return -1;
 
-	t->parent.encrypt = 1;
+	t->parent.use_ssl = 1;
 	t->parent.check_cert = 1;
 	*out = (git_transport *) t;