rufus-scheduler 3.8.0 → 3.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 86f0ae4ebefa9cf941f66efb56041515eea96cb5105289d9f0f54899841cffc6
-  data.tar.gz: 9e6d1422b91536aa56cc2cdb627f3c88e21748c8e8734ba2eb929a46912f303e
+  metadata.gz: 9fbe0f73068129b96196031b141f480f830e3110e35d3c5eaa2206530b1ae536
+  data.tar.gz: bec310a43820928b8d342b5b3602edf8cb27aaca8995e0a18073d70dfd3839f8
 SHA512:
-  metadata.gz: 45667cceb3f382ac71b7158d2884fbde21c9ac6f3027889a1dd8b7fd855bd014b35a1a4180b93118552aa7e6e08df061259113b1a5ce86f4e892a4b2f8c0436e
-  data.tar.gz: 9ef9d0926f33bacdb0c2b8727b801d861db960ba4b6efac28642ea27e578c1de60a6b1b144217cace6c17de759100b0229c42ba79bb9db4b40527c1e8cdac8e4
+  metadata.gz: 3e8edfd4df2ddbb0f8026ffa13fff69f9f4bd045da1638fe5ac38610992e0f7d173b20a27ad1833760d6fee62d41b5b160978e107dbc55a1b9d07dfaa62444ad
+  data.tar.gz: 412bb7e80546c5cd13bf8875f928ce6920a9e62774d296db83935adbfee56069cbb2729bb4640962351297cd55b8b5cfb92facfec38e7cb92b3ef9f7446c7283

data/CHANGELOG.md

@@ -2,6 +2,18 @@
 # CHANGELOG.md
 
 
+### rufus-scheduler 3.8.2 - released 2022-07-12
+
+* Prevent error in shutdown when @thread is current Thread, gh-337
+* Rescue errors on the scheduling thread, gh-335
+
+
+### rufus-scheduler 3.8.1 - released 2022-01-11
+
+* Suppress warning about @resume_discard_past
+* Suppress warning about unused variable, solackerman gh-332
+
+
 ### rufus-scheduler 3.8.0 - released 2021-07-14
 
 * Add #source_location to Job, gh-322

data/CREDITS.md

@@ -4,7 +4,12 @@
 
 ## Contributors
 
-* John Bachir https://github.com/jjb gh-310
+* Bence Monus https://github.com/cromega gh-337 on_error and friends
+* Talia Wong https://github.com/blowfishpro gh-335 on_error and friends
+* Konstantin https://github.com/fa11enangel gh-334 nodejitsu link
+* Olle Jonsson https://github.com/olleolleolle gh-333
+* Sol Ackerman https://github.com/solarckerman gh-332
+* John Bachir https://github.com/jjb gh-310 gh-327
 * Daniel Berger https://github.com/djberg96 gh-300
 * Ceyhun Onur https://github.com/ceyonur parse_cron no_error: true
 * Darwin Wu https://github.com/dwaxe Rails initializer vs tests change

data/LICENSE.txt

@@ -1,5 +1,5 @@
 
-Copyright (c) 2005-2021, John Mettraux, jmettraux@gmail.com
+Copyright (c) 2005-2022, John Mettraux, jmettraux@gmail.com
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -133,7 +133,7 @@ Yes, issues can be reported in [rufus-scheduler issues](https://github.com/jmett
 ### faq
 
 * [It doesn't work...](https://www.chiark.greenend.org.uk/~sgtatham/bugs.html)
-* [I want a refund](https://blog.nodejitsu.com/getting-refunds-on-open-source-projects)
+* [I want a refund](https://web.archive.org/web/20160425034214/http://blog.nodejitsu.com/getting-refunds-on-open-source-projects/)
 * [Passenger and rufus-scheduler](https://stackoverflow.com/questions/18108719/debugging-rufus-scheduler/18156180#18156180)
 * [Passenger and rufus-scheduler (2)](https://stackoverflow.com/questions/21861387/rufus-cron-job-not-working-in-apache-passenger#answer-21868555)
 * [Passenger in-depth spawn methods](https://www.phusionpassenger.com/library/indepth/ruby/spawn_methods/)
@@ -860,7 +860,11 @@ require 'rufus-scheduler'
 s = Rufus::Scheduler.new
 
 def s.on_error(job, err)
-  p [ 'error in scheduled job', job.class, job.original, err.message ]
+  if job
+    p [ 'error in scheduled job', job.class, job.original, err.message ]
+  else
+    p [ 'error while scheduling', err.message ]
+  end
 rescue
   p $!
 end
@@ -1649,14 +1653,16 @@ If you don't want rufus-scheduler to trigger anything while running the Ruby on
 
 require 'rufus-scheduler'
 
-s = Rufus::Scheduler.singleton
+return if defined?(Rails::Console) || Rails.env.test? || File.split($PROGRAM_NAME).last == 'rake'
+  #
+  # do not schedule when Rails is run from its console, for a test/spec, or
+  # from a Rake task
 
-return if defined?(Rails::Console) || Rails.env.test? || File.split($0).last == 'rake'
 # return if $PROGRAM_NAME.include?('spring')
+  #
   # see https://github.com/jmettraux/rufus-scheduler/issues/186
 
-# do not schedule when Rails is run from its console, for a test/spec, or
-# from a Rake task
+s = Rufus::Scheduler.singleton
 
 s.every '1m' do
   Rails.logger.info "hello, it's #{Time.now}"
@@ -1664,6 +1670,8 @@ s.every '1m' do
 end
 ```
 
+(Beware later version of Rails where Spring takes care pre-running the initializers. Running `spring stop` or disabling Spring might be necessary in some cases to see changes to initializers being taken into account.)
+
 
 ### rails server -d
 
@@ -1680,6 +1688,9 @@ These are two well crafted articles on process daemonization, please read them:
 
 If, anyway, you need something like `rails server -d`, why not try `bundle exec unicorn -D` instead? In my (limited) experience, it worked out of the box (well, had to add `gem 'unicorn'` to `Gemfile` first).
 
+### executor / reloader
+
+You might benefit from wraping your scheduled code in the executor or reloader. Read more here: https://guides.rubyonrails.org/threading_and_code_execution.html
 
 ## support
 

data/lib/rufus/scheduler/jobs_repeat.rb

@@ -25,6 +25,8 @@ class Rufus::Scheduler::RepeatJob < Rufus::Scheduler::Job
       nil
     self.last_at =
       opts[:last] || opts[:last_at] || opts[:last_in]
+
+    @resume_discard_past = nil
   end
 
   FIRSTS = [ :now, :immediately, 0 ].freeze

data/lib/rufus/scheduler.rb

@@ -9,7 +9,7 @@ module Rufus; end
 
 class Rufus::Scheduler
 
-  VERSION = '3.8.0'
+  VERSION = '3.8.2'
 
   EoTime = ::EtOrbi::EoTime
 
@@ -443,10 +443,14 @@ class Rufus::Scheduler
     ms = {}; mutexes.each { |k, v| ms[k] = v.locked? }
 
     stderr.puts("{ #{pre} rufus-scheduler intercepted an error:")
-    stderr.puts("  #{pre}   job:")
-    stderr.puts("  #{pre}     #{job.class} #{job.original.inspect} #{job.opts.inspect}")
-    stderr.puts("  #{pre}     #{job.source_location.inspect}")
-    # TODO: eventually use a Job#detail or something like that
+    if job
+      stderr.puts("  #{pre}   job:")
+      stderr.puts("  #{pre}     #{job.class} #{job.original.inspect} #{job.opts.inspect}")
+      stderr.puts("  #{pre}     #{job.source_location.inspect}")
+      # TODO: eventually use a Job#detail or something like that
+    else
+      stderr.puts("  #{pre}   job: (error did not occur in a job)")
+    end
     stderr.puts("  #{pre}   error:")
     stderr.puts("  #{pre}     #{err.object_id}")
     stderr.puts("  #{pre}     #{err.class}")
@@ -530,7 +534,7 @@ class Rufus::Scheduler
 
     unlock
 
-    @thread.join
+    @thread.join unless @thread == Thread.current
   end
   alias stop shutdown
 
@@ -583,7 +587,7 @@ class Rufus::Scheduler
       r =
         begin
           @join_queue.pop(true)
-        rescue ThreadError => e
+        rescue ThreadError
           # #<ThreadError: queue empty>
           false
         end
@@ -630,12 +634,20 @@ class Rufus::Scheduler
       Thread.new do
 
         while @started_at do
+          begin
+
+            unschedule_jobs
+            trigger_jobs unless @paused_at
+            timeout_jobs
 
-          unschedule_jobs
-          trigger_jobs unless @paused_at
-          timeout_jobs
+            sleep(@frequency)
 
-          sleep(@frequency)
+          rescue => err
+            #
+            # for `blocking: true` jobs mostly
+            #
+            on_error(nil, err)
+          end
         end
 
         rejoin

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rufus-scheduler
 version: !ruby/object:Gem::Version
-  version: 3.8.0
+  version: 3.8.2
 platform: ruby
 authors:
 - John Mettraux
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-07-14 00:00:00.000000000 Z
+date: 2022-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fugit