rufus-scheduler 3.3.3 → 3.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 31bff13de665010182dbbb8aad7b32be532e0fe7
-  data.tar.gz: 71389925d05e4c699246d0ce5b8509270e967909
+  metadata.gz: aadc34a3585ec0563a43eeecee75009ac311490f
+  data.tar.gz: ea9e07f929da453a7fe63711bd80c75457444f6d
 SHA512:
-  metadata.gz: 5246e1928d1a4149f47133d55f107389542bbabe5f7772d48fc64406f3ec0573ec54b213fc5b2a59f7d0675cc247bfc3ef4b801415ce3b0cc92640735b7db3af
-  data.tar.gz: 375afb960f519c4f57167dd6e339a5c390b6b54066ef1469b6cbbf40cbc2ffe109f6f71da6afbfc1e51ac6c8b61d5529b63cf4c969c043abc7c7aec2507bb65f
+  metadata.gz: f43b61128d67c893d88a1a796dbf029c3d18577a80d4f8874c25d8272318252c96da6f499c561e5bafa25349c228d0c950a937db12b492ef2f348667b2ba700d
+  data.tar.gz: c01cbfd377824b64f148f515e65db781f5433eaab1d574fd46c45210139bf1fbbb3ec5b8208f371044bdde909bb7917d38955d5e3dd8fcd3bdff79ef4f52d450

data/CHANGELOG.txt

@@ -2,6 +2,11 @@
 = rufus-scheduler CHANGELOG.txt
 
 
+== rufus-scheduler - 3.3.4    released 2017-02-16
+
+- More detailed "cannot determine timezone from nil" message, gh-237
+
+
 == rufus-scheduler - 3.3.3    released 2017-01-29
 
 - use Rails' timezone by default if Rails is present, gh-230, gh-233,

data/CREDITS.txt

@@ -53,6 +53,7 @@
 
 == Feedback
 
+- Yoshimi Keiji - https://githuc.com/walf443 - v.3.3.3 mislabelling
 - Alexander Deeb - https://github.com/adeeb1 - gh-230
 - Sofia Bravo - http://stackoverflow.com/users/1123850/sofia-bravo - gh-231
 - zzjin - https://githu.com/zzjin - 3.3.x vs CST abbreviated timezone - gh-228

data/README.md

@@ -1449,7 +1449,7 @@ rufus-scheduler/lib/rufus/scheduler/zotime.rb:41:
 	...
 ```
 
-It may happen on Windows or on systems that poor hints to Ruby on which timezone to use. It should be solved by setting explicitely the `ENV['TZ']` before the scheduler instantiation:
+It may happen on Windows or on systems that poorly hints to Ruby on which timezone to use. It should be solved by setting explicitely the `ENV['TZ']` before the scheduler instantiation:
 ```ruby
 ENV['TZ'] = 'Asia/Shanghai'
 scheduler = Rufus::Scheduler.new
@@ -1468,18 +1468,23 @@ end
 ```
 (Hat tip to Alexander in [gh-230](https://github.com/jmettraux/rufus-scheduler/issues/230))
 
-Rails set its timezone under `config/application.rb`.
+Rails sets its timezone under `config/application.rb`.
 
 Rufus-Scheduler 3.3.3 detects the presence of Rails and uses its timezone setting (tested with Rails 4), so setting `ENV['TZ']` should not be necessary.
 
 The value can be determined thanks to [https://en.wikipedia.org/wiki/List_of_tz_database_time_zones](https://en.wikipedia.org/wiki/List_of_tz_database_time_zones).
 
-Use a "continent/city" identifier (for example "Asia/Shanghai"). Do not use an abbreviation (not "CST") and do not use a local time zone name (not "中国标准时间").
+Use a "continent/city" identifier (for example "Asia/Shanghai"). Do not use an abbreviation (not "CST") and do not use a local time zone name (not "中国标准时间" nor "Eastern Standard Time" which, for instance, points to a time zone in America and to another one in Australia...).
 
-If the error persists, try to add the `tzinfo-data` to your Gemfile, as in:
+If the error persists (and especially on Windows), try to add the `tzinfo-data` to your Gemfile, as in:
 ```ruby
 gem 'tzinfo-data'
 ```
+or by manually requiring it before requiring rufus-scheduler (if you don't use Bundler):
+```ruby
+require 'tzinfo/data'
+require 'rufus-scheduler'
+```
 
 
 ## so Rails?

data/lib/rufus/scheduler.rb

@@ -39,7 +39,7 @@ module Rufus
     require 'rufus/scheduler/job_array'
     require 'rufus/scheduler/locks'
 
-    VERSION = '3.3.3'
+    VERSION = '3.3.4'
 
     #
     # A common error class for rufus-scheduler

data/lib/rufus/scheduler/zotime.rb

@@ -41,7 +41,10 @@ class Rufus::Scheduler
       fail ArgumentError.new(
         "cannot determine timezone from #{zone.inspect}" +
         " (etz:#{ENV['TZ'].inspect},tnz:#{Time.now.zone.inspect}," +
-        "tzid:#{defined?(TZInfo::Data).inspect})"
+        "tzid:#{defined?(TZInfo::Data).inspect})\n" +
+        "Try setting `ENV['TZ'] = 'Continent/City'` in your script " +
+        "(see https://en.wikipedia.org/wiki/List_of_tz_database_time_zones)" +
+        (defined?(TZInfo::Data) ? '' : " and adding 'tzinfo-data' to your gems")
       ) unless @zone
 
       @time = nil # cache for #to_time result

data/sofia.md

@@ -0,0 +1,89 @@
+
+I would take a different approach, one with a single schedule:
+
+```ruby
+# config/initializers/scheduler.rb
+
+require 'rufus-scheduler'
+
+Rufus::Scheduler.singleton.cron('* * * * *') do
+  # every minute
+
+  HarvestPlan.trigger_if_necessary
+end
+```
+
+```ruby
+# app/models/harvest_plan.rb
+
+class HarvestPlan < ApplicationRecord
+
+  def self.trigger_if_necessary
+
+    now = Time.now
+
+    HarvestPlan.where(start_date < now && repetitions > 0) do |plan|
+      # warning pseudo active record code !
+
+      elapsed = now - plan.last_time / 3600
+      next if elapsed < @harveset_plan.hours_between
+        # that elapsed check could even be done in the `where` above
+
+      # clear to trigger
+
+      plan.trigger
+    end
+  end
+
+  def trigger
+
+    self.repetitions -= 1
+    self.last_time = Time.now
+    self.save
+
+    CreateHarvestFromPlanJob.perform_later(self)
+      # that's ugly, when do not want to perform_later, we want to perform now!
+  end
+end
+```
+
+```ruby
+# in the controller...
+
+def create
+
+   @harvest_plan = HarvestPlan.new(resource_params)
+   @harvest_plan.start_date = Time.parse(resource_params[:start_date])
+
+   return unless @harvest_plan.save
+
+   ApplicationController.new.insert_in_messages_list(
+     session, :success, 'Harvest plan created')
+
+   redirect_to farms_path
+end
+```
+
+
+You could even avoid using rufus-scheduler:
+
+```ruby
+# config/initializers/scheduler.rb
+
+Thread.new do
+  loop do
+    begin
+      sleep 59
+      HarvestPlan.trigger_if_necessary
+    rescue => err
+      Rails.logger.warn "#{err.object_id} - problem with HarvestPlan triggering... " + err.inspect
+      err.backtrace.each do |line|
+        Rails.logger.warn "#{err.object_id} - #{line}"
+      end
+    end
+  end
+end
+```
+
+Best regards.
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rufus-scheduler
 version: !ruby/object:Gem::Version
-  version: 3.3.3
+  version: 3.3.4
 platform: ruby
 authors:
 - John Mettraux
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-29 00:00:00.000000000 Z
+date: 2017-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: tzinfo
@@ -78,6 +78,7 @@ files:
 - n.txt
 - pics.txt
 - rufus-scheduler.gemspec
+- sofia.md
 homepage: http://github.com/jmettraux/rufus-scheduler
 licenses:
 - MIT
@@ -98,7 +99,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: rufus
-rubygems_version: 2.4.5.1
+rubygems_version: 2.4.5.2
 signing_key: 
 specification_version: 4
 summary: job scheduler for Ruby (at, cron, in and every jobs)