rudra 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff3f69221a8e01fb0c0bf5a517c11547872f475b4cdc7aa551a26f81929c8373
-  data.tar.gz: e039db5f85576af890d9b58f8deed4f7f30cf09ea474d8b2226c6574cad9c115
+  metadata.gz: f6485433a80329770ea6ce43647f1d10176c20fa1eefa825b51e222615e0b4fe
+  data.tar.gz: 980b66578597240fab1f2b0c68ee9fcc68be47b7466a8b5d99decf3dec6787c4
 SHA512:
-  metadata.gz: a632f5ee68fa9417a78e86642246c47d2b4480292ca4816471b8f948458d7c6444150ccb7eb1a65fe8d7167f25dca32e1271f97cd725dbc86643362d763d4361
-  data.tar.gz: 9edc12b61b22302ef0d80698a682d859a124acaa7c3d121d87353f83c84fef948f9fa93971ce85074c4b7faf52b27bf9ebef4bdedcb14429a8ef7222b73854f3
+  metadata.gz: f12e6ea46bb610708c6fa9cf13cd897bbd2e19ea645d7f5e748b1daccac7efdf00470b8333f16907401c9e63968f975f2c526188513862197db8771669e7c785
+  data.tar.gz: 7584799d278830b5912e6eb57e6582c3b2b7bb93cafff6c2bbc331137b06181674f5152e3cf179696ff3d1c6b66d0a91546fbd5800e2329662e5bb95357a8f40

data/lib/rudra.rb

@@ -292,13 +292,16 @@ class Rudra
   # Save a PNG screenshot to file
   # @param [String] filename the filename of PNG screenshot
   def save_screenshot(filename)
-    mkdir(@screen_dir) unless Dir.exist?(@screen_dir)
-    driver.save_screenshot(
-      File.join(
-        @screen_dir,
-        filename.end_with?('.png') ? filename : "#{filename}.png"
-      )
+    file = File.join(
+      @screen_dir,
+      sanitize(filename.end_with?('.png') ? filename : "#{filename}.png")
     )
+
+    dir = File.dirname(file)
+
+    mkdir(dir) unless Dir.exist?(dir)
+
+    driver.save_screenshot(file)
   end
 
   # Switch to the currently active modal dialog
@@ -370,24 +373,22 @@ class Rudra
   # @param [String, Selenium::WebDriver::Element] locator the locator to
   #   identify the element or Selenium::WebDriver::Element
   # @param [Integer] seconds seconds before timed out
-  def wait_for_not_visible(locator, seconds = 2)
+  def wait_for_not_visible(locator, seconds = 3)
     how, what = parse_locator(locator)
 
+    implicit_wait(seconds)
+
     begin
       wait_for(seconds) do
-        begin
-          elements = driver.find_elements(how, what)
-          elements.empty? || elements.map(&:displayed?).none?
-        rescue Selenium::WebDriver::Error::NoSuchElementError
-          true
-        rescue Selenium::WebDriver::Error::StaleElementReferenceError
-          false
-        end
+        elements = driver.find_elements(how, what)
+        elements.empty? || elements.map(&:displayed?).none?
       end
     rescue Selenium::WebDriver::Error::TimeoutError
       true
     rescue Net::ReadTimeout
       true
+    ensure
+      implicit_wait(timeout)
     end
   end
 
@@ -1305,6 +1306,14 @@ class Rudra
     )
   end
 
+  def sanitize(filename)
+    invalid_characters = ['/', '\\', '?', '%', '*', ':', '|', '"', '<', '>']
+    invalid_characters.each do |character|
+      filename.gsub!(character, '')
+    end
+    filename
+  end
+
   def random_id(length = 8)
     charset = [(0..9), ('a'..'z')].flat_map(&:to_a)
     id = Array.new(length) { charset.sample }.join

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rudra
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Aaron Chen