ruco 0.0.37 → 0.0.38

data/Readme.md

@@ -63,8 +63,7 @@ TIPS
 
 TODO
 =====
- - big warning when editing a not-writeable file
- - nice warning when failing to write a write-only file
+ - big warning when editing a not-writable file
  - find next (Alt+n)
  - add selection colors to forms in command_bar
  - session storage (stay at same line/column when reopening)
@@ -77,7 +76,7 @@ TODO
  - add auto-confirm to 'replace?' dialog -> type s == skip, no enter needed
  - 1.8: unicode support <-> already finished but unusable due to Curses (see encoding branch)
  - support Alt+Fx keys
- - (later) extract keyboard and html-style components into seperate project
+ - (later) extract keyboard and html-style components into separate project
 
 Author
 ======

data/VERSION

@@ -1 +1 @@
-0.0.37
+0.0.38

data/lib/ruco/application.rb

@@ -141,7 +141,10 @@ module Ruco
       end
 
       action :save do
-        editor.save
+        result = editor.save
+        if result != true
+          ask("#{result.slice(0,100)} -- Enter=Retry Esc=Cancel "){ @actions[:save].call }
+        end
       end
 
       action :quit do

data/lib/ruco/editor.rb

@@ -50,6 +50,9 @@ module Ruco
       content = text_area.content
       File.open(@file,'w'){|f| f.write(content) }
       @saved_content = content
+      true
+    rescue Object => e
+      e.message
     end
   end
 end

data/ruco.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{ruco}
-  s.version = "0.0.37"
+  s.version = "0.0.38"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Michael Grosser"]

data/spec/ruco/application_spec.rb

@@ -11,6 +11,11 @@ describe Ruco::Application do
     File.open(@file,'w'){|f| f.write(content) }
   end
 
+  def read
+    File.read(@file)
+  end
+
+
   def editor_part(view)
     view.naive_split("\n")[1..-2].join("\n")
   end
@@ -251,4 +256,27 @@ describe Ruco::Application do
       end
     end
   end
+
+  describe :save do
+    it "just saves" do
+      write('')
+      app.key('x')
+      app.key(:'Ctrl+s')
+      read.should == 'x'
+    end
+
+    it "warns when saving failed" do
+      begin
+        `chmod -w #{@file}`
+        app.key(:'Ctrl+s')
+        app.view.should include('Permission denied')
+        app.key(:enter) # retry ?
+        app.view.should include('Permission denied')
+        app.key(:escape)
+        app.view.should_not include('Permission denied')
+      ensure
+        `chmod +w #{@file}`
+      end
+    end
+  end
 end

data/spec/ruco/editor_spec.rb

@@ -631,16 +631,25 @@ describe Ruco::Editor do
     it 'stores the file' do
       write('xxx')
       editor.insert('a')
-      editor.save
+      editor.save.should == true
       File.read(@file).should == 'axxx'
     end
 
     it 'creates the file' do
       `rm #{@file}`
       editor.insert('a')
-      editor.save
+      editor.save.should == true
       File.read(@file).should == 'a'
     end
+
+    it 'does not crash when it cannot save a file' do
+      begin
+        `chmod -w #{@file}`
+        editor.save.should == "Permission denied - #{@file}"
+      ensure
+        `chmod +w #{@file}`
+      end
+    end
   end
 
   describe :delete do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: ruco
 version: !ruby/object:Gem::Version 
-  hash: 85
+  hash: 83
   prerelease: 
   segments: 
   - 0
   - 0
-  - 37
-  version: 0.0.37
+  - 38
+  version: 0.0.38
 platform: ruby
 authors: 
 - Michael Grosser