rubyn-code 0.1.0 → 0.2.0

data/lib/rubyn_code/tools/bundle_add.rb

@@ -1,16 +1,16 @@
 # frozen_string_literal: true
 
-require "open3"
-require_relative "base"
-require_relative "registry"
+require 'open3'
+require_relative 'base'
+require_relative 'registry'
 
 module RubynCode
   module Tools
     class BundleAdd < Base
-      TOOL_NAME = "bundle_add"
-      DESCRIPTION = "Adds a gem to the Gemfile and installs it via `bundle add`."
+      TOOL_NAME = 'bundle_add'
+      DESCRIPTION = 'Adds a gem to the Gemfile and installs it via `bundle add`.'
       PARAMETERS = {
-        gem_name: { type: :string, required: true, description: "Name of the gem to add" },
+        gem_name: { type: :string, required: true, description: 'Name of the gem to add' },
         version: { type: :string, required: false, description: "Version constraint (e.g. '~> 1.0')" },
         group: { type: :string, required: false, description: "Gemfile group (e.g. 'development', 'test')" }
       }.freeze
@@ -18,14 +18,12 @@ module RubynCode
       REQUIRES_CONFIRMATION = false
 
       def execute(gem_name:, version: nil, group: nil)
-        gemfile_path = File.join(project_root, "Gemfile")
+        gemfile_path = File.join(project_root, 'Gemfile')
 
-        unless File.exist?(gemfile_path)
-          raise Error, "No Gemfile found in project root. Cannot run bundle add."
-        end
+        raise Error, 'No Gemfile found in project root. Cannot run bundle add.' unless File.exist?(gemfile_path)
 
         command = build_command(gem_name, version, group)
-        stdout, stderr, status = Open3.capture3(command, chdir: project_root)
+        stdout, stderr, status = safe_capture3(command, chdir: project_root)
 
         build_output(stdout, stderr, status)
       end
@@ -44,7 +42,7 @@ module RubynCode
         parts << stdout unless stdout.empty?
         parts << "STDERR:\n#{stderr}" unless stderr.empty?
         parts << "Exit code: #{status.exitstatus}" unless status.success?
-        parts.empty? ? "(no output)" : parts.join("\n")
+        parts.empty? ? '(no output)' : parts.join("\n")
       end
     end
 

data/lib/rubyn_code/tools/bundle_install.rb

@@ -1,26 +1,24 @@
 # frozen_string_literal: true
 
-require "open3"
-require_relative "base"
-require_relative "registry"
+require 'open3'
+require_relative 'base'
+require_relative 'registry'
 
 module RubynCode
   module Tools
     class BundleInstall < Base
-      TOOL_NAME = "bundle_install"
-      DESCRIPTION = "Runs `bundle install` to install gem dependencies."
+      TOOL_NAME = 'bundle_install'
+      DESCRIPTION = 'Runs `bundle install` to install gem dependencies.'
       PARAMETERS = {}.freeze
       RISK_LEVEL = :execute
       REQUIRES_CONFIRMATION = false
 
       def execute(**_params)
-        gemfile_path = File.join(project_root, "Gemfile")
+        gemfile_path = File.join(project_root, 'Gemfile')
 
-        unless File.exist?(gemfile_path)
-          raise Error, "No Gemfile found in project root. Cannot run bundle install."
-        end
+        raise Error, 'No Gemfile found in project root. Cannot run bundle install.' unless File.exist?(gemfile_path)
 
-        stdout, stderr, status = Open3.capture3("bundle install", chdir: project_root)
+        stdout, stderr, status = safe_capture3('bundle install', chdir: project_root)
 
         build_output(stdout, stderr, status)
       end
@@ -32,7 +30,7 @@ module RubynCode
         parts << stdout unless stdout.empty?
         parts << "STDERR:\n#{stderr}" unless stderr.empty?
         parts << "Exit code: #{status.exitstatus}" unless status.success?
-        parts.empty? ? "(no output)" : parts.join("\n")
+        parts.empty? ? '(no output)' : parts.join("\n")
       end
     end
 

data/lib/rubyn_code/tools/compact.rb

@@ -1,15 +1,16 @@
 # frozen_string_literal: true
 
-require_relative "base"
-require_relative "registry"
+require_relative 'base'
+require_relative 'registry'
 
 module RubynCode
   module Tools
     class Compact < Base
-      TOOL_NAME = "compact"
-      DESCRIPTION = "Triggers manual context compaction to reduce conversation size while preserving key information."
+      TOOL_NAME = 'compact'
+      DESCRIPTION = 'Triggers manual context compaction to reduce conversation size while preserving key information.'
       PARAMETERS = {
-        focus: { type: :string, required: false, description: "What to focus the summary on (e.g. 'the auth refactor', 'test failures')" }
+        focus: { type: :string, required: false,
+                 description: "What to focus the summary on (e.g. 'the auth refactor', 'test failures')" }
       }.freeze
       RISK_LEVEL = :read
       REQUIRES_CONFIRMATION = false
@@ -23,22 +24,22 @@ module RubynCode
         manager = @context_manager
 
         unless manager
-          return "Context compaction is not available in this session. " \
-                 "No context manager was provided."
+          return 'Context compaction is not available in this session. ' \
+                 'No context manager was provided.'
         end
 
         if manager.respond_to?(:compact)
           result = manager.compact(focus: focus)
           format_result(result, focus)
         else
-          "Context manager does not support compaction."
+          'Context manager does not support compaction.'
         end
       end
 
       private
 
       def format_result(result, focus)
-        parts = ["Context compacted successfully."]
+        parts = ['Context compacted successfully.']
 
         if result.is_a?(Hash)
           parts << "Messages before: #{result[:before]}" if result[:before]

data/lib/rubyn_code/tools/db_migrate.rb

@@ -1,24 +1,26 @@
 # frozen_string_literal: true
 
-require "open3"
-require_relative "base"
-require_relative "registry"
+require 'open3'
+require_relative 'base'
+require_relative 'registry'
 
 module RubynCode
   module Tools
     class DbMigrate < Base
-      TOOL_NAME = "db_migrate"
-      DESCRIPTION = "Runs Rails database migrations (up) or rollback (down)."
+      TOOL_NAME = 'db_migrate'
+      DESCRIPTION = 'Runs Rails database migrations (up) or rollback (down).'
       PARAMETERS = {
-        direction: { type: :string, required: false, default: "up", enum: %w[up down], description: "Migration direction: 'up' to migrate, 'down' to rollback (default: 'up')" },
-        steps: { type: :integer, required: false, description: "Number of steps to rollback (only used with direction 'down')" }
+        direction: { type: :string, required: false, default: 'up', enum: %w[up down],
+                     description: "Migration direction: 'up' to migrate, 'down' to rollback (default: 'up')" },
+        steps: { type: :integer, required: false,
+                 description: "Number of steps to rollback (only used with direction 'down')" }
       }.freeze
       RISK_LEVEL = :execute
       REQUIRES_CONFIRMATION = false
 
-      def execute(direction: "up", steps: nil)
+      def execute(direction: 'up', steps: nil)
         command = build_command(direction, steps)
-        stdout, stderr, status = Open3.capture3(command, chdir: project_root)
+        stdout, stderr, status = safe_capture3(command, chdir: project_root)
 
         build_output(stdout, stderr, status)
       end
@@ -27,11 +29,11 @@ module RubynCode
 
       def build_command(direction, steps)
         case direction
-        when "up"
-          "bundle exec rails db:migrate"
-        when "down"
-          cmd = "bundle exec rails db:rollback"
-          cmd += " STEP=#{steps.to_i}" if steps && steps.to_i > 0
+        when 'up'
+          'bundle exec rails db:migrate'
+        when 'down'
+          cmd = 'bundle exec rails db:rollback'
+          cmd += " STEP=#{steps.to_i}" if steps&.to_i&.positive?
           cmd
         else
           raise Error, "Invalid direction: #{direction}. Must be 'up' or 'down'."
@@ -43,7 +45,7 @@ module RubynCode
         parts << stdout unless stdout.empty?
         parts << "STDERR:\n#{stderr}" unless stderr.empty?
         parts << "Exit code: #{status.exitstatus}" unless status.success?
-        parts.empty? ? "(no output)" : parts.join("\n")
+        parts.empty? ? '(no output)' : parts.join("\n")
       end
     end
 

data/lib/rubyn_code/tools/edit_file.rb

@@ -1,18 +1,19 @@
 # frozen_string_literal: true
 
-require_relative "base"
-require_relative "registry"
+require_relative 'base'
+require_relative 'registry'
 
 module RubynCode
   module Tools
     class EditFile < Base
-      TOOL_NAME = "edit_file"
-      DESCRIPTION = "Performs exact string replacement in a file. Fails if old_text is not found or is ambiguous."
+      TOOL_NAME = 'edit_file'
+      DESCRIPTION = 'Performs exact string replacement in a file. Fails if old_text is not found or is ambiguous.'
       PARAMETERS = {
-        path: { type: :string, required: true, description: "Path to the file to edit" },
-        old_text: { type: :string, required: true, description: "The exact text to find and replace" },
-        new_text: { type: :string, required: true, description: "The replacement text" },
-        replace_all: { type: :boolean, required: false, default: false, description: "Replace all occurrences (default: false)" }
+        path: { type: :string, required: true, description: 'Path to the file to edit' },
+        old_text: { type: :string, required: true, description: 'The exact text to find and replace' },
+        new_text: { type: :string, required: true, description: 'The replacement text' },
+        replace_all: { type: :boolean, required: false, default: false,
+                       description: 'Replace all occurrences (default: false)' }
       }.freeze
       RISK_LEVEL = :write
       REQUIRES_CONFIRMATION = false
@@ -23,12 +24,11 @@ module RubynCode
 
         occurrences = content.scan(old_text).length
 
-        if occurrences.zero?
-          raise Error, "old_text not found in #{path}. No changes made."
-        end
+        raise Error, "old_text not found in #{path}. No changes made." if occurrences.zero?
 
         if !replace_all && occurrences > 1
-          raise Error, "old_text found #{occurrences} times in #{path}. Use replace_all: true to replace all, or provide a more specific old_text."
+          raise Error,
+                "old_text found #{occurrences} times in #{path}. Use replace_all: true to replace all, or provide a more specific old_text."
         end
 
         new_content = if replace_all

data/lib/rubyn_code/tools/executor.rb

@@ -20,7 +20,12 @@ module RubynCode
         inject_dependencies(tool, tool_name)
 
         symbolized = params.transform_keys(&:to_sym)
-        result = tool.execute(**symbolized)
+        # Filter to only params the tool's execute method accepts — LLM may send extra keys
+        allowed = tool.method(:execute).parameters
+                      .slice(:key, :keyreq)
+                      .map(&:last)
+        filtered = allowed.empty? ? symbolized : symbolized.slice(*allowed)
+        result = tool.execute(**filtered)
         tool.truncate(result.to_s)
       rescue ToolNotFoundError => e
         error_result("Tool error: #{e.message}")
@@ -42,14 +47,14 @@ module RubynCode
 
       def inject_dependencies(tool, tool_name)
         case tool_name
-        when "spawn_agent"
+        when 'spawn_agent'
           tool.llm_client = @llm_client if tool.respond_to?(:llm_client=)
           tool.on_status = @on_agent_status if tool.respond_to?(:on_status=)
-        when "spawn_teammate"
+        when 'spawn_teammate'
           tool.llm_client = @llm_client if tool.respond_to?(:llm_client=)
           tool.on_status = @on_agent_status if tool.respond_to?(:on_status=)
           tool.db = @db if tool.respond_to?(:db=)
-        when "background_run"
+        when 'background_run'
           tool.background_worker = @background_worker if tool.respond_to?(:background_worker=)
         end
       end

data/lib/rubyn_code/tools/git_commit.rb

@@ -1,70 +1,65 @@
 # frozen_string_literal: true
 
-require "open3"
-require_relative "base"
-require_relative "registry"
+require 'open3'
+require_relative 'base'
+require_relative 'registry'
 
 module RubynCode
   module Tools
     class GitCommit < Base
-      TOOL_NAME = "git_commit"
+      TOOL_NAME = 'git_commit'
       DESCRIPTION = "Stage files and create a git commit. Specify files to stage or use 'all' to stage everything."
       PARAMETERS = {
-        message: { type: :string, required: true, description: "The commit message" },
-        files: { type: :string, required: false, default: "all", description: "Space-separated file paths to stage, or 'all' to stage everything (git add -A)" }
+        message: { type: :string, required: true, description: 'The commit message' },
+        files: { type: :string, required: false, default: 'all',
+                 description: "Space-separated file paths to stage, or 'all' to stage everything (git add -A)" }
       }.freeze
       RISK_LEVEL = :write
       REQUIRES_CONFIRMATION = true
 
-      def execute(message:, files: "all")
+      def execute(message:, files: 'all')
         validate_git_repo!
         validate_message!(message)
 
         stage_files(files)
-        commit_output = create_commit(message)
-
-        commit_output
+        create_commit(message)
       end
 
       private
 
       def validate_git_repo!
-        _, _, status = Open3.capture3("git", "rev-parse", "--is-inside-work-tree", chdir: project_root)
-        unless status.success?
-          raise Error, "Not a git repository: #{project_root}"
-        end
+        _, _, status = safe_capture3('git', 'rev-parse', '--is-inside-work-tree', chdir: project_root)
+        return if status.success?
+
+        raise Error, "Not a git repository: #{project_root}"
       end
 
       def validate_message!(message)
-        if message.nil? || message.strip.empty?
-          raise Error, "Commit message cannot be empty"
-        end
+        return unless message.nil? || message.strip.empty?
+
+        raise Error, 'Commit message cannot be empty'
       end
 
       def stage_files(files)
-        if files.strip.downcase == "all"
-          stdout, stderr, status = Open3.capture3("git", "add", "-A", chdir: project_root)
+        if files.strip.downcase == 'all'
+          _, stderr, status = safe_capture3('git', 'add', '-A', chdir: project_root)
         else
           file_list = files.split(/\s+/).reject(&:empty?)
-          if file_list.empty?
-            raise Error, "No files specified to stage"
-          end
+          raise Error, 'No files specified to stage' if file_list.empty?
 
-          stdout, stderr, status = Open3.capture3("git", "add", "--", *file_list, chdir: project_root)
+          _, stderr, status = safe_capture3('git', 'add', '--', *file_list, chdir: project_root)
         end
 
-        unless status.success?
-          raise Error, "Failed to stage files: #{stderr.strip}"
-        end
+        return if status.success?
+
+        raise Error, "Failed to stage files: #{stderr.strip}"
       end
 
       def create_commit(message)
-        stdout, stderr, status = Open3.capture3("git", "commit", "-m", message, chdir: project_root)
+        stdout, stderr, status = safe_capture3('git', 'commit', '-m', message, chdir: project_root)
 
         unless status.success?
-          if stderr.include?("nothing to commit")
-            return "Nothing to commit — working tree is clean."
-          end
+          return 'Nothing to commit — working tree is clean.' if stderr.include?('nothing to commit')
 
           raise Error, "Commit failed: #{stderr.strip}"
         end
@@ -75,20 +70,20 @@ module RubynCode
 
         lines = ["Committed on branch: #{branch}"]
         lines << "Commit: #{commit_hash}" if commit_hash
-        lines << ""
+        lines << ''
         lines << stdout.strip
 
         lines.join("\n")
       end
 
       def extract_commit_hash
-        stdout, _, status = Open3.capture3("git", "rev-parse", "--short", "HEAD", chdir: project_root)
+        stdout, _, status = safe_capture3('git', 'rev-parse', '--short', 'HEAD', chdir: project_root)
         status.success? ? stdout.strip : nil
       end
 
       def current_branch
-        stdout, _, status = Open3.capture3("git", "branch", "--show-current", chdir: project_root)
-        status.success? && !stdout.strip.empty? ? stdout.strip : "HEAD (detached)"
+        stdout, _, status = safe_capture3('git', 'branch', '--show-current', chdir: project_root)
+        status.success? && !stdout.strip.empty? ? stdout.strip : 'HEAD (detached)'
       end
     end
 

data/lib/rubyn_code/tools/git_diff.rb

@@ -1,31 +1,30 @@
 # frozen_string_literal: true
 
-require "open3"
-require_relative "base"
-require_relative "registry"
+require 'open3'
+require_relative 'base'
+require_relative 'registry'
 
 module RubynCode
   module Tools
     class GitDiff < Base
-      TOOL_NAME = "git_diff"
-      DESCRIPTION = "Show git diff for staged, unstaged, or between branches/commits."
+      TOOL_NAME = 'git_diff'
+      DESCRIPTION = 'Show git diff for staged, unstaged, or between branches/commits.'
       PARAMETERS = {
-        target: { type: :string, required: false, default: "unstaged", description: 'What to diff: "staged", "unstaged", or a branch/commit ref (default: "unstaged")' }
+        target: { type: :string, required: false, default: 'unstaged',
+                  description: 'What to diff: "staged", "unstaged", or a branch/commit ref (default: "unstaged")' }
       }.freeze
       RISK_LEVEL = :read
       REQUIRES_CONFIRMATION = false
 
       MAX_DIFF_LENGTH = 80_000
 
-      def execute(target: "unstaged")
+      def execute(target: 'unstaged')
         validate_git_repo!
 
         cmd = build_diff_command(target.to_s.strip)
-        stdout, stderr, status = Open3.capture3(*cmd, chdir: project_root)
+        stdout, stderr, status = safe_capture3(*cmd, chdir: project_root)
 
-        unless status.success?
-          raise Error, "git diff failed: #{stderr.strip}"
-        end
+        raise Error, "git diff failed: #{stderr.strip}" unless status.success?
 
         if stdout.strip.empty?
           "No differences found for target: #{target}"
@@ -38,20 +37,20 @@ module RubynCode
       private
 
       def validate_git_repo!
-        _, _, status = Open3.capture3("git", "rev-parse", "--is-inside-work-tree", chdir: project_root)
-        unless status.success?
-          raise Error, "Not a git repository: #{project_root}"
-        end
+        _, _, status = safe_capture3('git', 'rev-parse', '--is-inside-work-tree', chdir: project_root)
+        return if status.success?
+
+        raise Error, "Not a git repository: #{project_root}"
       end
 
       def build_diff_command(target)
         case target.downcase
-        when "staged", "cached"
+        when 'staged', 'cached'
           %w[git diff --cached]
-        when "unstaged", ""
+        when 'unstaged', ''
           %w[git diff]
         else
-          ["git", "diff", target]
+          ['git', 'diff', target]
         end
       end
     end

data/lib/rubyn_code/tools/git_log.rb

@@ -1,17 +1,17 @@
 # frozen_string_literal: true
 
-require "open3"
-require_relative "base"
-require_relative "registry"
+require 'open3'
+require_relative 'base'
+require_relative 'registry'
 
 module RubynCode
   module Tools
     class GitLog < Base
-      TOOL_NAME = "git_log"
-      DESCRIPTION = "Show recent git commit history."
+      TOOL_NAME = 'git_log'
+      DESCRIPTION = 'Show recent git commit history.'
       PARAMETERS = {
-        count: { type: :integer, required: false, default: 20, description: "Number of commits to show (default: 20)" },
-        branch: { type: :string, required: false, description: "Branch name to show log for (default: current branch)" }
+        count: { type: :integer, required: false, default: 20, description: 'Number of commits to show (default: 20)' },
+        branch: { type: :string, required: false, description: 'Branch name to show log for (default: current branch)' }
       }.freeze
       RISK_LEVEL = :read
       REQUIRES_CONFIRMATION = false
@@ -21,17 +21,15 @@ module RubynCode
 
         count = [[count.to_i, 1].max, 200].min
 
-        cmd = ["git", "log", "--oneline", "-#{count}"]
+        cmd = ['git', 'log', '--oneline', "-#{count}"]
         cmd << branch unless branch.nil? || branch.strip.empty?
 
-        stdout, stderr, status = Open3.capture3(*cmd, chdir: project_root)
+        stdout, stderr, status = safe_capture3(*cmd, chdir: project_root)
 
-        unless status.success?
-          raise Error, "git log failed: #{stderr.strip}"
-        end
+        raise Error, "git log failed: #{stderr.strip}" unless status.success?
 
         if stdout.strip.empty?
-          "No commits found."
+          'No commits found.'
         else
           current = current_branch
           header = "Commit history#{branch ? " (#{branch})" : " (#{current})"}:\n\n"
@@ -42,15 +40,15 @@ module RubynCode
       private
 
       def validate_git_repo!
-        _, _, status = Open3.capture3("git", "rev-parse", "--is-inside-work-tree", chdir: project_root)
-        unless status.success?
-          raise Error, "Not a git repository: #{project_root}"
-        end
+        _, _, status = safe_capture3('git', 'rev-parse', '--is-inside-work-tree', chdir: project_root)
+        return if status.success?
+
+        raise Error, "Not a git repository: #{project_root}"
       end
 
       def current_branch
-        stdout, _, status = Open3.capture3("git", "branch", "--show-current", chdir: project_root)
-        status.success? && !stdout.strip.empty? ? stdout.strip : "HEAD (detached)"
+        stdout, _, status = safe_capture3('git', 'branch', '--show-current', chdir: project_root)
+        status.success? && !stdout.strip.empty? ? stdout.strip : 'HEAD (detached)'
       end
     end
 

data/lib/rubyn_code/tools/git_status.rb

@@ -1,14 +1,14 @@
 # frozen_string_literal: true
 
-require "open3"
-require_relative "base"
-require_relative "registry"
+require 'open3'
+require_relative 'base'
+require_relative 'registry'
 
 module RubynCode
   module Tools
     class GitStatus < Base
-      TOOL_NAME = "git_status"
-      DESCRIPTION = "Show the current git status — modified, staged, and untracked files."
+      TOOL_NAME = 'git_status'
+      DESCRIPTION = 'Show the current git status — modified, staged, and untracked files.'
       PARAMETERS = {}.freeze
       RISK_LEVEL = :read
       REQUIRES_CONFIRMATION = false
@@ -21,11 +21,11 @@ module RubynCode
 
         lines = ["Branch: #{branch}\n"]
 
-        if status_output.strip.empty?
-          lines << "Working tree is clean — nothing to commit."
-        else
-          lines << status_output
-        end
+        lines << if status_output.strip.empty?
+                   'Working tree is clean — nothing to commit.'
+                 else
+                   status_output
+                 end
 
         lines.join("\n")
       end
@@ -33,22 +33,20 @@ module RubynCode
       private
 
       def validate_git_repo!
-        _, _, status = Open3.capture3("git", "rev-parse", "--is-inside-work-tree", chdir: project_root)
-        unless status.success?
-          raise Error, "Not a git repository: #{project_root}"
-        end
+        _, _, status = safe_capture3('git', 'rev-parse', '--is-inside-work-tree', chdir: project_root)
+        return if status.success?
+
+        raise Error, "Not a git repository: #{project_root}"
       end
 
       def current_branch
-        stdout, _, status = Open3.capture3("git", "branch", "--show-current", chdir: project_root)
-        status.success? && !stdout.strip.empty? ? stdout.strip : "HEAD (detached)"
+        stdout, _, status = safe_capture3('git', 'branch', '--show-current', chdir: project_root)
+        status.success? && !stdout.strip.empty? ? stdout.strip : 'HEAD (detached)'
       end
 
       def git_status
-        stdout, stderr, status = Open3.capture3("git", "status", "--short", chdir: project_root)
-        unless status.success?
-          raise Error, "git status failed: #{stderr.strip}"
-        end
+        stdout, stderr, status = safe_capture3('git', 'status', '--short', chdir: project_root)
+        raise Error, "git status failed: #{stderr.strip}" unless status.success?
 
         stdout
       end