rubyjobbuilderdsl 0.0.5 → 0.0.6

data/test/test_cucumber_json_publisher.rb

@@ -1,30 +1,30 @@
-require_relative './test_xml_generator'
-
-class TestCucumberPublisher < Test::Unit::TestCase
-  def test_postbuild_cucumber_json_publisher
-    file_location = 'cucumber/results.json'
-    ignore_bad_results = 'false'
-
-    builder = JenkinsJob::Builder.new
-
-    builder.freestyle 'foo' do
-      postbuild do
-        cucumber_json_publisher do
-          test_results file_location
-          ignore_bad_tests ignore_bad_results
-        end
-      end
-    end
-
-    actual = builder.config_as_xml_node('foo')
-
-    {
-      'testResults' => file_location,
-      'ignoreBadSteps' => ignore_bad_results,
-    }.each do |k, v|
-      path = ['./project/publishers/org.jenkinsci.plugins.cucumber.',
-              "jsontestsupport.CucumberTestResultArchiver/#{k}"].join('')
-      assert_equal v, actual.xpath(path).text
-    end
-  end
-end
+require_relative './test_xml_generator'
+
+class TestCucumberPublisher < Test::Unit::TestCase
+  def test_postbuild_cucumber_json_publisher
+    file_location = 'cucumber/results.json'
+    ignore_bad_results = 'false'
+
+    builder = JenkinsJob::Builder.new
+
+    builder.freestyle 'foo' do
+      postbuild do
+        cucumber_json_publisher do
+          test_results file_location
+          ignore_bad_tests ignore_bad_results
+        end
+      end
+    end
+
+    actual = builder.config_as_xml_node('foo')
+
+    {
+      'testResults' => file_location,
+      'ignoreBadSteps' => ignore_bad_results,
+    }.each do |k, v|
+      path = ['./project/publishers/org.jenkinsci.plugins.cucumber.',
+              "jsontestsupport.CucumberTestResultArchiver/#{k}"].join('')
+      assert_equal v, actual.xpath(path).text
+    end
+  end
+end

data/test/test_default_setting.rb

@@ -1,29 +1,29 @@
-require_relative './test_xml_generator'
-
-class TestXmlDefaultSetting < Test::Unit::TestCase
-  def test_created_jobs_inherit_default_setting
-    builder = JenkinsJob::Builder.new do
-      node 'windows'
-      quiet_period 5
-    end
-
-    builder.freestyle 'show-env' do
-      shell 'env'
-    end
-
-    builder.freestyle 'show-dir' do
-      shell 'pwd'
-    end
-
-    actual_show_env = builder.config_as_xml_node('show-env')
-    actual_show_dir = builder.config_as_xml_node('show-dir')
-
-    assert_equal '5', actual_show_env.xpath('./project/quietPeriod').text
-    assert_equal 'windows', actual_show_env.xpath('./project/assignedNode').text
-    assert_equal 'env', actual_show_env.xpath('./project/builders/hudson.tasks.Shell/command').text
-
-    assert_equal '5', actual_show_dir.xpath('./project/quietPeriod').text
-    assert_equal 'windows', actual_show_dir.xpath('./project/assignedNode').text
-    assert_equal 'pwd', actual_show_dir.xpath('./project/builders/hudson.tasks.Shell/command').text
-  end
-end
+require_relative './test_xml_generator'
+
+class TestXmlDefaultSetting < Test::Unit::TestCase
+  def test_created_jobs_inherit_default_setting
+    builder = JenkinsJob::Builder.new do
+      node 'windows'
+      quiet_period 5
+    end
+
+    builder.freestyle 'show-env' do
+      shell 'env'
+    end
+
+    builder.freestyle 'show-dir' do
+      shell 'pwd'
+    end
+
+    actual_show_env = builder.config_as_xml_node('show-env')
+    actual_show_dir = builder.config_as_xml_node('show-dir')
+
+    assert_equal '5', actual_show_env.xpath('./project/quietPeriod').text
+    assert_equal 'windows', actual_show_env.xpath('./project/assignedNode').text
+    assert_equal 'env', actual_show_env.xpath('./project/builders/hudson.tasks.Shell/command').text
+
+    assert_equal '5', actual_show_dir.xpath('./project/quietPeriod').text
+    assert_equal 'windows', actual_show_dir.xpath('./project/assignedNode').text
+    assert_equal 'pwd', actual_show_dir.xpath('./project/builders/hudson.tasks.Shell/command').text
+  end
+end

data/test/test_email_publisher.rb

@@ -1,44 +1,44 @@
-require_relative './test_xml_generator'
-
-class TestXmlEmailPublisher < Test::Unit::TestCase
-  def test_postbuild_email_publisher
-    builder = JenkinsJob::Builder.new
-
-    builder.freestyle 'foo' do
-      postbuild do
-        send_email 'test@example.com' do
-          notify_every_unstable_build false
-          send_to_individuals true
-        end
-      end
-    end
-
-    actual = builder.config_as_xml_node('foo')
-
-    { 'recipients' => 'test@example.com',
-      'dontNotifyEveryUnstableBuild' => 'true',
-      'sendToIndividuals' => 'true'
-     }.each do |k, v|
-       assert_equal v, actual.xpath("./project/publishers/hudson.tasks.Mailer/#{k}").text, k
-     end
-  end
-
-  def test_postbuild_email_publisher_defaults
-    builder = JenkinsJob::Builder.new
-
-    builder.freestyle 'foo' do
-      postbuild do
-        send_email 'test@example.com'
-      end
-    end
-
-    actual = builder.config_as_xml_node('foo')
-
-    { 'recipients' => 'test@example.com',
-      'dontNotifyEveryUnstableBuild' => 'false',
-      'sendToIndividuals' => 'false'
-     }.each do |k, v|
-       assert_equal v, actual.xpath("./project/publishers/hudson.tasks.Mailer/#{k}").text, k
-     end
-  end
-end
+require_relative './test_xml_generator'
+
+class TestXmlEmailPublisher < Test::Unit::TestCase
+  def test_postbuild_email_publisher
+    builder = JenkinsJob::Builder.new
+
+    builder.freestyle 'foo' do
+      postbuild do
+        send_email 'test@example.com' do
+          notify_every_unstable_build false
+          send_to_individuals true
+        end
+      end
+    end
+
+    actual = builder.config_as_xml_node('foo')
+
+    { 'recipients' => 'test@example.com',
+      'dontNotifyEveryUnstableBuild' => 'true',
+      'sendToIndividuals' => 'true'
+     }.each do |k, v|
+       assert_equal v, actual.xpath("./project/publishers/hudson.tasks.Mailer/#{k}").text, k
+     end
+  end
+
+  def test_postbuild_email_publisher_defaults
+    builder = JenkinsJob::Builder.new
+
+    builder.freestyle 'foo' do
+      postbuild do
+        send_email 'test@example.com'
+      end
+    end
+
+    actual = builder.config_as_xml_node('foo')
+
+    { 'recipients' => 'test@example.com',
+      'dontNotifyEveryUnstableBuild' => 'false',
+      'sendToIndividuals' => 'false'
+     }.each do |k, v|
+       assert_equal v, actual.xpath("./project/publishers/hudson.tasks.Mailer/#{k}").text, k
+     end
+  end
+end

data/test/test_flow.rb

@@ -1,19 +1,19 @@
-require_relative './test_xml_generator'
-
-class TestXmlFlow < Test::Unit::TestCase
-  def test_flow
-    groovy_code = <<EOS
-build("ops-" + params["GERRIT_BRANCH"], GERRIT_REFSPEC: "refs/heads/${params["GERRIT_BRANCH"]}",
-  GERRIT_BRANCH: params["GERRIT_BRANCH"])
-EOS
-    builder = JenkinsJob::Builder.new
-    builder.flow 'foo' do
-      dsl groovy_code
-    end
-
-    actual = builder.config_as_xml_node('foo')
-    { 'buildNeedsWorkspace' => 'true', 'dsl' => groovy_code }.each do |k, v|
-      assert_equal v, actual.xpath("./com.cloudbees.plugins.flow.BuildFlow/#{k}").text, k
-    end
-  end
-end
+require_relative './test_xml_generator'
+
+class TestXmlFlow < Test::Unit::TestCase
+  def test_flow
+    groovy_code = <<EOS
+build("ops-" + params["GERRIT_BRANCH"], GERRIT_REFSPEC: "refs/heads/${params["GERRIT_BRANCH"]}",
+  GERRIT_BRANCH: params["GERRIT_BRANCH"])
+EOS
+    builder = JenkinsJob::Builder.new
+    builder.flow 'foo' do
+      dsl groovy_code
+    end
+
+    actual = builder.config_as_xml_node('foo')
+    { 'buildNeedsWorkspace' => 'true', 'dsl' => groovy_code }.each do |k, v|
+      assert_equal v, actual.xpath("./com.cloudbees.plugins.flow.BuildFlow/#{k}").text, k
+    end
+  end
+end

data/test/test_freestyle.rb

@@ -1,52 +1,52 @@
-require_relative './test_xml_generator'
-
-class TestXmlFreestyle < Test::Unit::TestCase
-  def test_freestyle
-    builder = JenkinsJob::Builder.new
-
-    builder.freestyle 'foo' do
-      desc 'this is a foo'
-      workspace 'foo-$BUILD_NUMBER'
-      node 'windows'
-      quiet_period 5
-    end
-
-    actual = builder.config_as_xml_node('foo')
-
-    assert_equal '', actual.xpath('./project/actions').text
-    assert_equal 'this is a foo', actual.xpath('./project/description').text
-    assert_equal 'false', actual.xpath('./project/keepDependencies').text
-    assert_equal 'false', actual.xpath('./project/blockBuildWhenDownstreamBuilding').text
-    assert_equal 'false', actual.xpath('./project/concurrentBuild').text
-    assert_equal 'foo-$BUILD_NUMBER', actual.xpath('./project/customWorkspace').text
-    assert_equal '5', actual.xpath('./project/quietPeriod').text
-    assert_equal 'windows', actual.xpath('./project/assignedNode').text
-    assert_equal 'false', actual.xpath('./project/canRoam').text
-    assert_equal '', actual.xpath('./project/properties').text
-    assert_equal 'hudson.scm.NullSCM',  actual.xpath('./project/scm').attr('class').text
-    assert_equal '', actual.xpath('./project/builders').text
-    assert_equal '', actual.xpath('./project/publishers').text
-    assert_equal '', actual.xpath('./project/buildWrappers').text
-  end
-
-  def test_builders
-    builder = JenkinsJob::Builder.new
-
-    builder.freestyle 'foo' do
-      powershell 'Get-Service bar.* | foreach { sc.exe stop $_.Name }'
-      shell 'rm -rf * || true'
-      batch 'c:\Nuget\NuGet.exe Install ServiceTestRunner -source ArtifactoryBuildScripts -config c:\Nuget\NuGet.Config'
-    end
-
-    actual = builder.config_as_xml_node('foo')
-
-    assert_equal 'Get-Service bar.* | foreach { sc.exe stop $_.Name }',
-                 actual.xpath('./project/builders/hudson.plugins.powershell.PowerShell/command').text
-
-    assert_equal 'rm -rf * || true',
-                 actual.xpath('./project/builders/hudson.tasks.Shell/command').text
-
-    assert_equal 'c:\Nuget\NuGet.exe Install ServiceTestRunner -source ArtifactoryBuildScripts -config c:\Nuget\NuGet.Config',
-                 actual.xpath('./project/builders/hudson.tasks.BatchFile/command').text
-  end
-end
+require_relative './test_xml_generator'
+
+class TestXmlFreestyle < Test::Unit::TestCase
+  def test_freestyle
+    builder = JenkinsJob::Builder.new
+
+    builder.freestyle 'foo' do
+      desc 'this is a foo'
+      workspace 'foo-$BUILD_NUMBER'
+      node 'windows'
+      quiet_period 5
+    end
+
+    actual = builder.config_as_xml_node('foo')
+
+    assert_equal '', actual.xpath('./project/actions').text
+    assert_equal 'this is a foo', actual.xpath('./project/description').text
+    assert_equal 'false', actual.xpath('./project/keepDependencies').text
+    assert_equal 'false', actual.xpath('./project/blockBuildWhenDownstreamBuilding').text
+    assert_equal 'false', actual.xpath('./project/concurrentBuild').text
+    assert_equal 'foo-$BUILD_NUMBER', actual.xpath('./project/customWorkspace').text
+    assert_equal '5', actual.xpath('./project/quietPeriod').text
+    assert_equal 'windows', actual.xpath('./project/assignedNode').text
+    assert_equal 'false', actual.xpath('./project/canRoam').text
+    assert_equal '', actual.xpath('./project/properties').text
+    assert_equal 'hudson.scm.NullSCM',  actual.xpath('./project/scm').attr('class').text
+    assert_equal '', actual.xpath('./project/builders').text
+    assert_equal '', actual.xpath('./project/publishers').text
+    assert_equal '', actual.xpath('./project/buildWrappers').text
+  end
+
+  def test_builders
+    builder = JenkinsJob::Builder.new
+
+    builder.freestyle 'foo' do
+      powershell 'Get-Service bar.* | foreach { sc.exe stop $_.Name }'
+      shell 'rm -rf * || true'
+      batch 'c:\Nuget\NuGet.exe Install ServiceTestRunner -source ArtifactoryBuildScripts -config c:\Nuget\NuGet.Config'
+    end
+
+    actual = builder.config_as_xml_node('foo')
+
+    assert_equal 'Get-Service bar.* | foreach { sc.exe stop $_.Name }',
+                 actual.xpath('./project/builders/hudson.plugins.powershell.PowerShell/command').text
+
+    assert_equal 'rm -rf * || true',
+                 actual.xpath('./project/builders/hudson.tasks.Shell/command').text
+
+    assert_equal 'c:\Nuget\NuGet.exe Install ServiceTestRunner -source ArtifactoryBuildScripts -config c:\Nuget\NuGet.Config',
+                 actual.xpath('./project/builders/hudson.tasks.BatchFile/command').text
+  end
+end

data/test/test_game_publisher.rb

@@ -1,17 +1,17 @@
-require_relative './test_xml_generator'
-
-class TestGamePublisher < Test::Unit::TestCase
-  def test_postbuild_game_publisher
-    builder = JenkinsJob::Builder.new
-
-    builder.freestyle 'foo' do
-      postbuild do
-        game
-      end
-    end
-
-    actual = builder.config_as_xml_node('foo')
-
-    assert actual.at('./project/publishers/hudson.plugins.cigame.GamePublisher')
-  end
-end
+require_relative './test_xml_generator'
+
+class TestGamePublisher < Test::Unit::TestCase
+  def test_postbuild_game_publisher
+    builder = JenkinsJob::Builder.new
+
+    builder.freestyle 'foo' do
+      postbuild do
+        game
+      end
+    end
+
+    actual = builder.config_as_xml_node('foo')
+
+    assert actual.at('./project/publishers/hudson.plugins.cigame.GamePublisher')
+  end
+end

data/test/test_gerrit.rb

@@ -1,117 +1,117 @@
-require_relative './test_xml_generator'
-
-class TestXmlGerrit < Test::Unit::TestCase
-  def test_gerrit_project
-    builder = JenkinsJob::Builder.new
-
-    builder.flow 'foo' do
-      gerrit do
-        patchset_uploaded
-
-        project 'foo/bar' do
-          branch 'master', 'release'
-          file 'a/**',
-               'b/**'
-        end
-      end
-    end
-
-    actual = builder.config_as_xml_node('foo')
-
-    { 'compareType' => 'PLAIN', 'pattern' => 'foo/bar' }.each do |k, v|
-      assert_equal v, actual.xpath('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
-                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/gerritProjects/' \
-                     "com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject/#{k}").text, k
-    end
-
-    { 1 =>  { 'compareType' => 'ANT', 'pattern' => 'master' },
-      2 =>  { 'compareType' => 'ANT', 'pattern' => 'release' } }.each do |item, data|
-      data.each do |k, v|
-        assert_equal v, actual.xpath('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
-                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/gerritProjects/' \
-                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject/branches/' \
-                     "com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.Branch[#{item}]/#{k}").text, "item #{item}, #{k}"
-      end
-    end
-
-    { 1 =>  { 'compareType' => 'ANT', 'pattern' => 'a/**' },
-      2 =>  { 'compareType' => 'ANT', 'pattern' => 'b/**' } }.each do |item, data|
-      data.each do |k, v|
-        assert_equal v, actual.xpath('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
-                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/gerritProjects/' \
-                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject/filePaths/' \
-                     "com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.FilePath[#{item}]/#{k}").text, "item #{item}, #{k}"
-      end
-    end
-  end
-
-  def test_patchset_uploaded
-    builder = JenkinsJob::Builder.new
-
-    builder.flow 'foo' do
-      gerrit do
-        patchset_uploaded
-      end
-    end
-
-    actual = builder.config_as_xml_node('foo')
-
-    assert actual.at('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
-                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/triggerOnEvents/' \
-                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginPatchsetCreatedEvent')
-  end
-
-  def test_gerrit_change_merged
-    builder = JenkinsJob::Builder.new
-
-    builder.flow 'foo' do
-      gerrit do
-        change_merged
-      end
-    end
-
-    actual = builder.config_as_xml_node('foo')
-    assert actual.at('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
-                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/triggerOnEvents/' \
-                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginChangeMergedEvent')
-  end
-
-  def test_gerrit_one_comment_added
-    builder = JenkinsJob::Builder.new
-
-    builder.flow 'foo' do
-      gerrit do
-        comment_added 'Code-Review' => '2'
-      end
-    end
-
-    actual = builder.config_as_xml_node('foo')
-    { 'verdictCategory' => 'Code-Review', 'commentAddedTriggerApprovalValue' => '2' }.each do |k, v|
-      assert_equal v, actual.xpath('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
-                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/triggerOnEvents/' \
-                     "com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginCommentAddedEvent/#{k}").text, k
-    end
-  end
-
-  def test_gerrit_more_comment_added
-    builder = JenkinsJob::Builder.new
-
-    builder.flow 'foo' do
-      gerrit do
-        comment_added 'Code-Review' => '2', 'Verified' => '1'
-      end
-    end
-
-    actual = builder.config_as_xml_node('foo')
-
-    { 1 => { 'verdictCategory' => 'Code-Review', 'commentAddedTriggerApprovalValue' => '2' },
-      2 => { 'verdictCategory' => 'Verified', 'commentAddedTriggerApprovalValue' => '1' } }.each do |item, data|
-      data.each do |k, v|
-        assert_equal v, actual.xpath('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
-          'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/triggerOnEvents/' \
-          "com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginCommentAddedEvent[#{item}]/#{k}").text,
-                     "item #{item}, #{k}"
-      end
-    end
-  end
-end
+require_relative './test_xml_generator'
+
+class TestXmlGerrit < Test::Unit::TestCase
+  def test_gerrit_project
+    builder = JenkinsJob::Builder.new
+
+    builder.flow 'foo' do
+      gerrit do
+        patchset_uploaded
+
+        project 'foo/bar' do
+          branch 'master', 'release'
+          file 'a/**',
+               'b/**'
+        end
+      end
+    end
+
+    actual = builder.config_as_xml_node('foo')
+
+    { 'compareType' => 'PLAIN', 'pattern' => 'foo/bar' }.each do |k, v|
+      assert_equal v, actual.xpath('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
+                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/gerritProjects/' \
+                     "com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject/#{k}").text, k
+    end
+
+    { 1 =>  { 'compareType' => 'ANT', 'pattern' => 'master' },
+      2 =>  { 'compareType' => 'ANT', 'pattern' => 'release' } }.each do |item, data|
+      data.each do |k, v|
+        assert_equal v, actual.xpath('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
+                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/gerritProjects/' \
+                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject/branches/' \
+                     "com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.Branch[#{item}]/#{k}").text, "item #{item}, #{k}"
+      end
+    end
+
+    { 1 =>  { 'compareType' => 'ANT', 'pattern' => 'a/**' },
+      2 =>  { 'compareType' => 'ANT', 'pattern' => 'b/**' } }.each do |item, data|
+      data.each do |k, v|
+        assert_equal v, actual.xpath('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
+                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/gerritProjects/' \
+                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject/filePaths/' \
+                     "com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.FilePath[#{item}]/#{k}").text, "item #{item}, #{k}"
+      end
+    end
+  end
+
+  def test_patchset_uploaded
+    builder = JenkinsJob::Builder.new
+
+    builder.flow 'foo' do
+      gerrit do
+        patchset_uploaded
+      end
+    end
+
+    actual = builder.config_as_xml_node('foo')
+
+    assert actual.at('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
+                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/triggerOnEvents/' \
+                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginPatchsetCreatedEvent')
+  end
+
+  def test_gerrit_change_merged
+    builder = JenkinsJob::Builder.new
+
+    builder.flow 'foo' do
+      gerrit do
+        change_merged
+      end
+    end
+
+    actual = builder.config_as_xml_node('foo')
+    assert actual.at('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
+                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/triggerOnEvents/' \
+                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginChangeMergedEvent')
+  end
+
+  def test_gerrit_one_comment_added
+    builder = JenkinsJob::Builder.new
+
+    builder.flow 'foo' do
+      gerrit do
+        comment_added 'Code-Review' => '2'
+      end
+    end
+
+    actual = builder.config_as_xml_node('foo')
+    { 'verdictCategory' => 'Code-Review', 'commentAddedTriggerApprovalValue' => '2' }.each do |k, v|
+      assert_equal v, actual.xpath('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
+                     'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/triggerOnEvents/' \
+                     "com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginCommentAddedEvent/#{k}").text, k
+    end
+  end
+
+  def test_gerrit_more_comment_added
+    builder = JenkinsJob::Builder.new
+
+    builder.flow 'foo' do
+      gerrit do
+        comment_added 'Code-Review' => '2', 'Verified' => '1'
+      end
+    end
+
+    actual = builder.config_as_xml_node('foo')
+
+    { 1 => { 'verdictCategory' => 'Code-Review', 'commentAddedTriggerApprovalValue' => '2' },
+      2 => { 'verdictCategory' => 'Verified', 'commentAddedTriggerApprovalValue' => '1' } }.each do |item, data|
+      data.each do |k, v|
+        assert_equal v, actual.xpath('./com.cloudbees.plugins.flow.BuildFlow/triggers/' \
+          'com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger/triggerOnEvents/' \
+          "com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginCommentAddedEvent[#{item}]/#{k}").text,
+                     "item #{item}, #{k}"
+      end
+    end
+  end
+end