rubyipmi 0.8.1 → 0.9.0

data/spec/unit/freeipmi/fru_spec.rb

@@ -1,5 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-
+require 'spec_helper'
 describe :Fru do
 
   before :all do
@@ -14,7 +13,7 @@ describe :Fru do
     user = "ipmiuser"
     pass = "impipass"
     host = "ipmihost"
-    Rubyipmi.stub(:locate_command).with('ipmipower').and_return("#{@path}/ipmipower")
+    allow(Rubyipmi).to receive(:locate_command).with('ipmipower').and_return("#{@path}/ipmipower")
 
     @conn = Rubyipmi.connect(user, pass, host, provider, {:debug => true})
     @fru = @conn.fru
@@ -22,9 +21,9 @@ describe :Fru do
       data = file.read
     end
 
-    @fru.stub(:locate_command).with('ipmi-fru').and_return("#{@path}/ipmi-fru")
-    @fru.stub(:`).and_return(data)
-    $?.stub(:success?).and_return(true)
+    allow(@fru).to receive(:locate_command).with('ipmi-fru').and_return("#{@path}/ipmi-fru")
+    allow(@fru).to receive(:`).and_return(data)
+    allow($?).to receive(:success?).and_return(true)
   end
 
   it "cmd should be ipmi-fru with correct number of arguments" do
@@ -33,43 +32,43 @@ describe :Fru do
   end
 
   it 'should list data' do
-    @fru.names.count.should eq(1)
+    expect(@fru.names.count).to eq(1)
   end
 
   it 'should return a list of unparsed frus' do
-    @fru.getfrus.should_not be_nil
+    expect(@fru.getfrus).not_to be_nil
   end
 
 
   it "should return a list of parsed frus" do
-    @fru.list.count.should eq(1)
+    expect(@fru.list.count).to eq(1)
   end
 
   it 'should return a manufacturer' do
-    @fru.board_manufacturer.should eq('HP')
+    expect(@fru.board_manufacturer).to eq('HP')
   end
 
   it 'should return a product' do
-    @fru.board_product_name.should eq('ProLiant DL380 G5')
+    expect(@fru.board_product_name).to eq('ProLiant DL380 G5')
   end
 
   it 'should return a chassis serial' do
-    @fru.chassis_serial_number.should eq('2UX64201U2')
+    expect(@fru.chassis_serial_number).to eq('2UX64201U2')
   end
 
   it 'should return a board serial' do
-    @fru.board_serial_number.should eq('2UX64201U2')
+    expect(@fru.board_serial_number).to eq('2UX64201U2')
   end
 
   it 'should return a list of fru names' do
-    @fru.names.count.should eq(1)
+    expect(@fru.names.count).to eq(1)
   end
 
   it 'should return a fru using method missing' do
     @fru.names.each do |name|
       fru = @fru.send(name)
-      fru.should be_an_instance_of(Rubyipmi::Freeipmi::FruData)
-      fru[:name].should eq(name)
+      expect(fru).to be_an_instance_of(Rubyipmi::Freeipmi::FruData)
+      expect(fru[:name]).to eq(name)
 
     end
   end

data/spec/unit/freeipmi/sensors_spec.rb

@@ -1,4 +1,6 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+require 'spec_helper'
+
+
 describe :Sensors do
   before :all do
     @path = '/usr/local/bin'
@@ -12,7 +14,7 @@ describe :Sensors do
     pass = "impipass"
     host = "ipmihost"
     # this stub allows us to mock the command that would be used to verify provider installation
-    Rubyipmi.stub(:locate_command).with('ipmipower').and_return("#{@path}/ipmipower")
+    allow(Rubyipmi).to receive(:locate_command).with('ipmipower').and_return("#{@path}/ipmipower")
 
     @conn = Rubyipmi.connect(user, pass, host, provider, {:debug => true})
     @sensors = @conn.sensors
@@ -20,11 +22,11 @@ describe :Sensors do
       data = file.read
     end
     # this stub allows us to mock the command that is used with this test case
-    @sensors.stub(:locate_command).with('ipmi-sensors').and_return('/usr/local/bin/ipmi-sensors')
+    allow(@sensors).to receive(:locate_command).with('ipmi-sensors').and_return('/usr/local/bin/ipmi-sensors')
 
     # these stubs allow us to run the command and return the fixtures
-    @sensors.stub(:`).and_return(data)
-    $?.stub(:success?).and_return(true)
+    allow(@sensors).to receive(:`).and_return(data)
+    allow($?).to receive(:success?).and_return(true)
 
   end
 
@@ -34,36 +36,36 @@ describe :Sensors do
  end
 
   it "can return a list of sensors" do
-   @sensors.list.should_not be_nil
+   expect(@sensors.list).not_to be_nil
   end
 
   it "should return a count of sensors" do
-    @sensors.count.should eq(29)
+    expect(@sensors.count).to eq(29)
   end
 
   it "should return a list of fan names" do
-    @sensors.fanlist.count.should eq(13)
+    expect(@sensors.fanlist.count).to eq(13)
   end
 
   it 'should return a list of temp names' do
-    @sensors.templist.count.should.should eq(7)
+    expect(@sensors.templist.count).to eq(7)
   end
 
   it 'should return a list of sensor names as an array' do
-    @sensors.names.should be_an_instance_of(Array)
-    @sensors.names.count.should eq(29)
+    expect(@sensors.names).to be_an_instance_of(Array)
+    expect(@sensors.names.count).to eq(29)
   end
 
   it 'should return an empty list if no data exists' do
-    @sensors.stub(:getsensors).and_return(nil)
-    @sensors.names.count.should eq(0)
+    allow(@sensors).to receive(:getsensors).and_return(nil)
+    expect(@sensors.names.count).to eq(0)
   end
 
   it 'should return a sensor using method missing' do
     @sensors.names.each do |name|
       sensor = @sensors.send(name)
-      sensor.should be_an_instance_of(Rubyipmi::Freeipmi::Sensor)
-      sensor[:name].should eq(name)
+      expect(sensor).to be_an_instance_of(Rubyipmi::Freeipmi::Sensor)
+      expect(sensor[:name]).to eq(name)
     end
   end
 

data/spec/unit/ipmitool/bmc_spec.rb

@@ -1,5 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-
+require 'spec_helper'
 
 
 describe "Bmc" do
@@ -14,7 +13,7 @@ describe "Bmc" do
     user = "ipmiuser"
     pass = "impipass"
     host = "ipmihost"
-    Rubyipmi.stub(:locate_command).with('ipmitool').and_return("#{@path}/ipmitool")
+    allow(Rubyipmi).to receive(:locate_command).with('ipmitool').and_return("#{@path}/ipmitool")
     @conn = Rubyipmi.connect(user, pass, host, provider, {:debug => true})
     @bmc = @conn.bmc
     data = nil
@@ -22,32 +21,32 @@ describe "Bmc" do
       data = file.read
     end
 
-    @bmc.stub(:locate_command).with('ipmitool').and_return("#{@path}/ipmitool")
-    @bmc.stub(:`).and_return(data)
-    $?.stub(:success?).and_return(true)
+    allow(@bmc).to receive(:locate_command).with('ipmitool').and_return("#{@path}/ipmitool")
+    allow(@bmc).to receive(:`).and_return(data)
+    allow($?).to receive(:success?).and_return(true)
 
-    @bmc.stub(:guid).and_return("guid")
+    allow(@bmc).to receive(:guid).and_return("guid")
 
   end
 
   it "bmc should not be nil" do
-    @bmc.should_not be nil
+    expect(@bmc).not_to be nil
   end
 
   it "lan should not be nil" do
-    @bmc.lan.should_not be_nil
+    expect(@bmc.lan).not_to be_nil
   end
 
   it "guid should not be nil" do
-     @bmc.guid.should_not be_nil
+     expect(@bmc.guid).not_to be_nil
   end
 
   it "info should not be nil" do
-    @bmc.info.should_not be_nil
+    expect(@bmc.info).not_to be_nil
   end
 
   it "info should parse as expected" do
-    @bmc.info.should eq(RETRIEVE)
+    expect(@bmc.info).to eq(RETRIEVE)
   end
 
 end

data/spec/unit/ipmitool/connection_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+require 'spec_helper'
 
 describe :Connection do
 
@@ -12,55 +12,51 @@ describe :Connection do
 
   before :each do
 
-    Rubyipmi.stub(:locate_command).with('ipmitool').and_return("#{@path}/ipmitool")
+    allow(Rubyipmi).to receive(:locate_command).with('ipmitool').and_return("#{@path}/ipmitool")
     @conn = Rubyipmi.connect(@user, @pass, @host, @provider,{:debug => true})
 
   end
 
   it "connection should not be nil" do
-    @conn.should_not be_nil
+    expect(@conn).not_to be_nil
   end
 
   it "fru should not be nil" do
-    @conn.fru.should_not be_nil
+    expect(@conn.fru).not_to be_nil
   end
 
   it "provider should not be nil" do
-    @conn.provider.should_not be_nil
+    expect(@conn.provider).not_to be_nil
   end
 
   it "provider should be ipmitool" do
-    @conn.provider.should == "ipmitool"
+    expect(@conn.provider).to eq("ipmitool")
   end
 
   it "bmc should not be nil" do
-    @conn.bmc.should_not be_nil
+    expect(@conn.bmc).not_to be_nil
   end
 
   it "sensors should not be nil" do
-    @conn.sensors.should_not be_nil
+    expect(@conn.sensors).not_to be_nil
 
   end
 
   it "chassis should not be nill" do
-    @conn.chassis.should_not be_nil
+    expect(@conn.chassis).not_to be_nil
   end
 
   it "provider should return ipmitool" do
-    @conn.provider.should eq("ipmitool")
-  end
-
-  it "debug value should be true" do
-    @conn.debug.should be_true
+    expect(@conn.provider).to eq("ipmitool")
   end
 
   it 'object should have driver set to auto if not specified' do
-    @conn.options.has_key?('driver-type').should be_false
+    expect(@conn.options.has_key?('driver-type')).to eq false
   end
 
   it 'object should have driver set to auto if not specified' do
     @conn = Rubyipmi.connect(@user, @pass, @host, @provider,{:debug => true, :driver => 'auto'})
-    @conn.options.has_key?('I').should be_false
+    expect(@conn.options.has_key?('I')).to eq false
   end
 
   it 'should raise exception if invalid driver type' do
@@ -69,12 +65,12 @@ describe :Connection do
 
   it 'object should have priv type set to ADMINISTRATOR if not specified' do
     @conn = Rubyipmi.connect(@user, @pass, @host, @provider,{:debug => true, :driver => 'auto'})
-    @conn.options.has_key?('L').should be_false
+    expect(@conn.options.has_key?('L')).to eq false
   end
 
   it 'object should have priv type set to USER ' do
     @conn = Rubyipmi.connect(@user, @pass, @host, @provider,{:privilege => 'USER', :debug => true, :driver => 'auto'})
-    @conn.options.fetch('L').should eq('USER')
+    expect(@conn.options.fetch('L')).to eq('USER')
   end
 
   it 'should raise exception if invalid privilege type' do
@@ -83,17 +79,43 @@ describe :Connection do
 
   it 'object should have driver set to lanplus' do
     @conn = Rubyipmi.connect(@user, @pass, @host, @provider,{:debug => true, :driver => 'lan20'})
-    @conn.options['I'].should eq('lanplus')
+    expect(@conn.options['I']).to eq('lanplus')
   end
 
   it 'object should have driver set to lanplus' do
     @conn = Rubyipmi.connect(@user, @pass, @host, @provider,{:debug => true, :driver => 'lan15'})
-    @conn.options['I'].should eq('lan')
+    expect(@conn.options['I']).to eq('lan')
   end
 
   it 'object should have driver set to open' do
     @conn = Rubyipmi.connect(@user, @pass, @host, @provider,{:debug => true, :driver => 'open'})
-    @conn.options['I'].should eq('open')
+    expect(@conn.options['I']).to eq('open')
+  end
+  describe 'test' do
+    it 'should retrun boolean on test connection when result is not a hash' do
+      conn = Rubyipmi.connect(@user, @pass, @host, @provider,{:debug => true, :driver => 'auto'})
+      bmc = double()
+      allow(bmc).to receive(:info).and_return('')
+      allow(conn).to receive(:bmc).and_return(bmc)
+      expect(conn.connection_works?).to eq false
+    end
+
+    it 'should retrun boolean on test connection when result is a hash' do
+      conn = Rubyipmi.connect(@user, @pass, @host, @provider,{:debug => true, :driver => 'auto'})
+      bmc = double()
+      allow(bmc).to receive(:info).and_return({:test => true})
+      allow(conn).to receive(:bmc).and_return(bmc)
+      expect(conn.connection_works?).to eq true
+    end
+
+    it 'should retrun boolean on test connection when nil' do
+      conn = Rubyipmi.connect(@user, @pass, @host, @provider,{:debug => true, :driver => 'auto'})
+      bmc = double()
+      allow(bmc).to receive(:info).and_return(nil)
+      allow(conn).to receive(:bmc).and_return(bmc)
+      expect(conn.connection_works?).to eq false
+    end
   end
 
+
 end

data/spec/unit/ipmitool/errorcodes_spec.rb

@@ -1,4 +1,5 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+require 'spec_helper'
+
 require 'rubyipmi/ipmitool/errorcodes'
 
 describe "Errorcodes" do
@@ -6,17 +7,17 @@ describe "Errorcodes" do
 
 
   it 'should return the length of fix hash' do
-     Rubyipmi::Ipmitool::ErrorCodes.length.should be > 1
+     expect(Rubyipmi::Ipmitool::ErrorCodes.length).to be > 1
   end
 
   it 'should return a hash of codes' do
-    Rubyipmi::Ipmitool::ErrorCodes.code.should be_an_instance_of Hash
+    expect(Rubyipmi::Ipmitool::ErrorCodes.code).to be_an_instance_of Hash
 
   end
 
   it 'should return a fix if code is found' do
     code = 'Authentication type NONE not supported'
-    Rubyipmi::Ipmitool::ErrorCodes.search(code).should eq({"I"=>"lanplus"})
+    expect(Rubyipmi::Ipmitool::ErrorCodes.search(code)).to eq({"I"=>"lanplus"})
   end
 
   it 'should throw and error if no fix is found' do

data/spec/unit/ipmitool/fru_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+require 'spec_helper'
 
 describe :Fru do
 
@@ -13,7 +13,7 @@ describe :Fru do
     user = "ipmiuser"
     pass = "impipass"
     host = "ipmihost"
-    Rubyipmi.stub(:locate_command).with('ipmitool').and_return("#{@path}/ipmitool")
+    allow(Rubyipmi).to receive(:locate_command).with('ipmitool').and_return("#{@path}/ipmitool")
 
     @conn = Rubyipmi.connect(user, pass, host, provider, {:debug => true})
     @fru = @conn.fru
@@ -22,9 +22,9 @@ describe :Fru do
       data = file.read
     end
 
-    @fru.stub(:locate_command).with('ipmitool').and_return("#{@path}/ipmitool")
-    @fru.stub(:`).and_return(data)
-    $?.stub(:success?).and_return(true)
+    allow(@fru).to receive(:locate_command).with('ipmitool').and_return("#{@path}/ipmitool")
+    allow(@fru).to receive(:`).and_return(data)
+    allow($?).to receive(:success?).and_return(true)
 
   end
 
@@ -34,42 +34,42 @@ describe :Fru do
   end
 
   it 'should return a list of unparsed frus' do
-    @fru.getfrus.should_not be_nil
+    expect(@fru.getfrus).not_to be_nil
   end
 
   it 'should return a list of fru names' do
-    @fru.names.count.should eq(13)
+    expect(@fru.names.count).to eq(13)
   end
 
   it "should return a list of parsed frus" do
-    @fru.list.count.should eq(13)
+    expect(@fru.list.count).to eq(13)
   end
 
   it 'should return a manufactor' do
-    @fru.product_manufacturer.should eq('HP')
+    expect(@fru.product_manufacturer).to eq('HP')
   end
 
   it 'should return a product' do
-    @fru.product_name.should eq('ProLiant SL230s Gen8')
+    expect(@fru.product_name).to eq('ProLiant SL230s Gen8')
   end
 
   it 'should return a board serial' do
-    @fru.board_serial.should eq('USE238F0D0')
+    expect(@fru.board_serial).to eq('USE238F0D0')
   end
 
   it 'should return a product serial' do
-    @fru.product_serial.should eq('USE238F0D0')
+    expect(@fru.product_serial).to eq('USE238F0D0')
   end
 
   it 'should return a asset tag' do
-    @fru.product_asset_tag.should eq('000015B90F82')
+    expect(@fru.product_asset_tag).to eq('000015B90F82')
   end
 
   it 'should return a fru using method missing' do
     @fru.names.each do |name|
       fru = @fru.send(name)
-      fru.should be_an_instance_of(Rubyipmi::Ipmitool::FruData)
-      fru[:name].should eq(name)
+      expect(fru).to be_an_instance_of(Rubyipmi::Ipmitool::FruData)
+      expect(fru[:name]).to eq(name)
     end
   end