rubygems-update 3.3.18 → 3.4.19

data/test/rubygems/test_gem_request.rb

@@ -1,25 +1,31 @@
 # frozen_string_literal: true
-require_relative 'helper'
-require 'rubygems/request'
-require 'ostruct'
-require 'base64'
+
+require_relative "helper"
+require "rubygems/request"
+require "ostruct"
 
 unless Gem::HAVE_OPENSSL
-  warn 'Skipping Gem::Request tests.  openssl not found.'
+  warn "Skipping Gem::Request tests.  openssl not found."
 end
 
 class TestGemRequest < Gem::TestCase
-  CA_CERT_FILE     = cert_path 'ca'
-  CHILD_CERT       = load_cert 'child'
-  EXPIRED_CERT     = load_cert 'expired'
-  PUBLIC_CERT      = load_cert 'public'
-  PUBLIC_CERT_FILE = cert_path 'public'
-  SSL_CERT         = load_cert 'ssl'
+  CA_CERT_FILE     = cert_path "ca"
+  CHILD_CERT       = load_cert "child"
+  EXPIRED_CERT     = load_cert "expired"
+  PUBLIC_CERT      = load_cert "public"
+  PUBLIC_CERT_FILE = cert_path "public"
+  SSL_CERT         = load_cert "ssl"
 
   def make_request(uri, request_class, last_modified, proxy)
     Gem::Request.create_with_proxy uri, request_class, last_modified, proxy
   end
 
+  # This method is same code as Base64.encode64
+  # We should not use Base64.encode64 because we need to avoid gem activation.
+  def base64_encode64(bin)
+    [bin].pack("m")
+  end
+
   def setup
     @proxies = %w[http_proxy https_proxy HTTP_PROXY http_proxy_user HTTP_PROXY_USER http_proxy_pass HTTP_PROXY_PASS no_proxy NO_PROXY]
     @old_proxies = @proxies.map {|k| ENV[k] }
@@ -28,7 +34,7 @@ class TestGemRequest < Gem::TestCase
     super
 
     @proxy_uri = "http://localhost:1234"
-    @uri = URI('http://example')
+    @uri = URI("http://example")
 
     @request = make_request @uri, nil, nil, nil
   end
@@ -40,7 +46,7 @@ class TestGemRequest < Gem::TestCase
   end
 
   def test_initialize_proxy
-    proxy_uri = 'http://proxy.example.com'
+    proxy_uri = "http://proxy.example.com"
 
     request = make_request @uri, nil, nil, proxy_uri
 
@@ -48,7 +54,7 @@ class TestGemRequest < Gem::TestCase
   end
 
   def test_initialize_proxy_URI
-    proxy_uri = 'http://proxy.example.com'
+    proxy_uri = "http://proxy.example.com"
 
     request = make_request @uri, nil, nil, URI(proxy_uri)
 
@@ -56,22 +62,22 @@ class TestGemRequest < Gem::TestCase
   end
 
   def test_initialize_proxy_ENV
-    ENV['http_proxy'] = @proxy_uri
-    ENV['http_proxy_user'] = 'foo'
-    ENV['http_proxy_pass'] = 'bar'
+    ENV["http_proxy"] = @proxy_uri
+    ENV["http_proxy_user"] = "foo"
+    ENV["http_proxy_pass"] = "bar"
 
     request = make_request @uri, nil, nil, nil
 
     proxy = request.proxy_uri
 
-    assert_equal 'foo', proxy.user
-    assert_equal 'bar', proxy.password
+    assert_equal "foo", proxy.user
+    assert_equal "bar", proxy.password
   end
 
   def test_initialize_proxy_ENV_https
-    ENV['https_proxy'] = @proxy_uri
+    ENV["https_proxy"] = @proxy_uri
 
-    request = make_request URI('https://example'), nil, nil, nil
+    request = make_request URI("https://example"), nil, nil, nil
 
     proxy = request.proxy_uri
 
@@ -79,10 +85,10 @@ class TestGemRequest < Gem::TestCase
   end
 
   def test_proxy_ENV
-    ENV['http_proxy'] = "http://proxy"
-    ENV['https_proxy'] = ""
+    ENV["http_proxy"] = "http://proxy"
+    ENV["https_proxy"] = ""
 
-    request = make_request URI('https://example'), nil, nil, nil
+    request = make_request URI("https://example"), nil, nil, nil
 
     proxy = request.proxy_uri
 
@@ -90,13 +96,13 @@ class TestGemRequest < Gem::TestCase
   end
 
   def test_configure_connection_for_https
-    connection = Net::HTTP.new 'localhost', 443
+    connection = Net::HTTP.new "localhost", 443
 
     request = Class.new(Gem::Request) do
       def self.get_cert_files
         [TestGemRequest::PUBLIC_CERT_FILE]
       end
-    end.create_with_proxy URI('https://example'), nil, nil, nil
+    end.create_with_proxy URI("https://example"), nil, nil, nil
 
     Gem::Request.configure_connection_for_https connection, request.cert_files
 
@@ -109,13 +115,13 @@ class TestGemRequest < Gem::TestCase
     ssl_ca_cert, Gem.configuration.ssl_ca_cert =
       Gem.configuration.ssl_ca_cert, CA_CERT_FILE
 
-    connection = Net::HTTP.new 'localhost', 443
+    connection = Net::HTTP.new "localhost", 443
 
     request = Class.new(Gem::Request) do
       def self.get_cert_files
         [TestGemRequest::PUBLIC_CERT_FILE]
       end
-    end.create_with_proxy URI('https://example'), nil, nil, nil
+    end.create_with_proxy URI("https://example"), nil, nil, nil
 
     Gem::Request.configure_connection_for_https connection, request.cert_files
 
@@ -128,7 +134,7 @@ class TestGemRequest < Gem::TestCase
   end
 
   def test_get_proxy_from_env_fallback
-    ENV['http_proxy'] = @proxy_uri
+    ENV["http_proxy"] = @proxy_uri
     request = make_request @uri, nil, nil, nil
     proxy = request.proxy_uri
 
@@ -136,8 +142,8 @@ class TestGemRequest < Gem::TestCase
   end
 
   def test_get_proxy_from_env_https
-    ENV['https_proxy'] = @proxy_uri
-    uri = URI('https://example')
+    ENV["https_proxy"] = @proxy_uri
+    uri = URI("https://example")
     request = make_request uri, nil, nil, nil
 
     proxy = request.proxy_uri
@@ -146,39 +152,39 @@ class TestGemRequest < Gem::TestCase
   end
 
   def test_get_proxy_from_env_domain
-    ENV['http_proxy'] = @proxy_uri
-    ENV['http_proxy_user'] = 'foo\user'
-    ENV['http_proxy_pass'] = 'my bar'
+    ENV["http_proxy"] = @proxy_uri
+    ENV["http_proxy_user"] = 'foo\user'
+    ENV["http_proxy_pass"] = "my bar"
     request = make_request @uri, nil, nil, nil
 
     proxy = request.proxy_uri
 
     assert_equal 'foo\user', Gem::UriFormatter.new(proxy.user).unescape
-    assert_equal 'my bar', Gem::UriFormatter.new(proxy.password).unescape
+    assert_equal "my bar", Gem::UriFormatter.new(proxy.password).unescape
   end
 
   def test_get_proxy_from_env_escape
-    ENV['http_proxy'] = @proxy_uri
-    ENV['http_proxy_user'] = 'foo@user'
-    ENV['http_proxy_pass'] = 'my@bar'
+    ENV["http_proxy"] = @proxy_uri
+    ENV["http_proxy_user"] = "foo@user"
+    ENV["http_proxy_pass"] = "my@bar"
     request = make_request @uri, nil, nil, nil
 
     proxy = request.proxy_uri
 
-    assert_equal 'foo%40user', proxy.user
-    assert_equal 'my%40bar',   proxy.password
+    assert_equal "foo%40user", proxy.user
+    assert_equal "my%40bar",   proxy.password
   end
 
   def test_get_proxy_from_env_normalize
-    ENV['HTTP_PROXY'] = 'fakeurl:12345'
+    ENV["HTTP_PROXY"] = "fakeurl:12345"
     request = make_request @uri, nil, nil, nil
 
-    assert_equal 'http://fakeurl:12345', request.proxy_uri.to_s
+    assert_equal "http://fakeurl:12345", request.proxy_uri.to_s
   end
 
   def test_get_proxy_from_env_empty
-    ENV['HTTP_PROXY'] = ''
-    ENV.delete 'http_proxy'
+    ENV["HTTP_PROXY"] = ""
+    ENV.delete "http_proxy"
     request = make_request @uri, nil, nil, nil
 
     assert_nil request.proxy_uri
@@ -207,8 +213,8 @@ class TestGemRequest < Gem::TestCase
       c
     end
 
-    auth_header = conn.payload['Authorization']
-    assert_equal "Basic #{Base64.encode64('user:pass')}".strip, auth_header
+    auth_header = conn.payload["Authorization"]
+    assert_equal "Basic #{base64_encode64('user:pass')}".strip, auth_header
     assert_includes @ui.output, "GET https://user:REDACTED@example.rubygems/specs.#{Gem.marshal_version}"
   end
 
@@ -224,8 +230,8 @@ class TestGemRequest < Gem::TestCase
       c
     end
 
-    auth_header = conn.payload['Authorization']
-    assert_equal "Basic #{Base64.encode64('user:{DEScede}pass')}".strip, auth_header
+    auth_header = conn.payload["Authorization"]
+    assert_equal "Basic #{base64_encode64('user:{DEScede}pass')}".strip, auth_header
     assert_includes @ui.output, "GET https://user:REDACTED@example.rubygems/specs.#{Gem.marshal_version}"
   end
 
@@ -241,36 +247,36 @@ class TestGemRequest < Gem::TestCase
       c
     end
 
-    auth_header = conn.payload['Authorization']
-    assert_equal "Basic #{Base64.encode64('{DEScede}pass:x-oauth-basic')}".strip, auth_header
+    auth_header = conn.payload["Authorization"]
+    assert_equal "Basic #{base64_encode64('{DEScede}pass:x-oauth-basic')}".strip, auth_header
     assert_includes @ui.output, "GET https://REDACTED:x-oauth-basic@example.rubygems/specs.#{Gem.marshal_version}"
   end
 
   def test_fetch_head
     uri = Gem::Uri.new(URI.parse "#{@gem_repo}/specs.#{Gem.marshal_version}")
-    response = util_stub_net_http(:body => '', :code => 200) do |conn|
+    response = util_stub_net_http(:body => "", :code => 200) do |conn|
       @request = make_request(uri, Net::HTTP::Get, nil, nil)
       @request.fetch
     end
 
     assert_equal 200, response.code
-    assert_equal '', response.body
+    assert_equal "", response.body
   end
 
   def test_fetch_unmodified
     uri = Gem::Uri.new(URI.parse "#{@gem_repo}/specs.#{Gem.marshal_version}")
     t = Time.utc(2013, 1, 2, 3, 4, 5)
-    conn, response = util_stub_net_http(:body => '', :code => 304) do |c|
+    conn, response = util_stub_net_http(:body => "", :code => 304) do |c|
       @request = make_request(uri, Net::HTTP::Get, t, nil)
       [c, @request.fetch]
     end
 
     assert_equal 304, response.code
-    assert_equal '', response.body
+    assert_equal "", response.body
 
-    modified_header = conn.payload['if-modified-since']
+    modified_header = conn.payload["if-modified-since"]
 
-    assert_equal 'Wed, 02 Jan 2013 03:04:05 GMT', modified_header
+    assert_equal "Wed, 02 Jan 2013 03:04:05 GMT", modified_header
   end
 
   def test_user_agent
@@ -287,7 +293,7 @@ class TestGemRequest < Gem::TestCase
     util_save_version
 
     Object.send :remove_const, :RUBY_ENGINE
-    Object.send :const_set,    :RUBY_ENGINE, 'vroom'
+    Object.send :const_set,    :RUBY_ENGINE, "vroom"
 
     ua = make_request(@uri, nil, nil, nil).user_agent
 
@@ -300,7 +306,7 @@ class TestGemRequest < Gem::TestCase
     util_save_version
 
     Object.send :remove_const, :RUBY_ENGINE
-    Object.send :const_set,    :RUBY_ENGINE, 'ruby'
+    Object.send :const_set,    :RUBY_ENGINE, "ruby"
 
     ua = make_request(@uri, nil, nil, nil).user_agent
 

data/test/rubygems/test_gem_request_connection_pools.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
-require_relative 'helper'
-require 'rubygems/request'
-require 'timeout'
+
+require_relative "helper"
+require "rubygems/request"
+require "timeout"
 
 class TestGemRequestConnectionPool < Gem::TestCase
   class FakeHttp
@@ -17,7 +18,7 @@ class TestGemRequestConnectionPool < Gem::TestCase
     @old_client = Gem::Request::ConnectionPools.client
     Gem::Request::ConnectionPools.client = FakeHttp
 
-    @proxy = URI 'http://proxy.example'
+    @proxy = URI "http://proxy.example"
   end
 
   def teardown
@@ -32,9 +33,9 @@ class TestGemRequestConnectionPool < Gem::TestCase
       ems.example
     ]
 
-    no_proxy = pools.send :no_proxy?, 'rubygems.example', env_no_proxy
+    no_proxy = pools.send :no_proxy?, "rubygems.example", env_no_proxy
 
-    refute no_proxy, 'mismatch'
+    refute no_proxy, "mismatch"
   end
 
   def test_to_proxy_empty_string
@@ -42,13 +43,13 @@ class TestGemRequestConnectionPool < Gem::TestCase
 
     env_no_proxy = [""]
 
-    no_proxy = pools.send :no_proxy?, 'ems.example', env_no_proxy
+    no_proxy = pools.send :no_proxy?, "ems.example", env_no_proxy
 
-    refute no_proxy, 'mismatch'
+    refute no_proxy, "mismatch"
   end
 
   def test_checkout_same_connection
-    uri = URI.parse('http://example/some_endpoint')
+    uri = URI.parse("http://example/some_endpoint")
 
     pools = Gem::Request::ConnectionPools.new nil, []
     pool = pools.pool_for uri
@@ -66,13 +67,13 @@ class TestGemRequestConnectionPool < Gem::TestCase
       2.no-proxy.example
     ]
 
-    no_proxy = pools.send :no_proxy?, '2.no-proxy.example', env_no_proxy
+    no_proxy = pools.send :no_proxy?, "2.no-proxy.example", env_no_proxy
 
-    assert no_proxy, 'match'
+    assert no_proxy, "match"
 
-    no_proxy = pools.send :no_proxy?, 'proxy.example', env_no_proxy
+    no_proxy = pools.send :no_proxy?, "proxy.example", env_no_proxy
 
-    refute no_proxy, 'mismatch'
+    refute no_proxy, "mismatch"
   end
 
   def test_to_proxy_eh_wildcard
@@ -82,31 +83,31 @@ class TestGemRequestConnectionPool < Gem::TestCase
       .no-proxy.example
     ]
 
-    no_proxy = pools.send :no_proxy?, '2.no-proxy.example', env_no_proxy
+    no_proxy = pools.send :no_proxy?, "2.no-proxy.example", env_no_proxy
 
-    assert no_proxy, 'wildcard matching subdomain'
+    assert no_proxy, "wildcard matching subdomain"
 
-    no_proxy = pools.send :no_proxy?, 'no-proxy.example', env_no_proxy
+    no_proxy = pools.send :no_proxy?, "no-proxy.example", env_no_proxy
 
-    assert no_proxy, 'wildcard matching dotless domain'
+    assert no_proxy, "wildcard matching dotless domain"
 
-    no_proxy = pools.send :no_proxy?, 'proxy.example', env_no_proxy
+    no_proxy = pools.send :no_proxy?, "proxy.example", env_no_proxy
 
-    refute no_proxy, 'wildcard mismatch'
+    refute no_proxy, "wildcard mismatch"
   end
 
   def test_net_http_args
     pools = Gem::Request::ConnectionPools.new nil, []
 
-    net_http_args = pools.send :net_http_args, URI('http://example'), nil
+    net_http_args = pools.send :net_http_args, URI("http://example"), nil
 
-    assert_equal ['example', 80], net_http_args
+    assert_equal ["example", 80], net_http_args
   end
 
   def test_net_http_args_ipv6
     pools = Gem::Request::ConnectionPools.new nil, []
 
-    net_http_args = pools.send :net_http_args, URI('http://[::1]'), nil
+    net_http_args = pools.send :net_http_args, URI("http://[::1]"), nil
 
     assert_equal ["::1", 80], net_http_args
   end
@@ -114,26 +115,26 @@ class TestGemRequestConnectionPool < Gem::TestCase
   def test_net_http_args_proxy
     pools = Gem::Request::ConnectionPools.new nil, []
 
-    net_http_args = pools.send :net_http_args, URI('http://example'), @proxy
+    net_http_args = pools.send :net_http_args, URI("http://example"), @proxy
 
-    assert_equal ['example', 80, 'proxy.example', 80, nil, nil], net_http_args
+    assert_equal ["example", 80, "proxy.example", 80, nil, nil], net_http_args
   end
 
   def test_net_http_args_no_proxy
-    orig_no_proxy, ENV['no_proxy'] = ENV['no_proxy'], 'example'
+    orig_no_proxy, ENV["no_proxy"] = ENV["no_proxy"], "example"
 
     pools = Gem::Request::ConnectionPools.new nil, []
 
-    net_http_args = pools.send :net_http_args, URI('http://example'), @proxy
+    net_http_args = pools.send :net_http_args, URI("http://example"), @proxy
 
-    assert_equal ['example', 80, nil, nil], net_http_args
+    assert_equal ["example", 80, nil, nil], net_http_args
 
   ensure
-    ENV['no_proxy'] = orig_no_proxy
+    ENV["no_proxy"] = orig_no_proxy
   end
 
   def test_thread_waits_for_connection
-    uri = URI.parse('http://example/some_endpoint')
+    uri = URI.parse("http://example/some_endpoint")
     pools = Gem::Request::ConnectionPools.new nil, []
     pool  = pools.pool_for uri