rubygems-update 3.2.30 → 3.4.10

data/test/rubygems/test_gem_update_suggestion.rb

@@ -0,0 +1,208 @@
+# frozen_string_literal: true
+require_relative "helper"
+require "rubygems/command"
+require "rubygems/update_suggestion"
+
+class TestUpdateSuggestion < Gem::TestCase
+  def setup
+    super
+
+    @cmd = Gem::Command.new "dummy", "dummy"
+    @cmd.extend Gem::UpdateSuggestion
+    @start_time = 1_000_000
+    @minute = 60 * 60
+    @week = 7 * 24 * @minute
+  end
+
+  def with_eglible_environment(**params)
+    self.class.with_eglible_environment(**params) do
+      yield
+    end
+  end
+
+  def self.with_eglible_environment(
+    tty: true,
+    rubygems_version: Gem::Version.new("1.2.3"),
+    latest_rubygems_version: Gem::Version.new("2.0.0"),
+    ci: false,
+    reset_last_update_check: true,
+    cmd:
+  )
+    original_config, Gem.configuration[:prevent_update_suggestion] = Gem.configuration[:prevent_update_suggestion], nil
+    original_env, ENV["RUBYGEMS_PREVENT_UPDATE_SUGGESTION"] = ENV["RUBYGEMS_PREVENT_UPDATE_SUGGESTION"], nil
+    original_disable, Gem.disable_system_update_message = Gem.disable_system_update_message, nil
+    Gem.configuration.last_update_check = 0 if reset_last_update_check
+
+    Gem.ui.stub :tty?, tty do
+      Gem.stub :rubygems_version, rubygems_version do
+        Gem.stub :latest_rubygems_version, latest_rubygems_version do
+          cmd.stub :ci?, ci do
+            yield
+          end
+        end
+      end
+    end
+  ensure
+    Gem.configuration[:prevent_update_suggestion] = original_config
+    ENV["RUBYGEMS_PREVENT_UPDATE_SUGGESTION"] = original_env
+    Gem.disable_system_update_message = original_disable
+  end
+
+  def test_update_suggestion
+    Gem.stub :rubygems_version, Gem::Version.new("1.2.3") do
+      Gem.stub :latest_rubygems_version, Gem::Version.new("2.0.0") do
+        assert_equal @cmd.update_suggestion, <<~SUGGESTION
+
+          A new release of RubyGems is available: 1.2.3 → 2.0.0!
+          Run `gem update --system 2.0.0` to update your installation.
+
+        SUGGESTION
+      end
+    end
+  end
+
+  def test_eglible_for_update
+    with_eglible_environment(cmd: @cmd) do
+      Time.stub :now, 123456789 do
+        assert @cmd.eglible_for_update?
+        assert_equal Gem.configuration.last_update_check, 123456789
+
+        # test last check is written to config file
+        assert File.read(Gem.configuration.state_file_name).match("123456789")
+      end
+    end
+  end
+
+  def test_eglible_for_update_is_not_annoying_when_new_version_is_released
+    current_version = Gem::Version.new("1.2.0")
+    latest_version = current_version
+
+    # checking for first time, it is not eglible since new version
+    # is not released yet and stored
+    with_eglible_environment(cmd: @cmd, rubygems_version: current_version, latest_rubygems_version: latest_version) do
+      Time.stub :now, @start_time do
+        refute @cmd.eglible_for_update?
+        assert_equal Gem.configuration.last_update_check, @start_time
+      end
+    end
+
+    # checking next week, it is not eglible since new version
+    # is not released yet and timestamp is stored
+    with_eglible_environment(
+      cmd: @cmd,
+      rubygems_version: current_version,
+      latest_rubygems_version: latest_version,
+      reset_last_update_check: false
+    ) do
+      Time.stub :now, @start_time + @week do
+        refute @cmd.eglible_for_update?
+        assert_equal Gem.configuration.last_update_check, @start_time + @week
+      end
+    end
+
+    # pretend new version is released
+    latest_version = Gem::Version.new("1.3.0")
+
+    # checking later same next week, it is not eglible even new version
+    # is released and timestamp is not stored
+    with_eglible_environment(
+      cmd: @cmd,
+      rubygems_version: current_version,
+      latest_rubygems_version: latest_version,
+      reset_last_update_check: false
+    ) do
+      Time.stub :now, @start_time + @week + @minute do
+        refute @cmd.eglible_for_update?
+        assert_equal Gem.configuration.last_update_check, @start_time + @week
+      end
+    end
+  end
+
+  def test_eglible_for_update_is_not_annoying_when_not_upgraded
+    with_eglible_environment(cmd: @cmd) do
+      # checking for first time, it is eglible and stored
+      Time.stub :now, @start_time do
+        assert @cmd.eglible_for_update?
+        assert_equal Gem.configuration.last_update_check, @start_time
+      end
+
+      # checking minute later is not eglible and not stored
+      Time.stub :now, @start_time + @minute do
+        refute @cmd.eglible_for_update?
+        assert_equal Gem.configuration.last_update_check, @start_time
+      end
+
+      # checking week later is eglible again and stored
+      Time.stub :now, @start_time + @week do
+        assert @cmd.eglible_for_update?
+        assert_equal Gem.configuration.last_update_check, @start_time + @week
+      end
+    end
+  end
+
+  def test_eglible_for_update_prevent_config
+    with_eglible_environment(cmd: @cmd) do
+      begin
+        original_config, Gem.configuration[:prevent_update_suggestion] = Gem.configuration[:prevent_update_suggestion], true
+        refute @cmd.eglible_for_update?
+      ensure
+        Gem.configuration[:prevent_update_suggestion] = original_config
+      end
+    end
+  end
+
+  def test_eglible_for_update_prevent_env
+    with_eglible_environment(cmd: @cmd) do
+      begin
+        original_env, ENV["RUBYGEMS_PREVENT_UPDATE_SUGGESTION"] = ENV["RUBYGEMS_PREVENT_UPDATE_SUGGESTION"], "yes"
+        refute @cmd.eglible_for_update?
+      ensure
+        ENV["RUBYGEMS_PREVENT_UPDATE_SUGGESTION"] = original_env
+      end
+    end
+  end
+
+  def test_eglible_for_update_non_tty
+    with_eglible_environment(tty: false, cmd: @cmd) do
+      refute @cmd.eglible_for_update?
+    end
+  end
+
+  def test_eglible_for_update_for_prerelease
+    with_eglible_environment(rubygems_version: Gem::Version.new("1.0.0-rc1"), cmd: @cmd) do
+      refute @cmd.eglible_for_update?
+    end
+  end
+
+  def test_eglible_for_update_disabled_update
+    with_eglible_environment(cmd: @cmd) do
+      begin
+        original_disable, Gem.disable_system_update_message = Gem.disable_system_update_message, "disabled"
+        refute @cmd.eglible_for_update?
+      ensure
+        Gem.disable_system_update_message = original_disable
+      end
+    end
+  end
+
+  def test_eglible_for_update_on_ci
+    with_eglible_environment(ci: true, cmd: @cmd) do
+      refute @cmd.eglible_for_update?
+    end
+  end
+
+  def test_eglible_for_update_unwrittable_config
+    with_eglible_environment(cmd: @cmd) do
+      Gem.configuration.stub :state_file_writable?, false do
+        refute @cmd.eglible_for_update?
+      end
+    end
+  end
+
+  def test_eglible_for_update_notification_delay
+    with_eglible_environment(cmd: @cmd) do
+      Gem.configuration.last_update_check = Time.now.to_i
+      refute @cmd.eglible_for_update?
+    end
+  end
+end

data/test/rubygems/test_gem_uri.rb

@@ -1,5 +1,5 @@
-require_relative 'helper'
-require 'rubygems/uri'
+require_relative "helper"
+require "rubygems/uri"
 
 class TestUri < Gem::TestCase
   def test_to_s_not_string
@@ -31,9 +31,9 @@ class TestUri < Gem::TestCase
   end
 
   def test_redacted_does_not_modify_uri
-    url = 'https://user:password@example.com'
+    url = "https://user:password@example.com"
     uri = Gem::Uri.new(url)
-    assert_equal 'https://user:REDACTED@example.com', uri.redacted.to_s
+    assert_equal "https://user:REDACTED@example.com", uri.redacted.to_s
     assert_equal url, uri.to_s
   end
 end

data/test/rubygems/test_gem_uri_formatter.rb

@@ -1,26 +1,26 @@
 # frozen_string_literal: true
-require_relative 'helper'
-require 'rubygems/uri_formatter'
+require_relative "helper"
+require "rubygems/uri_formatter"
 
 class TestGemUriFormatter < Gem::TestCase
   def test_normalize_uri
-    assert_equal 'FILE://example/',
-      Gem::UriFormatter.new('FILE://example/').normalize
-    assert_equal 'FTP://example/',
-      Gem::UriFormatter.new('FTP://example/').normalize
-    assert_equal 'HTTP://example/',
-      Gem::UriFormatter.new('HTTP://example/').normalize
-    assert_equal 'HTTPS://example/',
-      Gem::UriFormatter.new('HTTPS://example/').normalize
-    assert_equal 'http://example/',
-      Gem::UriFormatter.new('example/').normalize
+    assert_equal "FILE://example/",
+      Gem::UriFormatter.new("FILE://example/").normalize
+    assert_equal "FTP://example/",
+      Gem::UriFormatter.new("FTP://example/").normalize
+    assert_equal "HTTP://example/",
+      Gem::UriFormatter.new("HTTP://example/").normalize
+    assert_equal "HTTPS://example/",
+      Gem::UriFormatter.new("HTTPS://example/").normalize
+    assert_equal "http://example/",
+      Gem::UriFormatter.new("example/").normalize
   end
 
   def test_escape
-    assert_equal 'a%40b%5Cc', Gem::UriFormatter.new('a@b\c').escape
+    assert_equal "a%40b%5Cc", Gem::UriFormatter.new('a@b\c').escape
   end
 
   def test_unescape
-    assert_equal 'a@b\c', Gem::UriFormatter.new('a%40b%5Cc').unescape
+    assert_equal 'a@b\c', Gem::UriFormatter.new("a%40b%5Cc").unescape
   end
 end

data/test/rubygems/test_gem_util.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
-require_relative 'helper'
-require 'rubygems/util'
+require_relative "helper"
+require "rubygems/util"
 
 class TestGemUtil < Gem::TestCase
   def test_class_popen
     pend "popen with a block does not behave well on jruby" if Gem.java_platform?
-    assert_equal "0\n", Gem::Util.popen(*ruby_with_rubygems_in_load_path, '-e', 'p 0')
+    assert_equal "0\n", Gem::Util.popen(*ruby_with_rubygems_in_load_path, "-e", "p 0")
 
     assert_raise Errno::ECHILD do
       Process.wait(-1)
@@ -16,7 +16,7 @@ class TestGemUtil < Gem::TestCase
     pend if Gem.java_platform?
     Gem::Deprecate.skip_during do
       out, err = capture_output do
-        Gem::Util.silent_system(*ruby_with_rubygems_in_load_path, '-e', 'puts "hello"; warn "hello"')
+        Gem::Util.silent_system(*ruby_with_rubygems_in_load_path, "-e", 'puts "hello"; warn "hello"')
       end
       assert_empty out
       assert_empty err
@@ -24,35 +24,35 @@ class TestGemUtil < Gem::TestCase
   end
 
   def test_traverse_parents
-    FileUtils.mkdir_p 'a/b/c'
+    FileUtils.mkdir_p "a/b/c"
 
-    enum = Gem::Util.traverse_parents 'a/b/c'
+    enum = Gem::Util.traverse_parents "a/b/c"
 
-    assert_equal File.join(@tempdir, 'a/b/c'), enum.next
-    assert_equal File.join(@tempdir, 'a/b'),   enum.next
-    assert_equal File.join(@tempdir, 'a'),     enum.next
+    assert_equal File.join(@tempdir, "a/b/c"), enum.next
+    assert_equal File.join(@tempdir, "a/b"),   enum.next
+    assert_equal File.join(@tempdir, "a"),     enum.next
     loop { break if enum.next.nil? } # exhaust the enumerator
   end
 
   def test_traverse_parents_does_not_crash_on_permissions_error
-    pend 'skipped on MS Windows (chmod has no effect)' if win_platform? || java_platform?
+    pend "skipped on MS Windows (chmod has no effect)" if win_platform? || java_platform?
 
-    FileUtils.mkdir_p 'd/e/f'
+    FileUtils.mkdir_p "d/e/f"
     # remove 'execute' permission from "e" directory and make it
     # impossible to cd into it and its children
-    FileUtils.chmod(0666, 'd/e')
+    FileUtils.chmod(0666, "d/e")
 
-    pend 'skipped in root privilege' if Process.uid.zero?
+    pend "skipped in root privilege" if Process.uid.zero?
 
-    paths = Gem::Util.traverse_parents('d/e/f').to_a
+    paths = Gem::Util.traverse_parents("d/e/f").to_a
 
-    assert_equal File.join(@tempdir, 'd'), paths[0]
+    assert_equal File.join(@tempdir, "d"), paths[0]
     assert_equal @tempdir, paths[1]
     assert_equal File.realpath("..", @tempdir), paths[2]
     assert_equal File.realpath("../..", @tempdir), paths[3]
   ensure
     # restore default permissions, allow the directory to be removed
-    FileUtils.chmod(0775, 'd/e') unless win_platform? || java_platform?
+    FileUtils.chmod(0775, "d/e") unless win_platform? || java_platform?
   end
 
   def test_linked_list_find
@@ -64,19 +64,19 @@ class TestGemUtil < Gem::TestCase
   end
 
   def test_glob_files_in_dir
-    FileUtils.mkdir_p 'g'
-    FileUtils.touch File.join('g', 'h.rb')
-    FileUtils.touch File.join('g', 'i.rb')
+    FileUtils.mkdir_p "g"
+    FileUtils.touch File.join("g", "h.rb")
+    FileUtils.touch File.join("g", "i.rb")
 
     expected_paths = [
-      File.join(@tempdir, 'g/h.rb'),
-      File.join(@tempdir, 'g/i.rb'),
+      File.join(@tempdir, "g/h.rb"),
+      File.join(@tempdir, "g/i.rb"),
     ]
 
-    files_with_absolute_base = Gem::Util.glob_files_in_dir('*.rb', File.join(@tempdir, 'g'))
+    files_with_absolute_base = Gem::Util.glob_files_in_dir("*.rb", File.join(@tempdir, "g"))
     assert_equal expected_paths.sort, files_with_absolute_base.sort
 
-    files_with_relative_base = Gem::Util.glob_files_in_dir('*.rb', 'g')
+    files_with_relative_base = Gem::Util.glob_files_in_dir("*.rb", "g")
     assert_equal expected_paths.sort, files_with_relative_base.sort
   end
 

data/test/rubygems/test_gem_validator.rb

@@ -11,21 +11,21 @@ class TestGemValidator < Gem::TestCase
   end
 
   def test_alien
-    @spec = quick_gem 'a' do |s|
+    @spec = quick_gem "a" do |s|
       s.files = %w[lib/a.rb lib/b.rb]
     end
 
     util_build_gem @spec
 
-    FileUtils.rm    File.join(@spec.gem_dir, 'lib/b.rb')
-    FileUtils.touch File.join(@spec.gem_dir, 'lib/c.rb')
+    FileUtils.rm    File.join(@spec.gem_dir, "lib/b.rb")
+    FileUtils.touch File.join(@spec.gem_dir, "lib/c.rb")
 
-    alien = @validator.alien 'a'
+    alien = @validator.alien "a"
 
     expected = {
       @spec.file_name => [
-        Gem::Validator::ErrorData.new('lib/b.rb', 'Missing file'),
-        Gem::Validator::ErrorData.new('lib/c.rb', 'Extra file'),
+        Gem::Validator::ErrorData.new("lib/b.rb", "Missing file"),
+        Gem::Validator::ErrorData.new("lib/c.rb", "Extra file"),
       ],
     }
 
@@ -33,9 +33,9 @@ class TestGemValidator < Gem::TestCase
   end
 
   def test_alien_default
-    new_default_spec 'c', 1, nil, 'lib/c.rb'
+    new_default_spec "c", 1, nil, "lib/c.rb"
 
-    alien = @validator.alien 'c'
+    alien = @validator.alien "c"
 
     assert_empty alien
   end

data/test/rubygems/test_gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-require_relative 'helper'
+require_relative "helper"
 require "rubygems/version"
 
 class TestGemVersion < Gem::TestCase
@@ -32,12 +32,19 @@ class TestGemVersion < Gem::TestCase
   def test_class_create
     real = Gem::Version.new(1.0)
 
-    assert_same  real, Gem::Version.create(real)
-    assert_nil   Gem::Version.create(nil)
+    assert_same real, Gem::Version.create(real)
+
+    expected = "nil versions are discouraged and will be deprecated in Rubygems 4\n"
+    actual_stdout, actual_stderr = capture_output do
+      assert_nil Gem::Version.create(nil)
+    end
+    assert_empty actual_stdout
+    assert_equal(expected, actual_stderr)
+
     assert_equal v("5.1"), Gem::Version.create("5.1")
 
-    ver = '1.1'.freeze
-    assert_equal v('1.1'), Gem::Version.create(ver)
+    ver = "1.1"
+    assert_equal v("1.1"), Gem::Version.create(ver)
   end
 
   def test_class_correct
@@ -53,8 +60,8 @@ class TestGemVersion < Gem::TestCase
   end
 
   def test_class_new_subclass
-    v1 = Gem::Version.new '1'
-    v2 = V.new '1'
+    v1 = Gem::Version.new "1"
+    v2 = V.new "1"
 
     refute_same v1, v2
   end
@@ -81,7 +88,7 @@ class TestGemVersion < Gem::TestCase
   end
 
   def test_initialize
-    ["1.0", "1.0 ", " 1.0 ", "1.0\n", "\n1.0\n", "1.0".freeze].each do |good|
+    ["1.0", "1.0 ", " 1.0 ", "1.0\n", "\n1.0\n", "1.0"].each do |good|
       assert_version_equal "1.0", good
     end
 
@@ -120,10 +127,10 @@ class TestGemVersion < Gem::TestCase
     assert_prerelease "22.1.50.0.d"
     assert_prerelease "1.2.d.42"
 
-    assert_prerelease '1.A'
+    assert_prerelease "1.A"
 
-    assert_prerelease '1-1'
-    assert_prerelease '1-a'
+    assert_prerelease "1-1"
+    assert_prerelease "1-a"
 
     refute_prerelease "1.2.0"
     refute_prerelease "2.9"
@@ -154,6 +161,10 @@ class TestGemVersion < Gem::TestCase
     assert_equal(-1, v("5.a") <=> v("5.0.0.rc2"))
     assert_equal(1, v("5.x") <=> v("5.0.0.rc2"))
 
+    assert_equal(0, v("1.9.3")  <=> "1.9.3")
+    assert_equal(1, v("1.9.3")  <=> "1.9.2.99")
+    assert_equal(-1, v("1.9.3") <=> "1.9.3.1")
+
     assert_nil v("1.0") <=> "whatever"
   end
 
@@ -195,7 +206,7 @@ class TestGemVersion < Gem::TestCase
 
   # modifying the segments of a version should not affect the segments of the cached version object
   def test_segments
-    v('9.8.7').segments[2] += 1
+    v("9.8.7").segments[2] += 1
 
     refute_version_equal "9.8.8", "9.8.7"
     assert_equal         [9,8,7], v("9.8.7").segments
@@ -208,10 +219,10 @@ class TestGemVersion < Gem::TestCase
   end
 
   def test_frozen_version
-    v = v('1.freeze.test').freeze
-    assert_less_than v, v('1')
-    assert_version_equal v('1'), v.release
-    assert_version_equal v('2'), v.bump
+    v = v("1.freeze.test").freeze
+    assert_less_than v, v("1")
+    assert_version_equal v("1"), v.release
+    assert_version_equal v("2"), v.bump
   end
 
   # Asserts that +version+ is a prerelease.

data/test/rubygems/test_gem_version_option.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
-require_relative 'helper'
-require 'rubygems/command'
-require 'rubygems/version_option'
+require_relative "helper"
+require "rubygems/command"
+require "rubygems/version_option"
 
 class TestGemVersionOption < Gem::TestCase
   def setup
     super
 
-    @cmd = Gem::Command.new 'dummy', 'dummy'
+    @cmd = Gem::Command.new "dummy", "dummy"
     @cmd.extend Gem::VersionOption
   end
 
@@ -43,8 +43,8 @@ class TestGemVersionOption < Gem::TestCase
 
     expected = [
       Gem::Platform::RUBY,
-      Gem::Platform.new('x86-freebsd6'),
-      Gem::Platform.new('x86-freebsd7'),
+      Gem::Platform.new("x86-freebsd6"),
+      Gem::Platform.new("x86-freebsd7"),
     ]
 
     assert_equal expected, Gem.platforms
@@ -69,7 +69,7 @@ class TestGemVersionOption < Gem::TestCase
 
     expected = [
       Gem::Platform::RUBY,
-      Gem::Platform.new('x86-freebsd6'),
+      Gem::Platform.new("x86-freebsd6"),
     ]
 
     assert_equal expected, Gem.platforms
@@ -84,7 +84,7 @@ class TestGemVersionOption < Gem::TestCase
       :args => [],
       :explicit_prerelease => false,
       :prerelease => false,
-      :version => Gem::Requirement.new('> 1'),
+      :version => Gem::Requirement.new("> 1"),
     }
 
     assert_equal expected, @cmd.options
@@ -93,13 +93,13 @@ class TestGemVersionOption < Gem::TestCase
   def test_version_option_compound
     @cmd.add_version_option
 
-    @cmd.handle_options ['--version', '< 1, > 0.9']
+    @cmd.handle_options ["--version", "< 1, > 0.9"]
 
     expected = {
       :args => [],
       :explicit_prerelease => false,
       :prerelease => false,
-      :version => Gem::Requirement.new('< 1', '> 0.9'),
+      :version => Gem::Requirement.new("< 1", "> 0.9"),
     }
 
     assert_equal expected, @cmd.options
@@ -108,13 +108,13 @@ class TestGemVersionOption < Gem::TestCase
   def test_multiple_version_operator_option_compound
     @cmd.add_version_option
 
-    @cmd.handle_options ['--version', '< 1', '--version', '> 0.9']
+    @cmd.handle_options ["--version", "< 1", "--version", "> 0.9"]
 
     expected = {
       :args => [],
       :explicit_prerelease => false,
       :prerelease => false,
-      :version => Gem::Requirement.new('< 1', '> 0.9'),
+      :version => Gem::Requirement.new("< 1", "> 0.9"),
     }
 
     assert_equal expected, @cmd.options
@@ -130,7 +130,7 @@ class TestGemVersionOption < Gem::TestCase
       :args => [],
       :explicit_prerelease => true,
       :prerelease => true,
-      :version => Gem::Requirement.new('> 1'),
+      :version => Gem::Requirement.new("> 1"),
     }
 
     assert_equal expected, @cmd.options
@@ -145,7 +145,7 @@ class TestGemVersionOption < Gem::TestCase
       :args => [],
       :explicit_prerelease => false,
       :prerelease => true,
-      :version => Gem::Requirement.new('> 1.a'),
+      :version => Gem::Requirement.new("> 1.a"),
     }
 
     assert_equal expected, @cmd.options
@@ -156,7 +156,7 @@ class TestGemVersionOption < Gem::TestCase
       :args => [],
       :explicit_prerelease => false,
       :prerelease => false,
-      :version => Gem::Requirement.new('> 1'),
+      :version => Gem::Requirement.new("> 1"),
     }
 
     assert_equal expected, @cmd.options