rubygems-update 3.0.6 → 3.2.14

data/lib/rubygems/specification_policy.rb

@@ -1,12 +1,13 @@
-require 'delegate'
-require 'uri'
+require 'rubygems/user_interaction'
+
+class Gem::SpecificationPolicy
+  include Gem::UserInteraction
 
-class Gem::SpecificationPolicy < SimpleDelegator
   VALID_NAME_PATTERN = /\A[a-zA-Z0-9\.\-\_]+\z/.freeze # :nodoc:
 
   SPECIAL_CHARACTERS = /\A[#{Regexp.escape('.-_')}]+/.freeze # :nodoc:
 
-  VALID_URI_PATTERN = %r{\Ahttps?:\/\/([^\s:@]+:[^\s:@]*@)?[A-Za-z\d\-]+(\.[A-Za-z\d\-]+)+\.?(:\d{1,5})?([\/?]\S*)?\z}.freeze  # :nodoc:
+  VALID_URI_PATTERN = %r{\Ahttps?:\/\/([^\s:@]+:[^\s:@]*@)?[A-Za-z\d\-]+(\.[A-Za-z\d\-]+)+\.?(:\d{1,5})?([\/?]\S*)?\z}.freeze # :nodoc:
 
   METADATA_LINK_KEYS = %w[
     bug_tracker_uri
@@ -16,12 +17,13 @@ class Gem::SpecificationPolicy < SimpleDelegator
     mailing_list_uri
     source_code_uri
     wiki_uri
+    funding_uri
   ].freeze # :nodoc:
 
   def initialize(specification)
     @warnings = 0
 
-    super(specification)
+    @specification = specification
   end
 
   ##
@@ -30,13 +32,32 @@ class Gem::SpecificationPolicy < SimpleDelegator
   attr_accessor :packaging
 
   ##
-  # Checks that the specification contains all required fields, and does a
-  # very basic sanity check.
+  # Does a sanity check on the specification.
   #
   # Raises InvalidSpecificationException if the spec does not pass the
   # checks.
+  #
+  # It also performs some validations that do not raise but print warning
+  # messages instead.
 
   def validate(strict = false)
+    validate_required!
+
+    validate_optional(strict) if packaging || strict
+
+    true
+  end
+
+  ##
+  # Does a sanity check on the specification.
+  #
+  # Raises InvalidSpecificationException if the spec does not pass the
+  # checks.
+  #
+  # Only runs checks that are considered necessary for the specification to be
+  # functional.
+
+  def validate_required!
     validate_nil_attributes
 
     validate_rubygems_version
@@ -47,7 +68,7 @@ class Gem::SpecificationPolicy < SimpleDelegator
 
     validate_require_paths
 
-    keep_only_files_and_directories
+    @specification.keep_only_files_and_directories
 
     validate_non_files
 
@@ -63,16 +84,26 @@ class Gem::SpecificationPolicy < SimpleDelegator
 
     validate_metadata
 
+    validate_licenses_length
+
+    validate_lazy_metadata
+
+    validate_duplicate_dependencies
+  end
+
+  def validate_optional(strict)
     validate_licenses
 
     validate_permissions
 
-    validate_lazy_metadata
-
     validate_values
 
     validate_dependencies
 
+    validate_extensions
+
+    validate_removed_attributes
+
     if @warnings > 0
       if strict
         error "specification has warnings"
@@ -80,14 +111,14 @@ class Gem::SpecificationPolicy < SimpleDelegator
         alert_warning help_text
       end
     end
-
-    true
   end
 
   ##
   # Implementation for Specification#validate_metadata
 
   def validate_metadata
+    metadata = @specification.metadata
+
     unless Hash === metadata
       error 'metadata must be a hash'
     end
@@ -118,15 +149,14 @@ class Gem::SpecificationPolicy < SimpleDelegator
   end
 
   ##
-  # Implementation for Specification#validate_dependencies
+  # Checks that no duplicate dependencies are specified.
 
-  def validate_dependencies # :nodoc:
+  def validate_duplicate_dependencies # :nodoc:
     # NOTE: see REFACTOR note in Gem::Dependency about types - this might be brittle
-    seen = Gem::Dependency::TYPES.inject({}) { |types, type| types.merge({ type => {}}) }
+    seen = Gem::Dependency::TYPES.inject({}) {|types, type| types.merge({ type => {}}) }
 
     error_messages = []
-    warning_messages = []
-    dependencies.each do |dep|
+    @specification.dependencies.each do |dep|
       if prev = seen[dep.type][dep.name]
         error_messages << <<-MESSAGE
 duplicate dependency on #{dep}, (#{prev.requirement}) use:
@@ -135,13 +165,26 @@ duplicate dependency on #{dep}, (#{prev.requirement}) use:
       end
 
       seen[dep.type][dep.name] = dep
+    end
+    if error_messages.any?
+      error error_messages.join
+    end
+  end
+
+  ##
+  # Checks that dependencies use requirements as we recommend.  Warnings are
+  # issued when dependencies are open-ended or overly strict for semantic
+  # versioning.
 
+  def validate_dependencies # :nodoc:
+    warning_messages = []
+    @specification.dependencies.each do |dep|
       prerelease_dep = dep.requirements_list.any? do |req|
         Gem::Requirement.new(req).prerelease?
       end
 
       warning_messages << "prerelease dependency on #{dep} is not recommended" if
-          prerelease_dep && !version.prerelease?
+          prerelease_dep && !@specification.version.prerelease?
 
       open_ended = dep.requirement.requirements.all? do |op, version|
         not version.prerelease? and (op == '>' or op == '>=')
@@ -170,11 +213,8 @@ duplicate dependency on #{dep}, (#{prev.requirement}) use:
         warning_messages << ["open-ended dependency on #{dep} is not recommended", recommendation].join("\n") + "\n"
       end
     end
-    if error_messages.any?
-      error error_messages.join
-    end
     if warning_messages.any?
-      warning_messages.each { |warning_message| warning warning_message }
+      warning_messages.each {|warning_message| warning warning_message }
     end
   end
 
@@ -186,14 +226,14 @@ duplicate dependency on #{dep}, (#{prev.requirement}) use:
   def validate_permissions
     return if Gem.win_platform?
 
-    files.each do |file|
+    @specification.files.each do |file|
       next unless File.file?(file)
       next if File.stat(file).mode & 0444 == 0444
       warning "#{file} is not world-readable"
     end
 
-    executables.each do |name|
-      exec = File.join bindir, name
+    @specification.executables.each do |name|
+      exec = File.join @specification.bindir, name
       next unless File.file?(exec)
       next if File.stat(exec).executable?
       warning "#{exec} is not executable"
@@ -204,7 +244,7 @@ duplicate dependency on #{dep}, (#{prev.requirement}) use:
 
   def validate_nil_attributes
     nil_attributes = Gem::Specification.non_nil_attributes.select do |attrname|
-      __getobj__.instance_variable_get("@#{attrname}").nil?
+      @specification.instance_variable_get("@#{attrname}").nil?
     end
     return if nil_attributes.empty?
     error "#{nil_attributes.join ', '} must not be nil"
@@ -212,6 +252,9 @@ duplicate dependency on #{dep}, (#{prev.requirement}) use:
 
   def validate_rubygems_version
     return unless packaging
+
+    rubygems_version = @specification.rubygems_version
+
     return if rubygems_version == Gem::VERSION
 
     error "expected RubyGems version #{Gem::VERSION}, was #{rubygems_version}"
@@ -219,13 +262,15 @@ duplicate dependency on #{dep}, (#{prev.requirement}) use:
 
   def validate_required_attributes
     Gem::Specification.required_attributes.each do |symbol|
-      unless send symbol
+      unless @specification.send symbol
         error "missing value for attribute #{symbol}"
       end
     end
   end
 
   def validate_name
+    name = @specification.name
+
     if !name.is_a?(String)
       error "invalid value for attribute name: \"#{name.inspect}\" must be a string"
     elsif name !~ /[a-zA-Z]/
@@ -238,14 +283,15 @@ duplicate dependency on #{dep}, (#{prev.requirement}) use:
   end
 
   def validate_require_paths
-    return unless raw_require_paths.empty?
+    return unless @specification.raw_require_paths.empty?
 
     error 'specification must have at least one require_path'
   end
 
   def validate_non_files
     return unless packaging
-    non_files = files.reject {|x| File.file?(x) || File.symlink?(x)}
+
+    non_files = @specification.files.reject {|x| File.file?(x) || File.symlink?(x) }
 
     unless non_files.empty?
       error "[\"#{non_files.join "\", \""}\"] are not files"
@@ -253,20 +299,24 @@ duplicate dependency on #{dep}, (#{prev.requirement}) use:
   end
 
   def validate_self_inclusion_in_files_list
-    return unless files.include?(file_name)
+    file_name = @specification.file_name
+
+    return unless @specification.files.include?(file_name)
 
-    error "#{full_name} contains itself (#{file_name}), check your files list"
+    error "#{@specification.full_name} contains itself (#{file_name}), check your files list"
   end
 
   def validate_specification_version
-    return if specification_version.is_a?(Integer)
+    return if @specification.specification_version.is_a?(Integer)
 
     error 'specification_version must be an Integer (did you mean version?)'
   end
 
   def validate_platform
+    platform = @specification.platform
+
     case platform
-    when Gem::Platform, Gem::Platform::RUBY  # ok
+    when Gem::Platform, Gem::Platform::RUBY # ok
     else
       error "invalid platform #{platform.inspect}, see Gem::Platform"
     end
@@ -279,7 +329,7 @@ duplicate dependency on #{dep}, (#{prev.requirement}) use:
   end
 
   def validate_array_attribute(field)
-    val = self.send(field)
+    val = @specification.send(field)
     klass = case field
             when :dependencies then
               Gem::Dependency
@@ -287,39 +337,46 @@ duplicate dependency on #{dep}, (#{prev.requirement}) use:
               String
             end
 
-    unless Array === val and val.all? {|x| x.kind_of?(klass)}
-      raise(Gem::InvalidSpecificationException,
-            "#{field} must be an Array of #{klass}")
+    unless Array === val and val.all? {|x| x.kind_of?(klass) }
+      error "#{field} must be an Array of #{klass}"
     end
   end
 
   def validate_authors_field
-    return unless authors.empty?
+    return unless @specification.authors.empty?
 
     error "authors may not be empty"
   end
 
-  def validate_licenses
-    licenses.each { |license|
+  def validate_licenses_length
+    licenses = @specification.licenses
+
+    licenses.each do |license|
       if license.length > 64
         error "each license must be 64 characters or less"
       end
+    end
+  end
 
+  def validate_licenses
+    licenses = @specification.licenses
+
+    licenses.each do |license|
       if !Gem::Licenses.match?(license)
         suggestions = Gem::Licenses.suggestions(license)
-        message = <<-warning
+        message = <<-WARNING
 license value '#{license}' is invalid.  Use a license identifier from
 http://spdx.org/licenses or '#{Gem::Licenses::NONSTANDARD}' for a nonstandard license.
-        warning
-        message += "Did you mean #{suggestions.map { |s| "'#{s}'"}.join(', ')}?\n" unless suggestions.nil?
+        WARNING
+        message += "Did you mean #{suggestions.map {|s| "'#{s}'" }.join(', ')}?\n" unless suggestions.nil?
         warning(message)
       end
-    }
+    end
 
-    warning <<-warning if licenses.empty?
+    warning <<-WARNING if licenses.empty?
 licenses is empty, but is recommended.  Use a license identifier from
 http://spdx.org/licenses or '#{Gem::Licenses::NONSTANDARD}' for a nonstandard license.
-    warning
+    WARNING
   end
 
   LAZY = '"FIxxxXME" or "TOxxxDO"'.gsub(/xxx/, '')
@@ -327,24 +384,27 @@ http://spdx.org/licenses or '#{Gem::Licenses::NONSTANDARD}' for a nonstandard li
   HOMEPAGE_URI_PATTERN = /\A[a-z][a-z\d+.-]*:/i.freeze
 
   def validate_lazy_metadata
-    unless authors.grep(LAZY_PATTERN).empty?
+    unless @specification.authors.grep(LAZY_PATTERN).empty?
       error "#{LAZY} is not an author"
     end
 
-    unless Array(email).grep(LAZY_PATTERN).empty?
+    unless Array(@specification.email).grep(LAZY_PATTERN).empty?
       error "#{LAZY} is not an email"
     end
 
-    if description =~ LAZY_PATTERN
+    if @specification.description =~ LAZY_PATTERN
       error "#{LAZY} is not a description"
     end
 
-    if summary =~ LAZY_PATTERN
+    if @specification.summary =~ LAZY_PATTERN
       error "#{LAZY} is not a summary"
     end
 
+    homepage = @specification.homepage
+
     # Make sure a homepage is valid HTTP/HTTPS URI
     if homepage and not homepage.empty?
+      require 'uri'
       begin
         homepage_uri = URI.parse(homepage)
         unless [URI::HTTP, URI::HTTPS].member? homepage_uri.class
@@ -361,34 +421,52 @@ http://spdx.org/licenses or '#{Gem::Licenses::NONSTANDARD}' for a nonstandard li
       validate_attribute_present(attribute)
     end
 
-    if description == summary
+    if @specification.description == @specification.summary
       warning "description and summary are identical"
     end
 
     # TODO: raise at some given date
-    warning "deprecated autorequire specified" if autorequire
+    warning "deprecated autorequire specified" if @specification.autorequire
 
-    executables.each do |executable|
+    @specification.executables.each do |executable|
       validate_shebang_line_in(executable)
     end
 
-    files.select { |f| File.symlink?(f) }.each do |file|
+    @specification.files.select {|f| File.symlink?(f) }.each do |file|
       warning "#{file} is a symlink, which is not supported on all platforms"
     end
   end
 
   def validate_attribute_present(attribute)
-    value = self.send attribute
+    value = @specification.send attribute
     warning("no #{attribute} specified") if value.nil? || value.empty?
   end
 
   def validate_shebang_line_in(executable)
-    executable_path = File.join(bindir, executable)
+    executable_path = File.join(@specification.bindir, executable)
     return if File.read(executable_path, 2) == '#!'
 
     warning "#{executable_path} is missing #! line"
   end
 
+  def validate_removed_attributes # :nodoc:
+    @specification.removed_method_calls.each do |attr|
+      warning("#{attr} is deprecated and ignored. Please remove this from your gemspec to ensure that your gem continues to build in the future.")
+    end
+  end
+
+  def validate_extensions # :nodoc:
+    require_relative 'ext'
+    builder = Gem::Ext::Builder.new(@specification)
+
+    rake_extension = @specification.extensions.any? {|s| builder.builder_for(s) == Gem::Ext::RakeBuilder }
+    rake_dependency = @specification.dependencies.any? {|d| d.name == 'rake' }
+
+    warning <<-WARNING if rake_extension && !rake_dependency
+You have specified rake based extension, but rake is not added as dependency. It is recommended to add rake as a dependency in gemspec since there's no guarantee rake will be already installed.
+    WARNING
+  end
+
   def warning(statement) # :nodoc:
     @warnings += 1
 
@@ -402,6 +480,6 @@ http://spdx.org/licenses or '#{Gem::Licenses::NONSTANDARD}' for a nonstandard li
   end
 
   def help_text # :nodoc:
-    "See http://guides.rubygems.org/specification-reference/ for help"
+    "See https://guides.rubygems.org/specification-reference/ for help"
   end
 end

data/lib/rubygems/ssl_certs/rubygems.org/GlobalSignRootCA_R3.pem

@@ -0,0 +1,21 @@
+-----BEGIN CERTIFICATE-----
+MIIDXzCCAkegAwIBAgILBAAAAAABIVhTCKIwDQYJKoZIhvcNAQELBQAwTDEgMB4G
+A1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNp
+Z24xEzARBgNVBAMTCkdsb2JhbFNpZ24wHhcNMDkwMzE4MTAwMDAwWhcNMjkwMzE4
+MTAwMDAwWjBMMSAwHgYDVQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEG
+A1UEChMKR2xvYmFsU2lnbjETMBEGA1UEAxMKR2xvYmFsU2lnbjCCASIwDQYJKoZI
+hvcNAQEBBQADggEPADCCAQoCggEBAMwldpB5BngiFvXAg7aEyiie/QV2EcWtiHL8
+RgJDx7KKnQRfJMsuS+FggkbhUqsMgUdwbN1k0ev1LKMPgj0MK66X17YUhhB5uzsT
+gHeMCOFJ0mpiLx9e+pZo34knlTifBtc+ycsmWQ1z3rDI6SYOgxXG71uL0gRgykmm
+KPZpO/bLyCiR5Z2KYVc3rHQU3HTgOu5yLy6c+9C7v/U9AOEGM+iCK65TpjoWc4zd
+QQ4gOsC0p6Hpsk+QLjJg6VfLuQSSaGjlOCZgdbKfd/+RFO+uIEn8rUAVSNECMWEZ
+XriX7613t2Saer9fwRPvm2L7DWzgVGkWqQPabumDk3F2xmmFghcCAwEAAaNCMEAw
+DgYDVR0PAQH/BAQDAgEGMA8GA1UdEwEB/wQFMAMBAf8wHQYDVR0OBBYEFI/wS3+o
+LkUkrk1Q+mOai97i3Ru8MA0GCSqGSIb3DQEBCwUAA4IBAQBLQNvAUKr+yAzv95ZU
+RUm7lgAJQayzE4aGKAczymvmdLm6AC2upArT9fHxD4q/c2dKg8dEe3jgr25sbwMp
+jjM5RcOO5LlXbKr8EpbsU8Yt5CRsuZRj+9xTaGdWPoO4zzUhw8lo/s7awlOqzJCK
+6fBdRoyV3XpYKBovHd7NADdBj+1EbddTKJd+82cEHhXXipa0095MJ6RMG3NzdvQX
+mcIfeg7jLQitChws/zyrVQ4PkX4268NXSb7hLi18YIvDQVETI53O9zJrlAGomecs
+Mx86OyXShkDOOyyGeMlhLxS67ttVb9+E7gUJTb0o2HLO02JQZR7rkpeDMdmztcpH
+WD9f
+-----END CERTIFICATE-----