rubygems-update 2.0.17 → 2.1.0.rc.1

data/test/rubygems/test_gem_request.rb

@@ -0,0 +1,239 @@
+require 'rubygems/test_case'
+require 'rubygems/request'
+require 'ostruct'
+
+class TestGemRequest < Gem::TestCase
+
+  def setup
+    @proxies = %w[http_proxy HTTP_PROXY http_proxy_user HTTP_PROXY_USER http_proxy_pass HTTP_PROXY_PASS no_proxy NO_PROXY]
+    @old_proxies = @proxies.map {|k| ENV[k] }
+    @proxies.each {|k| ENV[k] = nil }
+
+    super
+
+    @proxy_uri = "http://localhost:1234"
+
+    @request = Gem::Request.new nil, nil, nil, nil
+  end
+
+  def teardown
+    super
+    Gem.configuration[:http_proxy] = nil
+    @proxies.each_with_index {|k, i| ENV[k] = @old_proxies[i] }
+  end
+
+  def test_initialize_proxy
+    proxy_uri = 'http://proxy.example.com'
+
+    request = Gem::Request.new nil, nil, nil, proxy_uri
+
+    assert_equal proxy_uri, request.proxy_uri.to_s
+  end
+
+  def test_initialize_proxy_URI
+    proxy_uri = 'http://proxy.example.com'
+
+    request = Gem::Request.new nil, nil, nil, URI(proxy_uri)
+
+    assert_equal proxy_uri, request.proxy_uri.to_s
+  end
+
+  def test_initialize_proxy_ENV
+    ENV['http_proxy'] = @proxy_uri
+    ENV['http_proxy_user'] = 'foo'
+    ENV['http_proxy_pass'] = 'bar'
+
+    request = Gem::Request.new nil, nil, nil, nil
+
+    proxy = request.proxy_uri
+
+    assert_equal 'foo', proxy.user
+    assert_equal 'bar', proxy.password
+  end
+
+  def test_get_proxy_from_env_domain
+    ENV['http_proxy'] = @proxy_uri
+    ENV['http_proxy_user'] = 'foo\user'
+    ENV['http_proxy_pass'] = 'my bar'
+
+    proxy = @request.get_proxy_from_env
+
+    assert_equal 'foo\user', Gem::UriFormatter.new(proxy.user).unescape
+    assert_equal 'my bar', Gem::UriFormatter.new(proxy.password).unescape
+  end
+
+  def test_get_proxy_from_env_normalize
+    ENV['HTTP_PROXY'] = 'fakeurl:12345'
+
+    assert_equal 'http://fakeurl:12345', @request.get_proxy_from_env.to_s
+  end
+
+  def test_get_proxy_from_env_empty
+    ENV['HTTP_PROXY'] = ''
+    ENV.delete 'http_proxy'
+
+    assert_nil @request.get_proxy_from_env
+  end
+
+  def test_fetch
+    uri = URI.parse "#{@gem_repo}/specs.#{Gem.marshal_version}"
+    @request = Gem::Request.new(uri, Net::HTTP::Get, nil, nil)
+    util_stub_connection_for :body => :junk, :code => 200
+
+    response = @request.fetch
+
+    assert_equal 200, response.code
+    assert_equal :junk, response.body
+  end
+
+  def test_fetch_head
+    uri = URI.parse "#{@gem_repo}/specs.#{Gem.marshal_version}"
+    @request = Gem::Request.new(uri, Net::HTTP::Get, nil, nil)
+    util_stub_connection_for :body => '', :code => 200
+
+    response = @request.fetch
+
+    assert_equal 200, response.code
+    assert_equal '', response.body
+  end
+
+  def test_fetch_unmodified
+    uri = URI.parse "#{@gem_repo}/specs.#{Gem.marshal_version}"
+    t = Time.now
+    @request = Gem::Request.new(uri, Net::HTTP::Get, t, nil)
+    conn = util_stub_connection_for :body => '', :code => 304
+
+    response = @request.fetch
+
+    assert_equal 304, response.code
+    assert_equal '', response.body
+
+    assert_equal t.rfc2822, conn.payload['if-modified-since']
+  end
+
+  def test_user_agent
+    ua = Gem::Request.new(nil, nil, nil, nil).user_agent
+
+    assert_match %r%^RubyGems/\S+ \S+ Ruby/\S+ \(.*?\)%,          ua
+    assert_match %r%RubyGems/#{Regexp.escape Gem::VERSION}%,      ua
+    assert_match %r% #{Regexp.escape Gem::Platform.local.to_s} %, ua
+    assert_match %r%Ruby/#{Regexp.escape RUBY_VERSION}%,          ua
+    assert_match %r%\(#{Regexp.escape RUBY_RELEASE_DATE} %,       ua
+  end
+
+  def test_user_agent_engine
+    util_save_version
+
+    Object.send :remove_const, :RUBY_ENGINE if defined?(RUBY_ENGINE)
+    Object.send :const_set,    :RUBY_ENGINE, 'vroom'
+
+    ua = Gem::Request.new(nil, nil, nil, nil).user_agent
+
+    assert_match %r%\) vroom%, ua
+  ensure
+    util_restore_version
+  end
+
+  def test_user_agent_engine_ruby
+    util_save_version
+
+    Object.send :remove_const, :RUBY_ENGINE if defined?(RUBY_ENGINE)
+    Object.send :const_set,    :RUBY_ENGINE, 'ruby'
+
+    ua = Gem::Request.new(nil, nil, nil, nil).user_agent
+
+    assert_match %r%\)%, ua
+  ensure
+    util_restore_version
+  end
+
+  def test_user_agent_patchlevel
+    util_save_version
+
+    Object.send :remove_const, :RUBY_PATCHLEVEL
+    Object.send :const_set,    :RUBY_PATCHLEVEL, 5
+
+    ua = Gem::Request.new(nil, nil, nil, nil).user_agent
+
+    assert_match %r% patchlevel 5\)%, ua
+  ensure
+    util_restore_version
+  end
+
+  def test_user_agent_revision
+    util_save_version
+
+    Object.send :remove_const, :RUBY_PATCHLEVEL
+    Object.send :const_set,    :RUBY_PATCHLEVEL, -1
+    Object.send :remove_const, :RUBY_REVISION if defined?(RUBY_REVISION)
+    Object.send :const_set,    :RUBY_REVISION, 6
+
+    ua = Gem::Request.new(nil, nil, nil, nil).user_agent
+
+    assert_match %r% revision 6\)%, ua
+    assert_match %r%Ruby/#{Regexp.escape RUBY_VERSION}dev%, ua
+  ensure
+    util_restore_version
+  end
+
+  def test_user_agent_revision_missing
+    util_save_version
+
+    Object.send :remove_const, :RUBY_PATCHLEVEL
+    Object.send :const_set,    :RUBY_PATCHLEVEL, -1
+    Object.send :remove_const, :RUBY_REVISION if defined?(RUBY_REVISION)
+
+    ua = Gem::Request.new(nil, nil, nil, nil).user_agent
+
+    assert_match %r%\(#{Regexp.escape RUBY_RELEASE_DATE}\)%, ua
+  ensure
+    util_restore_version
+  end
+
+  def util_restore_version
+    Object.send :remove_const, :RUBY_ENGINE if defined?(RUBY_ENGINE)
+    Object.send :const_set,    :RUBY_ENGINE, @orig_RUBY_ENGINE if
+      defined?(@orig_RUBY_ENGINE)
+
+    Object.send :remove_const, :RUBY_PATCHLEVEL
+    Object.send :const_set,    :RUBY_PATCHLEVEL, @orig_RUBY_PATCHLEVEL
+
+    Object.send :remove_const, :RUBY_REVISION if defined?(RUBY_REVISION)
+    Object.send :const_set,    :RUBY_REVISION, @orig_RUBY_REVISION if
+      defined?(@orig_RUBY_REVISION)
+  end
+
+  def util_save_version
+    @orig_RUBY_ENGINE     = RUBY_ENGINE if defined? RUBY_ENGINE
+    @orig_RUBY_PATCHLEVEL = RUBY_PATCHLEVEL
+    @orig_RUBY_REVISION   = RUBY_REVISION if defined? RUBY_REVISION
+  end
+
+  def util_stub_connection_for hash
+    def @request.connection= conn
+      @conn = conn
+    end
+
+    def @request.connection_for uri
+      @conn
+    end
+
+    @request.connection = Conn.new OpenStruct.new(hash)
+  end
+
+  class Conn
+    attr_accessor :payload
+
+    def initialize(response)
+      @response = response
+      self.payload = nil
+    end
+
+    def request(req)
+      self.payload = req
+      @response
+    end
+  end
+
+end
+

data/test/rubygems/test_gem_requirement.rb

@@ -47,20 +47,18 @@ class TestGemRequirement < Gem::TestCase
   end
 
   def test_parse_bad
-    [
-      nil,
-      '',
-      '! 1',
-      '= junk',
-      '1..2',
-    ].each do |bad|
-      e = assert_raises Gem::Requirement::BadRequirementError do
-        Gem::Requirement.parse bad
-      end
+    e = assert_raises Gem::Requirement::BadRequirementError do
+      Gem::Requirement.parse nil
+    end
 
-      assert_equal "Illformed requirement [#{bad.inspect}]", e.message
+    assert_equal 'Illformed requirement [nil]', e.message
+
+    e = assert_raises Gem::Requirement::BadRequirementError do
+      Gem::Requirement.parse ""
     end
 
+    assert_equal 'Illformed requirement [""]', e.message
+
     assert_equal Gem::Requirement::BadRequirementError.superclass, ArgumentError
   end
 

data/test/rubygems/test_gem_security.rb

@@ -2,6 +2,10 @@ require 'rubygems/test_case'
 require 'rubygems/security'
 require 'rubygems/fix_openssl_warnings' if RUBY_VERSION < "1.9"
 
+unless defined?(OpenSSL::SSL) then
+  warn 'Skipping Gem::Security tests.  openssl not found.'
+end
+
 class TestGemSecurity < Gem::TestCase
 
   CHILD_KEY = load_key 'child'
@@ -95,7 +99,7 @@ class TestGemSecurity < Gem::TestCase
   end
 
   def test_class_create_key
-    key = @SEC.create_key 256
+    key = @SEC.create_key 1024
 
     assert_kind_of OpenSSL::PKey::RSA, key
   end
@@ -246,5 +250,57 @@ class TestGemSecurity < Gem::TestCase
     assert_equal expected, trust_dir.dir
   end
 
-end
+  def test_class_write
+    key = @SEC.create_key 1024
+
+    path = File.join @tempdir, 'test-private_key.pem'
+
+    @SEC.write key, path
+
+    assert_path_exists path
+
+    key_from_file = File.read path
+
+    assert_equal key.to_pem, key_from_file
+  end
+
+  def test_class_write_encrypted
+    key = @SEC.create_key 1024
+
+    path = File.join @tempdir, 'test-private_encrypted_key.pem'
+
+    passphrase = 'It should be long.'
+
+    @SEC.write key, path, 0600, passphrase
+
+    assert_path_exists path
+
+    key_from_file =  OpenSSL::PKey::RSA.new File.read(path), passphrase
+
+    assert_equal key.to_pem, key_from_file.to_pem
+  end
+
+  def test_class_write_encrypted_cipher
+    key = @SEC.create_key 1024
+
+    path = File.join @tempdir, 'test-private_encrypted__with_non_default_cipher_key.pem'
+
+    passphrase = 'It should be long.'
+
+    cipher = OpenSSL::Cipher.new 'AES-192-CBC'
+
+    @SEC.write key, path, 0600, passphrase, cipher
+
+    assert_path_exists path
+
+    key_file_contents = File.read(path)
+
+    assert key_file_contents.split("\n")[2].match(cipher.name)
+
+    key_from_file = OpenSSL::PKey::RSA.new key_file_contents, passphrase
+
+    assert_equal key.to_pem, key_from_file.to_pem
+  end
+
+end if defined?(OpenSSL::SSL)
 

data/test/rubygems/test_gem_security_policy.rb

@@ -2,6 +2,10 @@
 
 require 'rubygems/test_case'
 
+unless defined?(OpenSSL::SSL) then
+  warn 'Skipping Gem::Security::Policy tests.  openssl not found.'
+end
+
 class TestGemSecurityPolicy < Gem::TestCase
 
   ALTERNATE_KEY    = load_key 'alternate'
@@ -11,6 +15,7 @@ class TestGemSecurityPolicy < Gem::TestCase
   INVALIDCHILD_KEY = load_key 'invalidchild'
 
   ALTERNATE_CERT      = load_cert 'alternate'
+  CA_CERT             = load_cert 'ca'
   CHILD_CERT          = load_cert 'child'
   EXPIRED_CERT        = load_cert 'expired'
   FUTURE_CERT         = load_cert 'future'
@@ -285,6 +290,11 @@ class TestGemSecurityPolicy < Gem::TestCase
                  "(root of signing cert #{CHILD_CERT.subject})", e.message
   end
 
+  def test_subject
+    assert_equal 'email:nobody@example', @no.subject(PUBLIC_CERT)
+    assert_equal '/C=JP/O=JIN.GR.JP/OU=RRR/CN=CA', @no.subject(CA_CERT)
+  end
+
   def test_verify
     Gem::Security.trust_dir.trust_cert PUBLIC_CERT
 
@@ -325,6 +335,22 @@ class TestGemSecurityPolicy < Gem::TestCase
     assert_equal 'missing digest for 0', e.message
   end
 
+  def test_verify_no_signatures
+    Gem::Security.trust_dir.trust_cert PUBLIC_CERT
+
+    digests, = dummy_signatures
+
+    use_ui @ui do
+      @no.verify [PUBLIC_CERT], nil, digests, {}, 'some_gem'
+    end
+
+    assert_match "WARNING:  some_gem is not signed\n", @ui.error
+
+    assert_raises Gem::Security::Exception do
+      @almost_no.verify [PUBLIC_CERT], nil, digests, {}
+    end
+  end
+
   def test_verify_not_enough_signatures
     Gem::Security.trust_dir.trust_cert PUBLIC_CERT
 
@@ -341,6 +367,21 @@ class TestGemSecurityPolicy < Gem::TestCase
     assert_equal 'missing digest for 1', e.message
   end
 
+  def test_verify_no_trust
+    digests, signatures = dummy_signatures
+
+    use_ui @ui do
+      @low.verify [PUBLIC_CERT], nil, digests, signatures, 'some_gem'
+    end
+
+    assert_equal "WARNING:  email:nobody@example is not trusted for some_gem\n",
+                 @ui.error
+
+    assert_raises Gem::Security::Exception do
+      @medium.verify [PUBLIC_CERT], nil, digests, signatures
+    end
+  end
+
   def test_verify_wrong_digest_type
     Gem::Security.trust_dir.trust_cert PUBLIC_CERT
 
@@ -484,5 +525,5 @@ class TestGemSecurityPolicy < Gem::TestCase
     return digests, signatures
   end
 
-end
+end if defined?(OpenSSL::SSL)
 

data/test/rubygems/test_gem_security_signer.rb

@@ -1,5 +1,9 @@
 require 'rubygems/test_case'
 
+unless defined?(OpenSSL::SSL) then
+  warn 'Skipping Gem::Security::Signer tests.  openssl not found.'
+end
+
 class TestGemSecuritySigner < Gem::TestCase
 
   ALTERNATE_KEY  = load_key 'alternate'
@@ -72,6 +76,14 @@ class TestGemSecuritySigner < Gem::TestCase
     assert_equal PRIVATE_KEY.to_s, signer.key.to_s
   end
 
+  def test_initialize_encrypted_key_path
+    key_file = ENCRYPTED_PRIVATE_KEY_PATH
+
+    signer = Gem::Security::Signer.new key_file, nil, PRIVATE_KEY_PASSPHRASE
+
+    assert_equal ENCRYPTED_PRIVATE_KEY.to_s, signer.key.to_s
+  end
+
   def test_load_cert_chain
     Gem::Security.trust_dir.trust_cert PUBLIC_CERT
 
@@ -186,5 +198,5 @@ c7NM7KZZjj7G++SXjYTEI1PHSA7aFQ/i/+qSUvx+Pg==
     end
   end
 
-end
+end if defined?(OpenSSL::SSL)