rubygems-update 0.8.3

data/test/test_source_index.rb

@@ -0,0 +1,58 @@
+require 'test/unit'
+require 'rubygems'
+Gem::manage_gems
+
+class TestSourceIndex < Test::Unit::TestCase
+
+  SAMPLE_SPEC = Gem::Specification.new do |s|
+    s.name = 'foo'
+    s.version = "1.2.3"
+    s.platform = Gem::Platform::RUBY
+    s.summary = "This is a cool package"
+    s.files = [] 
+  end 
+  SAMPLE_SOURCE_HASH = { 'foo-1.2.3' => SAMPLE_SPEC }
+  
+  def setup
+    @source_index = Gem::SourceIndex.new(SAMPLE_SOURCE_HASH)
+  end
+
+  def test_create_from_directory
+  end
+
+  def test_search_for_missing_gem_returns_nothing
+    gems = @source_index.search("bogusstring")
+    assert_equal(gems.size, 0)
+  end
+
+  def test_search_empty_cache_returns_nothing
+    empty_source_index = Gem::SourceIndex.new({})
+    gems = empty_source_index.search("foo")
+    assert_equal(gems.size, 0)
+  end
+
+  def test_search_with_full_gem_name_returns_gem
+    gems = @source_index.search("foo")
+    assert_equal(gems.size, 1)
+  end
+
+  def test_search_with_full_gem_name_and_version_returns_gem
+    gems = @source_index.search("foo", "= 1.2.3")
+    assert_equal(gems.size, 1)
+  end
+
+  def test_search_with_full_gem_name_and_wrong_version_returns_nothing
+    gems = @source_index.search("foo", "= 3.2.1")
+    assert_equal(gems.size, 0)
+  end
+
+  def test_search_with_full_gem_name_in_mixed_case_returns_gem
+    gems = @source_index.search("FOo")
+    assert_equal(gems.size, 1,
+      %{This is failing because we have duplication between remote_installer and } + 
+      %{source_index.rb.  We should factor remote_installer's search logic out } +
+      %{into source_index.rb's search and delegate from remote_installer to } +
+      %{source_index.rb})
+  end
+
+end

data/test/test_specification.rb

@@ -0,0 +1,286 @@
+require 'test/unit'
+require 'rubygems'
+Gem::manage_gems
+
+LEGACY_GEM_SPEC_FILE = 'test/data/legacy/keyedlist-0.4.0.ruby'
+LEGACY_GEM_YAML_FILE = 'test/data/legacy/keyedlist-0.4.0.yaml'
+
+class TestDefaultSpecification < Test::Unit::TestCase
+  def test_defaults
+    spec = Gem::Specification.new do |s|
+      s.name = "blah"
+      s.version = "1.3.5"
+    end
+    assert_equal "blah", spec.name
+    assert_equal "1.3.5", spec.version.to_s
+    assert_equal Gem::Platform::RUBY, spec.platform
+    assert_equal nil, spec.summary
+    assert_equal [], spec.files
+  end
+end
+
+class TestSimpleSpecification < Test::Unit::TestCase
+  def setup
+    @spec = Gem::Specification.new do |s|
+      s.version = "1.0.0"
+      s.name = "boo"
+      s.platform = Gem::Platform::RUBY
+      s.date = Time.now
+      s.summary = "Hello"
+      s.require_paths = ["."]
+    end
+    @spec.mark_version 
+  end
+
+  def test_empty_specification_is_invalid
+    spec = Gem::Specification.new
+    assert_raises(Gem::InvalidSpecificationException) {
+      spec.validate
+    }
+  end
+
+  def test_empty_non_nil_require_paths_is_invalid
+    @spec.require_paths = []
+    assert_raises(Gem::InvalidSpecificationException) {
+      @spec.validate
+    }
+  end
+
+  def test_spec_with_all_required_attributes_validates
+    assert_nothing_raised {
+      @spec.validate
+    }
+  end
+
+  def test_rdoc_files_included
+    @spec.files = %w(a b c d)
+    @spec.extra_rdoc_files = %w(x y z)
+    @spec.normalize
+    assert @spec.files.include?('x')
+  end
+
+  def test_duplicate_files_removed
+    @spec.files = %w(a b c d b)
+    @spec.extra_rdoc_files = %w(x y z x)
+    @spec.normalize
+    assert_equal 1, @spec.files.select{|n| n=='b'}.size
+    assert_equal 1, @spec.extra_rdoc_files.select{|n| n=='x'}.size
+  end
+
+  def test_invalid_version_in_gem_spec_makes_spec_invalid
+    @spec.rubygems_version = "3"
+    assert_raises(Gem::InvalidSpecificationException) { @spec.validate }
+  end
+
+  def test_singular_attributes
+    @spec.require_path = 'mylib'
+    @spec.test_file = 'test/suite.rb'
+    @spec.executable = 'bin/app'
+    assert_equal ['mylib'], @spec.require_paths
+    assert_equal ['test/suite.rb'], @spec.test_files
+    assert_equal ['bin/app'], @spec.executables
+  end
+
+  def test_add_bindir_to_list_of_files
+    @spec.bindir = 'apps'
+    @spec.executable = 'app'
+    assert_equal ['apps/app'], @spec.files
+  end
+
+  def test_no_bindir_in_list_of_files
+    @spec.bindir = nil
+    @spec.executable = 'bin/app'
+    assert_equal ['bin/app'], @spec.files
+  end
+
+  def test_deprecated_attributes
+    @spec.test_suite_file = 'test/suite.rb'
+    assert_equal ['test/suite.rb'], @spec.test_files
+    # XXX: what about the warning?
+  end
+
+  def test_attribute_names
+    expected_value = %w{
+      rubygems_version specification_version name version date summary
+      require_paths authors email homepage rubyforge_project description
+      autorequire default_executable bindir has_rdoc required_ruby_version
+      platform files test_files rdoc_options extra_rdoc_files
+      executables extensions requirements dependencies
+    }.sort
+    actual_value = Gem::Specification.attribute_names.map { |a| a.to_s }.sort
+    assert_equal expected_value, actual_value
+  end
+
+  # TODO: test all the methods in the "convenience class methods" section of specification.rb
+
+  def test_defaults
+    # @spec is pretty plain, so we'll test some of the default values.
+    assert_equal [], @spec.test_files
+    assert_equal [], @spec.rdoc_options
+    assert_equal [], @spec.extra_rdoc_files
+    assert_equal [], @spec.executables
+    assert_equal [], @spec.extensions
+    assert_equal [], @spec.requirements
+    assert_equal [], @spec.dependencies
+    assert_equal 'bin', @spec.bindir
+    assert_equal false, @spec.has_rdoc
+    assert_equal false, @spec.has_rdoc?
+    assert_equal '> 0.0.0', @spec.required_ruby_version.to_s
+  end
+
+  def test_directly_setting_dependencies_doesnt_work
+    assert_raises(NoMethodError) do
+      @spec.dependencies = [1,2,3]
+    end
+  end
+
+  def test_equality
+    same_spec = @spec.dup
+    assert_equal @spec, same_spec
+  end
+
+  def test_to_yaml_and_back
+    yaml_str = @spec.to_yaml
+    same_spec = YAML.load(yaml_str)
+    assert_equal @spec, same_spec
+  end
+
+  def test_to_ruby_and_back
+    ruby_code = @spec.to_ruby
+    same_spec = eval ruby_code
+    assert_equal @spec, same_spec
+  end
+end  # class TestSimpleSpecification
+
+
+class TestComplexSpecification < Test::Unit::TestCase
+
+  def setup
+    @spec = Gem::Specification.new do |s|
+      s.name = "rfoo"
+      s.version = "0.1"
+      # Omit 'platform' and test for default.
+      # Omit 'date' and test for default.
+      s.summary = <<-EOF
+        Ruby/Foo is an example RubyGem used for
+        unit testing.
+      EOF
+      # Omit 'require_paths' and test for default.
+      s.author = "The RubyGems Team"
+      s.description = s.summary
+      s.executable = 'foo1'          # We'll test default_executable.
+      s.has_rdoc = 'true'            # We'll test has_rdoc?
+      s.test_file = 'test/suite.rb'  # We'll test has_unit_tests?
+      s.extensions << 'ext/rfoo/extconf.rb'
+      s.requirements << 'A working computer'
+      s.add_dependency('rake', '> 0.4')
+      s.add_dependency('jabber4r')
+      s.add_dependency('pqa', '> 0.4', '<= 0.6')
+    end
+    @spec.mark_version 
+  end
+
+  def test_basics
+    @spec.normalize
+    summary_value = "Ruby/Foo is an example RubyGem used for unit testing."
+    assert_equal 'rfoo',                  @spec.name
+    assert_equal '0.1',                   @spec.version.to_s
+    assert_equal Gem::Platform::RUBY,     @spec.platform
+    assert_equal Date.today,              @spec.date
+    assert_equal summary_value,           @spec.summary
+    assert_equal summary_value,           @spec.description
+    assert_equal "The RubyGems Team",     @spec.author
+    assert_equal ['foo1'],                @spec.executables
+    assert_equal 'foo1',                  @spec.default_executable
+    assert_equal true,                    @spec.has_rdoc?
+    assert_equal ['test/suite.rb'],       @spec.test_files
+    assert_equal ['ext/rfoo/extconf.rb'], @spec.extensions
+    assert_equal ['A working computer'],  @spec.requirements
+  end
+
+  def test_dependencies
+    deps = @spec.dependencies.map { |d| d.to_s }
+    assert_equal 3, deps.size
+    assert deps.include?('rake (> 0.4)')
+    assert deps.include?('jabber4r (> 0.0.0)')
+    assert deps.include?('pqa (> 0.4, <= 0.6)')
+  end
+
+  def test_equality
+    same_spec = @spec.dup
+    assert_equal @spec, same_spec
+  end
+
+  def xtest_to_yaml_and_back
+    yaml_str = @spec.to_yaml
+    same_spec = YAML.load(yaml_str)
+    assert_equal @spec, same_spec
+  end
+
+  def test_to_ruby_and_back
+    ruby_code = @spec.to_ruby
+    same_spec = eval ruby_code
+    assert_equal @spec, same_spec
+  end
+
+  # Test different mechanisms for setting the gem's date: String, Time, and
+  # Date.  It should always come out as a Date.
+  def test_date_settings
+    @spec.date = '2003-09-17'
+    assert_equal Date.new(2003, 9, 17), @spec.date
+    @spec.date = Time.local(2003, 9, 17)
+    assert_equal Date.new(2003, 9, 17), @spec.date
+    @spec.date = Date.new(2003, 9, 17)
+    assert_equal Date.new(2003, 9, 17), @spec.date
+  end
+end  # class TestComplexSpecification
+
+
+class TestLegacyRubySpecification < Test::Unit::TestCase
+  def setup
+    @ruby_spec = File.read(LEGACY_GEM_SPEC_FILE)
+  end
+
+  def test_eval
+    s = gemspec = eval(@ruby_spec)
+    assert_equal 'keyedlist', s.name
+    assert_equal '0.4.0', s.version.to_s
+    assert_equal true, s.has_rdoc?
+    assert_equal Date.today, s.date
+    assert s.required_ruby_version.satisfied_by?(Gem::Version.new('0.0.1'))
+    assert_equal false, s.has_unit_tests?
+  end
+
+  def test_to_ruby_and_back
+    gemspec1 = eval(@ruby_spec)
+    ruby_code = gemspec1.to_ruby
+    gemspec2 = eval(ruby_code)
+    assert_equal gemspec1, gemspec2
+  end
+end  # class TestLegacyRubySpecification
+
+
+class TestLegacyYamlSpecification < Test::Unit::TestCase
+  def setup
+    @yaml_spec = File.read(LEGACY_GEM_YAML_FILE)
+  end
+
+  def test_load
+    s = gemspec = YAML.load(@yaml_spec)
+    assert_equal 'keyedlist', s.name
+    assert_equal '0.4.0', s.version.to_s
+    assert_equal true, s.has_rdoc?
+    #assert_equal Date.today, s.date
+    #assert s.required_ruby_version.satisfied_by?(Gem::Version.new('0.0.1'))
+    assert_equal false, s.has_unit_tests?
+  end
+
+end  # class TestLegacyYamlSpecification
+
+class TestSpecificationClassMethods < Test::Unit::TestCase
+  def test_load
+    gs = Gem::Specification.load("test/data/one/one.gemspec")
+    assert_equal "one", gs.name
+    assert_equal "one-0.0.1", gs.full_name
+  end
+end

data/test/test_validator.rb

@@ -0,0 +1,53 @@
+require 'test/unit'
+require 'rubygems'
+Gem::manage_gems
+
+class TestValidator < Test::Unit::TestCase
+  def test_missing_gem_throws_error
+    assert_raises(Gem::VerificationError) {
+      Gem::Validator.new.verify_gem_file("")
+    }
+    assert_raises(Gem::VerificationError) {
+      Gem::Validator.new.verify_gem_file("/this/path/will/almost/definitely/not/exist.gem")
+    }
+  end
+
+  def test_invalid_gem_throws_error
+    assert_raises(Gem::VerificationError) {
+      Gem::Validator.new.verify_gem("")
+    }
+    assert_raises(Gem::VerificationError) {
+      Gem::Validator.new.verify_gem(@simple_gem.upcase)
+    }
+
+# TODO: Since the new format does not support MD5 checking, the
+# following code will not throw an exception.  So we disable this
+# assertion for now.
+#     assert_raises(Gem::VerificationError) {
+#       Gem::Validator.new.verify_gem(@simple_gem.reverse)
+#     }
+  end
+
+  def test_simple_valid_gem_verifies
+    assert_nothing_raised {
+      Gem::Validator.new.verify_gem(@simple_gem)
+    }
+  end
+
+  def test_truncated_simple_valid_gem_fails
+    assert_raises(Gem::VerificationError) {
+      Gem::Validator.new.verify_gem(@simple_gem.chop)
+    }
+  end
+
+  def test_invalid_checksum_fails_appropriately
+    assert_raises(Gem::VerificationError) {
+      Gem::Validator.new.verify_gem(@simple_gem.sub(/MD5SUM.*=.*/, 'MD5SUM = "foo"'))
+    }
+  end
+
+  def setup
+    require File.dirname(__FILE__) + "/simple_gem.rb"
+    @simple_gem = SIMPLE_GEM
+  end
+end

data/test/test_version_comparison.rb

@@ -0,0 +1,204 @@
+require 'test/unit'
+require 'rubygems'
+Gem::manage_gems
+
+module VersionAsserts
+  def assert_adequate(version, requirement)
+    ver = Gem::Version.new(version)
+    req = Gem::Version::Requirement.new(requirement)
+    assert req.satisfied_by?(ver),
+      "Version #{version} should be adequate for Requirement #{requirement}"
+  end
+
+  def assert_inadequate(version, requirement)
+    ver = Gem::Version.new(version)
+    req = Gem::Version::Requirement.new(requirement)
+    assert ! req.satisfied_by?(ver),
+      "Version #{version} should not be adequate for Requirement #{requirement}"
+  end
+end
+
+
+class Versions < Test::Unit::TestCase
+  include VersionAsserts
+
+  def test_ok
+      assert_adequate( "0.2.33",      "= 0.2.33")
+      assert_adequate( "0.2.34",      "> 0.2.33")
+      assert_adequate( "1.0",         "= 1.0")
+      assert_adequate( "1.0",         "1.0")
+      assert_adequate( "1.8.2",       "> 1.8.0")
+      assert_adequate( "1.112",       "> 1.111")
+      assert_adequate( "0.2",         "> 0.0.0")
+      assert_adequate( "0.0.0.0.0.2", "> 0.0.0")
+      assert_adequate( "0.0.1.0",     "> 0.0.0.1")
+      assert_adequate( "10.3.2",      "> 9.3.2")
+      assert_adequate( "1.0.0.0",     "= 1.0")
+      assert_adequate( "10.3.2",      "!= 9.3.4")
+      assert_adequate( "10.3.2",      "> 9.3.2")
+      assert_adequate( "10.3.2",      "> 9.3.2")
+      assert_adequate( " 9.3.2",      ">= 9.3.2")
+      assert_adequate( "9.3.2 ",      ">= 9.3.2")
+      assert_adequate( "",            "= 0")
+      assert_adequate( "",            "< 0.1")
+      assert_adequate( "  ",          "< 0.1 ")
+      assert_adequate( "",            " <  0.1")
+      assert_adequate( "0",           "=")
+      assert_adequate( "0",           ">=")
+      assert_adequate( "0",           "<=")
+    end
+
+    def test_bad
+      assert_inadequate( "",            "> 0.1")
+      assert_inadequate( "1.2.3",       "!= 1.2.3")
+      assert_inadequate( "1.2.003.0.0", "!= 1.02.3")
+      assert_inadequate( "4.5.6",       "< 1.2.3")
+      assert_inadequate( "1.0",         "> 1.1")
+      assert_inadequate( "0",           ">")
+      assert_inadequate( "0",           "<")
+      assert_inadequate( "",            "= 0.1")
+      assert_inadequate( "1.1.1",       "> 1.1.1")
+      assert_inadequate( "1.2",         "= 1.1")
+      assert_inadequate( "1.40",        "= 1.1")
+      assert_inadequate( "1.3",         "= 1.40")
+      assert_inadequate( "9.3.3",       "<= 9.3.2")
+      assert_inadequate( "9.3.1",       ">= 9.3.2")
+      assert_inadequate( "9.3.03",      "<= 9.3.2")
+      assert_inadequate( "1.0.0.1",     "= 1.0")
+    end
+
+    def test_illformed_version
+      [ "blah", "1.3.a", "1.3.5." ].each do |wn|
+	assert_raises(ArgumentError) { Gem::Version.new(wn) }
+      end
+    end
+
+    def test_illformed_requirements
+      [ ">>> 1.3.5", "> blah" ].each do |rq|
+	assert_raises(ArgumentError, "req [#{rq}] should fail") {
+	  Gem::Version::Requirement.new(rq)
+	}
+      end
+    end
+end
+
+class TestVersion < Test::Unit::TestCase
+  def test_to_s
+    v = Gem::Version.new("5.2.4")
+    assert_equal "5.2.4", v.to_s
+  end
+  def test_bump
+    v = Gem::Version.new("5.2.4")
+    assert_equal "5.3", v.bump.to_s
+  end
+  def test_bump_one_level
+    v = Gem::Version.new("5")
+    assert_equal "6", v.bump.to_s
+  end
+end
+    
+
+class TestExtendedVersionComparisons < Test::Unit::TestCase
+  include VersionAsserts
+
+  def test_multiple
+    req = [">= 1.4", "<= 1.6", "!= 1.5"]
+    assert_inadequate("1.3", req)
+    assert_adequate(  "1.4", req)
+    assert_inadequate("1.5", req)
+    assert_adequate(  "1.6", req)
+    assert_inadequate("1.7", req)
+    assert_inadequate("2.0", req)
+  end
+
+  def test_boxed
+    assert_inadequate("1.3", "~> 1.4")
+    assert_adequate(  "1.4", "~> 1.4")
+    assert_adequate(  "1.5", "~> 1.4")
+    assert_inadequate("2.0", "~> 1.4")
+  end
+
+end
+
+class TestDependencies < Test::Unit::TestCase
+  def test_create
+    dep = Gem::Dependency.new("pkg", ["> 1.0"])
+    assert_equal "pkg", dep.name
+    assert_equal Gem::Version::Requirement.new(["> 1.0"]), dep.version_requirements
+  end
+
+  def test_create_single
+    dep = Gem::Dependency.new("pkg", "> 1.0")
+    assert_equal Gem::Version::Requirement.new(["> 1.0"]), dep.version_requirements
+  end
+
+  def test_create_double
+    dep = Gem::Dependency.new("pkg", ["> 1.0", "< 2.0"])
+    assert_equal Gem::Version::Requirement.new(["> 1.0", "< 2.0"]), dep.version_requirements
+  end
+
+  def test_create_wacked
+    require 'yaml'
+    dep = Gem::Dependency.new("pkg", [])
+    old_req = Gem::Version::Requirement.new(["> 1.0"])
+    old_req.instance_eval do
+      @version = ">= 1.0"
+      @op = ">="
+      @nums = [1,0]
+      @requirements = nil
+    end
+    dep.instance_eval do
+      @version_requirement = old_req
+      @version_requirements = nil
+    end
+    assert_equal Gem::Version::Requirement.new([">= 1.0"]), dep.version_requirements
+  end
+
+  def test_create_from_string
+    req = Gem::Version::Requirement.create(">1")
+    assert ! req.satisfied_by?(Gem::Version.new("1.0"))
+    assert req.satisfied_by?(Gem::Version.new("1.1"))
+  end
+
+  def test_create_from_string_equal
+    req = Gem::Version::Requirement.create("1.3")
+    assert ! req.satisfied_by?(Gem::Version.new("1.0"))
+    assert req.satisfied_by?(Gem::Version.new("1.3"))
+  end
+
+  def test_create_from_requirement
+    req = Gem::Version::Requirement.create(Gem::Version::Requirement.new("1.3"))
+    assert ! req.satisfied_by?(Gem::Version.new("1.0"))
+    assert req.satisfied_by?(Gem::Version.new("1.3"))
+  end
+
+  def test_compare_to_nil
+    assert(Gem::Version.new("0.0") > nil)
+    req = Gem::Version::Requirement.create("1.3")
+    assert ! req.satisfied_by?(nil)
+  end
+
+  def test_create_from_list
+    req = Gem::Version::Requirement.create([">1", "<2"])
+    assert ! req.satisfied_by?(Gem::Version.new("1.0"))
+    assert ! req.satisfied_by?(Gem::Version.new("2.0"))
+    assert req.satisfied_by?(Gem::Version.new("1.3"))
+  end
+
+  # We may get some old gems that have requirements in old formats.
+  # We need to be able to handle those old requirements by normalizing
+  # them to the latest format.
+  def test_normalization
+    require 'yaml'
+    yamldep = %{--- !ruby/object:Gem::Version::Requirement
+      nums: 
+        - 1
+        - 0
+        - 4
+      op: ">="
+      version: ">= 1.0.4"}
+    dep = YAML.load(yamldep)
+    dep.normalize
+    assert_equal ">= 1.0.4", dep.to_s
+  end
+end