rubygems-test 0.2.3 → 0.2.4

data/History.txt

@@ -1,3 +1,10 @@
+=== 0.2.4 / 1/13/2011
+
+* Better I/O loop and terminal handling; test/unit dots should appear as they
+  arrive again.
+
+* Better help for those who provide no gem names.
+
 === 0.2.2 / 1/10/2011
 
 * Windows + 1.8 support. Requires the 'win32-open3' gem.

data/Rakefile

@@ -12,7 +12,7 @@ Hoe.spec 'rubygems-test' do
 
   # doin' it wrong because we're a gem plugin
   # that means I can be "special"!
-  self.version = '0.2.3'
+  self.version = '0.2.4'
   
   self.rubyforge_name = nil
 

data/lib/rubygems/commands/test_command.rb

@@ -209,33 +209,52 @@ class Gem::Commands::TestCommand < Gem::Command
     output = ""
     exit_status = nil
 
+    [STDOUT, STDERR, $stdout, $stderr].map { |x| x.sync = true }
+
     Dir.chdir(spec.full_gem_path) do
       reader_proc = proc do |orig_handles|
         current_handles = orig_handles.dup
 
         handles, _, _ = IO.select(current_handles, nil, nil, 0.1)
-        buf = ""
+        bufs = Hash.new { |h, k| h[k] = "" }
 
         if handles
           handles.compact.each do |io| 
             begin
-              buf += io.readline
+              bufs[io] += io.readpartial(8)
             rescue EOFError
-              buf += io.read rescue ""
+              bufs[io] += io.read rescue ""
               current_handles.reject! { |x| x == io }
             end
           end 
         end
 
-        [buf, current_handles]
+        [bufs, current_handles]
       end
 
       outer_reader_proc = proc do |stdout, stderr|
+        stderr_buf = ""
+
         loop do
+          output = ""
           handles = [stderr, stdout]
-          buf, handles = reader_proc.call(handles) 
-          output += buf
-          print buf
+          bufs, handles = reader_proc.call(handles)
+
+          # hello mom, I've rewritten unix i/o and it probably sucks.
+          # basically, we only "flush" stderr on newline and stdout 
+          # "flushes" immediately. and by "flush" I mean "concatenates".
+          if bufs.has_key?(stderr)
+            stderr_buf += bufs[stderr] 
+            buf_ary = stderr_buf.split(/\n/)
+            if buf_ary.length > 1
+              output += buf_ary[0..-2].join("\n") + "\n"
+              stderr_buf = buf_ary[-1] 
+            end
+          end
+
+          output += bufs[stdout] if bufs.has_key?(stdout)
+
+          print output
           break if handles.empty?
         end
       end
@@ -243,6 +262,10 @@ class Gem::Commands::TestCommand < Gem::Command
       rake_args = [rake_path, 'test', '--trace']
 
       # jruby stuffs it under IO, so we'll use that if it's available
+      # if we're on 1.9, use open3 regardless of platform.
+      # If we're not:
+      #   * on windows use win32/open3 from win32-open3 gem
+      #   * on unix use open4-vendor
       klass = 
         if IO.respond_to?(:popen4)
           IO.popen4(*rake_args) do |pid, stdin, stdout, stderr|
@@ -307,6 +330,13 @@ class Gem::Commands::TestCommand < Gem::Command
       version = options[:version] || Gem::Requirement.default
 
       (get_all_gem_names rescue [options[:name]]).each do |name|
+
+        unless name
+          alert_error "No gem specified."
+          show_help
+          terminate_interaction 1
+        end
+
         spec = find_gem(name, version)
 
         unless spec

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 2
-  - 3
-  version: 0.2.3
+  - 4
+  version: 0.2.4
 platform: ruby
 authors: 
 - Erik Hollensbe
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-11 00:00:00 -05:00
+date: 2011-01-13 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency