rubydb 0.1.2 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5cfc85dc4d3cfca89bd7d89335e4bf887fbfca212836f8a62d92a70a63f0f284
-  data.tar.gz: 9869f03b9da1a7e0cfd0c01f1f22ae9b5ba0e2b12eedaeac72e1b4deab878a0b
+  metadata.gz: 569e9ce02867a64e165f0703b4c2f3135255666ac938b05bed690b846df8b9b7
+  data.tar.gz: 29d7e3cb03885093407d20c51e52bfb4bb17257b701b862b5070fff5bc8f9eb3
 SHA512:
-  metadata.gz: 76650c2403e26244619687eb6146bb7a1561d3764d664094a6deb94e02566924c60979f481aca972be026987775f8c9b68ed02804d15e583f885528e02833613
-  data.tar.gz: 60c894fde163c1a47ed84aa2c2d8b374a9b6c70f3d810feb7ca419a06aa2cb5e6026d8aa278d27ed89ad4a83b48405c31137671f1d2dab7240d0efc36b367de8
+  metadata.gz: 1a3a33eb843e173974500f6848e395d10b4004b30c05c5c14b3afc353d3eff1c128d3d4ed6c3779889384aa0554b08c28d3722a0bcd623dca8d3576454fcc467
+  data.tar.gz: 3784d9d65f06788ab7e6e934b46e9916e1cd3ce0fc86f30bc677fb9b23c0b0d6cc04223b6b7acdcf38122d9ce0972b71eff1681bb02e6c07c350bf73f06d0d3f

data/CHANGELOG.md

@@ -23,6 +23,19 @@ All notable changes to RubyDB are documented here. Versions follow
   vacuum, maintenance, and release workflows.
 - Clarified the tested common SQLite-style profile and production limits.
 
+## 0.1.4 - 2026-09-09
+
+- Returned logical generated primary-key values to ActiveRecord separately
+  from physical storage row identifiers, including after deletes.
+- Preserved generated insert identifiers through the RubyDB result boundary.
+
+## 0.1.3 - 2026-09-09
+
+- Normalized numeric MVCC visibility-map keys after restart to prevent mixed
+  string/integer keys and duplicate-key warnings on Ruby 4.
+- Made visibility-map persistence failures raise `RubyDB::StorageError`
+  instead of silently reporting success.
+
 ## 0.1.2 - 2026-09-09
 
 - Added SQLite/ActiveRecord-compatible `INSERT ... DEFAULT VALUES` parsing,

data/adapters/activerecord/lib/active_record/connection_adapters/rubydb_adapter.rb

@@ -249,7 +249,10 @@ module ActiveRecord
         log(sql, name) do
           params = bind_values(binds)
           result = @connection.execute(sql, params)
-          id = result.row_id
+          # RubyDB keeps a physical row id for storage operations and a
+          # logical primary-key value for SQL/ActiveRecord. They can differ
+          # after deletes, so ActiveRecord must receive the logical id.
+          id = result.inserted_id || result.row_id
           ActiveRecord::Result.new([pk || "id"], id.nil? ? [] : [[id]])
         end
       end

data/adapters/activerecord/rubydb-activerecord.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name = "rubydb-activerecord"
-  spec.version = "0.1.1"
+  spec.version = "0.1.2"
   spec.authors = ["Aldane Hutchinson"]
   spec.email = ["aldanehutchinson5@gmail.com"]
 

data/adapters/activerecord/spec/rubydb_adapter_integration_spec.rb

@@ -89,6 +89,18 @@ RSpec.describe ActiveRecord::ConnectionAdapters::RubyDBAdapter do
     expect(settings_model.create!.reload.label).to eq("")
   end
 
+  it "returns the logical primary key after rows are deleted" do
+    connection = ActiveRecord::Base.connection
+    connection.execute("CREATE TABLE events (id INTEGER PRIMARY KEY, name VARCHAR(255) NOT NULL)")
+
+    events = Class.new(ActiveRecord::Base) { self.table_name = "events" }
+    events.create!(name: "first").destroy!
+    created = events.create!(name: "replacement")
+
+    expect(created.id).to eq(1)
+    expect(events.find(1).name).to eq("replacement")
+  end
+
   it "executes an ActiveRecord association join with qualified filtering" do
     stub_const("RubydbAccount", Class.new(ActiveRecord::Base) do
       self.table_name = "accounts"

data/lib/rubydb/execution/executor.rb

@@ -258,8 +258,10 @@ module RubyDB
             row_count: inserted.sum { |result| result[:row_count] },
             affected_rows: inserted.sum { |result| result[:affected_rows] },
             row_ids: inserted.filter_map { |result| result[:row_id] },
-            row_id: inserted.reverse_each.map { |result| result[:row_id] }.compact.first,
-            message: "INSERT #{inserted.sum { |result| result[:affected_rows] }}"
+            row_id: inserted.reverse_each.map { |result| result[:row_id] }.compact.first,
+            inserted_ids: inserted.filter_map { |result| result[:inserted_id] },
+            inserted_id: inserted.reverse_each.map { |result| result[:inserted_id] }.compact.first,
+            message: "INSERT #{inserted.sum { |result| result[:affected_rows] }}"
           }
         rescue Exception
           @engine.rollback_transaction if implicit_transaction && @engine.in_transaction?
@@ -277,12 +279,18 @@ module RubyDB
 
         # Insert into engine
         table_columns = @engine.table_columns(table_name)
-        row_id = @engine.insert_row(table_name, table_columns, row_data)
+        row_id = @engine.insert_row(table_name, table_columns, row_data)
+        primary_key = table_columns.find(&:primary_key?)
+        inserted_row = @engine.select_row(table_name, row_id, table_columns)
+        inserted_id = if primary_key && inserted_row
+          inserted_row[primary_key.name] || inserted_row[primary_key.name.to_sym]
+        end
 
         {
           row_count: 1,
           affected_rows: 1,
-          row_id: row_id,
+          row_id: row_id,
+          inserted_id: inserted_id,
           message: "INSERT 1"
         }
       rescue DatabaseError => error
@@ -313,7 +321,8 @@ module RubyDB
         end
         row_id = existing[:_row_id] || existing["_row_id"]
         @engine.update_row(table_name, row_id, values)
-        { row_count: 1, affected_rows: 1, row_id: row_id, message: "INSERT 0 UPDATE 1" }
+        inserted_id = target.map { |column| existing[column] || existing[column.to_sym] }.first
+        { row_count: 1, affected_rows: 1, row_id: row_id, inserted_id: inserted_id, message: "INSERT 0 UPDATE 1" }
       end
 
       def execute_update(plan)

data/lib/rubydb/rails/result.rb

@@ -7,7 +7,7 @@ module RubyDB
       include Enumerable
 
       attr_reader :columns, :rows, :row_count, :affected_rows
-      attr_reader :command_tag, :statement_id, :row_id
+      attr_reader :command_tag, :statement_id, :row_id, :inserted_id
 
       def initialize(result)
         @columns = result[:columns] || result[:column_names] || []
@@ -16,7 +16,8 @@ module RubyDB
         @affected_rows = result[:affected_rows] || 0
         @command_tag = result[:command_tag] || "SELECT"
         @statement_id = result[:statement_id]
-        @row_id = result[:row_id]
+        @row_id = result[:row_id]
+        @inserted_id = result[:inserted_id]
         @transaction_id = result[:transaction_id]
         @success = result[:success] != false
         @error = result[:error]
@@ -84,7 +85,9 @@ module RubyDB
           rows: @rows,
           row_count: @row_count,
           affected_rows: @affected_rows,
-          command_tag: @command_tag,
+          command_tag: @command_tag,
+          row_id: @row_id,
+          inserted_id: @inserted_id,
           success: @success,
           error: @error,
           execution_time_ms: @execution_time

data/lib/rubydb/storage/visibility_map.rb

@@ -686,11 +686,13 @@ module RubyDB
                 end
               end
               
-              @active_transactions = parsed[:active_transactions] || {}
-              @committed_transactions = Set.new(parsed[:committed_transactions] || [])
-              @aborted_transactions = Set.new(parsed[:aborted_transactions] || [])
-              @next_version_id = parsed[:next_version_id] || 1
-              @row_version_chains = parsed[:row_version_chains] || {}
+              @active_transactions = normalize_numeric_keyed_hash(parsed[:active_transactions])
+              @committed_transactions = Set.new(parsed[:committed_transactions] || [])
+              @aborted_transactions = Set.new(parsed[:aborted_transactions] || [])
+              @next_version_id = parsed[:next_version_id] || 1
+              @row_version_chains = normalize_numeric_keyed_hash(parsed[:row_version_chains]) do |versions|
+                Array(versions).map(&:to_i)
+              end
               
               # Clean up any invalid data
               @active_transactions.each do |tx_id, info|
@@ -727,24 +729,35 @@ module RubyDB
             
             # Write to a temp file first, then rename
             temp_path = "#{visibility_path}.tmp"
-            File.write(temp_path, JSON.generate(data))
-            FileUtils.mv(temp_path, visibility_path)
-            
-            true
-          rescue => e
-            false
-          end
-        end
-      end
+            File.write(temp_path, JSON.generate(data))
+            FileUtils.mv(temp_path, visibility_path)
+            
+            true
+          rescue => e
+            File.delete(temp_path) if defined?(temp_path) && File.file?(temp_path)
+            raise StorageError, "Failed to flush visibility map: #{e.message}"
+          end
+        end
+      end
 
       # Remove a row from disk storage
       def remove_row_from_disk(row_id)
         true
       end
 
-      def remember_version(row_id, info)
-        @version_history[row_id][info[:version].to_i] = info.dup
-      end
+      def remember_version(row_id, info)
+        @version_history[row_id][info[:version].to_i] = info.dup
+      end
+
+      # JSON object keys are strings. Normalize numeric-keyed runtime maps on
+      # load so a reopened database cannot accumulate both "1" and 1 keys.
+      def normalize_numeric_keyed_hash(value)
+        normalized = {}
+        (value || {}).each do |key, entry|
+          normalized[key.to_s.to_i] = block_given? ? yield(entry) : entry
+        end
+        normalized
+      end
 
       def normalize_loaded_info(info)
         info.each_with_object({}) do |(key, value), normalized|

data/lib/rubydb/version.rb

@@ -11,13 +11,13 @@ module RubyDB
   # - MAJOR: Incompatible API changes
   # - MINOR: Backwards-compatible new functionality
   # - PATCH: Backwards-compatible bug fixes
-  VERSION = "0.1.2"
+  VERSION = "0.1.4"
 
   # Version components for easy access
   module Version
     MAJOR = 0
     MINOR = 1
-    PATCH = 2
+    PATCH = 4
     PRE = nil  # e.g., "alpha", "beta", "rc1"
 
     def self.to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubydb
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.4
 platform: ruby
 authors:
 - Aldane Hutchinson