rubycritic 4.4.0 → 4.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a45e87f4cbffc1c9e2bfa7b9f1fad1c78e93e772197cc33bfadd7c8e18890083
-  data.tar.gz: 1ad31a33e2fdf9ed9c3101c62c2c8dd205e3894e920f3e11b8e0cce5cfdf61c1
+  metadata.gz: 80cbe6c77393b0819c820cd22c3cc67a0f6a5824598e1f67dbb1f8a7097070d8
+  data.tar.gz: '08b6e201d99ad0537cc440f885a36c5f07cda146766a3009cb4616ce7209fc06'
 SHA512:
-  metadata.gz: 012ad61ae4afa4cc279beb5ad78d47f78f65600e99dc373a94db1fb0583fbd4296f11e40e9b2414615fe495eb38f62a91781e0e1a75e805f912d17f670fe304a
-  data.tar.gz: c47b6878398d30f5bc5831198eb36414f63e195e43f1a6e20ccdfb3922f98d74bc5830652355303a80efc2170a7a76d0eea3626328314b3e1514be3af895eb72
+  metadata.gz: 1883ee9f5c4832b9fefcabed5f768d368e0b539d7cd7435813546c5a1db0b93856bc0705e525de902dd2d5cd500e6692854476c2b5a24dd23dc5a6a260c37877
+  data.tar.gz: ebdb193754eab2b5d9b94830bda9de53cec62eecc1c11a1a4d15bf50c3a7e7f7bfcd0147fafbd85565f9a28962669e39b097a1f5dce93af77242be699b5d132a

data/CHANGELOG.md

@@ -1,4 +1,8 @@
-# master [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.4.0...master)
+# master [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.4.1...master)
+
+# v4.4.1 / 2020-02-20 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.4.0...v4.4.1)
+
+* [CHANGE] Rewrite how churn is calculated to make it faster
 
 # v4.4.0 / 2020-02-15 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.3.3...v4.4.0)
 

data/lib/rubycritic/source_control_systems/git.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'tty/which'
+require 'rubycritic/source_control_systems/git/churn'
 
 module RubyCritic
   module SourceControlSystem
@@ -28,12 +29,16 @@ module RubyCritic
         'Git'
       end
 
+      def churn
+        @churn ||= Churn.new
+      end
+
       def revisions_count(path)
-        git("log --follow --format=%h #{path.shellescape}").count("\n")
+        churn.revisions_count(path)
       end
 
       def date_of_last_commit(path)
-        git("log -1 --date=iso --format=%ad #{path.shellescape}").chomp!
+        churn.date_of_last_commit(path)
       end
 
       def revision?

data/lib/rubycritic/source_control_systems/git/churn.rb

@@ -0,0 +1,87 @@
+# frozen_string_literal: true
+
+module RubyCritic
+  module SourceControlSystem
+    class Git < Base
+      Stats = Struct.new(:count, :date)
+
+      class Renames
+        def initialize
+          @data = {}
+        end
+
+        def renamed(from, to)
+          current = current(to)
+          @data[from] = current
+        end
+
+        def current(name)
+          @data.fetch(name, name)
+        end
+      end
+
+      class Churn
+        def initialize
+          @renames = Renames.new
+          @date = nil
+          @stats = {}
+
+          call
+        end
+
+        def revisions_count(path)
+          stats(path).count
+        end
+
+        def date_of_last_commit(path)
+          stats(path).date
+        end
+
+        private
+
+        def call
+          Git
+            .git("log --all --date=iso --follow --format='format:date:%x09%ad' --name-status .")
+            .split("\n")
+            .reject(&:empty?)
+            .each { |line| process_line(line) }
+        end
+
+        def process_line(line)
+          operation, *rest = line.split("\t")
+
+          case operation
+          when /^date:/
+            process_date(*rest)
+          when /^R/
+            process_rename(*rest)
+          else
+            process_file(*rest)
+          end
+        end
+
+        def process_date(date)
+          @date = date
+        end
+
+        def process_rename(from, to)
+          @renames.renamed(from, to)
+          process_file(to)
+        end
+
+        def process_file(filename)
+          record_commit(@renames.current(filename), @date)
+        end
+
+        def record_commit(filename, date)
+          stats = @stats[filename] ||= Stats.new(0, date)
+          stats.count += 1
+        end
+
+        def stats(path)
+          @stats.fetch(path, Stats.new(0))
+        end
+      end
+    end
+  end
+end

data/lib/rubycritic/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RubyCritic
-  VERSION = '4.4.0'.freeze
+  VERSION = '4.4.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 4.4.0
+  version: 4.4.1
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-15 00:00:00.000000000 Z
+date: 2020-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flay
@@ -496,6 +496,7 @@ files:
 - lib/rubycritic/source_control_systems/base.rb
 - lib/rubycritic/source_control_systems/double.rb
 - lib/rubycritic/source_control_systems/git.rb
+- lib/rubycritic/source_control_systems/git/churn.rb
 - lib/rubycritic/source_control_systems/mercurial.rb
 - lib/rubycritic/source_control_systems/perforce.rb
 - lib/rubycritic/source_locator.rb