rubycritic 4.3.2 → 4.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab394b4a8387f11c8c5a994c5e23aa59a49a57196c28501742947a4d375d9af7
-  data.tar.gz: 2010ea5086ad4f0b0f0dd967aa33605d2ebf240cb2fc1fc487d19935f60165bd
+  metadata.gz: 8955de9da7554418f70f6eecbf32b6c7dfc42c67791b99865c8bcfd9162a65a6
+  data.tar.gz: 7e87d6f2bb1b95f898b6ce3c0237434dc8f4cacf4486b5d78367b8f6d2995bfc
 SHA512:
-  metadata.gz: 02c8f325ebd8c28331147f46776ee1743a3b95ebbe59649a9246bf40831c9bcafc346ce75ae4bf084a2ec3fd22ad38b3a3d6dfe8ad3a76d4781366a1854339e2
-  data.tar.gz: 9e040206e4175574c45dfc19a17a31c62c7e79c14e67bc849e3dc7300307b1726af848f93fd0b668886ab2ed6c44aea7d1738a546f4a520c40b36c21d8a43586
+  metadata.gz: fe01a2dbb0d5c96643bd9ace5c6b76d1b6353722cb88c9916fd03360740f36dbf09f5de5a7e1e17c2efc2e94696e88add01e403ec8caeb1b875c3161a776624f
+  data.tar.gz: 1e804c7bc111a534840930ad4ecf608b3d616fd491881af4bc9f85678b6106481b13320ec5718567c254ba251fa093e5903b20b2bb5f84678721c3284ad24a77

data/CHANGELOG.md

@@ -1,4 +1,26 @@
-# master [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.3.2...master)
+# master [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.5.1...master)
+
+# v4.5.1 / 2020-06-29 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.5.0...v4.5.1)
+
+* [BUGFIX] Handle git --name-status Copied (C) operation (by [@rizalmuthi][])
+
+# v4.5.0 / 2020-05-14 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.4.1...v4.5.0)
+
+* [CHANGE] Relax `launchy` version dependency requirement
+* [CHANGE] Drop support for ruby 2.3 (by [@joshrpowell][])
+* [CHANGE] Update Reek dependency to '~> 6.0', '< 7.0' (by [@joshrpowell][])
+
+# v4.4.1 / 2020-02-20 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.4.0...v4.4.1)
+
+* [CHANGE] Rewrite how churn is calculated to make it faster
+
+# v4.4.0 / 2020-02-15 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.3.3...v4.4.0)
+
+* [FEATURE] Take into account the `.flayignore` file (by [@Flink][])
+
+# v4.3.3 / 2020-01-31 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.3.2...v4.3.3)
+
+* [BUGFIX] Relax constraint on `simplecov` gem (by [@etagwerker][])
 
 # v4.3.2 / 2020-01-27 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.3.1...v4.3.2)
 
@@ -321,3 +343,4 @@
 [@Adre]: https://github.com/Adre
 [@GeoffTidey]: https://github.com/GeoffTidey
 [@lloydwatkin]: https://github.com/lloydwatkin
+[@Flink]: https://github.com/Flink

data/README.md

@@ -216,10 +216,10 @@ See [formatters](docs/formatters.md)
 
 RubyCritic is supporting Ruby versions:
 
-* 2.3
 * 2.4
 * 2.5
 * 2.6
+* 2.7
 
 ## Improving RubyCritic
 

data/lib/rubycritic/analysers/helpers/flay.rb

@@ -6,6 +6,7 @@ module RubyCritic
   class Flay < ::Flay
     def initialize(paths)
       super()
+      paths = PathExpander.new([], '').filter_files(paths, DEFAULT_IGNORE)
       process(*paths)
       analyze
     end

data/lib/rubycritic/source_control_systems/git.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'tty/which'
+require 'rubycritic/source_control_systems/git/churn'
 
 module RubyCritic
   module SourceControlSystem
@@ -28,12 +29,16 @@ module RubyCritic
         'Git'
       end
 
+      def churn
+        @churn ||= Churn.new
+      end
+
       def revisions_count(path)
-        git("log --follow --format=%h #{path.shellescape}").count("\n")
+        churn.revisions_count(path)
       end
 
       def date_of_last_commit(path)
-        git("log -1 --date=iso --format=%ad #{path.shellescape}").chomp!
+        churn.date_of_last_commit(path)
       end
 
       def revision?

data/lib/rubycritic/source_control_systems/git/churn.rb

@@ -0,0 +1,87 @@
+# frozen_string_literal: true
+
+module RubyCritic
+  module SourceControlSystem
+    class Git < Base
+      Stats = Struct.new(:count, :date)
+
+      class Renames
+        def initialize
+          @data = {}
+        end
+
+        def renamed(from, to)
+          current = current(to)
+          @data[from] = current
+        end
+
+        def current(name)
+          @data.fetch(name, name)
+        end
+      end
+
+      class Churn
+        def initialize
+          @renames = Renames.new
+          @date = nil
+          @stats = {}
+
+          call
+        end
+
+        def revisions_count(path)
+          stats(path).count
+        end
+
+        def date_of_last_commit(path)
+          stats(path).date
+        end
+
+        private
+
+        def call
+          Git
+            .git("log --all --date=iso --follow --format='format:date:%x09%ad' --name-status .")
+            .split("\n")
+            .reject(&:empty?)
+            .each { |line| process_line(line) }
+        end
+
+        def process_line(line)
+          operation, *rest = line.split("\t")
+
+          case operation
+          when /^date:/
+            process_date(*rest)
+          when /^[RC]/
+            process_rename(*rest)
+          else
+            process_file(*rest)
+          end
+        end
+
+        def process_date(date)
+          @date = date
+        end
+
+        def process_rename(from, to)
+          @renames.renamed(from, to)
+          process_file(to)
+        end
+
+        def process_file(filename)
+          record_commit(@renames.current(filename), @date)
+        end
+
+        def record_commit(filename, date)
+          stats = @stats[filename] ||= Stats.new(0, date)
+          stats.count += 1
+        end
+
+        def stats(path)
+          @stats.fetch(path, Stats.new(0))
+        end
+      end
+    end
+  end
+end

data/lib/rubycritic/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RubyCritic
-  VERSION = '4.3.2'.freeze
+  VERSION = '4.5.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 4.3.2
+  version: 4.5.1
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-27 00:00:00.000000000 Z
+date: 2020-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flay
@@ -42,16 +42,16 @@ dependencies:
   name: launchy
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.3
+        version: 2.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.3
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement
@@ -86,20 +86,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: ruby_parser
   requirement: !ruby/object:Gem::Requirement
@@ -118,14 +118,14 @@ dependencies:
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.17.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.17.0
 - !ruby/object:Gem::Dependency
@@ -496,6 +496,7 @@ files:
 - lib/rubycritic/source_control_systems/base.rb
 - lib/rubycritic/source_control_systems/double.rb
 - lib/rubycritic/source_control_systems/git.rb
+- lib/rubycritic/source_control_systems/git/churn.rb
 - lib/rubycritic/source_control_systems/mercurial.rb
 - lib/rubycritic/source_control_systems/perforce.rb
 - lib/rubycritic/source_locator.rb
@@ -512,14 +513,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: RubyCritic is a Ruby code quality reporter