rubycritic 4.10.0 → 4.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ffa925049a3ca35743b419abfa744f93b7a4c7f3a5c6ee702703eff959c05177
-  data.tar.gz: 1349a8bf0b72de99e5d7415dc3fd59dbacfe93683a20c5e7c25285243a11f28e
+  metadata.gz: 157017151022a109530d1ffcd1e5dfba4426bc52402374b9c18783557babf73b
+  data.tar.gz: b131aa27676576517687cf8cbc32c1fa0faf99f309cb2c5dd398ec5e8d704ccb
 SHA512:
-  metadata.gz: b7487d521e1c7070d3cb30430e8d5ea023a2baad07a69a2d0e540ba28c014d7caef9b9727585b0731775281cde5a31f1f7a20fb46112e4eb86c6938f2b249fe2
-  data.tar.gz: eb343b8c57606946ccc3439275eb829c06cf52c3557f63661c85923a4b1a7babc587ba3bcdabf3297adc69a725ad62fde6c2cc0634890ba24176d89c599e9145
+  metadata.gz: 4c7278a159f2fb51b0f1398a38388c0e54ad2164c5ea35c34c5dad38d07219e09c63f92d3038fd091d786a1055e1df9f9bf8854139c6512177ac9068d8e9e131
+  data.tar.gz: 864313501b155e876fdb8b83c6cf9f079eb22c2b706ff1d7f93239b03069d965dc1bbc1250e05bd46bf716437f15a2a063cb6f83990c2e9ce849345d7eadf9a1

data/CHANGELOG.md

@@ -1,4 +1,24 @@
-# main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.9.2...main)
+# main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.11.0...main)
+
+* [CHANGE] ...
+* [BUGFIX] ...
+* [CHORE] ...
+* [FEATURE] ...
+
+# v4.12.0 / 2026-01-25 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.11.0...v4.12.0)
+
+* [CHANGE] Bump cucumber dependency (by [@faisal][])
+* [BUGFIX] Fixed regression in compatibility with Flog 4.9.0 (by [@faisal][])
+* [CHANGE] Bump mocha dependency (by [@faisal][])
+* [CHORE] Update CI checkout action to v6 (by [@faisal][]])
+* [CHORE] Uses prism instead of parser for Ruby 3.4 and above (by [@torresga][] and [@julioalucero][])
+* [BUGFIX] Respect excluded paths from .reek configuration file during reek analysis (by [@fbuys][])
+
+# v4.11.0 / 2025-10-15 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.10.0...v4.11.0)
+
+* [CHANGE] Bump cucumber dependency (by [@faisal][])
+* [CHANGE] Performance improvement for churn calculation: Memoize call to `git rev-parse --show-toplevel` for churn calculations (by [@mateusdeap][])
+* [CHANGE] Bump minitest dependency. (by [@faisal][])
 
 # v4.10.0 / 2025-07-30 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.9.2...v4.10.0)
 
@@ -23,6 +43,8 @@
 * [CHANGE] Fix some typos (by [@jbampton][])
 * [FEATURE] Add coverage_path configuration option (by [@exoego][])
 
+* [CHANGE] Add support for wildcard entries to the paths option in rubycritic.yml (by [@rishiain][])
+
 # v4.9.0 / 2023-10-18 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.8.1...v4.9.0)
 
 * [CHANGE] Bump aruba, cucumber, fakefs, flog, mdl, minitest, and rubocop dependencies (by [@faisal][])

data/README.md

@@ -154,6 +154,7 @@ minimum_score: 95 # default is 0
 paths: # Files to analyse. Churn calculation is scoped to these files when using Git SCM.
   - 'app/controllers/'
   - 'app/models/'
+  - 'lib/**'  # Wildcard patterns are supported (excludes tmp directories automatically)
 ```
 
 ### Analyzer Configuration
@@ -243,9 +244,9 @@ RubyCritic is supporting Ruby versions:
 | 2.4 | [v4.7.0](https://github.com/whitesmith/rubycritic/tree/v4.7.0) |
 | 2.5 | [v4.7.0](https://github.com/whitesmith/rubycritic/tree/v4.7.0) |
 | 2.6 | [v4.7.0](https://github.com/whitesmith/rubycritic/tree/v4.7.0) |
-| 2.7 | [v4.9.x](https://github.com/whitesmith/rubycritic/tree/v4.9.1) |
-| 3.0 | latest |
-| 3.1 | latest |
+| 2.7 | [v4.9.1](https://github.com/whitesmith/rubycritic/tree/v4.9.1) |
+| 3.0 | [v4.9.2](https://github.com/whitesmith/rubycritic/tree/v4.9.1) |
+| 3.1 | [v4.12.0](https://github.com/whitesmith/rubycritic/tree/v4.12.0) |
 | 3.2 | latest |
 | 3.3 | latest |
 

data/lib/rubycritic/analysers/helpers/flog.rb

@@ -11,7 +11,7 @@ module RubyCritic
     }.freeze
 
     def initialize
-      super(DEFAULT_OPTIONS)
+      super(DEFAULT_OPTIONS.clone(freeze: false))
     end
   end
 end

data/lib/rubycritic/analysers/helpers/parser.rb

@@ -1,14 +1,27 @@
 # frozen_string_literal: true
 
-require 'parser/current'
-require 'rubycritic/analysers/helpers/ast_node'
-
 module RubyCritic
   module Parser
     def self.parse(content)
-      ::Parser::CurrentRuby.parse(content) || AST::EmptyNode.new
+      parser = parser_class
+      require 'rubycritic/analysers/helpers/ast_node'
+      parser.parse(content) || AST::EmptyNode.new
     rescue ::Parser::SyntaxError
       AST::EmptyNode.new
     end
+
+    def self.parser_class
+      return @parser_class if defined?(@parser_class) && @parser_class
+
+      @parser_class =
+        if Gem::Version.new(RUBY_VERSION) <= '3.3'
+          require 'parser/current'
+          ::Parser::CurrentRuby
+        else
+          require 'prism'
+          ::Prism::Translation::ParserCurrent
+        end
+    end
+    private_class_method :parser_class
   end
 end

data/lib/rubycritic/analysers/smells/reek.rb

@@ -10,7 +10,7 @@ module RubyCritic
       include Colorize
 
       def initialize(analysed_modules)
-        @analysed_modules = analysed_modules
+        @analysed_modules = analysed_modules.reject { Reek.configuration.path_excluded?(_1.pathname) }
       end
 
       def run

data/lib/rubycritic/configuration.rb

@@ -21,11 +21,16 @@ module RubyCritic
       self.no_browser = options[:no_browser]
       self.coverage_path = options[:coverage_path]
       self.threshold_score = options[:threshold_score].to_i
+      setup_paths_for_targets(options) if options[:paths]
       setup_analysis_targets(options)
       setup_version_control(options)
       setup_formats(options)
     end
 
+    def setup_paths_for_targets(options)
+      options[:paths] = find_directories(options[:paths])
+    end
+
     def setup_analysis_targets(options)
       self.paths = options[:paths] || ['.']
       self.ruby_extensions = options[:ruby_extensions] || %w[.rb .rake .thor]
@@ -51,6 +56,20 @@ module RubyCritic
       source_control_system &&
         !source_control_system.is_a?(SourceControlSystem::Double)
     end
+
+    private
+
+    def find_directories(paths)
+      expanded_paths = paths.flat_map do |path|
+        if path.include?('**')
+          search_pattern = File.join(path)
+          Dir.glob(search_pattern).select { |tmp_path| File.directory?(tmp_path) && !tmp_path.start_with?('tmp') }
+        else
+          path
+        end
+      end
+      expanded_paths
+    end
   end
 
   module Config

data/lib/rubycritic/source_control_systems/git/churn.rb

@@ -123,7 +123,7 @@ module RubyCritic
         # :reek:DuplicateMethodCall
         def filename_for_subdirectory(filename)
           if @git_root == Dir.pwd
-            git_path = Git.git('rev-parse --show-toplevel')
+            git_path = git_top_level
             cd_path = Dir.pwd
             if cd_path.length > git_path.length
               filename = filename.sub(/^#{Regexp.escape("#{File.basename(cd_path)}/")}/, '')
@@ -134,6 +134,10 @@ module RubyCritic
           end
         end
 
+        def git_top_level
+          @git_top_level ||= Git.git('rev-parse --show-toplevel').strip
+        end
+
         def process_file(filename)
           record_commit(renames.current(filename), @date)
         end

data/lib/rubycritic/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RubyCritic
-  VERSION = '4.10.0'
+  VERSION = '4.12.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 4.10.0
+  version: 4.12.0
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-07-30 00:00:00.000000000 Z
+date: 2026-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flay
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.3.0.5
+- !ruby/object:Gem::Dependency
+  name: prism
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.6.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.6.0
 - !ruby/object:Gem::Dependency
   name: rainbow
   requirement: !ruby/object:Gem::Requirement
@@ -230,20 +244,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.0.0
-    - - "!="
+        version: 10.2.0
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 9.0.0
+        version: 10.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.0.0
-    - - "!="
+        version: 10.2.0
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 9.0.0
+        version: 10.1.0
 - !ruby/object:Gem::Dependency
   name: diff-lcs
   requirement: !ruby/object:Gem::Requirement
@@ -312,7 +326,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.25.2
+        version: 5.26.0
     - - ">="
       - !ruby/object:Gem::Version
         version: 5.3.0
@@ -322,7 +336,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.25.2
+        version: 5.26.0
     - - ">="
       - !ruby/object:Gem::Version
         version: 5.3.0
@@ -352,14 +366,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.7.1
+        version: 2.8.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.7.1
+        version: 2.8.0
 - !ruby/object:Gem::Dependency
   name: ostruct
   requirement: !ruby/object:Gem::Requirement
@@ -627,7 +641,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: RubyCritic is a Ruby code quality reporter