rubycritic 3.1.1 → 3.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0555c63872e8ba208eed9e2b2ba2e409b6bcc2af
-  data.tar.gz: 4ec5b4de84de9b3f9ab6c864d9cf1056f38c07b8
+  metadata.gz: f8f2f85163f5b08fc060734e2d5f0bd1a507a8a3
+  data.tar.gz: 96e256ad688633e3fcd70241ca88e83c2bd1b985
 SHA512:
-  metadata.gz: 652e9d64e4ac113cb346833907e4d05b289f98f236aaa52970b40f9d472b38bf56bcb48fff30fc31d4e4774f28740dbbfafc5950a75c356d6bc3894b0dbf00bc
-  data.tar.gz: 20d381594ebb3ab984e95e0d62b00086ea379f119bbbd63698c51439f8e8b7ce83145b5d9bfba57d1d5c4e2868dee0cea239d5b3ef40d961decae640de9d240f
+  metadata.gz: f01945bea4bab8706ecd0df163bc0295edc6f28d300b45aa91dac33af99888694b50d819d9cb072782afc2514d26b72815b53b886919534e4d797c82fa76072b
+  data.tar.gz: 2fdd9bece78a7604c76f5d0ddaf4a197000463eb1c42854603f6452ba663d875b98e6e9706916c5c81d7f1be69aa4e697b4dd6365856e0424a41e6815305e3f3

data/.travis.yml

@@ -5,9 +5,9 @@ before_install: gem update bundler
 matrix:
   include:
     - rvm: 2.1.0
-    - rvm: 2.1.10
-    - rvm: 2.2.5
-    - rvm: 2.3.1
+    - rvm: 2.1
+    - rvm: 2.2
+    - rvm: 2.3.3
     - rvm: ruby-head
     - rvm: jruby-9.1.5.0
       env: JRUBY_OPTS='--debug' # get more accurate coverage data

data/CHANGELOG.md

@@ -1,7 +1,13 @@
-# 3.1.1 / 2016-12-01
+# 3.1.2 / 2016-12-17
+
+* [BUGFIX] Fix lack of the GPA chart when used with rake/rails (by hoshinotsuyoshi)
+* [BUGFIX] Fix code navigation links in the new UI (by rohitcy)
+
+# 3.1.1 / 2016-12-02
 
 * [FEATURE] Implement search and filter on code and smells view (rohitcy)
 * [CHANGE] Use Ruby's File instead of `wc` system command (by tejasbubane)
+* [CHANGE] Add MRI 2.3.3 compatibility by updating `parser` to v2.3.3.1 (by josephpage)
 * [BUGFIX] Fix code navigation links in the new UI (by rohitcy)
 * [BUGFIX] Add missing method 'head_reference' for Perforce source control (Rataah)
 

data/lib/rubycritic/configuration.rb

@@ -1,4 +1,6 @@
 # frozen_string_literal: true
+require 'rubycritic/source_control_systems/base'
+
 module RubyCritic
   class Configuration
     attr_reader :root
@@ -18,6 +20,11 @@ module RubyCritic
     def root=(path)
       @root = File.expand_path(path)
     end
+
+    def source_control_present?
+      source_control_system &&
+        !source_control_system.is_a?(SourceControlSystem::Double)
+    end
   end
 
   module Config

data/lib/rubycritic/generators/html/templates/overview.html.erb

@@ -20,12 +20,16 @@
         <!--Churn vs Complexity graph-->
         <div class="col-xs-7 col-sm-7 col-md-6 col-lg-8">
           <div class="Graph_Cards fadeIn">
+            <% if Config.source_control_present? %>
+              <div id="churn-vs-complexity-graph-container" class="chart-container"></div>
+            <% else %>
+              <div id="churn-error">We can't show you Churn-vs-Complexity graph because this project does not seem to be under a source code management system like git or perforce at the moment. This doesn't mean that anything is wrong, it just means certain features like this one are not avaiable.</div>
+            <% end %>
 
-          <div id="churn-vs-complexity-graph-container" class="chart-container"></div>
-          <script type="text/javascript">
-            var turbulenceData = <%= @turbulence_data %>;
-            var score = <%= @score %>;
-          </script>
+            <script type="text/javascript">
+             var turbulenceData = <%= @turbulence_data %>;
+             var score = <%= @score %>;
+            </script>
           </div>
         </div>
         <!--End Churn vs Complexity graph-->

data/lib/rubycritic/generators/html/turbulence.rb

@@ -8,7 +8,7 @@ module RubyCritic
           name: analysed_module.name,
           x: analysed_module.churn,
           y: analysed_module.complexity,
-          rating: analysed_module.rating
+          rating: analysed_module.rating.to_s
         }
       end.to_json
     end

data/lib/rubycritic/source_control_systems/base.rb

@@ -19,7 +19,9 @@ module RubyCritic
         if supported_system
           supported_system.new
         else
-          puts "RubyCritic can provide more feedback if you use a #{connected_system_names} repository."
+          puts 'RubyCritic can provide more feedback if you use '\
+               "a #{connected_system_names} repository. "\
+               'Churn will not be calculated.'
           Double.new
         end
       end

data/lib/rubycritic/source_control_systems/double.rb

@@ -3,7 +3,7 @@ module RubyCritic
   module SourceControlSystem
     class Double < Base
       def revisions_count(_)
-        'N/A'
+        0
       end
 
       def date_of_last_commit(_)

data/lib/rubycritic/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RubyCritic
-  VERSION = '3.1.1'.freeze
+  VERSION = '3.1.2'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 3.1.2
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-02 00:00:00.000000000 Z
+date: 2016-12-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -493,4 +493,3 @@ test_files:
 - test/samples/reek/smelly.rb
 - test/samples/unparsable.rb
 - test/test_helper.rb
-has_rdoc: