rubycritic 2.9.4 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ec33a1c32385f0cbfdefeaa9129d913496b1ae5c
-  data.tar.gz: dee2aa84cf1b44b413d269c9f245376922a20519
+  metadata.gz: 9808a80e4acec1d11ff047566ab93b3f9970fbf8
+  data.tar.gz: 9aa277fd09847ff8164136143821fe756922f30b
 SHA512:
-  metadata.gz: 1a5d63349c3a3cf426b70edfb3ffc5bf28a6c6d469fd4e725aed83633e7b6e0d3ccc7ab708c9fabaabb73afb4e7984b08b00885456f6c2bf1499248b84f3bbe5
-  data.tar.gz: afe13be04b5e8cf03258f08fb1cb82403a99e41afa092bdc26e57a4e254d850ee5e047a2739e0e48a1032b54c680c8061c260fcead134439308d067c034aa864
+  metadata.gz: 99ed2a9703e405fa3cf562f44e10a577a5d03b2c1a12738ad5dfbb677afbff6a4b0729ef1a0c21ba7030214e463d8d43f4a2f9021cc8027bf1681076b3a1daee
+  data.tar.gz: 7347e0315bb8964d3e19815538176117045cf0900f9796917efcd186e5cbbeffb0de0640127ecb7447e3e39d5173cd1efb298d372589d1f34170a44b49c0861a

data/.rubocop.yml

@@ -7,6 +7,10 @@ AllCops:
   Exclude:
     - 'test/samples/**/*'
     - 'tmp/**/*'
+    - 'vendor/**/*'
+
+Metrics/BlockLength:
+  Enabled: false
 
 Metrics/LineLength:
   Max: 120

data/.todo.reek

@@ -133,9 +133,10 @@ UncommunicativeParameterName:
   - RubyCritic::Location#to_json
   - RubyCritic::Rating#to_json
   - RubyCritic::Smell#to_json
+  - Theon # This is needed for the tests to pass
 ClassVariable:
   exclude:
   - RubyCritic::SourceControlSystem::Base
-BooleanParameter: 
+BooleanParameter:
   exclude:
   - RubyCritic::Config#self.respond_to_missing?

data/.travis.yml

@@ -1,25 +1,20 @@
 sudo: false
 language: ruby
-
-rvm:
-  - 2.1.8
-  - 2.2.4
-  - 2.3.0
-  - ruby-head
-  - jruby-9.0.5.0
-  - rbx-3
-
-env:
-  # this doesn't do anything for MRI or RBX, but it doesn't hurt them either
-  # for JRuby, it enables us to get more accurate coverage data
-  - JRUBY_OPTS="--debug"
-
+cache: bundler
+before_install: gem update bundler
 matrix:
+  include:
+    - rvm: 2.1.0
+    - rvm: 2.1.10
+    - rvm: 2.2.5
+    - rvm: 2.3.1
+    - rvm: ruby-head
+    - rvm: jruby-9.1.5.0
+      env: JRUBY_OPTS='--debug' # get more accurate coverage data
+    - rvm: rbx-3
   allow_failures:
     - rvm: ruby-head
-    - rvm: jruby-9.0.5.0
+    - rvm: jruby-9.1.5.0
     - rvm: rbx-3
   fast_finish: true
-
-before_install: gem update bundler
 script: bundle exec rake

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 3.0.0 / 2016-11-01
+
+* [CHANGE] Set required ruby version to 2.1 (by Onumis)
+* [BUGFIX] Respect the .reek configuration file (by mereghost)
 
 # 2.9.4 / 2016-09-16
 

data/lib/rubycritic/analysers/helpers/reek.rb

@@ -3,5 +3,8 @@ require 'reek'
 
 module RubyCritic
   class Reek < ::Reek::Examiner
+    def initialize(analysed_module)
+      super(analysed_module, configuration: ::Reek::Configuration::AppConfiguration.from_path)
+    end
   end
 end

data/lib/rubycritic/generators/text/list.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-require 'colorize'
+require 'rainbow'
 
 module RubyCritic
   module Generator

data/lib/rubycritic/generators/text/templates/list.erb

@@ -1,5 +1,5 @@
-<%= @analysed_module.name.colorize(color) %>:
-  Rating:       <%= @analysed_module.rating.to_s.colorize(color) %>
+<%= Rainbow(@analysed_module.name.to_s).foreground(color) %>:
+  Rating:       <%= Rainbow(@analysed_module.rating.to_s).foreground(color) %>
   Churn:        <%= @analysed_module.churn %>
   Complexity:   <%= @analysed_module.complexity %>
   Duplication:  <%= @analysed_module.duplication %>

data/lib/rubycritic/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RubyCritic
-  VERSION = '2.9.4'.freeze
+  VERSION = '3.0.0'.freeze
 end

data/rubycritic.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
   spec.summary       = 'RubyCritic is a Ruby code quality reporter'
   spec.homepage      = 'https://github.com/whitesmith/rubycritic'
   spec.license       = 'MIT'
-  spec.required_ruby_version = '>= 2.0.0'
+  spec.required_ruby_version = '>= 2.1.0'
 
   spec.files         = `git ls-files`.split("\n")
   spec.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'reek', '~> 4.4'
   spec.add_runtime_dependency 'parser', '2.3.1.2'
   spec.add_runtime_dependency 'ruby_parser', '~> 3.8'
-  spec.add_runtime_dependency 'colorize'
+  spec.add_runtime_dependency 'rainbow'
   spec.add_runtime_dependency 'launchy', '2.4.3'
 
   spec.add_development_dependency 'aruba'
@@ -38,5 +38,4 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'minitest', '~> 5.3'
   spec.add_development_dependency 'mocha', '~> 1.1'
   spec.add_development_dependency 'rubocop', '>= 0.42.0'
-  spec.add_development_dependency 'pry-byebug'
 end

data/test/lib/rubycritic/analysers/smells/reek_test.rb

@@ -15,6 +15,11 @@ describe RubyCritic::Analyser::ReekSmells do
       @analysed_module.smells.length.must_equal 2
     end
 
+    it 'respects the .reek file' do
+      messages = @analysed_module.smells.map(&:message)
+      messages.wont_include "has the parameter name 'a'"
+    end
+
     it 'creates smells with messages' do
       first_smell = @analysed_module.smells.first
       first_smell.message.must_equal "has boolean parameter 'reek'"

data/test/samples/reek/smelly.rb

@@ -2,6 +2,10 @@ class Theon
   def reeks?(reek = true)
     reek
   end
+
+  def flayed?(a)
+    a
+  end
 end
 
 # Reek should report
@@ -10,3 +14,4 @@ end
 # This comment is below the module because otherwise Reek will interpret this
 # as a comment describing the module which would thus prevent
 # IrresponsibleModule from being reported.
+# It should ignore the UncommunicativeParameterName as it's on the .todo.reek

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 2.9.4
+  version: 3.0.0
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-16 00:00:00.000000000 Z
+date: 2016-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -95,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.8'
 - !ruby/object:Gem::Dependency
-  name: colorize
+  name: rainbow
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -234,20 +234,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.42.0
-- !ruby/object:Gem::Dependency
-  name: pry-byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: RubyCritic is a tool that wraps around various static analysis gems to
   provide a quality report of your Ruby code.
 email:
@@ -412,7 +398,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -420,7 +406,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: RubyCritic is a Ruby code quality reporter
@@ -472,3 +458,4 @@ test_files:
 - test/samples/reek/smelly.rb
 - test/samples/unparsable.rb
 - test/test_helper.rb
+has_rdoc: 

data/test/samples/location/file0_symlink.rb

@@ -1 +0,0 @@
-file0.rb