rubycritic 2.9.2 → 2.9.3

data/lib/rubycritic/commands/default.rb

@@ -4,7 +4,7 @@ require 'rubycritic/revision_comparator'
 require 'rubycritic/reporter'
 require 'rubycritic/commands/base'
 
-module Rubycritic
+module RubyCritic
   module Command
     class Default < Base
       def initialize(options)

data/lib/rubycritic/commands/help.rb

@@ -1,6 +1,6 @@
 require 'rubycritic/commands/base'
 
-module Rubycritic
+module RubyCritic
   module Command
     class Help < Base
       def execute

data/lib/rubycritic/commands/status_reporter.rb

@@ -1,4 +1,4 @@
-module Rubycritic
+module RubyCritic
   module Command
     class StatusReporter
       attr_reader :status, :status_message

data/lib/rubycritic/commands/version.rb

@@ -1,7 +1,7 @@
 require 'rubycritic/version'
 require 'rubycritic/commands/base'
 
-module Rubycritic
+module RubyCritic
   module Command
     class Version < Base
       def execute

data/lib/rubycritic/configuration.rb

@@ -1,4 +1,4 @@
-module Rubycritic
+module RubyCritic
   class Configuration
     attr_reader :root
     attr_accessor :source_control_system, :mode, :format, :deduplicate_symlinks,
@@ -31,5 +31,9 @@ module Rubycritic
     def self.method_missing(method, *args, &block)
       configuration.public_send(method, *args, &block)
     end
+
+    def self.respond_to_missing?(symbol, include_all = false)
+      configuration.respond_to_missing?(symbol) || super
+    end
   end
 end

data/lib/rubycritic/core/analysed_module.rb

@@ -1,7 +1,7 @@
 require 'virtus'
 require 'rubycritic/core/rating'
 
-module Rubycritic
+module RubyCritic
   class AnalysedModule
     include Virtus.model
 
@@ -27,7 +27,7 @@ module Rubycritic
     end
 
     def complexity_per_method
-      if methods_count == 0
+      if methods_count.zero?
         'N/A'
       else
         complexity.fdiv(methods_count).round(1)

data/lib/rubycritic/core/analysed_modules_collection.rb

@@ -1,7 +1,7 @@
 require 'rubycritic/source_locator'
 require 'rubycritic/core/analysed_module'
 
-module Rubycritic
+module RubyCritic
   class AnalysedModulesCollection
     include Enumerable
 

data/lib/rubycritic/core/location.rb

@@ -1,6 +1,6 @@
 require 'pathname'
 
-module Rubycritic
+module RubyCritic
   class Location
     attr_reader :pathname, :line
 

data/lib/rubycritic/core/rating.rb

@@ -1,4 +1,4 @@
-module Rubycritic
+module RubyCritic
   class Rating
     def self.from_cost(cost)
       if    cost <= 2  then new('A')

data/lib/rubycritic/core/smell.rb

@@ -1,7 +1,7 @@
 require 'virtus'
 require 'rubycritic/core/location'
 
-module Rubycritic
+module RubyCritic
   class Smell
     include Virtus.model
 

data/lib/rubycritic/generators/console_report.rb

@@ -1,6 +1,6 @@
 require 'rubycritic/generators/text/list'
 
-module Rubycritic
+module RubyCritic
   module Generator
     class ConsoleReport
       def initialize(analysed_modules)

data/lib/rubycritic/generators/html/assets/javascripts/jquery-2.1.0.js

@@ -9108,4 +9108,4 @@ if ( typeof noGlobal === strundefined ) {
 
 return jQuery;
 
-}));
+}));

data/lib/rubycritic/generators/html/base.rb

@@ -2,7 +2,7 @@ require 'erb'
 require 'pathname'
 require 'rubycritic/generators/html/view_helpers'
 
-module Rubycritic
+module RubyCritic
   module Generator
     module Html
       class Base

data/lib/rubycritic/generators/html/code_file.rb

@@ -1,7 +1,7 @@
 require 'rubycritic/generators/html/base'
 require 'rubycritic/generators/html/line'
 
-module Rubycritic
+module RubyCritic
   module Generator
     module Html
       class CodeFile < Base

data/lib/rubycritic/generators/html/code_index.rb

@@ -1,6 +1,6 @@
 require 'rubycritic/generators/html/base'
 
-module Rubycritic
+module RubyCritic
   module Generator
     module Html
       class CodeIndex < Base

data/lib/rubycritic/generators/html/line.rb

@@ -1,7 +1,7 @@
 require 'cgi'
 require 'rubycritic/generators/html/base'
 
-module Rubycritic
+module RubyCritic
   module Generator
     module Html
       class Line < Base

data/lib/rubycritic/generators/html/overview.rb

@@ -1,7 +1,7 @@
 require 'rubycritic/generators/html/base'
 require 'rubycritic/generators/html/turbulence'
 
-module Rubycritic
+module RubyCritic
   module Generator
     module Html
       class Overview < Base

data/lib/rubycritic/generators/html/smells_index.rb

@@ -1,6 +1,6 @@
 require 'rubycritic/generators/html/base'
 
-module Rubycritic
+module RubyCritic
   module Generator
     module Html
       class SmellsIndex < Base

data/lib/rubycritic/generators/html/turbulence.rb

@@ -1,6 +1,6 @@
 require 'json'
 
-module Rubycritic
+module RubyCritic
   module Turbulence
     def self.data(analysed_modules)
       analysed_modules.map do |analysed_module|

data/lib/rubycritic/generators/html/view_helpers.rb

@@ -1,4 +1,4 @@
-module Rubycritic
+module RubyCritic
   module ViewHelpers
     def timeago_tag(time)
       "<time class='js-timeago' datetime='#{time}'>#{time}</time>"

data/lib/rubycritic/generators/html_report.rb

@@ -5,7 +5,7 @@ require 'rubycritic/generators/html/smells_index'
 require 'rubycritic/generators/html/code_index'
 require 'rubycritic/generators/html/code_file'
 
-module Rubycritic
+module RubyCritic
   module Generator
     class HtmlReport
       ASSETS_DIR = File.expand_path('../html/assets', __FILE__)
@@ -22,7 +22,7 @@ module Rubycritic
       end
 
       def browser
-        @browser ||= Rubycritic::Browser.new(report_location)
+        @browser ||= RubyCritic::Browser.new(report_location)
       end
 
       private

data/lib/rubycritic/generators/json/simple.rb

@@ -1,7 +1,8 @@
 require 'json'
 require 'rubycritic/version'
+require 'pathname'
 
-module Rubycritic
+module RubyCritic
   module Generator
     module Json
       class Simple
@@ -9,6 +10,8 @@ module Rubycritic
           @analysed_modules = analysed_modules
         end
 
+        FILE_NAME = 'report.json'.freeze
+
         def render
           JSON.dump(data)
         end
@@ -17,13 +20,21 @@ module Rubycritic
           {
             metadata: {
               rubycritic: {
-                version: Rubycritic::VERSION
+                version: RubyCritic::VERSION
               }
             },
             analysed_modules: @analysed_modules,
             score: @analysed_modules.score
           }
         end
+
+        def file_directory
+          @file_directory ||= Pathname.new(Config.root)
+        end
+
+        def file_pathname
+          Pathname.new(file_directory).join FILE_NAME
+        end
       end
     end
   end

data/lib/rubycritic/generators/json_report.rb

@@ -1,6 +1,6 @@
 require 'rubycritic/generators/json/simple'
 
-module Rubycritic
+module RubyCritic
   module Generator
     class JsonReport
       def initialize(analysed_modules)
@@ -8,7 +8,10 @@ module Rubycritic
       end
 
       def generate_report
-        print generator.render
+        FileUtils.mkdir_p(generator.file_directory)
+        File.open(generator.file_pathname, 'w+') do |file|
+          file.write(generator.render)
+        end
       end
 
       private

data/lib/rubycritic/generators/text/list.rb

@@ -1,6 +1,6 @@
 require 'colorize'
 
-module Rubycritic
+module RubyCritic
   module Generator
     module Text
       class List

data/lib/rubycritic/rake_task.rb

@@ -3,7 +3,7 @@ require 'rake/tasklib'
 require 'English'
 require 'rubycritic/cli/application'
 
-module Rubycritic
+module RubyCritic
   #
   # A rake task that runs RubyCritic on a set of source files.
   #
@@ -58,7 +58,7 @@ module Rubycritic
         puts "\n\n!!! Running `#{name}` rake command\n"
         puts "!!! Inspecting #{paths} #{options.empty? ? '' : "with options #{options}"}\n\n"
       end
-      application = Rubycritic::Cli::Application.new(options_as_arguments + paths)
+      application = RubyCritic::Cli::Application.new(options_as_arguments + paths)
       application.execute
     end
 

data/lib/rubycritic/reporter.rb

@@ -1,4 +1,4 @@
-module Rubycritic
+module RubyCritic
   module Reporter
     def self.generate_report(analysed_modules)
       report_generator_class.new(analysed_modules).generate_report

data/lib/rubycritic/revision_comparator.rb

@@ -6,7 +6,7 @@ require 'rubycritic/smells_status_setter'
 require 'rubycritic/version'
 require 'digest/md5'
 
-module Rubycritic
+module RubyCritic
   class RevisionComparator
     SNAPSHOTS_DIR_NAME = 'snapshots'.freeze
 

data/lib/rubycritic/serializer.rb

@@ -1,6 +1,6 @@
 require 'fileutils'
 
-module Rubycritic
+module RubyCritic
   class Serializer
     def initialize(file)
       @file = file

data/lib/rubycritic/smells_status_setter.rb

@@ -1,4 +1,4 @@
-module Rubycritic
+module RubyCritic
   module SmellsStatusSetter
     def self.set(smells_before, smells_now)
       old_smells = smells_now & smells_before

data/lib/rubycritic/source_control_systems/base.rb

@@ -1,6 +1,6 @@
 require 'shellwords'
 
-module Rubycritic
+module RubyCritic
   module SourceControlSystem
     class Base
       @@systems = []

data/lib/rubycritic/source_control_systems/double.rb

@@ -1,4 +1,4 @@
-module Rubycritic
+module RubyCritic
   module SourceControlSystem
     class Double < Base
       def revisions_count(_)

data/lib/rubycritic/source_control_systems/git.rb

@@ -1,4 +1,4 @@
-module Rubycritic
+module RubyCritic
   module SourceControlSystem
     class Git < Base
       register_system

data/lib/rubycritic/source_control_systems/mercurial.rb

@@ -1,4 +1,4 @@
-module Rubycritic
+module RubyCritic
   module SourceControlSystem
     class Mercurial < Base
       register_system

data/lib/rubycritic/source_locator.rb

@@ -2,7 +2,7 @@
 
 require 'pathname'
 
-module Rubycritic
+module RubyCritic
   class SourceLocator
     RUBY_EXTENSION = '.rb'.freeze
     RUBY_FILES = File.join('**', "*#{RUBY_EXTENSION}")

data/lib/rubycritic/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
-module Rubycritic
-  VERSION = '2.9.2'.freeze
+module RubyCritic
+  VERSION = '2.9.3'.freeze
 end

data/lib/rubycritic.rb

@@ -1,4 +1,4 @@
 require 'rubycritic/command_factory'
 
-module Rubycritic
+module RubyCritic
 end

data/rubycritic.gemspec

@@ -5,7 +5,7 @@ require 'rubycritic/version'
 
 Gem::Specification.new do |spec|
   spec.name          = 'rubycritic'
-  spec.version       = Rubycritic::VERSION
+  spec.version       = RubyCritic::VERSION
   spec.authors       = ['Guilherme Simoes']
   spec.email         = ['guilherme.rdems@gmail.com']
   spec.description   = 'RubyCritic is a tool that wraps around various static analysis gems '\
@@ -32,6 +32,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'aruba'
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'cucumber'
+  spec.add_development_dependency 'fakefs'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'minitest', '~> 5.3'
   spec.add_development_dependency 'mocha', '~> 1.1'

data/test/lib/rubycritic/analysers/churn_test.rb

@@ -2,12 +2,12 @@ require 'analysers_test_helper'
 require 'rubycritic/analysers/churn'
 require 'rubycritic/source_control_systems/base'
 
-describe Rubycritic::Analyser::Churn do
+describe RubyCritic::Analyser::Churn do
   context 'when analysing a file' do
     before do
       @analysed_module = AnalysedModuleDouble.new(path: 'path_to_some_file.rb')
       analysed_modules = [@analysed_module]
-      analyser = Rubycritic::Analyser::Churn.new(analysed_modules)
+      analyser = RubyCritic::Analyser::Churn.new(analysed_modules)
       analyser.source_control_system = SourceControlSystemDouble.new
       analyser.run
     end
@@ -22,7 +22,7 @@ describe Rubycritic::Analyser::Churn do
   end
 end
 
-class SourceControlSystemDouble < Rubycritic::SourceControlSystem::Base
+class SourceControlSystemDouble < RubyCritic::SourceControlSystem::Base
   def revisions_count(_path)
     1 # churn
   end

data/test/lib/rubycritic/analysers/complexity_test.rb

@@ -1,12 +1,12 @@
 require 'analysers_test_helper'
 require 'rubycritic/analysers/complexity'
 
-describe Rubycritic::Analyser::Complexity do
+describe RubyCritic::Analyser::Complexity do
   context 'when analysing a file' do
     before do
       @analysed_module = AnalysedModuleDouble.new(path: 'test/samples/flog/complex.rb', smells: [])
       analysed_modules = [@analysed_module]
-      Rubycritic::Analyser::Complexity.new(analysed_modules).run
+      RubyCritic::Analyser::Complexity.new(analysed_modules).run
     end
 
     it 'calculates its complexity' do

data/test/lib/rubycritic/analysers/helpers/methods_counter_test.rb

@@ -1,19 +1,19 @@
 require 'analysers_test_helper'
 require 'rubycritic/analysers/helpers/methods_counter'
 
-describe Rubycritic::MethodsCounter do
+describe RubyCritic::MethodsCounter do
   describe '#count' do
     context 'when a file contains Ruby code' do
       it 'calculates the number of methods' do
         analysed_module = AnalysedModuleDouble.new(path: 'test/samples/methods_count.rb')
-        Rubycritic::MethodsCounter.new(analysed_module).count.must_equal 2
+        RubyCritic::MethodsCounter.new(analysed_module).count.must_equal 2
       end
     end
 
     context 'when a file is empty' do
       it 'returns 0 as the number of methods' do
         analysed_module = AnalysedModuleDouble.new(path: 'test/samples/empty.rb')
-        Rubycritic::MethodsCounter.new(analysed_module).count.must_equal 0
+        RubyCritic::MethodsCounter.new(analysed_module).count.must_equal 0
       end
     end
 
@@ -21,7 +21,7 @@ describe Rubycritic::MethodsCounter do
       it 'does not blow up and returns 0 as the number of methods' do
         analysed_module = AnalysedModuleDouble.new(path: 'test/samples/unparsable.rb')
         capture_output_streams do
-          Rubycritic::MethodsCounter.new(analysed_module).count.must_equal 0
+          RubyCritic::MethodsCounter.new(analysed_module).count.must_equal 0
         end
       end
     end

data/test/lib/rubycritic/analysers/helpers/modules_locator_test.rb

@@ -3,49 +3,49 @@ require 'rubycritic/analysers/helpers/modules_locator'
 require 'rubycritic/core/analysed_module'
 require 'pathname'
 
-describe Rubycritic::ModulesLocator do
+describe RubyCritic::ModulesLocator do
   describe '#names' do
     context 'when a file contains Ruby code' do
       it 'returns the names of all the classes and modules inside the file' do
-        analysed_module = Rubycritic::AnalysedModule.new(
+        analysed_module = RubyCritic::AnalysedModule.new(
           pathname: Pathname.new('test/samples/module_names.rb'),
           methods_count: 1
         )
-        Rubycritic::ModulesLocator.new(analysed_module).names
+        RubyCritic::ModulesLocator.new(analysed_module).names
                                   .must_equal ['Foo', 'Foo::Bar', 'Foo::Baz', 'Foo::Qux', 'Foo::Quux::Corge']
       end
     end
 
     context 'when a file is empty' do
       it 'returns the name of the file titleized' do
-        analysed_module = Rubycritic::AnalysedModule.new(
+        analysed_module = RubyCritic::AnalysedModule.new(
           pathname: Pathname.new('test/samples/empty.rb'),
           methods_count: 1
         )
-        Rubycritic::ModulesLocator.new(analysed_module).names.must_equal ['Empty']
+        RubyCritic::ModulesLocator.new(analysed_module).names.must_equal ['Empty']
       end
     end
 
     context 'when a file is unparsable' do
       it 'does not blow up and returns the name of the file titleized' do
-        analysed_module = Rubycritic::AnalysedModule.new(
+        analysed_module = RubyCritic::AnalysedModule.new(
           pathname: Pathname.new('test/samples/unparsable.rb'),
           methods_count: 1
         )
         capture_output_streams do
-          Rubycritic::ModulesLocator.new(analysed_module).names.must_equal ['Unparsable']
+          RubyCritic::ModulesLocator.new(analysed_module).names.must_equal ['Unparsable']
         end
       end
     end
 
     context 'when a file has no methods' do
       it 'returns the names of all the classes and modules inside the file' do
-        analysed_module = Rubycritic::AnalysedModule.new(
+        analysed_module = RubyCritic::AnalysedModule.new(
           pathname: Pathname.new('test/samples/no_methods.rb'),
           methods_count: 0
         )
         capture_output_streams do
-          Rubycritic::ModulesLocator.new(analysed_module).names.must_equal ['Foo::NoMethods']
+          RubyCritic::ModulesLocator.new(analysed_module).names.must_equal ['Foo::NoMethods']
         end
       end
     end

data/test/lib/rubycritic/analysers/smells/flay_test.rb

@@ -3,14 +3,14 @@ require 'rubycritic/analysers/smells/flay'
 require 'rubycritic/core/analysed_module'
 require 'pathname'
 
-describe Rubycritic::Analyser::FlaySmells do
+describe RubyCritic::Analyser::FlaySmells do
   context 'when analysing a bunch of files with duplicate code' do
     before do
       @analysed_modules = [
-        Rubycritic::AnalysedModule.new(pathname: Pathname.new('test/samples/flay/smelly.rb')),
-        Rubycritic::AnalysedModule.new(pathname: Pathname.new('test/samples/flay/smelly2.rb'))
+        RubyCritic::AnalysedModule.new(pathname: Pathname.new('test/samples/flay/smelly.rb')),
+        RubyCritic::AnalysedModule.new(pathname: Pathname.new('test/samples/flay/smelly2.rb'))
       ]
-      Rubycritic::Analyser::FlaySmells.new(@analysed_modules).run
+      RubyCritic::Analyser::FlaySmells.new(@analysed_modules).run
     end
 
     it 'detects its smells' do

data/test/lib/rubycritic/analysers/smells/flog_test.rb

@@ -1,12 +1,12 @@
 require 'analysers_test_helper'
 require 'rubycritic/analysers/smells/flog'
 
-describe Rubycritic::Analyser::FlogSmells do
+describe RubyCritic::Analyser::FlogSmells do
   context 'when analysing a complex file' do
     before do
       @analysed_module = AnalysedModuleDouble.new(path: 'test/samples/flog/smelly.rb', smells: [])
       analysed_modules = [@analysed_module]
-      Rubycritic::Analyser::FlogSmells.new(analysed_modules).run
+      RubyCritic::Analyser::FlogSmells.new(analysed_modules).run
     end
 
     it 'detects its smells' do

data/test/lib/rubycritic/analysers/smells/reek_test.rb

@@ -1,13 +1,13 @@
 require 'analysers_test_helper'
 require 'rubycritic/analysers/smells/reek'
 
-describe Rubycritic::Analyser::ReekSmells do
+describe RubyCritic::Analyser::ReekSmells do
   context 'when analysing a smelly file' do
     before do
       pathname = Pathname.new('test/samples/reek/smelly.rb')
       @analysed_module = AnalysedModuleDouble.new(pathname: pathname, smells: [])
       analysed_modules = [@analysed_module]
-      Rubycritic::Analyser::ReekSmells.new(analysed_modules).run
+      RubyCritic::Analyser::ReekSmells.new(analysed_modules).run
     end
 
     it 'detects its smells' do

data/test/lib/rubycritic/browser_test.rb

@@ -1,10 +1,10 @@
 require 'test_helper'
 require 'rubycritic/browser'
 
-describe Rubycritic::Browser do
+describe RubyCritic::Browser do
   before do
     @report_path = 'tmp/rubycritic/overview.html'
-    @browser = Rubycritic::Browser.new @report_path
+    @browser = RubyCritic::Browser.new @report_path
   end
 
   describe '#open' do

data/test/lib/rubycritic/commands/status_reporter_test.rb

@@ -2,15 +2,15 @@ require 'test_helper'
 require 'rubycritic/commands/status_reporter'
 require 'rubycritic/cli/options'
 
-describe Rubycritic::Command::StatusReporter do
-  let(:success_status) { Rubycritic::Command::StatusReporter::SUCCESS }
-  let(:score_below_minimum) { Rubycritic::Command::StatusReporter::SCORE_BELOW_MINIMUM }
+describe RubyCritic::Command::StatusReporter do
+  let(:success_status) { RubyCritic::Command::StatusReporter::SUCCESS }
+  let(:score_below_minimum) { RubyCritic::Command::StatusReporter::SCORE_BELOW_MINIMUM }
 
   describe 'with default options' do
     before do
-      @options = Rubycritic::Cli::Options.new([])
+      @options = RubyCritic::Cli::Options.new([])
       @options.parse
-      @reporter = Rubycritic::Command::StatusReporter.new(@options.to_h)
+      @reporter = RubyCritic::Command::StatusReporter.new(@options.to_h)
     end
 
     it 'has a default' do
@@ -33,9 +33,9 @@ describe Rubycritic::Command::StatusReporter do
 
   describe 'with minimum-score option' do
     before do
-      @options = Rubycritic::Cli::Options.new(['-s', '99'])
+      @options = RubyCritic::Cli::Options.new(['-s', '99'])
       @options.parse
-      @reporter = Rubycritic::Command::StatusReporter.new(@options.to_h)
+      @reporter = RubyCritic::Command::StatusReporter.new(@options.to_h)
     end
 
     it 'has a default' do