rubycritic 1.0.2 → 1.1.0

data/lib/rubycritic/analysers/adapters/ast_node.rb

@@ -1,35 +0,0 @@
-module Parser
-  module AST
-
-    class Node
-      def count_nodes_of_type(*types)
-        count = 0
-        recursive_children do |child|
-          count += 1 if types.include?(child.type)
-        end
-        count
-      end
-
-      def recursive_children
-        children.each do |child|
-          next unless child.is_a?(Parser::AST::Node)
-          yield child
-          child.recursive_children { |grand_child| yield grand_child }
-        end
-      end
-    end
-
-  end
-end
-
-module Rubycritic
-  module AST
-
-    class EmptyNode
-      def count_nodes_of_type(*types)
-        0
-      end
-    end
-
-  end
-end

data/lib/rubycritic/analysers/stats.rb

@@ -1,34 +0,0 @@
-require "parser/current"
-require "rubycritic/analysers/adapters/ast_node"
-
-module Rubycritic
-  module Analyser
-
-    class Stats
-      def initialize(analysed_files)
-        @analysed_files = analysed_files
-      end
-
-      def run
-        @analysed_files.each do |analysed_file|
-          analysed_file.methods_count = methods_count(analysed_file.path)
-        end
-      end
-
-      private
-
-      def methods_count(path)
-        content = File.read(path)
-        node = parse_content(content)
-        node.count_nodes_of_type(:def, :defs)
-      end
-
-      def parse_content(content)
-        Parser::CurrentRuby.parse(content) || AST::EmptyNode.new
-      rescue Parser::SyntaxError => error
-        AST::EmptyNode.new
-      end
-    end
-
-  end
-end

data/lib/rubycritic/files_initializer.rb

@@ -1,15 +0,0 @@
-require "rubycritic/source_locator"
-require "rubycritic/core/analysed_file"
-
-module Rubycritic
-
-  module FilesInitializer
-    def self.init(paths)
-      source = SourceLocator.new(paths)
-      source.pathnames.map do |pathname|
-        AnalysedFile.new(:pathname => pathname, :smells => [], :duplication => 0)
-      end
-    end
-  end
-
-end

data/test/lib/rubycritic/analysers/stats_test.rb

@@ -1,30 +0,0 @@
-require "analysers_test_helper"
-require "rubycritic/analysers/stats"
-
-describe Rubycritic::Analyser::Stats do
-  context "when a file contains Ruby code" do
-    it "calculates the number of methods of each file and adds it to analysed_files" do
-      analysed_file = AnalysedFileDouble.new(:path => "test/samples/stats/example.rb")
-      Rubycritic::Analyser::Stats.new([analysed_file]).run
-      analysed_file.methods_count.must_equal 2
-    end
-  end
-
-  context "when a file is empty" do
-    it "calculates the number of methods as 0, adding it to analysed_files" do
-      analysed_file = AnalysedFileDouble.new(:path => "test/samples/stats/empty_example.rb")
-      Rubycritic::Analyser::Stats.new([analysed_file]).run
-      analysed_file.methods_count.must_equal 0
-    end
-  end
-
-  context "when a file is unparsable" do
-    it "does not blow up" do
-      analysed_file = AnalysedFileDouble.new(:path => "test/samples/stats/unparsable_example.rb")
-      capture_output_streams do
-        Rubycritic::Analyser::Stats.new([analysed_file]).run
-      end
-      analysed_file.methods_count.must_equal 0
-    end
-  end
-end

data/test/lib/rubycritic/core/analysed_file_test.rb

@@ -1,86 +0,0 @@
-require "test_helper"
-require "rubycritic/core/analysed_file"
-require "rubycritic/core/smell"
-
-describe Rubycritic::AnalysedFile do
-  describe "attribute readers" do
-    before do
-      @pathname = Pathname.new("foo/bar.rb")
-      @smells = []
-      @churn = 1
-      @complexity = 2
-      @analysed_file = Rubycritic::AnalysedFile.new(
-        :pathname   => @pathname,
-        :smells     => @smells,
-        :churn      => @churn,
-        :complexity => @complexity
-      )
-    end
-
-    it "has a pathname reader" do
-      @analysed_file.pathname.must_equal @pathname
-    end
-
-    it "has a smells reader" do
-      @analysed_file.smells.must_equal @smells
-    end
-
-    it "has a churn reader" do
-      @analysed_file.churn.must_equal @churn
-    end
-
-    it "has a complexity reader" do
-      @analysed_file.complexity.must_equal @complexity
-    end
-
-    it "has a name reader" do
-      @analysed_file.name.must_equal "bar"
-    end
-
-    it "has a path reader" do
-      @analysed_file.path.must_equal @pathname.to_s
-    end
-  end
-
-  describe "#cost" do
-    it "returns the remediation cost of fixing the analysed_file" do
-      smells = [SmellDouble.new(:cost => 1), SmellDouble.new(:cost => 2)]
-      analysed_file = Rubycritic::AnalysedFile.new(:smells => smells, :complexity => 0)
-      analysed_file.cost.must_equal 3
-    end
-  end
-
-  describe "#complexity_per_method" do
-    context "when the file has no methods" do
-      it "returns a placeholder" do
-        analysed_file = Rubycritic::AnalysedFile.new(:complexity => 0, :methods_count => 0)
-        analysed_file.complexity_per_method.must_equal "N/A"
-      end
-    end
-
-    context "when the file has at least one method" do
-      it "returns the average complexity per method" do
-        analysed_file = Rubycritic::AnalysedFile.new(:complexity => 10, :methods_count => 2)
-        analysed_file.complexity_per_method.must_equal 5
-      end
-    end
-  end
-
-  describe "#has_smells?" do
-    it "returns true if the analysed_file has at least one smell" do
-      analysed_file = Rubycritic::AnalysedFile.new(:smells => [SmellDouble.new])
-      analysed_file.has_smells?.must_equal true
-    end
-  end
-
-  describe "#smells_at_location" do
-    it "returns the smells of an analysed_file at a certain location" do
-      location = Rubycritic::Location.new("./foo", "42")
-      smells = [Rubycritic::Smell.new(:locations => [location])]
-      analysed_file = Rubycritic::AnalysedFile.new(:smells => smells)
-      analysed_file.smells_at_location(location).must_equal smells
-    end
-  end
-end
-
-class SmellDouble < OpenStruct; end

data/test/samples/stats/unparsable_example.rb

@@ -1,2 +0,0 @@
-factory :<%= singular_name %> do
-end