RubyGems - rubycritic - Versions diffs - 0.0.5 → 1.4.0 - Mend

rubycritic 0.0.5 → 1.4.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (135) hide show

checksums.yaml +4 -4
data/.rubocop.yml +593 -0
data/.travis.yml +11 -0
data/CHANGELOG.md +45 -0
data/CONTRIBUTING.md +67 -15
data/README.md +105 -14
data/Rakefile +9 -6
data/bin/rubycritic +3 -1
data/lib/rubycritic/analysers/attributes.rb +21 -0
data/lib/rubycritic/analysers/churn.rb +21 -0
data/lib/rubycritic/analysers/complexity.rb +22 -0
data/lib/rubycritic/analysers/helpers/ast_node.rb +69 -0
data/lib/rubycritic/analysers/{config.reek → helpers/config.reek} +8 -0
data/lib/rubycritic/analysers/helpers/flay.rb +13 -0
data/lib/rubycritic/analysers/helpers/flog.rb +17 -0
data/lib/rubycritic/analysers/helpers/methods_counter.rb +25 -0
data/lib/rubycritic/analysers/helpers/modules_locator.rb +43 -0
data/lib/rubycritic/analysers/helpers/parser.rb +12 -0
data/lib/rubycritic/analysers/helpers/reek.rb +17 -0
data/lib/rubycritic/analysers/smells/flay.rb +68 -0
data/lib/rubycritic/analysers/smells/flog.rb +62 -0
data/lib/rubycritic/analysers/smells/reek.rb +44 -0
data/lib/rubycritic/analysers_runner.rb +21 -10
data/lib/rubycritic/cli/application.rb +24 -0
data/lib/rubycritic/cli/options.rb +79 -0
data/lib/rubycritic/commands/ci.rb +26 -0
data/lib/rubycritic/commands/default.rb +28 -0
data/lib/rubycritic/commands/help.rb +13 -0
data/lib/rubycritic/commands/version.rb +11 -0
data/lib/rubycritic/configuration.rb +33 -0
data/lib/rubycritic/core/analysed_module.rb +66 -0
data/lib/rubycritic/{location.rb → core/location.rb} +17 -2
data/lib/rubycritic/core/rating.rb +30 -0
data/lib/rubycritic/{smell.rb → core/smell.rb} +22 -13
data/lib/rubycritic/generators/html/assets/javascripts/application.js +104 -0
data/lib/rubycritic/generators/html/assets/javascripts/highcharts.src-4.0.1.js +17672 -0
data/lib/rubycritic/generators/html/assets/javascripts/jquery.floatThead-v1.2.7.js +754 -0
data/lib/rubycritic/generators/html/assets/javascripts/jquery.scrollTo-1.4.11.js +186 -0
data/lib/rubycritic/generators/html/assets/javascripts/jquery.tablesorter.js +2089 -0
data/lib/rubycritic/generators/html/assets/javascripts/jquery.timeago-v1.4.1.js +214 -0
data/lib/rubycritic/generators/html/assets/stylesheets/application.css +303 -0
data/lib/rubycritic/{report_generators → generators/html}/assets/stylesheets/prettify.custom_theme.css +1 -4
data/lib/rubycritic/generators/html/base.rb +52 -0
data/lib/rubycritic/generators/html/code_file.rb +40 -0
data/lib/rubycritic/generators/html/code_index.rb +26 -0
data/lib/rubycritic/generators/html/line.rb +37 -0
data/lib/rubycritic/generators/html/overview.rb +27 -0
data/lib/rubycritic/generators/html/smells_index.rb +38 -0
data/lib/rubycritic/generators/html/templates/code_file.html.erb +38 -0
data/lib/rubycritic/generators/html/templates/code_index.html.erb +30 -0
data/lib/rubycritic/generators/html/templates/layouts/application.html.erb +34 -0
data/lib/rubycritic/generators/html/templates/overview.html.erb +5 -0
data/lib/rubycritic/generators/html/templates/smells_index.html.erb +26 -0
data/lib/rubycritic/{report_generators → generators/html}/templates/smelly_line.html.erb +1 -1
data/lib/rubycritic/generators/html/turbulence.rb +17 -0
data/lib/rubycritic/generators/html/view_helpers.rb +43 -0
data/lib/rubycritic/generators/html_report.rb +66 -0
data/lib/rubycritic/generators/json/simple.rb +30 -0
data/lib/rubycritic/generators/json_report.rb +23 -0
data/lib/rubycritic/reporter.rb +20 -0
data/lib/rubycritic/revision_comparator.rb +27 -29
data/lib/rubycritic/serializer.rb +32 -0
data/lib/rubycritic/smells_status_setter.rb +7 -16
data/lib/rubycritic/source_control_systems/base.rb +37 -0
data/lib/rubycritic/source_control_systems/double.rb +18 -0
data/lib/rubycritic/source_control_systems/git.rb +41 -37
data/lib/rubycritic/source_control_systems/mercurial.rb +29 -0
data/lib/rubycritic/source_locator.rb +25 -13
data/lib/rubycritic/version.rb +1 -1
data/lib/rubycritic.rb +17 -22
data/rubycritic.gemspec +10 -7
data/test/analysers_test_helper.rb +3 -0
data/test/lib/rubycritic/analysers/churn_test.rb +33 -0
data/test/lib/rubycritic/analysers/complexity_test.rb +16 -0
data/test/lib/rubycritic/analysers/helpers/methods_counter_test.rb +29 -0
data/test/lib/rubycritic/analysers/helpers/modules_locator_test.rb +53 -0
data/test/lib/rubycritic/analysers/smells/flay_test.rb +39 -0
data/test/lib/rubycritic/analysers/smells/flog_test.rb +26 -0
data/test/lib/rubycritic/analysers/smells/reek_test.rb +33 -0
data/test/lib/rubycritic/configuration_test.rb +29 -0
data/test/lib/rubycritic/core/analysed_module_test.rb +88 -0
data/test/lib/rubycritic/{location_test.rb → core/location_test.rb} +8 -4
data/test/lib/rubycritic/core/smell_test.rb +72 -0
data/test/lib/rubycritic/{smells_array_test.rb → core/smells_array_test.rb} +1 -1
data/test/lib/rubycritic/report_generators/turbulence_test.rb +17 -0
data/test/lib/rubycritic/report_generators/view_helpers_test.rb +83 -0
data/test/lib/rubycritic/smells_status_setter_test.rb +5 -5
data/test/lib/rubycritic/source_control_systems/base_test.rb +29 -0
data/test/lib/rubycritic/source_control_systems/double_test.rb +11 -0
data/test/lib/rubycritic/source_control_systems/git_test.rb +13 -0
data/test/lib/rubycritic/source_control_systems/interfaces/basic.rb +7 -0
data/test/lib/rubycritic/source_control_systems/interfaces/time_travel.rb +7 -0
data/test/lib/rubycritic/source_control_systems/mercurial_test.rb +11 -0
data/test/lib/rubycritic/source_locator_test.rb +42 -18
data/test/lib/rubycritic/version_test.rb +1 -0
data/test/samples/empty.rb +0 -0
data/test/samples/flay/smelly.rb +8 -0
data/test/samples/flay/smelly2.rb +8 -0
data/test/samples/flog/complex.rb +11 -0
data/test/samples/flog/smelly.rb +7 -2
data/test/samples/location/file0_symlink.rb +0 -0
data/test/samples/methods_count.rb +7 -0
data/test/samples/module_names.rb +18 -0
data/test/samples/reek/not_smelly.rb +31 -3
data/test/samples/unparsable.rb +1 -0
data/test/test_helper.rb +39 -0
metadata +178 -53
data/SPEC.md +0 -58
data/lib/rubycritic/analysers/flog.rb +0 -20
data/lib/rubycritic/analysers/reek.rb +0 -15
data/lib/rubycritic/cli.rb +0 -25
data/lib/rubycritic/report_generators/assets/javascripts/application.js +0 -25
data/lib/rubycritic/report_generators/assets/stylesheets/application.css +0 -26
data/lib/rubycritic/report_generators/base_generator.rb +0 -42
data/lib/rubycritic/report_generators/file_generator.rb +0 -42
data/lib/rubycritic/report_generators/index_generator.rb +0 -28
data/lib/rubycritic/report_generators/line_generator.rb +0 -27
data/lib/rubycritic/report_generators/reporter.rb +0 -45
data/lib/rubycritic/report_generators/templates/file.html.erb +0 -3
data/lib/rubycritic/report_generators/templates/index.html.erb +0 -14
data/lib/rubycritic/report_generators/templates/layouts/application.html.erb +0 -19
data/lib/rubycritic/report_generators/view_helpers.rb +0 -26
data/lib/rubycritic/smell_adapters/flog.rb +0 -41
data/lib/rubycritic/smell_adapters/reek.rb +0 -35
data/lib/rubycritic/smells_aggregator.rb +0 -29
data/lib/rubycritic/smelly_pathnames_serializer.rb +0 -34
data/lib/rubycritic/source_control_systems/source_control_system.rb +0 -42
data/test/lib/rubycritic/metric_adapters/flog_adapter_test.rb +0 -25
data/test/lib/rubycritic/metric_adapters/reek_adapter_test.rb +0 -34
data/test/lib/rubycritic/smell_test.rb +0 -71
data/test/lib/rubycritic/smells_aggregator_test.rb +0 -47
data/test/lib/rubycritic/source_control_systems/source_control_system_test.rb +0 -26
/data/lib/rubycritic/{report_generators → generators/html}/assets/javascripts/jquery-2.1.0.js +0 -0
/data/lib/rubycritic/{report_generators/assets/javascripts/prettify.js → generators/html/assets/javascripts/prettify-4-Mar-2013.js} +0 -0
/data/lib/rubycritic/{report_generators → generators/html}/templates/line.html.erb +0 -0

data/lib/rubycritic/generators/html/smells_index.rb ADDED Viewed

@@ -0,0 +1,38 @@
+require "rubycritic/generators/html/base"
+module Rubycritic
+  module Generator
+    module Html
+      class SmellsIndex < Base
+        TEMPLATE = erb_template("smells_index.html.erb")
+        def initialize(analysed_modules)
+          @smells = analysed_modules.flat_map(&:smells).uniq
+          @analysed_module_names = analysed_module_names(analysed_modules)
+          @show_status = (Config.mode == :default)
+        end
+        def file_name
+          "smells_index.html"
+        end
+        def render
+          index_body = TEMPLATE.result(get_binding)
+          LAYOUT_TEMPLATE.result(get_binding { index_body })
+        end
+        private
+        def analysed_module_names(analysed_modules)
+          names = {}
+          analysed_modules.each do |analysed_module|
+            names[analysed_module.pathname] = analysed_module.name
+          end
+          names
+        end
+      end
+    end
+  end
+end

data/lib/rubycritic/generators/html/templates/code_file.html.erb ADDED Viewed

@@ -0,0 +1,38 @@
+<div class="file-header group <%= Config.suppress_ratings ? 'unrated' : 'rated' %>">
+  <span class="rating rating-<%= @analysed_module.rating.to_s.downcase %> circled-text circle">
+    <%= @analysed_module.rating %>
+  </span>
+  <h2 class="file-name"><%= @analysed_module.name %></h2>
+  <span class="file-committed-at">
+    <% if @analysed_module.committed_at %>
+      Updated <%= timeago_tag(@analysed_module.committed_at) %>
+    <% else %>
+      Never committed
+    <% end %>
+  </span>
+  <div class="file-stats group">
+    <div class="file-stat">
+      <%= @analysed_module.complexity %> complexity
+    </div>
+    <div class="file-stat">
+      <%= @analysed_module.complexity_per_method %> complexity per method
+    </div>
+    <div class="file-stat">
+      <%= @analysed_module.churn %> churn
+    </div>
+    <div class="file-stat">
+      <%= @analysed_module.methods_count %> methods
+    </div>
+    <div class="file-stat">
+      <%= @analysed_module.duplication %> duplication
+    </div>
+  </div>
+  <% if @analysed_module.smells? %>
+    <button id="js-toggle-smells" class="smells-toggle-button button">Toggle Smells</button>
+  <% end %>
+</div>
+<code class="prettyprint linenums lang-ruby file-code js-file-code"><%= yield %></code>

data/lib/rubycritic/generators/html/templates/code_index.html.erb ADDED Viewed

@@ -0,0 +1,30 @@
+<table id="js-index-table" class="index-table sortable-table">
+<thead>
+  <tr>
+    <th>Name</th>
+    <th class="numeric-cell" title="Number of times a file has changed">Churn</th>
+    <th class="numeric-cell" title="Overall amount of code in a file">Complexity</th>
+    <th class="numeric-cell" title="Amount of code that is similar to other code">Duplication</th>
+    <th class="numeric-cell">Smells</th>
+    <% unless Config.suppress_ratings %>
+      <th class="centered-cell">Rating</th>
+    <% end %>
+  </tr>
+</thead>
+<tbody>
+  <% @analysed_modules.each do |analysed_module| %>
+    <tr>
+      <td>
+        <a href="<%= file_path(analysed_module.pathname.sub_ext('.html')) %>"><%= analysed_module.name %></a>
+      </td>
+      <td class="numeric-cell"><%= analysed_module.churn %></td>
+      <td class="numeric-cell"><%= analysed_module.complexity %></td>
+      <td class="numeric-cell"><%= analysed_module.duplication %></td>
+      <td class="numeric-cell"><%= analysed_module.smells.length %></td>
+      <% unless Config.suppress_ratings %>
+        <td class="centered-cell"><span class="rating-<%= analysed_module.rating.to_s.downcase %> circled-text circle"><%= analysed_module.rating %></span></td>
+      <% end %>
+    </tr>
+  <% end %>
+</tbody>
+</table>

data/lib/rubycritic/generators/html/templates/layouts/application.html.erb ADDED Viewed

@@ -0,0 +1,34 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8">
+    <meta http-equiv="X-UA-Compatible" content="IE=edge">
+    <title>RubyCritic</title>
+    <link href="<%= stylesheet_path(:application) %>" media="screen, projection, print" rel="stylesheet" type="text/css">
+    <link href="<%= stylesheet_path(:'prettify.custom_theme') %>" media="screen, projection, print" rel="stylesheet" type="text/css">
+    <meta name="viewport" content="width=device-width, initial-scale=1">
+  </head>
+  <body>
+    <header class="project-header group">
+      <div class="container">
+        <h1 class="logo"><a href="<%= file_path('overview.html') %>" class="logo-link">RubyCritic</a></h1>
+        <nav class="project-nav">
+          <a href="<%= file_path('overview.html') %>" class="project-nav-item">Overview</a>
+          <a href="<%= file_path('code_index.html') %>" class="project-nav-item">Code</a>
+          <a href="<%= file_path('smells_index.html') %>" class="project-nav-item">Smells</a>
+        </nav>
+      </div>
+    </header>
+    <div class="container">
+      <%= yield %>
+    </div>
+    <%= javascript_tag(:'jquery-2.1.0') %>
+    <%= javascript_tag(:'jquery.tablesorter') %>
+    <%= javascript_tag(:'jquery.floatThead-v1.2.7') %>
+    <%= javascript_tag(:'jquery.timeago-v1.4.1') %>
+    <%= javascript_tag(:'highcharts.src-4.0.1') %>
+    <%= javascript_tag(:'jquery.scrollTo-1.4.11') %>
+    <%= javascript_tag(:'prettify-4-Mar-2013') %>
+    <%= javascript_tag(:application) %>
+  </body>
+</html>

data/lib/rubycritic/generators/html/templates/overview.html.erb ADDED Viewed

@@ -0,0 +1,5 @@
+<div id="js-chart-container" class="chart-container"></div>
+<script type="text/javascript">
+  var turbulenceData = <%= @turbulence_data %>;
+</script>

data/lib/rubycritic/generators/html/templates/smells_index.html.erb ADDED Viewed

@@ -0,0 +1,26 @@
+<table id="js-index-table" class="smells-index-table index-table sortable-table">
+<thead>
+  <tr>
+    <th>Smell</th>
+    <th>Locations</th>
+    <% if @show_status %>
+      <th class="centered-cell" title="Code smells introduced recently are marked as new. There's still time before they are committed!">Status</th>
+    <% end %>
+  </tr>
+</thead>
+<tbody>
+  <% @smells.each do |smell| %>
+    <tr>
+      <td><%= smell.type %></td>
+      <td>
+        <% smell.locations.each do |location| %>
+          <a href="<%= smell_location_path(location) %>"><%= @analysed_module_names[location.pathname] %></a>
+        <% end %>
+      </td>
+      <% if @show_status %>
+        <td class="centered-cell"><span class="status-<%= smell.status %> circled-text circle"><%= smell.status %></span></td>
+      <% end %>
+    </tr>
+  <% end %>
+</tbody>
+</table>

data/lib/rubycritic/{report_generators → generators/html}/templates/smelly_line.html.erb RENAMED Viewed

@@ -4,7 +4,7 @@
 <% @smells.each do |smell| %>
   <li class="smell <%= smell.status %>">
     <span class="description"><%= smell %>
-      <% if smell.has_multiple_locations? %>
+      <% if smell.multiple_locations? %>
         <% smell.locations.each_with_index do |location, index| %>
           <a href="<%= smell_location_path(location) %>" class="js-smell-location"><%= index %></a>
         <% end %>

data/lib/rubycritic/generators/html/turbulence.rb ADDED Viewed

@@ -0,0 +1,17 @@
+require "json"
+module Rubycritic
+  module Turbulence
+    def self.data(analysed_modules)
+      analysed_modules.map do |analysed_module|
+        {
+          :name => analysed_module.name,
+          :x => analysed_module.churn,
+          :y => analysed_module.complexity
+        }
+      end.to_json
+    end
+  end
+end

data/lib/rubycritic/generators/html/view_helpers.rb ADDED Viewed

@@ -0,0 +1,43 @@
+module Rubycritic
+  module ViewHelpers
+    def timeago_tag(time)
+      "<time class='js-timeago' datetime='#{time}'>#{time}</time>"
+    end
+    def javascript_tag(file)
+      "<script src='" + asset_path("javascripts/#{file}.js").to_s + "'></script>"
+    end
+    def stylesheet_path(file)
+      asset_path("stylesheets/#{file}.css")
+    end
+    def asset_path(file)
+      relative_path("assets/#{file}")
+    end
+    def file_path(file)
+      relative_path(file)
+    end
+    def smell_location_path(location)
+      file_path("#{location.pathname.sub_ext('.html')}#L#{location.line}")
+    end
+    private
+    def relative_path(file)
+      (root_directory + file).relative_path_from(file_directory)
+    end
+    def file_directory
+      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
+    end
+    def root_directory
+      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
+    end
+  end
+end

data/lib/rubycritic/generators/html_report.rb ADDED Viewed

@@ -0,0 +1,66 @@
+require "fileutils"
+require "rubycritic/generators/html/overview"
+require "rubycritic/generators/html/smells_index"
+require "rubycritic/generators/html/code_index"
+require "rubycritic/generators/html/code_file"
+module Rubycritic
+  module Generator
+    class HtmlReport
+      ASSETS_DIR = File.expand_path("../html/assets", __FILE__)
+      def initialize(analysed_modules)
+        @analysed_modules = analysed_modules
+      end
+      def generate_report
+        create_directories_and_files
+        copy_assets_to_report_directory
+        puts "New critique at #{report_location}"
+      end
+      private
+      def create_directories_and_files
+        Array(generators).each do |generator|
+          FileUtils.mkdir_p(generator.file_directory)
+          File.open(generator.file_pathname, "w+") do |file|
+            file.write(generator.render)
+          end
+        end
+      end
+      def generators
+        [overview_generator, code_index_generator, smells_index_generator] + file_generators
+      end
+      def overview_generator
+        @overview_generator ||= Html::Overview.new(@analysed_modules)
+      end
+      def code_index_generator
+        Html::CodeIndex.new(@analysed_modules)
+      end
+      def smells_index_generator
+        Html::SmellsIndex.new(@analysed_modules)
+      end
+      def file_generators
+        @analysed_modules.map do |analysed_module|
+          Html::CodeFile.new(analysed_module)
+        end
+      end
+      def copy_assets_to_report_directory
+        FileUtils.cp_r(ASSETS_DIR, Config.root)
+      end
+      def report_location
+        overview_generator.file_href
+      end
+    end
+  end
+end

data/lib/rubycritic/generators/json/simple.rb ADDED Viewed

@@ -0,0 +1,30 @@
+require "json"
+module Rubycritic
+  module Generator
+    module Json
+      class Simple
+        def initialize(analysed_modules)
+          @analysed_modules = analysed_modules
+        end
+        def render
+          JSON.dump(data)
+        end
+        def data
+          {
+            :metadata => {
+              :rubycritic => {
+                :version => Rubycritic::VERSION
+              }
+            },
+            :analysed_modules => @analysed_modules
+          }
+        end
+      end
+    end
+  end
+end

data/lib/rubycritic/generators/json_report.rb ADDED Viewed

@@ -0,0 +1,23 @@
+require "rubycritic/generators/json/simple"
+module Rubycritic
+  module Generator
+    class JsonReport
+      def initialize(analysed_modules)
+        @analysed_modules = analysed_modules
+      end
+      def generate_report
+        print generator.render
+      end
+      private
+      def generator
+        Json::Simple.new(@analysed_modules)
+      end
+    end
+  end
+end

data/lib/rubycritic/reporter.rb ADDED Viewed

@@ -0,0 +1,20 @@
+module Rubycritic
+  module Reporter
+    def self.generate_report(analysed_modules)
+      report_generator_class.new(analysed_modules).generate_report
+    end
+    def self.report_generator_class
+      case Config.format
+      when :json
+        require "rubycritic/generators/json_report"
+        Generator::JsonReport
+      else
+        require "rubycritic/generators/html_report"
+        Generator::HtmlReport
+      end
+    end
+  end
+end

data/lib/rubycritic/revision_comparator.rb CHANGED Viewed

@@ -1,54 +1,52 @@
-require "rubycritic/smelly_pathnames_serializer"
-require "rubycritic/source_locator"
+require "rubycritic/serializer"
 require "rubycritic/analysers_runner"
-require "rubycritic/smells_aggregator"
 require "rubycritic/smells_status_setter"
+require "rubycritic/version"
+require "digest/md5"
 module Rubycritic
   class RevisionComparator
-    SNAPSHOTS_DIR = File.expand_path("tmp/rubycritic/snapshots", Dir.getwd)
+    SNAPSHOTS_DIR_NAME = "snapshots"
-    def initialize(paths, source_control_system)
+    def initialize(paths)
       @paths = paths
-      @source_control_system = source_control_system
     end
-    def compare
-      SmellsStatusSetter.new(smelly_pathnames_before, smelly_pathnames_now).smelly_pathnames
+    def set_statuses(analysed_modules_now)
+      if Config.source_control_system.revision?
+        SmellsStatusSetter.set(
+          analysed_modules_before.flat_map(&:smells),
+          analysed_modules_now.flat_map(&:smells)
+        )
+      end
+      analysed_modules_now
     end
     private
-    def smelly_pathnames_before
-      serializer = SmellyPathnamesSerializer.new(revision_file)
+    def analysed_modules_before
+      serializer = Serializer.new(revision_file)
       if File.file?(revision_file)
         serializer.load
       else
-        smelly_pathnames = nil
-        @source_control_system.travel_to_head do
-          smelly_pathnames = smelly_pathnames(paths_of_tracked_files)
+        analysed_modules = nil
+        Config.source_control_system.travel_to_head do
+          analysed_modules = AnalysersRunner.new(@paths).run
         end
-        serializer.dump(smelly_pathnames)
-        smelly_pathnames
+        serializer.dump(analysed_modules)
+        analysed_modules
       end
     end
-    def smelly_pathnames_now
-      smelly_pathnames(@paths)
-    end
-    def smelly_pathnames(paths)
-      smell_adapters = AnalysersRunner.new(paths).run
-      SmellsAggregator.new(smell_adapters).smelly_pathnames
-    end
     def revision_file
-      @revision_file ||= File.join(SNAPSHOTS_DIR, @source_control_system.head_reference)
-    end
-    def paths_of_tracked_files
-      SourceLocator.new(["."]).paths
+      @revision_file ||= File.join(
+        Config.root,
+        SNAPSHOTS_DIR_NAME,
+        VERSION,
+        Digest::MD5.hexdigest(Marshal.dump(@paths)),
+        Config.source_control_system.head_reference
+      )
     end
   end

data/lib/rubycritic/serializer.rb ADDED Viewed

@@ -0,0 +1,32 @@
+require "fileutils"
+module Rubycritic
+  class Serializer
+    def initialize(file)
+      @file = file
+    end
+    def load
+      Marshal.load(File.binread(@file))
+    end
+    def dump(content)
+      create_file_directory
+      File.open(@file, "w+") do |file|
+        Marshal.dump(content, file)
+      end
+    end
+    private
+    def create_file_directory
+      FileUtils.mkdir_p(file_directory)
+    end
+    def file_directory
+      File.dirname(@file)
+    end
+  end
+end

data/lib/rubycritic/smells_status_setter.rb CHANGED Viewed

@@ -1,25 +1,16 @@
 module Rubycritic
-  class SmellsStatusSetter
-    def initialize(smelly_pathnames_before, smelly_pathnames_now)
-      @smelly_pathnames_before = smelly_pathnames_before
-      @smelly_pathnames_now = smelly_pathnames_now
-    end
-    def smelly_pathnames
-      @smelly_pathnames_now.each do |pathname, smells_now|
-        smells_before = @smelly_pathnames_before[pathname] || []
-        old_smells = smells_now & smells_before
-        set_status(old_smells, :old)
-        new_smells = smells_now - smells_before
-        set_status(new_smells, :new)
-      end
-      @smelly_pathnames_now
+  module SmellsStatusSetter
+    def self.set(smells_before, smells_now)
+      old_smells = smells_now & smells_before
+      set_status(old_smells, :old)
+      new_smells = smells_now - smells_before
+      set_status(new_smells, :new)
     end
     private
-    def set_status(smells, status)
+    def self.set_status(smells, status)
       smells.each { |smell| smell.status = status }
     end
   end

data/lib/rubycritic/source_control_systems/base.rb ADDED Viewed

@@ -0,0 +1,37 @@
+require "shellwords"
+module Rubycritic
+  module SourceControlSystem
+    class Base
+      @@systems = []
+      def self.register_system
+        @@systems << self
+      end
+      def self.systems
+        @@systems
+      end
+      def self.create
+        supported_system = systems.find(&:supported?)
+        if supported_system
+          supported_system.new
+        else
+          puts "RubyCritic can provide more feedback if you use a #{connected_system_names} repository."
+          Double.new
+        end
+      end
+      def self.connected_system_names
+        "#{systems[0...-1].join(', ')} or #{systems[-1]}"
+      end
+    end
+  end
+end
+require "rubycritic/source_control_systems/double"
+require "rubycritic/source_control_systems/git"
+require "rubycritic/source_control_systems/mercurial"

data/lib/rubycritic/source_control_systems/double.rb ADDED Viewed

@@ -0,0 +1,18 @@
+module Rubycritic
+  module SourceControlSystem
+    class Double < Base
+      def revisions_count(_)
+        "N/A"
+      end
+      def date_of_last_commit(_)
+        nil
+      end
+      def revision?
+        false
+      end
+    end
+  end
+end