rubycritic 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e3de50932159be5b26bc5a2cf4afe9eeec17e8dc
-  data.tar.gz: c7f9620aae8d000fe5f674844158d48296c706c3
+  metadata.gz: ff62ecc1acf094e82a10bf40ef08f3e99f503994
+  data.tar.gz: b72615619b79aeff062110b689f0795768a81ab4
 SHA512:
-  metadata.gz: 28d945ef0e7036d298e1c8ff54b909c7c4c67b777e6ccfad20c548905ccb515fe849c351866b38bbba6765dfd31af610d41ae6c6cede57e469db3b54ee4f44bb
-  data.tar.gz: 509b8ffc4b0cdcb85cccacbbe242a5a5bc5f0e06e2975d12ac3827d9f168c0426793bcde26d4c48cf953e49ff41ba0039dce216428e8a94f009ba0e964f21522
+  metadata.gz: 678cf22b3f926a270505432a1c7c473d782b05e93b647c3cb0754c25d606d35a76ff7af26d44182bfaeeddbc5845e07a8a6c219228b880f562940e5f8b1ec814
+  data.tar.gz: 46abcfc03b41e1824bc7acdd017955a2850095faf8ed3996cb698615e74f34d01ef108727dee9df7095d754bbf23c55ca4bdba6fa890106f33fd9893d1d570fb

data/lib/rubycritic/active_support/methods.rb

@@ -0,0 +1,36 @@
+module Rubycritic
+
+  module ActiveSupport
+    def constantize(camel_cased_word)
+      names = camel_cased_word.split('::')
+
+      # Trigger a built-in NameError exception including the ill-formed constant in the message.
+      Object.const_get(camel_cased_word) if names.empty?
+
+      # Remove the first blank element in case of '::ClassName' notation.
+      names.shift if names.size > 1 && names.first.empty?
+
+      names.inject(Object) do |constant, name|
+        if constant == Object
+          constant.const_get(name)
+        else
+          candidate = constant.const_get(name)
+          next candidate if constant.const_defined?(name, false)
+          next candidate unless Object.const_defined?(name)
+
+          # Go down the ancestors to check it it's owned
+          # directly before we reach Object or the end of ancestors.
+          constant = constant.ancestors.inject do |const, ancestor|
+            break const    if ancestor == Object
+            break ancestor if ancestor.const_defined?(name, false)
+            const
+          end
+
+          # owner is in Object, so raise
+          constant.const_get(name, false)
+        end
+      end
+    end
+  end
+
+end

data/lib/rubycritic/analysers_runner.rb

@@ -1,9 +1,12 @@
+require "rubycritic/active_support/methods"
 require "rubycritic/analysers/reek"
 require "rubycritic/smell_adapters/reek"
 
 module Rubycritic
 
   class AnalysersRunner
+    include ActiveSupport
+
     ANALYSERS = ["Reek"]
 
     def initialize(paths)
@@ -11,15 +14,15 @@ module Rubycritic
     end
 
     def run
-      smell_adapters
+      run_analysers_and_instantiate_adapters
     end
 
     private
 
-    def smell_adapters
+    def run_analysers_and_instantiate_adapters
       ANALYSERS.map do |analyser_name|
-        analyser = Object.const_get("Rubycritic::Analyser::#{analyser_name}").new(@paths)
-        Object.const_get("Rubycritic::SmellAdapter::#{analyser_name}").new(analyser)
+        analyser = constantize("Rubycritic::Analyser::#{analyser_name}").new(@paths)
+        constantize("Rubycritic::SmellAdapter::#{analyser_name}").new(analyser)
       end
     end
   end

data/lib/rubycritic/report_generators/file_generator.rb

@@ -15,7 +15,7 @@ module Rubycritic
     end
 
     def file_directory
-      File.join(REPORT_DIR, File.dirname(@pathname))
+      File.join(REPORT_DIR, @pathname.dirname)
     end
 
     def file_name

data/lib/rubycritic/report_generators/templates/index.html.erb

@@ -6,9 +6,9 @@
 </thead>
 <tbody>
   <% @file_generators.each do |file_generator| %>
-  <tr>
-    <td><a href="<%= file_generator.file_pathname %>"><%= file_generator.analysed_file_name %></a></td>
-  </tr>
+    <tr>
+      <td><a href="<%= file_generator.file_pathname %>"><%= file_generator.analysed_file_name %></a></td>
+    </tr>
   <% end %>
 </tbody>
 </table>

data/lib/rubycritic/report_generators/view_helpers.rb

@@ -15,7 +15,7 @@ module Rubycritic
 
     def smell_location_path(location)
       pathname = location.pathname
-      File.join(root_directory, File.dirname(pathname), "#{pathname.basename.sub_ext("")}.html#L#{location.line}")
+      File.join(root_directory, "#{pathname.sub_ext('.html')}#L#{location.line}")
     end
 
     def index_path

data/lib/rubycritic/version.rb

@@ -1,3 +1,3 @@
 module Rubycritic
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/test/lib/rubycritic/analysers_runner_test.rb

@@ -0,0 +1,11 @@
+require "test_helper"
+require "rubycritic/analysers_runner"
+
+describe Rubycritic::AnalysersRunner do
+  describe "#run" do
+    it "returns an array containing smell adapters" do
+      smell_adapters = Rubycritic::AnalysersRunner.new("test/samples/location/file0.rb").run
+      smell_adapters.each { |adapter| adapter.must_respond_to(:smells) }
+    end
+  end
+end

data/test/lib/rubycritic/smells_aggregator_test.rb

@@ -2,7 +2,7 @@ require "test_helper"
 require "rubycritic/smells_aggregator"
 
 describe Rubycritic::SmellsAggregator do
-  context "when when analysing smelly files" do
+  context "when analysing smelly files" do
     before do
       @location1 = Rubycritic::Location.new("./foo", "42")
       @location2 = Rubycritic::Location.new("./bar", "23")

data/test/lib/rubycritic/source_locator_test.rb

@@ -8,7 +8,7 @@ describe Rubycritic::SourceLocator do
   end
 
   describe "#paths" do
-    it "finds a single path" do
+    it "finds a single file" do
       paths = ["file0.rb"]
       Rubycritic::SourceLocator.new(paths).paths.must_equal paths
     end
@@ -18,7 +18,7 @@ describe Rubycritic::SourceLocator do
       Rubycritic::SourceLocator.new(paths).paths.must_equal paths
     end
 
-    it "finds all the paths" do
+    it "finds all the files" do
       paths = ["dir1/file1.rb", "file0.rb"]
       Rubycritic::SourceLocator.new(["."]).paths.must_equal paths
     end
@@ -40,7 +40,7 @@ describe Rubycritic::SourceLocator do
   end
 
   describe "#pathnames" do
-    it "finds a single path" do
+    it "finds a single file" do
       path = "file0.rb"
       paths = [path]
       result = [Pathname.new(path)]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-14 00:00:00.000000000 Z
+date: 2014-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -126,6 +126,7 @@ files:
 - SPEC.md
 - bin/rubycritic
 - lib/rubycritic.rb
+- lib/rubycritic/active_support/methods.rb
 - lib/rubycritic/analysers/config.reek
 - lib/rubycritic/analysers/flog.rb
 - lib/rubycritic/analysers/reek.rb
@@ -160,6 +161,7 @@ files:
 - lib/rubycritic/source_locator.rb
 - lib/rubycritic/version.rb
 - rubycritic.gemspec
+- test/lib/rubycritic/analysers_runner_test.rb
 - test/lib/rubycritic/location_test.rb
 - test/lib/rubycritic/metric_adapters/flog_adapter_test.rb
 - test/lib/rubycritic/metric_adapters/reek_adapter_test.rb
@@ -198,11 +200,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Ruby code smell detector
 test_files:
+- test/lib/rubycritic/analysers_runner_test.rb
 - test/lib/rubycritic/location_test.rb
 - test/lib/rubycritic/metric_adapters/flog_adapter_test.rb
 - test/lib/rubycritic/metric_adapters/reek_adapter_test.rb