rubycritic 0.0.15 → 0.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 68c58782f25f2ad071d05ae5060034e4f2b77832
-  data.tar.gz: 61ae75fea93cde03f7e9ab378e363f345eb8f184
+  metadata.gz: 5a43f9d486a902fa7eda73e1df3e492cdb6ab085
+  data.tar.gz: a29c16803a4e83f4b559065630b024b76b45a69c
 SHA512:
-  metadata.gz: 15a35a6440ba6536d6989451ec60d0d8037303e93c47049aaa73c05846ea65f22bad0517084510811ed9cfa794acf86f0f5dc512cee37320841cff402fb381ba
-  data.tar.gz: 493ebc3d9f648e39ca5869d397dfcd4af1bc5facb5c1a669eda9a358bce67f85c21b93c7781ae8dbce3a9c4a34bdf98b8df788c08964e5214affb957a081edd6
+  metadata.gz: d0720b07a319110c0cb31dc6c5ca1ec69fef4eb60d7759069ba1e1e869a16f537d1e7d49553aa5ca544ccc91993c481f16f6fe7da2abe8917358499f952e2436
+  data.tar.gz: 05e48772690e0230b7e8d5788751204e754ccaaf0c4e40d72a4e5520fc0bad81ddc3f87a09f141d9a494372de94ae9c1e6df5adf808d2b765de22a3ae23294d1

data/lib/rubycritic/configuration.rb

@@ -13,11 +13,12 @@ module Rubycritic
     end
 
     def root=(path)
-      @root = if Pathname(path).relative?
-                File.expand_path(path)
-              else
-                path
-              end
+      @root =
+        if Pathname(path).relative?
+          File.expand_path(path)
+        else
+          path
+        end
     end
   end
 end

data/lib/rubycritic/core/analysed_file.rb

@@ -31,9 +31,11 @@ module Rubycritic
     end
 
     def complexity_per_method
-      complexity.fdiv(methods_count).round(1)
-    rescue ZeroDivisionError
-      "N/A"
+      if methods_count == 0
+        "N/A"
+      else
+        complexity.fdiv(methods_count).round(1)
+      end
     end
 
     def has_smells?

data/lib/rubycritic/report_generators/base.rb

@@ -23,7 +23,7 @@ module Rubycritic
       end
 
       def file_directory
-        root_directory
+        @file_directory ||= root_directory
       end
 
       def file_name
@@ -34,6 +34,12 @@ module Rubycritic
         raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
       end
 
+      private
+
+      def root_directory
+        @root_directory ||= Pathname.new(::Rubycritic.configuration.root)
+      end
+
       def get_binding
         binding
       end

data/lib/rubycritic/report_generators/code_file.rb

@@ -14,7 +14,7 @@ module Rubycritic
       end
 
       def file_directory
-        File.join(root_directory, @pathname.dirname)
+        @file_directory ||= root_directory + @pathname.dirname
       end
 
       def file_name
@@ -26,7 +26,7 @@ module Rubycritic
         File.readlines(@pathname).each.with_index(LINE_NUMBER_OFFSET) do |line_text, line_number|
           location = Location.new(@pathname, line_number)
           line_smells = @analysed_file.smells_at_location(location)
-          file_code << Line.new(line_text, line_smells).render
+          file_code << Line.new(file_directory, line_text, line_smells).render
         end
 
         file_body = TEMPLATE.result(get_binding { file_code })

data/lib/rubycritic/report_generators/current_code_file.rb

@@ -5,7 +5,7 @@ module Rubycritic
 
     class CurrentCodeFile < CodeFile
       def file_directory
-        root_directory
+        @file_directory ||= root_directory
       end
 
       def file_name

data/lib/rubycritic/report_generators/line.rb

@@ -8,7 +8,10 @@ module Rubycritic
       NORMAL_TEMPLATE = erb_template("line.html.erb")
       SMELLY_TEMPLATE = erb_template("smelly_line.html.erb")
 
-      def initialize(text, smells)
+      attr_reader :file_directory
+
+      def initialize(file_directory, text, smells)
+        @file_directory = file_directory
         @text = CGI::escapeHTML(text.chomp)
         @smells = smells
         @template =

data/lib/rubycritic/report_generators/templates/code_index.html.erb

@@ -13,7 +13,7 @@
   <% @analysed_files.each do |analysed_file| %>
     <tr>
       <td class="first-cell">
-        <a href="<%= file_path(analysed_file.pathname) %>"><%= analysed_file.name %></a>
+        <a href="<%= file_path(analysed_file.pathname.sub_ext('.html')) %>"><%= analysed_file.name %></a>
       </td>
       <td class="numeric-cell"><%= analysed_file.churn %></td>
       <td class="numeric-cell"><%= analysed_file.complexity %></td>

data/lib/rubycritic/report_generators/templates/layouts/application.html.erb

@@ -10,11 +10,11 @@
   </head>
   <body>
     <header class="project-header group">
-      <h1 class="logo"><a href="<%= file_path('overview') %>" class="logo-link">RubyCritic</a></h1>
+      <h1 class="logo"><a href="<%= file_path('overview.html') %>" class="logo-link">RubyCritic</a></h1>
       <nav class="project-nav">
-        <a href="<%= file_path('overview') %>" class="project-nav-item">Overview</a>
-        <a href="<%= file_path('code_index') %>" class="project-nav-item">Code</a>
-        <a href="<%= file_path('smells_index') %>" class="project-nav-item">Smells</a>
+        <a href="<%= file_path('overview.html') %>" class="project-nav-item">Overview</a>
+        <a href="<%= file_path('code_index.html') %>" class="project-nav-item">Code</a>
+        <a href="<%= file_path('smells_index.html') %>" class="project-nav-item">Smells</a>
       </nav>
     </header>
     <%= yield %>

data/lib/rubycritic/report_generators/view_helpers.rb

@@ -8,27 +8,37 @@ module Rubycritic
     end
 
     def javascript_tag(file)
-      "<script src='" + asset_path(File.join("javascripts", "#{file}.js")) + "'></script>"
+      "<script src='" + asset_path("javascripts", "#{file}.js").to_s + "'></script>"
     end
 
     def stylesheet_path(file)
-      asset_path(File.join("stylesheets", "#{file}.css"))
+      asset_path("stylesheets", "#{file}.css")
     end
 
-    def asset_path(file)
-      File.join(root_directory, "assets", file)
+    def asset_path(*fragments)
+      relative_path(([root_directory, "assets"] + fragments).reduce(:+))
     end
 
     def file_path(file)
-      File.join(root_directory, Pathname(file).sub_ext(".html"))
+      relative_path(root_directory + file)
     end
 
     def smell_location_path(location)
-      File.join(root_directory, "#{location.pathname.sub_ext('.html')}#L#{location.line}")
+      relative_path(root_directory + "#{location.pathname.sub_ext('.html')}#L#{location.line}")
+    end
+
+    private
+
+    def relative_path(pathname)
+      pathname.relative_path_from(file_directory)
+    end
+
+    def file_directory
+      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
     end
 
     def root_directory
-      ::Rubycritic.configuration.root
+      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
     end
   end
 

data/lib/rubycritic/version.rb

@@ -1,3 +1,3 @@
 module Rubycritic
-  VERSION = "0.0.15"
+  VERSION = "0.0.16"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 0.0.15
+  version: 0.0.16
 platform: ruby
 authors:
 - Guilherme Simoes