rubycritic 0.0.12 → 0.0.13
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/lib/rubycritic.rb +3 -22
- data/lib/rubycritic/adapters/complexity/flog.rb +1 -1
- data/lib/rubycritic/adapters/smell/flay.rb +1 -1
- data/lib/rubycritic/adapters/smell/flog.rb +1 -1
- data/lib/rubycritic/adapters/smell/reek.rb +1 -1
- data/lib/rubycritic/analysed_files_builder.rb +36 -0
- data/lib/rubycritic/analysers/config.reek +6 -2
- data/lib/rubycritic/analysers_runner.rb +2 -2
- data/lib/rubycritic/cli.rb +2 -1
- data/lib/rubycritic/core/analysed_file.rb +22 -0
- data/lib/rubycritic/{location.rb → core/location.rb} +0 -0
- data/lib/rubycritic/{smell.rb → core/smell.rb} +10 -4
- data/lib/rubycritic/orchestrators/base.rb +27 -0
- data/lib/rubycritic/orchestrators/main.rb +14 -0
- data/lib/rubycritic/orchestrators/mini.rb +14 -0
- data/lib/rubycritic/report_generators/assets/javascripts/application.js +2 -9
- data/lib/rubycritic/report_generators/base.rb +43 -0
- data/lib/rubycritic/report_generators/code_file.rb +40 -0
- data/lib/rubycritic/report_generators/code_index.rb +29 -0
- data/lib/rubycritic/report_generators/line.rb +29 -0
- data/lib/rubycritic/report_generators/overview.rb +26 -0
- data/lib/rubycritic/report_generators/smells_index.rb +25 -0
- data/lib/rubycritic/report_generators/templates/{file.html.erb → code_file.html.erb} +2 -2
- data/lib/rubycritic/report_generators/templates/code_index.html.erb +3 -3
- data/lib/rubycritic/report_generators/templates/smells_index.html.erb +1 -1
- data/lib/rubycritic/report_generators/view_helpers.rb +0 -4
- data/lib/rubycritic/reporters/main.rb +55 -0
- data/lib/rubycritic/reporters/mini.rb +26 -0
- data/lib/rubycritic/revision_comparator.rb +1 -1
- data/lib/rubycritic/source_locator.rb +4 -4
- data/lib/rubycritic/turbulence.rb +8 -18
- data/lib/rubycritic/version.rb +1 -1
- data/test/lib/rubycritic/{quality_adapters → adapters/complexity}/flog_test.rb +2 -2
- data/test/lib/rubycritic/{smell_adapters → adapters/smell}/flay_test.rb +2 -2
- data/test/lib/rubycritic/{smell_adapters → adapters/smell}/flog_test.rb +0 -0
- data/test/lib/rubycritic/{smell_adapters → adapters/smell}/reek_test.rb +0 -0
- data/test/lib/rubycritic/analysed_files_builder_test.rb +36 -0
- data/test/lib/rubycritic/analysers_runner_test.rb +2 -2
- data/test/lib/rubycritic/core/analysed_file_test.rb +51 -0
- data/test/lib/rubycritic/{location_test.rb → core/location_test.rb} +1 -1
- data/test/lib/rubycritic/core/smell_test.rb +80 -0
- data/test/lib/rubycritic/{smells_array_test.rb → core/smells_array_test.rb} +1 -1
- data/test/lib/rubycritic/smells_status_setter_test.rb +1 -1
- data/test/lib/rubycritic/turbulence_test.rb +9 -18
- data/test/samples/reek/not_smelly.rb +10 -1
- metadata +36 -26
- data/lib/rubycritic/report_generators/base_generator.rb +0 -41
- data/lib/rubycritic/report_generators/code_index_generator.rb +0 -32
- data/lib/rubycritic/report_generators/file_generator.rb +0 -41
- data/lib/rubycritic/report_generators/line_generator.rb +0 -27
- data/lib/rubycritic/report_generators/overview_generator.rb +0 -24
- data/lib/rubycritic/report_generators/reporter.rb +0 -67
- data/lib/rubycritic/report_generators/smells_index_generator.rb +0 -23
- data/test/lib/rubycritic/smell_test.rb +0 -71
@@ -1,71 +0,0 @@
|
|
1
|
-
require "test_helper"
|
2
|
-
require "rubycritic/smell"
|
3
|
-
|
4
|
-
describe Rubycritic::Smell do
|
5
|
-
it "has a context reader" do
|
6
|
-
context = "#bar"
|
7
|
-
smell = Rubycritic::Smell.new(:context => context)
|
8
|
-
smell.context.must_equal context
|
9
|
-
end
|
10
|
-
|
11
|
-
it "has a locations reader" do
|
12
|
-
location = Rubycritic::Location.new("./foo", "42")
|
13
|
-
smell = Rubycritic::Smell.new(:locations => [location])
|
14
|
-
smell.locations.must_equal [location]
|
15
|
-
end
|
16
|
-
|
17
|
-
it "has a pathnames reader" do
|
18
|
-
path = Pathname.new("./foo")
|
19
|
-
location1 = Rubycritic::Location.new("./foo", "42")
|
20
|
-
location2 = Rubycritic::Location.new("./foo", "23")
|
21
|
-
smell = Rubycritic::Smell.new(:locations => [location1, location2])
|
22
|
-
smell.pathnames.must_equal [path]
|
23
|
-
end
|
24
|
-
|
25
|
-
it "has a message reader" do
|
26
|
-
message = "This smells"
|
27
|
-
smell = Rubycritic::Smell.new(:message => message)
|
28
|
-
smell.message.must_equal message
|
29
|
-
end
|
30
|
-
|
31
|
-
it "has a score reader" do
|
32
|
-
score = 0
|
33
|
-
smell = Rubycritic::Smell.new(:score => score)
|
34
|
-
smell.score.must_equal score
|
35
|
-
end
|
36
|
-
|
37
|
-
it "has a type reader" do
|
38
|
-
type = :complexity
|
39
|
-
smell = Rubycritic::Smell.new(:type => type)
|
40
|
-
smell.type.must_equal type
|
41
|
-
end
|
42
|
-
|
43
|
-
describe "#located_in?" do
|
44
|
-
it "returns true if the smell has a location that matches the location passed as argument" do
|
45
|
-
location = Rubycritic::Location.new("./foo", "42")
|
46
|
-
smell = Rubycritic::Smell.new(:locations => [location])
|
47
|
-
smell.located_in?(location).must_equal true
|
48
|
-
end
|
49
|
-
end
|
50
|
-
|
51
|
-
describe "#has_multiple_locations?" do
|
52
|
-
it "returns true if the smell has more than one location" do
|
53
|
-
location1 = Rubycritic::Location.new("./foo", "42")
|
54
|
-
location2 = Rubycritic::Location.new("./foo", "23")
|
55
|
-
smell = Rubycritic::Smell.new(:locations => [location1, location2])
|
56
|
-
smell.has_multiple_locations?.must_equal true
|
57
|
-
end
|
58
|
-
end
|
59
|
-
|
60
|
-
it "is comparable" do
|
61
|
-
attributes = {
|
62
|
-
:context => "#bar",
|
63
|
-
:message => "This smells",
|
64
|
-
:score => 0,
|
65
|
-
:type => :complexity
|
66
|
-
}
|
67
|
-
smell1 = Rubycritic::Smell.new(attributes)
|
68
|
-
smell2 = Rubycritic::Smell.new(attributes)
|
69
|
-
smell1.must_equal smell2
|
70
|
-
end
|
71
|
-
end
|