rubycritic 0.0.11 → 0.0.12

data/lib/rubycritic/report_generators/assets/stylesheets/application.css

@@ -39,31 +39,29 @@ html {
   margin: 0 auto;
 }
 
-.code-table,
-.smells-table {
+.analysis-index-table {
   width: 100%;
   border-collapse: collapse;
 }
 
-.code-table th,
-.smells-table th {
+.analysis-index-table th {
   text-align: left;
-  padding-bottom: 8px;
+  padding: 8px 10px;
   border-bottom: 1px solid silver;
   font-size: 1.55em;
   font-weight: normal;
 }
 
-.code-table td,
-.smells-table td {
-  padding-top: 12px;
-  padding-bottom: 12px;
+.sortable-table th:hover {
+  background-color: #ECECEC;
+  cursor: pointer;
+}
+
+.analysis-index-table td {
+  padding: 12px 10px;
 }
 
-.code-table tr td:first-child,
-.code-table tr th:first-child,
-.smells-table tr td:first-child,
-.smells-table tr th:first-child {
+.analysis-index-table .first-cell {
   padding-left: 60px;
 }
 

data/lib/rubycritic/report_generators/code_index_generator.rb

@@ -7,7 +7,7 @@ module Rubycritic
     TEMPLATE = erb_template("code_index.html.erb")
 
     def initialize(source_pathnames, smelly_pathnames)
-      @source_pathnames = source_pathnames.sort { |a, b| a.basename <=> b.basename }
+      @source_pathnames = source_pathnames
       @smelly_pathnames = smelly_pathnames
     end
 

data/lib/rubycritic/report_generators/templates/code_index.html.erb

@@ -1,14 +1,16 @@
-<table class="code-table">
+<table id="js-code-table" class="analysis-index-table sortable-table">
 <thead>
   <tr>
-    <th>Name</th>
+    <th class="first-cell">Name</th>
     <th>Smells</th>
   </tr>
 </thead>
 <tbody>
   <% @source_pathnames.each do |pathname| %>
     <tr>
-      <td><a href="<%= file_path(pathname) %>"><%= analysed_file_name(pathname) %></a></td>
+      <td class="first-cell">
+        <a href="<%= file_path(pathname) %>"><%= analysed_file_name(pathname) %></a>
+      </td>
       <td><%= smells_count(pathname) %></td>
     </tr>
   <% end %>

data/lib/rubycritic/report_generators/templates/layouts/application.html.erb

@@ -19,8 +19,10 @@
     </header>
     <%= yield %>
     <script src="<%= javascript_path(:'jquery-2.1.0') %>"></script>
-    <script src="<%= javascript_path(:'highcharts.src') %>"></script>
-    <script src="<%= javascript_path(:prettify) %>"></script>
+    <script src="<%= javascript_path(:'jquery.tablesorter-2.0') %>"></script>
+    <script src="<%= javascript_path(:'highcharts.src-4.0.1') %>"></script>
+    <script src="<%= javascript_path(:'jquery.scrollTo-1.4.11') %>"></script>
+    <script src="<%= javascript_path(:'prettify-4-Mar-2013') %>"></script>
     <script src="<%= javascript_path(:application) %>"></script>
   </body>
 </html>

data/lib/rubycritic/report_generators/templates/smells_index.html.erb

@@ -1,14 +1,14 @@
-<table class="smells-table">
+<table class="analysis-index-table">
 <thead>
   <tr>
-    <th>Smell</th>
+    <th class="first-cell">Smell</th>
     <th>Locations</th>
   </tr>
 </thead>
 <tbody>
   <% @smells.each do |smell| %>
     <tr>
-      <td><%= smell.type %></td>
+      <td class="first-cell"><%= smell.type %></td>
       <td>
         <% smell.locations.each do |location| %>
           <a href="<%= smell_location_path(location) %>"><%= location.file_name %></a>

data/lib/rubycritic/source_control_systems/git.rb

@@ -46,7 +46,7 @@ module Rubycritic
     end
 
     def stashes_count
-      `git stash list`.split("\n").length
+      `git stash list`.count("\n")
     end
 
     def travel_to_original_state

data/lib/rubycritic/turbulence.rb

@@ -1,6 +1,5 @@
 require "rubycritic/analysers/churn"
-require "rubycritic/analysers/flog"
-require "rubycritic/quality_adapters/flog"
+require "rubycritic/adapters/complexity/flog"
 
 module Rubycritic
 
@@ -13,9 +12,9 @@ module Rubycritic
     def data
       @paths.zip(churn, complexity).map do |path_info|
         {
-          name: path_info[0],
-          x: path_info[1],
-          y: path_info[2]
+          :name => path_info[0],
+          :x => path_info[1],
+          :y => path_info[2]
         }
       end
     end

data/lib/rubycritic/version.rb

@@ -1,3 +1,3 @@
 module Rubycritic
-  VERSION = "0.0.11"
+  VERSION = "0.0.12"
 end

data/test/lib/rubycritic/quality_adapters/flog_test.rb

@@ -1,6 +1,6 @@
 require "test_helper"
 require "rubycritic/analysers/flog"
-require "rubycritic/quality_adapters/flog"
+require "rubycritic/adapters/complexity/flog"
 
 describe Rubycritic::QualityAdapter::Flog do
   before do

data/test/lib/rubycritic/smell_adapters/flay_test.rb

@@ -1,5 +1,5 @@
 require "test_helper"
-require "rubycritic/smell_adapters/flay"
+require "rubycritic/adapters/smell/flay"
 
 describe Rubycritic::SmellAdapter::Flay do
   before do

data/test/lib/rubycritic/smell_adapters/flog_test.rb

@@ -1,5 +1,5 @@
 require "test_helper"
-require "rubycritic/smell_adapters/flog"
+require "rubycritic/adapters/smell/flog"
 
 describe Rubycritic::SmellAdapter::Flog do
   before do

data/test/lib/rubycritic/smell_adapters/reek_test.rb

@@ -1,5 +1,5 @@
 require "test_helper"
-require "rubycritic/smell_adapters/reek"
+require "rubycritic/adapters/smell/reek"
 
 describe Rubycritic::SmellAdapter::Reek do
   context "when analysing a smelly file" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-12 00:00:00.000000000 Z
+date: 2014-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -141,6 +141,10 @@ files:
 - bin/rubycritic
 - lib/rubycritic.rb
 - lib/rubycritic/active_support/methods.rb
+- lib/rubycritic/adapters/complexity/flog.rb
+- lib/rubycritic/adapters/smell/flay.rb
+- lib/rubycritic/adapters/smell/flog.rb
+- lib/rubycritic/adapters/smell/reek.rb
 - lib/rubycritic/analysers/churn.rb
 - lib/rubycritic/analysers/config.reek
 - lib/rubycritic/analysers/flay.rb
@@ -150,11 +154,12 @@ files:
 - lib/rubycritic/cli.rb
 - lib/rubycritic/configuration.rb
 - lib/rubycritic/location.rb
-- lib/rubycritic/quality_adapters/flog.rb
 - lib/rubycritic/report_generators/assets/javascripts/application.js
-- lib/rubycritic/report_generators/assets/javascripts/highcharts.src.js
+- lib/rubycritic/report_generators/assets/javascripts/highcharts.src-4.0.1.js
 - lib/rubycritic/report_generators/assets/javascripts/jquery-2.1.0.js
-- lib/rubycritic/report_generators/assets/javascripts/prettify.js
+- lib/rubycritic/report_generators/assets/javascripts/jquery.scrollTo-1.4.11.js
+- lib/rubycritic/report_generators/assets/javascripts/jquery.tablesorter-2.0.js
+- lib/rubycritic/report_generators/assets/javascripts/prettify-4-Mar-2013.js
 - lib/rubycritic/report_generators/assets/stylesheets/application.css
 - lib/rubycritic/report_generators/assets/stylesheets/prettify.custom_theme.css
 - lib/rubycritic/report_generators/base_generator.rb
@@ -174,9 +179,6 @@ files:
 - lib/rubycritic/report_generators/view_helpers.rb
 - lib/rubycritic/revision_comparator.rb
 - lib/rubycritic/smell.rb
-- lib/rubycritic/smell_adapters/flay.rb
-- lib/rubycritic/smell_adapters/flog.rb
-- lib/rubycritic/smell_adapters/reek.rb
 - lib/rubycritic/smells_serializer.rb
 - lib/rubycritic/smells_status_setter.rb
 - lib/rubycritic/source_control_systems/git.rb