rubycritic 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e3254c84987373469b8c33271f81794a5495b7a1
-  data.tar.gz: 7face22a8c659ef7fb50c701e2ceaab5925c618a
+  metadata.gz: 8ebaa6d00a861b24f55c474cec020a8377a7e392
+  data.tar.gz: 5cc6f6804dd52505d93e65e1faab58429fc1f168
 SHA512:
-  metadata.gz: 3f00535b10889d81455894436c7b79d117a085745fcc6e886dfb9aabf7c53bcb47827d4d1d9ca1a6b596a46e2a4f9b4ca0494b555e7552321f8ac76d887e1671
-  data.tar.gz: 5fd94e011dd5c5ae34fab83e23d528ec618307ce801fecb87cdf1971be8b32df281ee1c4ea05e12d338ac483a74f84b7566f9fd0ff7943f46661af8bad859496
+  metadata.gz: 586b8ad529ef714157aa4c95c5c69edf6e0c4c66a6a392763168af534845febb273bdcb6ecebcc04122d86f2d176ec6bd9afa86a6af6be0382630b65853f8b85
+  data.tar.gz: 0ac6a82d16c51b59958a32d6e55a76d255c55fd47080c7951c2be1ce43b6f9becbefdf338a2a16fd18f31d4ba5a2adafb907acffdda0f972914507941431e69d

data/lib/rubycritic.rb

@@ -1,22 +1,26 @@
 require "rubycritic/source_locator"
-require "rubycritic/analysers/reek"
-require "rubycritic/smell_adapters/reek"
+require "rubycritic/analysers_runner"
 require "rubycritic/smells_aggregator"
-require "rubycritic/report_generators/report_generator"
+require "rubycritic/source_control_systems/source_control_system"
+require "rubycritic/revision_comparator"
+require "rubycritic/report_generators/reporter"
 
 module Rubycritic
 
   class Rubycritic
-    def initialize(paths)
-      @source = SourceLocator.new(paths)
-
-      analyser = Analyser::Reek.new(@source.paths)
-      smell_adapters = [ SmellAdapter::Reek.new(analyser) ]
-      @aggregator = SmellsAggregator.new(smell_adapters)
+    def initialize(dirs)
+      @source = SourceLocator.new(dirs)
+      @source_control_system = SourceControlSystem.create
     end
 
     def critique
-      ReportGenerator.new(@source.pathnames, @aggregator.smelly_pathnames).generate_report
+      if @source_control_system.has_revision?
+        smelly_pathnames = RevisionComparator.new(@source.paths, @source_control_system).compare
+      else
+        smell_adapters = AnalysersRunner.new(@source.paths).run
+        smelly_pathnames = SmellsAggregator.new(smell_adapters).smelly_pathnames
+      end
+      Reporter.new(@source.pathnames, smelly_pathnames).generate_report
     end
   end
 

data/lib/rubycritic/analysers_runner.rb

@@ -0,0 +1,27 @@
+require "rubycritic/analysers/reek"
+require "rubycritic/smell_adapters/reek"
+
+module Rubycritic
+
+  class AnalysersRunner
+    ANALYSERS = ["Reek"]
+
+    def initialize(paths)
+      @paths = paths
+    end
+
+    def run
+      smell_adapters
+    end
+
+    private
+
+    def smell_adapters
+      ANALYSERS.map do |analyser_name|
+        analyser = Object.const_get("Rubycritic::Analyser::#{analyser_name}").new(@paths)
+        Object.const_get("Rubycritic::SmellAdapter::#{analyser_name}").new(analyser)
+      end
+    end
+  end
+
+end

data/lib/rubycritic/report_generators/assets/stylesheets/application.css

@@ -1,4 +1,12 @@
 .smelly {
   display: inline;
+  background-color: #FFE7C8;
+}
+
+.smell {
   background-color: #FFC8C8;
 }
+
+.smell.old {
+  background-color: #DFDFDF;
+}

data/lib/rubycritic/report_generators/base_generator.rb

@@ -0,0 +1,36 @@
+module Rubycritic
+
+  class BaseGenerator
+    REPORT_DIR = File.expand_path("tmp/rubycritic", Dir.getwd)
+    TEMPLATES_DIR = File.expand_path("../templates", __FILE__)
+
+    def file_pathname
+      File.join(file_directory, file_name)
+    end
+
+    def file_directory
+      raise NotImplementedError.new("You must implement the file_directory method.")
+    end
+
+    def file_name
+      raise NotImplementedError.new("You must implement the file_name method.")
+    end
+
+    def render
+      raise NotImplementedError.new("You must implement the render file_name method.")
+    end
+
+    def stylesheet_path
+      File.join(REPORT_DIR, "assets/stylesheets/application.css")
+    end
+
+    def index_path
+      File.join(REPORT_DIR, "index.html")
+    end
+
+    def get_binding
+      binding
+    end
+  end
+
+end

data/lib/rubycritic/report_generators/file_generator.rb

@@ -1,12 +1,11 @@
 require "erb"
+require "rubycritic/report_generators/base_generator"
 require "rubycritic/report_generators/line_generator"
 
 module Rubycritic
 
-  class FileGenerator
+  class FileGenerator < BaseGenerator
     LINE_NUMBER_OFFSET = 1
-    REPORT_DIR = File.expand_path("tmp/rubycritic", Dir.getwd)
-    TEMPLATES_DIR = File.expand_path("../templates", __FILE__)
     FILE_TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "file.html.erb")))
     LAYOUT_TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "layouts", "application.html.erb")))
 
@@ -15,42 +14,27 @@ module Rubycritic
       @smells = smells
     end
 
-    def file_pathname
-      File.join(file_directory, file_name)
-    end
-
     def file_directory
       File.join(REPORT_DIR, File.dirname(@pathname))
     end
 
     def file_name
-      "#{@pathname.basename.sub_ext('')}.html"
-    end
-
-    def output
-      output ||= file_content
+      "#{analysed_file_name}.html"
     end
 
-    def stylesheet_path
-      File.join(REPORT_DIR, "assets/stylesheets/application.css")
+    def analysed_file_name
+      @pathname.basename.sub_ext('').to_s
     end
 
-    def get_binding
-      binding
-    end
-
-    private
-
-    def file_content
+    def render
       file_code = ""
       File.readlines(@pathname).each.with_index(LINE_NUMBER_OFFSET) do |line_text, line_number|
         location = Location.new(@pathname, line_number)
         line_smells = @smells.select { |smell| smell.located_in?(location) }
-        file_code << LineGenerator.new(line_text, line_number, line_smells).output
+        file_code << LineGenerator.new(line_text, line_number, line_smells).render
       end
 
       file_body = FILE_TEMPLATE.result(self.get_binding { file_code })
-
       LAYOUT_TEMPLATE.result(self.get_binding { file_body })
     end
   end

data/lib/rubycritic/report_generators/index_generator.rb

@@ -0,0 +1,28 @@
+require "erb"
+require "rubycritic/report_generators/base_generator"
+
+module Rubycritic
+
+  class IndexGenerator < BaseGenerator
+    INDEX_TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "index.html.erb")))
+    LAYOUT_TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "layouts", "application.html.erb")))
+
+    def initialize(file_generators)
+      @file_generators = file_generators.sort { |a, b| a.analysed_file_name <=> b.analysed_file_name }
+    end
+
+    def file_directory
+      REPORT_DIR
+    end
+
+    def file_name
+      "index.html"
+    end
+
+    def render
+      index_body = INDEX_TEMPLATE.result(self.get_binding)
+      LAYOUT_TEMPLATE.result(self.get_binding { index_body })
+    end
+  end
+
+end

data/lib/rubycritic/report_generators/line_generator.rb

@@ -1,11 +1,11 @@
-require "cgi"
 require "erb"
+require "rubycritic/report_generators/base_generator"
+require "cgi"
 
 module Rubycritic
 
-  class LineGenerator
+  class LineGenerator < BaseGenerator
     LINE_NUMBER_PADDING = 3
-    TEMPLATES_DIR = File.expand_path("../templates", __FILE__)
     NORMAL_TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "line.html.erb")))
     SMELLY_TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "smelly_line.html.erb")))
 
@@ -21,8 +21,8 @@ module Rubycritic
         end
     end
 
-    def output
-      @output ||= @template.result(binding).delete("\n") + "\n"
+    def render
+      @template.result(binding).delete("\n") + "\n"
     end
   end
 

data/lib/rubycritic/report_generators/reporter.rb

@@ -0,0 +1,44 @@
+require "rubycritic/report_generators/base_generator"
+require "rubycritic/report_generators/file_generator"
+require "rubycritic/report_generators/index_generator"
+require "fileutils"
+
+module Rubycritic
+
+  class Reporter
+    ASSETS_DIR = File.expand_path("../assets", __FILE__)
+
+    def initialize(source_pathnames, smelly_pathnames)
+      @source_pathnames = source_pathnames
+      @smelly_pathnames = smelly_pathnames
+    end
+
+    def generate_report
+      generators.each do |generator|
+        FileUtils.mkdir_p(generator.file_directory)
+        File.open(generator.file_pathname, "w+") do |file|
+          file.write(generator.render)
+        end
+      end
+      FileUtils.cp_r(ASSETS_DIR, BaseGenerator::REPORT_DIR)
+    end
+
+    private
+
+    def generators
+      file_generators + [index_generator]
+    end
+
+    def index_generator
+      IndexGenerator.new(file_generators)
+    end
+
+    def file_generators
+      @file_generators ||= @source_pathnames.map do |pathname|
+        file_smells = @smelly_pathnames[pathname]
+        FileGenerator.new(pathname, file_smells)
+      end
+    end
+  end
+
+end

data/lib/rubycritic/report_generators/templates/index.html.erb

@@ -0,0 +1,14 @@
+<table>
+<thead>
+  <tr>
+    <th>Name</th>
+  </tr>
+</thead>
+<tbody>
+  <% @file_generators.each do |file_generator| %>
+  <tr>
+    <td><a href="<%= file_generator.file_pathname %>"><%= file_generator.analysed_file_name %></a></td>
+  </tr>
+  <% end %>
+</tbody>
+</table>

data/lib/rubycritic/report_generators/templates/layouts/application.html.erb

@@ -9,7 +9,7 @@
         <meta name="viewport" content="width=device-width, initial-scale=1">
     </head>
     <body>
-        <h1>RubyCritic</h1>
+        <h1><a href="<%= index_path %>">RubyCritic</a></h1>
 
         <%= yield %>
     </body>

data/lib/rubycritic/report_generators/templates/smelly_line.html.erb

@@ -1 +1 @@
-<div class='smelly'><%= @number %>. <%= @text %> # <% @smells.each { |smell| %><%= smell %><% } %></div>
+<div class='smelly'><%= @number %>. <%= @text %><% @smells.each { |smell| %><span class="smell <%= smell.status %>"> # <%= smell %><span><% } %></div>

data/lib/rubycritic/revision_comparator.rb

@@ -0,0 +1,55 @@
+require "rubycritic/smelly_pathnames_serializer"
+require "rubycritic/source_locator"
+require "rubycritic/analysers_runner"
+require "rubycritic/smells_aggregator"
+require "rubycritic/smells_status_setter"
+
+module Rubycritic
+
+  class RevisionComparator
+    SNAPSHOTS_DIR = File.expand_path("tmp/rubycritic/snapshots", Dir.getwd)
+
+    def initialize(paths, source_control_system)
+      @paths = paths
+      @source_control_system = source_control_system
+    end
+
+    def compare
+      SmellsStatusSetter.new(smelly_pathnames_before, smelly_pathnames_now).smelly_pathnames
+    end
+
+    private
+
+    def smelly_pathnames_before
+      serializer = SmellyPathnamesSerializer.new(revision_file)
+      if File.file?(revision_file)
+        serializer.load
+      else
+        smelly_pathnames = nil
+        @source_control_system.travel_to_head do
+          smelly_pathnames = smelly_pathnames(paths_of_tracked_files)
+        end
+        serializer.dump(smelly_pathnames)
+        smelly_pathnames
+      end
+    end
+
+    def smelly_pathnames_now
+      smelly_pathnames(@paths)
+    end
+
+    def smelly_pathnames(paths)
+      smell_adapters = AnalysersRunner.new(paths).run
+      SmellsAggregator.new(smell_adapters).smelly_pathnames
+    end
+
+    def revision_file
+      @revision_file ||= File.join(SNAPSHOTS_DIR, @source_control_system.head_reference)
+    end
+
+    def paths_of_tracked_files
+      SourceLocator.new(["."]).paths
+    end
+  end
+
+end

data/lib/rubycritic/smell.rb

@@ -11,6 +11,7 @@ module Rubycritic
     attribute :message
     attribute :score
     attribute :type
+    attribute :status
 
     def pathnames
       @pathnames ||= locations.map(&:pathname).uniq
@@ -20,6 +21,11 @@ module Rubycritic
       locations.any? { |location| location == other_location }
     end
 
+    def ==(other)
+      self.class == other.class && state == other.state
+    end
+    alias_method :eql?, :==
+
     def <=>(other)
       locations <=> other.locations
     end
@@ -27,6 +33,16 @@ module Rubycritic
     def to_s
       "(#{type}) #{context} #{message}"
     end
+
+    def hash
+      state.hash
+    end
+
+    protected
+
+    def state
+      [@context, @message, @score, @type]
+    end
   end
 
 end

data/lib/rubycritic/smells_status_setter.rb

@@ -0,0 +1,27 @@
+module Rubycritic
+
+  class SmellsStatusSetter
+    def initialize(smelly_pathnames_before, smelly_pathnames_now)
+      @smelly_pathnames_before = smelly_pathnames_before
+      @smelly_pathnames_now = smelly_pathnames_now
+    end
+
+    def smelly_pathnames
+      @smelly_pathnames_now.each do |pathname, smells_now|
+        smells_before = @smelly_pathnames_before[pathname] || []
+        old_smells = smells_now & smells_before
+        set_status(old_smells, :old)
+        new_smells = smells_now - smells_before
+        set_status(new_smells, :new)
+      end
+      @smelly_pathnames_now
+    end
+
+    private
+
+    def set_status(smells, status)
+      smells.each { |smell| smell.status = status }
+    end
+  end
+
+end

data/lib/rubycritic/smelly_pathnames_serializer.rb

@@ -0,0 +1,34 @@
+require "fileutils"
+
+module Rubycritic
+
+  class SmellyPathnamesSerializer
+    def initialize(file_name)
+      @file_name = file_name
+    end
+
+    def load
+      Marshal.load(File.read(@file_name))
+    end
+
+    def dump(smelly_pathnames)
+      create_file_directory
+      # HACK It's not possible to Marshal procs or lambdas.
+      smelly_pathnames.default = []
+      File.open(@file_name, "w+") do |file|
+        Marshal.dump(smelly_pathnames, file)
+      end
+    end
+
+    private
+
+    def create_file_directory
+      FileUtils.mkdir_p(file_directory)
+    end
+
+    def file_directory
+      File.dirname(@file_name)
+    end
+  end
+
+end

data/lib/rubycritic/source_control_systems/git.rb

@@ -0,0 +1,38 @@
+module Rubycritic
+
+  class Git < SourceControlSystem
+    register_system
+
+    def self.supported?
+      `git branch 2>&1` && $?.success?
+    end
+
+    def self.to_s
+      "Git"
+    end
+
+    def has_revision?
+      head_reference && $?.success?
+    end
+
+    def travel_to_head
+      if uncommited_changes?
+        stashed_changes = `git stash` && $?.success?
+      end
+      yield
+    ensure
+      `git stash pop` if stashed_changes
+    end
+
+    def head_reference
+      `git rev-parse --verify HEAD`.chomp
+    end
+
+    private
+
+    def uncommited_changes?
+      !`git status --porcelain`.empty?
+    end
+  end
+
+end

data/lib/rubycritic/source_control_systems/source_control_system.rb

@@ -0,0 +1,42 @@
+module Rubycritic
+
+  class SourceControlSystem
+    @@systems = []
+
+    def self.register_system
+      @@systems << self
+    end
+
+    def self.create
+      supported_system = systems.detect(&:supported?)
+      if supported_system
+        supported_system.new
+      else
+        raise "Rubycritic requires a #{system_names} repository."
+      end
+    end
+
+    def self.systems
+      @@systems
+    end
+
+    def self.system_names
+      systems.join(", ")
+    end
+
+    def has_revision?
+      raise NotImplementedError.new("You must implement the has_revision? method.")
+    end
+
+    def travel_to_head
+      raise NotImplementedError.new("You must implement the travel_to_head method.")
+    end
+
+    def head_reference
+      raise NotImplementedError.new("You must implement the head_reference method.")
+    end
+  end
+
+end
+
+require "rubycritic/source_control_systems/git"

data/lib/rubycritic/source_locator.rb

@@ -1,7 +1,8 @@
 module Rubycritic
 
   class SourceLocator
-    RUBY_FILES = File.join("**", "*.rb")
+    RUBY_EXTENSION = ".rb"
+    RUBY_FILES = File.join("**", "*#{RUBY_EXTENSION}")
 
     def initialize(dirs)
       @dirs = dirs
@@ -21,7 +22,7 @@ module Rubycritic
       @dirs.map do |path|
         if File.directory?(path)
           Pathname.glob(RUBY_FILES)
-        elsif File.exists?(path)
+        elsif File.exists?(path) && File.extname(path) == RUBY_EXTENSION
           Pathname.new(path)
         end
       end.flatten.compact.sort

data/lib/rubycritic/version.rb

@@ -1,3 +1,3 @@
 module Rubycritic
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/test/lib/rubycritic/metric_adapters/flog_adapter_test.rb

@@ -4,8 +4,8 @@ require "rubycritic/smell_adapters/flog"
 
 describe Rubycritic::SmellAdapter::Flog do
   before do
-    @sample_path = "test/samples/flog/smelly.rb"
-    flog = Rubycritic::Analyser::Flog.new([@sample_path])
+    sample_path = "test/samples/flog/smelly.rb"
+    flog = Rubycritic::Analyser::Flog.new([sample_path])
     @adapter = Rubycritic::SmellAdapter::Flog.new(flog)
   end
 

data/test/lib/rubycritic/metric_adapters/reek_adapter_test.rb

@@ -5,8 +5,8 @@ require "rubycritic/smell_adapters/reek"
 describe Rubycritic::SmellAdapter::Reek do
   context "when analysing a smelly file" do
     before do
-      @sample_path = "test/samples/reek/smelly.rb"
-      reek = Rubycritic::Analyser::Reek.new([@sample_path])
+      sample_path = "test/samples/reek/smelly.rb"
+      reek = Rubycritic::Analyser::Reek.new([sample_path])
       @adapter = Rubycritic::SmellAdapter::Reek.new(reek)
     end
 
@@ -23,7 +23,7 @@ describe Rubycritic::SmellAdapter::Reek do
   context "when analysing a file with smells ignored in config.reek" do
     before do
       sample_path = "test/samples/reek/not_smelly.rb"
-      reek = Rubycritic::Analyser::Reek.new(sample_path)
+      reek = Rubycritic::Analyser::Reek.new([sample_path])
       @adapter = Rubycritic::SmellAdapter::Reek.new(reek)
     end
 

data/test/lib/rubycritic/smell_test.rb

@@ -40,13 +40,6 @@ describe Rubycritic::Smell do
     smell.type.must_equal type
   end
 
-  it "is sortable" do
-    location1 = Rubycritic::Location.new("./foo", 42)
-    location2 = Rubycritic::Location.new("./bar", 23)
-    location3 = Rubycritic::Location.new("./bar", 16)
-    [location1, location2, location3].sort.must_equal [location3, location2, location1]
-  end
-
   describe "#located_in?" do
     it "returns true if the smell has a location that matches the location passed as argument" do
       location = Rubycritic::Location.new("./foo", "42")
@@ -54,4 +47,16 @@ describe Rubycritic::Smell do
       smell.located_in?(location).must_equal true
     end
   end
+
+  it "is comparable" do
+    attributes = {
+      :context => "#bar",
+      :message => "This smells",
+      :score => 0,
+      :type => :complexity
+    }
+    smell1 = Rubycritic::Smell.new(attributes)
+    smell2 = Rubycritic::Smell.new(attributes)
+    smell1.must_equal smell2
+  end
 end

data/test/lib/rubycritic/smells_array_test.rb

@@ -0,0 +1,28 @@
+require "test_helper"
+require "rubycritic/smell"
+
+describe "Array of Smells" do
+  it "is sortable" do
+    location1 = Rubycritic::Location.new("./foo", 42)
+    location2 = Rubycritic::Location.new("./bar", 23)
+    location3 = Rubycritic::Location.new("./bar", 16)
+    smell1 = Rubycritic::Smell.new(:locations => [location1])
+    smell2 = Rubycritic::Smell.new(:locations => [location2])
+    smell3 = Rubycritic::Smell.new(:locations => [location3])
+    [smell1, smell2, smell3].sort.must_equal [smell3, smell2, smell1]
+  end
+
+  it "implements set intersection" do
+    smell1 = Rubycritic::Smell.new(:context => "#bar")
+    smell2 = Rubycritic::Smell.new(:context => "#bar")
+    smell3 = Rubycritic::Smell.new(:context => "#foo")
+    ([smell1, smell3] & [smell2]).must_equal [smell1]
+  end
+
+  it "implements set union" do
+    smell1 = Rubycritic::Smell.new(:context => "#bar")
+    smell2 = Rubycritic::Smell.new(:context => "#bar")
+    smell3 = Rubycritic::Smell.new(:context => "#foo")
+    ([smell1, smell3] | [smell2]).must_equal [smell1, smell3]
+  end
+end

data/test/lib/rubycritic/smells_status_setter_test.rb

@@ -0,0 +1,22 @@
+require "test_helper"
+require "rubycritic/smell"
+require "rubycritic/smells_status_setter"
+
+describe Rubycritic::SmellsStatusSetter do
+  describe "#smelly_pathnames" do
+    before do
+      @smell = Rubycritic::Smell.new(:context => "#bar")
+      @smelly_pathnames = { "file0.rb" => [@smell] }
+    end
+
+    it "marks old smells" do
+      Rubycritic::SmellsStatusSetter.new(@smelly_pathnames, @smelly_pathnames).smelly_pathnames
+      @smell.status.must_equal :old
+    end
+
+    it "marks new smells" do
+      Rubycritic::SmellsStatusSetter.new({}, @smelly_pathnames).smelly_pathnames
+      @smell.status.must_equal :new
+    end
+  end
+end

data/test/lib/rubycritic/source_control_systems/source_control_system_test.rb

@@ -0,0 +1,26 @@
+require "test_helper"
+require "rubycritic/source_control_systems/source_control_system"
+
+describe Rubycritic::SourceControlSystem do
+  before do
+    Rubycritic::SourceControlSystem.systems.each do |system|
+      system.stubs(:supported?).returns(false)
+    end
+  end
+
+  describe "::create" do
+    describe "when a source control system is found" do
+      it "creates an instance of that source control system" do
+        Rubycritic::Git.stubs(:supported?).returns(true)
+        system = Rubycritic::SourceControlSystem.create
+        system.must_be_instance_of Rubycritic::Git
+      end
+    end
+
+    describe "when no source control system is found" do
+      it "raises an error" do
+        proc { Rubycritic::SourceControlSystem.create }.must_raise RuntimeError
+      end
+    end
+  end
+end

data/test/lib/rubycritic/source_locator_test.rb

@@ -1,5 +1,6 @@
 require "test_helper"
 require "rubycritic/source_locator"
+require "pathname"
 
 describe Rubycritic::SourceLocator do
   before do
@@ -23,10 +24,15 @@ describe Rubycritic::SourceLocator do
       Rubycritic::SourceLocator.new(["."]).paths.must_equal paths
     end
 
-    it "deals with non-existent paths" do
+    it "ignores non-existent paths" do
       paths = ["non_existent_dir1/non_existent_file1.rb", "non_existent_file0.rb"]
       Rubycritic::SourceLocator.new(paths).paths.must_equal []
     end
+
+    it "ignores existent paths that do not match the Ruby extension" do
+      paths = ["file_with_no_extension", "file_with_different_extension.py"]
+      Rubycritic::SourceLocator.new(paths).paths.must_equal []
+    end
   end
 
   describe "#pathnames" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-18 00:00:00.000000000 Z
+date: 2014-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -129,20 +129,29 @@ files:
 - lib/rubycritic/analysers/config.reek
 - lib/rubycritic/analysers/flog.rb
 - lib/rubycritic/analysers/reek.rb
+- lib/rubycritic/analysers_runner.rb
 - lib/rubycritic/cli.rb
 - lib/rubycritic/location.rb
 - lib/rubycritic/report_generators/assets/stylesheets/application.css
+- lib/rubycritic/report_generators/base_generator.rb
 - lib/rubycritic/report_generators/file_generator.rb
+- lib/rubycritic/report_generators/index_generator.rb
 - lib/rubycritic/report_generators/line_generator.rb
-- lib/rubycritic/report_generators/report_generator.rb
+- lib/rubycritic/report_generators/reporter.rb
 - lib/rubycritic/report_generators/templates/file.html.erb
+- lib/rubycritic/report_generators/templates/index.html.erb
 - lib/rubycritic/report_generators/templates/layouts/application.html.erb
 - lib/rubycritic/report_generators/templates/line.html.erb
 - lib/rubycritic/report_generators/templates/smelly_line.html.erb
+- lib/rubycritic/revision_comparator.rb
 - lib/rubycritic/smell.rb
 - lib/rubycritic/smell_adapters/flog.rb
 - lib/rubycritic/smell_adapters/reek.rb
 - lib/rubycritic/smells_aggregator.rb
+- lib/rubycritic/smells_status_setter.rb
+- lib/rubycritic/smelly_pathnames_serializer.rb
+- lib/rubycritic/source_control_systems/git.rb
+- lib/rubycritic/source_control_systems/source_control_system.rb
 - lib/rubycritic/source_locator.rb
 - lib/rubycritic/version.rb
 - rubycritic.gemspec
@@ -151,11 +160,16 @@ files:
 - test/lib/rubycritic/metric_adapters/reek_adapter_test.rb
 - test/lib/rubycritic/smell_test.rb
 - test/lib/rubycritic/smells_aggregator_test.rb
+- test/lib/rubycritic/smells_array_test.rb
+- test/lib/rubycritic/smells_status_setter_test.rb
+- test/lib/rubycritic/source_control_systems/source_control_system_test.rb
 - test/lib/rubycritic/source_locator_test.rb
 - test/lib/rubycritic/version_test.rb
 - test/samples/flog/smelly.rb
 - test/samples/location/dir1/file1.rb
 - test/samples/location/file0.rb
+- test/samples/location/file_with_different_extension.py
+- test/samples/location/file_with_no_extension
 - test/samples/reek/not_smelly.rb
 - test/samples/reek/smelly.rb
 - test/test_helper.rb
@@ -189,11 +203,16 @@ test_files:
 - test/lib/rubycritic/metric_adapters/reek_adapter_test.rb
 - test/lib/rubycritic/smell_test.rb
 - test/lib/rubycritic/smells_aggregator_test.rb
+- test/lib/rubycritic/smells_array_test.rb
+- test/lib/rubycritic/smells_status_setter_test.rb
+- test/lib/rubycritic/source_control_systems/source_control_system_test.rb
 - test/lib/rubycritic/source_locator_test.rb
 - test/lib/rubycritic/version_test.rb
 - test/samples/flog/smelly.rb
 - test/samples/location/dir1/file1.rb
 - test/samples/location/file0.rb
+- test/samples/location/file_with_different_extension.py
+- test/samples/location/file_with_no_extension
 - test/samples/reek/not_smelly.rb
 - test/samples/reek/smelly.rb
 - test/test_helper.rb

data/lib/rubycritic/report_generators/report_generator.rb

@@ -1,31 +0,0 @@
-require "fileutils"
-require "rubycritic/report_generators/file_generator"
-
-module Rubycritic
-
-  class ReportGenerator
-    ASSETS_DIR = File.expand_path("../assets", __FILE__)
-    REPORT_DIR = File.expand_path("tmp/rubycritic", Dir.getwd)
-
-    def initialize(source_pathnames, smelly_pathnames)
-      @source_pathnames = source_pathnames
-      @smelly_pathnames = smelly_pathnames
-    end
-
-    def generate_report
-      FileUtils.mkdir_p(REPORT_DIR)
-      FileUtils.cp_r(ASSETS_DIR, REPORT_DIR)
-
-      @source_pathnames.each do |pathname|
-        file_smells = @smelly_pathnames[pathname]
-        file_generator = FileGenerator.new(pathname, file_smells)
-
-        FileUtils.mkdir_p(file_generator.file_directory)
-        File.open(file_generator.file_pathname, "w+") do |report_file|
-          report_file.write(file_generator.output)
-        end
-      end
-    end
-  end
-
-end