rubycas-client 2.3.1 → 2.3.2

data/.rspec

@@ -0,0 +1,2 @@
+--format nested
+--color

data/.travis.yml

@@ -0,0 +1,5 @@
+rvm:
+  - 1.8.7
+  - 1.9.2
+  - 1.9.3
+  - ree

data/Gemfile

@@ -1,13 +1,14 @@
 source "http://rubygems.org"
 
 group :development do
-  gem "riot"
-  gem "rr"
+  gem "json", "~> 1.6.1"
+  gem "rspec", "~> 2.7.0"
   gem "bundler", "~> 1.0.0"
   gem "jeweler", "~> 1.6.2"
-  gem "rcov"
   gem "actionpack"
+  gem "rake"
+  gem "rcov"
 end
 
-gem "activesupport"
+gem "activesupport", :require => "active_support"
 

data/Gemfile.lock

@@ -5,17 +5,24 @@ GEM
       activesupport (= 2.3.11)
       rack (~> 1.1.0)
     activesupport (2.3.11)
+    diff-lcs (1.1.3)
     git (1.2.5)
-    jeweler (1.6.2)
+    jeweler (1.6.4)
       bundler (~> 1.0)
       git (>= 1.2.5)
       rake
+    json (1.6.1)
     rack (1.1.2)
-    rake (0.9.2)
-    rcov (0.9.9)
-    riot (0.12.5)
-      rr
-    rr (1.0.4)
+    rake (0.9.2.2)
+    rcov (0.9.11)
+    rspec (2.7.0)
+      rspec-core (~> 2.7.0)
+      rspec-expectations (~> 2.7.0)
+      rspec-mocks (~> 2.7.0)
+    rspec-core (2.7.1)
+    rspec-expectations (2.7.0)
+      diff-lcs (~> 1.1.2)
+    rspec-mocks (2.7.0)
 
 PLATFORMS
   ruby
@@ -25,6 +32,7 @@ DEPENDENCIES
   activesupport
   bundler (~> 1.0.0)
   jeweler (~> 1.6.2)
+  json (~> 1.6.1)
+  rake
   rcov
-  riot
-  rr
+  rspec (~> 2.7.0)

data/History.txt

@@ -1,6 +1,13 @@
 = RubyCAS-Client Changelog
 
-== Version 2.3.0 :: 2011-10-22
+== Version 2.3.2 :: 2011-11-11
+
+* Bug Fixes
+  * Removed a puts that didn't get cleaned up
+  * Fix a bug with parsing extra attributes caused by a strange edge
+    case in active_support
+
+== Version 2.3.1 :: 2011-10-22
 
 * New Functionality
   * Add configuration option to expect complex extra attributes to be encoded
@@ -33,7 +40,7 @@ See http://www.opensource.org/licenses/mit-license.php
 
 * New functionality:
   * Added config parameter force_ssl_verification (self explanatory) [Roberto Klein]
-  * Added explicit SingleSignutFilter for Rails (convenient?) [Adam Elliot]
+  * Added explicit SingleSigoutFilter for Rails (convenient?) [Adam Elliot]
   * Added support for faking out the filter; useful when testing. See
     http://github.com/gunark/rubycas-client/commit/1eb10cc285d59193eede3d4406f95cad9db9d93a
     [Brian Hogan]

data/Rakefile

@@ -19,28 +19,34 @@ Jeweler::Tasks.new do |gem|
   gem.summary = "Client library for the Central Authentication Service (CAS) protocol."
   gem.authors = ["Matt Zukowski", "Matt Walker", "Matt Campbell"]
   gem.rdoc_options = ['--main', 'README.rdoc']
-  gem.files.exclude '.rvmrc', '.infinity_test'
+  gem.files.exclude '.rvmrc', '.infinity_test', '.rbenv-version', '.rbenv-gemsets'
   # dependencies defined in Gemfile
 end
 Jeweler::RubygemsDotOrgTasks.new
 
-require 'rake/testtask'
-Rake::TestTask.new(:test) do |test|
-  test.libs << 'test'
-  test.pattern = 'test/**/*_test.rb'
-  test.verbose = true
+begin
+  require 'rcov/rcovtask'
+  Rcov::RcovTask.new do |test|
+    test.libs << 'test'
+    test.pattern = 'test/**/test_*.rb'
+    test.verbose = true
+    test.rcov_opts << '--exclude "gems/*"'
+  end
+rescue LoadError
+  puts "Hiding rcov tasks because rcov is not available"
 end
 
-require 'rcov/rcovtask'
-Rcov::RcovTask.new do |test|
-  test.libs << 'test'
-  test.pattern = 'test/**/test_*.rb'
-  test.verbose = true
-  test.rcov_opts << '--exclude "gems/*"'
+begin
+  require 'rspec/core/rake_task'
+  desc 'Run RSpecs to confirm that all functionality is working as expected'
+  RSpec::Core::RakeTask.new('spec') do |t|
+    t.pattern = 'spec/**/*_spec.rb'
+  end
+  task :default => :spec
+rescue LoadError
+  puts "Hiding spec tasks because RSpec is not available"
 end
 
-task :default => :test
-
 require 'rake/rdoctask'
 Rake::RDocTask.new do |rdoc|
   version = File.exist?('VERSION') ? File.read('VERSION') : ""

data/TODO.md

@@ -0,0 +1,44 @@
+# Planned Changes
+
+Also take a look at the [issues page](/rubycas/rubycas-client/issues)
+
+## Version 2.4
+
+1. Support for Ruby 1.9.3
+1. Integration with travis for CI
+  1. Test against Rails 2.3
+  1. Test without Rails
+  1. Test against 1.8.7, 1.9.2, 1.9.3, jruby
+
+## Version 3.0
+
+1. Convert test cases from riot to rspec2 - Done!
+1. Move Service Callback, PGT Callback and Single Sign Out Callback to
+   a Rack Middleware.
+
+## Version 3.1
+
+1. Cleanup the way Ticket Store integration works
+1. Improve test coverage for CASClient::Client
+1. Remove dependency on activesupport (expect in Rails specific classes)
+1. Support for Rails 3.0 and 3.1
+
+## Future
+
+1. Support for other Rubies (JRuby, Rubinius, etc.)
+1. Support for Rails 3.2
+
+# Documentation Needs
+
+## Improve/Rewrite Documentation
+
+The documentation isn't the clearest and is now a bit out of date. That
+needs addressing
+
+## Examples
+
+We could use some new and/or improved examples for
+
+1. Rails 2.3
+1. Rails 3.x
+1. Sinatra

data/VERSION

@@ -1 +1 @@
-2.3.1
+2.3.2

data/lib/casclient/responses.rb

@@ -66,9 +66,7 @@ module CASClient
         
         @extra_attributes = {}
         @xml.elements.to_a('//cas:authenticationSuccess/cas:attributes/* | //cas:authenticationSuccess/*[local-name() != \'proxies\' and local-name() != \'proxyGrantingTicket\' and local-name() != \'user\' and local-name() != \'attributes\']').each do |el|
-          # generating the hash requires prefixes to be defined, so add all of the namespaces
-          el.namespaces.each {|k,v| el.add_namespace(k,v)}
-          @extra_attributes.merge!(Hash.from_xml(el.to_s))
+          @extra_attributes.merge! el.name => el.text
         end
         
         # unserialize extra attributes

data/lib/casclient/tickets/storage/active_record_ticket_store.rb

@@ -56,7 +56,7 @@ module CASClient
         end
 
       end
-      puts "loaded active record ticket store!"
+
       ::ACTIVE_RECORD_TICKET_STORE = ActiveRecordTicketStore
 
       class CasPgtiou < ActiveRecord::Base

data/lib/casclient/tickets/storage.rb

@@ -63,13 +63,13 @@ module CASClient
       # worker processes have access to a shared file system.
       #
       # This ticket store takes the following config parameters
-      # :storage_dir - The directory to store data in. Defaults to RAILS_ROOT/tmp
+      # :storage_dir - The directory to store data in. Defaults to Rails.root/tmp
       # :service_session_lookup_dir - The directory to store Service Ticket/Session ID files in. Defaults to :storage_dir/sessions
       # :pgt_store_path - The location to store the pgt PStore file. Defaults to :storage_dir/cas_pgt.pstore
       class LocalDirTicketStore < AbstractTicketStore
         require 'pstore'
 
-        DEFAULT_TMP_DIR = defined?(RAILS_ROOT) ? "#{RAILS_ROOT}/tmp" : "#{Dir.pwd}/tmp"
+        DEFAULT_TMP_DIR = defined?(Rails.root) ? "#{Rails.root}/tmp" : "#{Dir.pwd}/tmp"
 
         def initialize(config={})
           config ||= {}

data/rubycas-client.gemspec

@@ -4,17 +4,19 @@
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
-  s.name = %q{rubycas-client}
-  s.version = "2.3.1"
+  s.name = "rubycas-client"
+  s.version = "2.3.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Matt Zukowski", "Matt Walker", "Matt Campbell"]
-  s.date = %q{2011-10-23}
+  s.date = "2011-11-11"
   s.extra_rdoc_files = [
     "LICENSE.txt",
     "README.rdoc"
   ]
   s.files = [
+    ".rspec",
+    ".travis.yml",
     "CHANGELOG.txt",
     "Gemfile",
     "Gemfile.lock",
@@ -22,6 +24,7 @@ Gem::Specification.new do |s|
     "LICENSE.txt",
     "README.rdoc",
     "Rakefile",
+    "TODO.md",
     "VERSION",
     "examples/rails/README",
     "examples/rails/app/controllers/advanced_example_controller.rb",
@@ -60,44 +63,48 @@ Gem::Specification.new do |s|
     "rails_generators/active_record_ticket_store/templates/README",
     "rails_generators/active_record_ticket_store/templates/migration.rb",
     "rubycas-client.gemspec",
-    "test/teststrap.rb",
-    "test/units/casclient/frameworks/rails/filter_test.rb"
+    "spec/casclient/frameworks/rails/filter_spec.rb",
+    "spec/casclient/validation_response_spec.rb",
+    "spec/spec_helper.rb"
   ]
-  s.homepage = %q{http://github.com/rubycas/rubycas-client}
+  s.homepage = "http://github.com/rubycas/rubycas-client"
   s.licenses = ["MIT"]
   s.rdoc_options = ["--main", "README.rdoc"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.7.2}
-  s.summary = %q{Client library for the Central Authentication Service (CAS) protocol.}
+  s.rubygems_version = "1.8.11"
+  s.summary = "Client library for the Central Authentication Service (CAS) protocol."
 
   if s.respond_to? :specification_version then
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<activesupport>, [">= 0"])
-      s.add_development_dependency(%q<riot>, [">= 0"])
-      s.add_development_dependency(%q<rr>, [">= 0"])
+      s.add_development_dependency(%q<json>, ["~> 1.6.1"])
+      s.add_development_dependency(%q<rspec>, ["~> 2.7.0"])
       s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.6.2"])
-      s.add_development_dependency(%q<rcov>, [">= 0"])
       s.add_development_dependency(%q<actionpack>, [">= 0"])
+      s.add_development_dependency(%q<rake>, [">= 0"])
+      s.add_development_dependency(%q<rcov>, [">= 0"])
     else
       s.add_dependency(%q<activesupport>, [">= 0"])
-      s.add_dependency(%q<riot>, [">= 0"])
-      s.add_dependency(%q<rr>, [">= 0"])
+      s.add_dependency(%q<json>, ["~> 1.6.1"])
+      s.add_dependency(%q<rspec>, ["~> 2.7.0"])
       s.add_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_dependency(%q<jeweler>, ["~> 1.6.2"])
-      s.add_dependency(%q<rcov>, [">= 0"])
       s.add_dependency(%q<actionpack>, [">= 0"])
+      s.add_dependency(%q<rake>, [">= 0"])
+      s.add_dependency(%q<rcov>, [">= 0"])
     end
   else
     s.add_dependency(%q<activesupport>, [">= 0"])
-    s.add_dependency(%q<riot>, [">= 0"])
-    s.add_dependency(%q<rr>, [">= 0"])
+    s.add_dependency(%q<json>, ["~> 1.6.1"])
+    s.add_dependency(%q<rspec>, ["~> 2.7.0"])
     s.add_dependency(%q<bundler>, ["~> 1.0.0"])
     s.add_dependency(%q<jeweler>, ["~> 1.6.2"])
-    s.add_dependency(%q<rcov>, [">= 0"])
     s.add_dependency(%q<actionpack>, [">= 0"])
+    s.add_dependency(%q<rake>, [">= 0"])
+    s.add_dependency(%q<rcov>, [">= 0"])
   end
 end
 

data/spec/casclient/frameworks/rails/filter_spec.rb

@@ -0,0 +1,175 @@
+require 'spec_helper'
+require 'action_controller'
+require 'casclient/frameworks/rails/filter'
+
+describe CASClient::Frameworks::Rails::Filter do
+
+  def controller_with_session(request = nil, session={})
+    request ||= mock_post_request
+    controller = double("Controller")
+    controller.stub(:session) {session}
+    controller.stub(:request) {request}
+    controller.stub(:url_for) {"bogusurl"}
+    controller.stub(:params) {{:ticket => "bogusticket", :renew => false}}
+    controller
+  end
+
+  def mock_post_request
+      mock_request = ActionController::Request.new({})
+      mock_request.stub(:post?) {true}
+      mock_request
+  end
+
+  before(:each) do
+    CASClient::Frameworks::Rails::Filter.configure(
+      :cas_base_url => 'http://test.local/',
+      :logger => double("Logger")
+    )
+  end
+
+  describe "#fake" do
+    subject { Hash.new }
+    context "faking user without attributes" do
+      before { CASClient::Frameworks::Rails::Filter.fake('tester@test.com') }
+      it 'should set the session user' do
+        CASClient::Frameworks::Rails::Filter.filter(controller_with_session(nil, subject))
+        subject.should eq({:cas_user => 'tester@test.com', :casfilteruser => 'tester@test.com'})
+      end
+      after { CASClient::Frameworks::Rails::Filter.fake(nil,nil) }
+    end
+
+    context "faking user with attributes" do
+      before { CASClient::Frameworks::Rails::Filter.fake('tester@test.com', {:test => 'stuff', :this => 'that'}) }
+      it 'should set the session user and attributes' do
+        CASClient::Frameworks::Rails::Filter.filter(controller_with_session(nil, subject))
+        subject.should eq({ :cas_user => 'tester@test.com', :casfilteruser => 'tester@test.com', :cas_extra_attributes => {:test => 'stuff', :this => 'that' }})
+      end
+      after { CASClient::Frameworks::Rails::Filter.fake(nil,nil) }
+    end
+  end
+
+  context "new valid service ticket" do
+     it "should return successfully from filter" do
+
+      pgt = CASClient::ProxyGrantingTicket.new(
+      "PGT-1308586001r9573FAD5A8C62E134A4AA93273F226BD3F0C3A983DCCCD176",
+      "PGTIOU-1308586001r29DC1F852C95930FE6694C1EFC64232A3359798893BC0B")
+
+      raw_text = "<cas:serviceResponse xmlns:cas=\"http://www.yale.edu/tp/cas\">
+                    <cas:authenticationSuccess>
+                      <cas:user>rich.yarger@vibes.com</cas:user>
+                      <cas:proxyGrantingTicket>PGTIOU-1308586001r29DC1F852C95930FE6694C1EFC64232A3359798893BC0B</cas:proxyGrantingTicket>
+                    </cas:authenticationSuccess>
+                  </cas:serviceResponse>"
+      response = CASClient::ValidationResponse.new(raw_text)
+
+      CASClient::Client.any_instance.stub(:request_cas_response).and_return(response)
+      CASClient::Client.any_instance.stub(:retrieve_proxy_granting_ticket).and_return(pgt)
+
+      controller = controller_with_session()
+      CASClient::Frameworks::Rails::Filter.filter(controller).should eq(true)
+     end
+  end
+
+  context "new invalid service ticket" do
+     it "should return failure from filter" do
+
+      raw_text = "<cas:serviceResponse xmlns:cas=\"http://www.yale.edu/tp/cas\">
+                    <cas:authenticationFailure>Some Error Text</cas:authenticationFailure>
+                  </cas:serviceResponse>"
+      response = CASClient::ValidationResponse.new(raw_text)
+
+      CASClient::Client.any_instance.stub(:request_cas_response).and_return(response)
+      CASClient::Frameworks::Rails::Filter.stub(:unauthorized!) {"bogusresponse"}
+
+      controller = controller_with_session()
+      CASClient::Frameworks::Rails::Filter.filter(controller).should eq(false)
+     end
+  end
+
+  context "does not have new input service ticket" do
+    context "with last service ticket" do
+       it "should return failure from filter" do
+
+        CASClient::Frameworks::Rails::Filter.stub(:unauthorized!) {"bogusresponse"}
+
+        controller = controller_with_session()
+        controller.stub(:params) {{}}
+        CASClient::Frameworks::Rails::Filter.filter(controller).should eq(false)
+       end
+    end
+
+    context "sent through gateway" do
+      context "gatewaying off" do
+         it "should return failure from filter" do
+
+          CASClient::Frameworks::Rails::Filter.stub(:unauthorized!) {"bogusresponse"}
+
+          CASClient::Frameworks::Rails::Filter.config[:use_gatewaying] = false 
+          controller = controller_with_session()
+          controller.session[:cas_sent_to_gateway] = true
+          controller.stub(:params) {{}}
+          CASClient::Frameworks::Rails::Filter.filter(controller).should eq(false)
+         end
+      end
+
+      context "gatewaying on" do
+         it "should return failure from filter" do
+
+          CASClient::Frameworks::Rails::Filter.config[:use_gatewaying] = true 
+          controller = controller_with_session()
+          controller.session[:cas_sent_to_gateway] = true
+          controller.stub(:params) {{}}
+          CASClient::Frameworks::Rails::Filter.filter(controller).should eq(true)
+         end
+      end
+    end
+  end
+
+  context "has new input service ticket" do
+    context "no PGT" do
+       it "should return failure from filter" do
+
+        raw_text = "<cas:serviceResponse xmlns:cas=\"http://www.yale.edu/tp/cas\">
+                      <cas:authenticationSuccess>
+                        <cas:user>rich.yarger@vibes.com</cas:user>
+                        <cas:proxyGrantingTicket>PGTIOU-1308586001r29DC1F852C95930FE6694C1EFC64232A3359798893BC0B</cas:proxyGrantingTicket>
+                      </cas:authenticationSuccess>
+                    </cas:serviceResponse>"
+        response = CASClient::ValidationResponse.new(raw_text)
+
+        CASClient::Client.any_instance.stub(:request_cas_response).and_return(response)
+        CASClient::Client.any_instance.stub(:retrieve_proxy_granting_ticket).and_raise CASClient::CASException
+
+        controller = controller_with_session()
+        expect { CASClient::Frameworks::Rails::Filter.filter(controller) }.to raise_error(CASClient::CASException)
+       end
+    end
+
+    context "cannot connect to CASServer" do
+       it "should return failure from filter" do
+
+        CASClient::Client.any_instance.stub(:request_cas_response).and_raise "Some exception"
+
+        controller = controller_with_session()
+        expect { CASClient::Frameworks::Rails::Filter.filter(controller) }.to raise_error(RuntimeError)
+       end
+    end
+
+    context "matches existing service ticket" do
+      subject { Hash.new }
+      it "should return successfully from filter" do
+
+        mock_client = CASClient::Client.new()
+        mock_client.should_receive(:request_cas_response).at_most(0).times
+        mock_client.should_receive(:retrieve_proxy_granting_ticket).at_most(0).times
+        CASClient::Frameworks::Rails::Filter.send(:class_variable_set, :@@client, mock_client)
+
+        subject[:cas_last_valid_ticket] = 'bogusticket'
+        subject[:cas_last_valid_ticket_service] = 'bogusurl'
+        controller = controller_with_session(mock_post_request(), subject)
+        CASClient::Frameworks::Rails::Filter.filter(controller).should eq(true)
+      end
+    end
+  end
+end

data/spec/casclient/validation_response_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+require 'casclient/responses.rb'
+
+describe CASClient::ValidationResponse do
+  context "when parsing extra attributes as JSON" do
+    let(:response_text) do
+<<RESPONSE_TEXT
+<cas:serviceResponse xmlns:cas="http://www.yale.edu/tp/cas">
+  <cas:authenticationSuccess>
+    <cas:attributes>
+      <cas:first_name>Jack</cas:first_name>
+      <cas:mobile_phone></cas:mobile_phone>
+      <cas:global_roles><![CDATA[]]></cas:global_roles>
+      <cas:foo_data><![CDATA[{ foo: "bar" }]]></cas:foo_data>
+    </cas:attributes>
+  </cas:authenticationSuccess>
+</cas:serviceResponse>
+RESPONSE_TEXT
+    end
+
+    let(:subject) { CASClient::ValidationResponse.new response_text, :encode_extra_attributes_as => :json }
+
+    it "sets the value of non-CDATA escaped empty attribute to nil" do
+      subject.extra_attributes["mobile_phone"].should be_nil
+    end
+
+    it "sets the value of CDATA escaped empty attribute to nil" do
+      subject.extra_attributes["global_roles"].should be_nil
+    end
+
+    it "sets the value of literal attributes to their value" do
+      subject.extra_attributes["first_name"].should == "Jack"
+    end
+
+    it "sets the value of JSON attributes to their parsed value" do
+      subject.extra_attributes["foo_data"]["foo"].should == "bar"
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,16 @@
+require 'bundler'
+
+Bundler.setup(:default, :test)
+Bundler.require
+
+RSpec.configure do |config|
+  #config.include Rack::Test::Methods
+  #config.include Webrat::Methods
+  #config.include Webrat::Matchers
+  #config.include TestHelpers
+  #config.include Helpers
+  config.mock_with :rspec
+  config.mock_framework = :rspec
+end
+
+require 'rubycas-client'

metadata

@@ -1,136 +1,116 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: rubycas-client
-version: !ruby/object:Gem::Version 
-  hash: 1
+version: !ruby/object:Gem::Version
+  version: 2.3.2
   prerelease: 
-  segments: 
-  - 2
-  - 3
-  - 1
-  version: 2.3.1
 platform: ruby
-authors: 
+authors:
 - Matt Zukowski
 - Matt Walker
 - Matt Campbell
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-10-23 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  version_requirements: *id001
+date: 2011-11-11 00:00:00.000000000Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: activesupport
-  prerelease: false
-  type: :runtime
-- !ruby/object:Gem::Dependency 
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  requirement: &70128146526380 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  version_requirements: *id002
-  name: riot
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
   prerelease: false
-  type: :development
-- !ruby/object:Gem::Dependency 
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: *70128146526380
+- !ruby/object:Gem::Dependency
+  name: json
+  requirement: &70128146525800 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  version_requirements: *id003
-  name: rr
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.6.1
+  type: :development
   prerelease: false
+  version_requirements: *70128146525800
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: &70128146525180 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.7.0
   type: :development
-- !ruby/object:Gem::Dependency 
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  prerelease: false
+  version_requirements: *70128146525180
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: &70128146524640 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 23
-        segments: 
-        - 1
-        - 0
-        - 0
+      - !ruby/object:Gem::Version
         version: 1.0.0
-  version_requirements: *id004
-  name: bundler
-  prerelease: false
   type: :development
-- !ruby/object:Gem::Dependency 
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  prerelease: false
+  version_requirements: *70128146524640
+- !ruby/object:Gem::Dependency
+  name: jeweler
+  requirement: &70128146524100 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 11
-        segments: 
-        - 1
-        - 6
-        - 2
+      - !ruby/object:Gem::Version
         version: 1.6.2
-  version_requirements: *id005
-  name: jeweler
-  prerelease: false
   type: :development
-- !ruby/object:Gem::Dependency 
-  requirement: &id006 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  version_requirements: *id006
-  name: rcov
   prerelease: false
+  version_requirements: *70128146524100
+- !ruby/object:Gem::Dependency
+  name: actionpack
+  requirement: &70128146523500 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-- !ruby/object:Gem::Dependency 
-  requirement: &id007 !ruby/object:Gem::Requirement 
+  prerelease: false
+  version_requirements: *70128146523500
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: &70128146522900 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  version_requirements: *id007
-  name: actionpack
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
   prerelease: false
+  version_requirements: *70128146522900
+- !ruby/object:Gem::Dependency
+  name: rcov
+  requirement: &70128146522320 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
+  prerelease: false
+  version_requirements: *70128146522320
 description: 
 email: 
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - LICENSE.txt
 - README.rdoc
-files: 
+files:
+- .rspec
+- .travis.yml
 - CHANGELOG.txt
 - Gemfile
 - Gemfile.lock
@@ -138,6 +118,7 @@ files:
 - LICENSE.txt
 - README.rdoc
 - Rakefile
+- TODO.md
 - VERSION
 - examples/rails/README
 - examples/rails/app/controllers/advanced_example_controller.rb
@@ -176,41 +157,37 @@ files:
 - rails_generators/active_record_ticket_store/templates/README
 - rails_generators/active_record_ticket_store/templates/migration.rb
 - rubycas-client.gemspec
-- test/teststrap.rb
-- test/units/casclient/frameworks/rails/filter_test.rb
+- spec/casclient/frameworks/rails/filter_spec.rb
+- spec/casclient/validation_response_spec.rb
+- spec/spec_helper.rb
 homepage: http://github.com/rubycas/rubycas-client
-licenses: 
+licenses:
 - MIT
 post_install_message: 
-rdoc_options: 
+rdoc_options:
 - --main
 - README.rdoc
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
       - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+      hash: 631183831459328070
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.7.2
+rubygems_version: 1.8.11
 signing_key: 
 specification_version: 3
 summary: Client library for the Central Authentication Service (CAS) protocol.
 test_files: []
-

data/test/teststrap.rb

@@ -1,10 +0,0 @@
-require 'rubygems'
-require 'bundler/setup'
-require 'casclient'
-require 'riot'
-require 'riot/rr'
-require 'action_pack'
-
-RAILS_ROOT = "#{File.dirname(__FILE__)}/.." unless defined?(RAILS_ROOT)
-
-Riot.reporter = Riot::VerboseStoryReporter

data/test/units/casclient/frameworks/rails/filter_test.rb

@@ -1,184 +0,0 @@
-require 'teststrap'
-require 'casclient/frameworks/rails/filter'
-require 'action_controller'
-
-context CASClient::Frameworks::Rails::Filter do
-  
-  helper(:controller_with_session) do |session, request|
-    controller = Object.new
-    stub(controller).session {session}
-    stub(controller).request {request}
-    stub(controller).url_for {"bogusurl"}
-    stub(controller).params {{:ticket => "bogusticket", :renew => false}}
-    controller
-  end
-    
-  setup do
-    CASClient::Frameworks::Rails::Filter.configure(
-      :cas_base_url => 'http://test.local/',
-      :logger => stub!
-    )
-  end
-  
-  context "fake user without attributes" do
-    setup { CASClient::Frameworks::Rails::Filter.fake('tester@test.com') }
-    should 'set the session user on #filter' do
-      setup { Hash.new }
-      CASClient::Frameworks::Rails::Filter.filter(controller_with_session(topic,nil))
-      topic
-    end.equals :cas_user => 'tester@test.com', :casfilteruser => 'tester@test.com'
-    teardown { CASClient::Frameworks::Rails::Filter.fake(nil,nil) }
-  end
-  
-  context "fake user with attributes" do
-    setup { CASClient::Frameworks::Rails::Filter.fake('tester@test.com', {:test => 'stuff', :this => 'that'}) }
-    should 'set the session user and attributes on #filter' do
-      setup { Hash.new }
-      CASClient::Frameworks::Rails::Filter.filter(controller_with_session(topic,nil))
-      topic
-    end.equals :cas_user => 'tester@test.com', :casfilteruser => 'tester@test.com', :cas_extra_attributes => {:test => 'stuff', :this => 'that' }
-    teardown { CASClient::Frameworks::Rails::Filter.fake(nil,nil) }
-  end
-  
-  context "new service ticket successfully" do
-     should("return successfully from filter") do
-      setup { Hash.new }
-      mock_request = ActionController::Request.new({})
-      mock(mock_request).post? {true}
-      
-      pgt = CASClient::ProxyGrantingTicket.new(
-      "PGT-1308586001r9573FAD5A8C62E134A4AA93273F226BD3F0C3A983DCCCD176",
-      "PGTIOU-1308586001r29DC1F852C95930FE6694C1EFC64232A3359798893BC0B")
-      
-      raw_text = "<cas:serviceResponse xmlns:cas=\"http://www.yale.edu/tp/cas\">
-                    <cas:authenticationSuccess>
-                      <cas:user>rich.yarger@vibes.com</cas:user>
-                      <cas:proxyGrantingTicket>PGTIOU-1308586001r29DC1F852C95930FE6694C1EFC64232A3359798893BC0B</cas:proxyGrantingTicket>
-                    </cas:authenticationSuccess>
-                  </cas:serviceResponse>"
-      response = CASClient::ValidationResponse.new(raw_text)
-      
-      any_instance_of(CASClient::Client, :request_cas_response => response)
-      any_instance_of(CASClient::Client, :retrieve_proxy_granting_ticket => pgt)
-      
-      controller = controller_with_session(topic,mock_request)
-      CASClient::Frameworks::Rails::Filter.filter(controller)
-     end.equals(true)
-  end
-  
-  context "new service ticket with invalid service ticket" do
-     should("return failure from filter") do
-      setup { Hash.new }
-      mock_request = ActionController::Request.new({})
-      mock(mock_request).post? {true}
-      
-      raw_text = "<cas:serviceResponse xmlns:cas=\"http://www.yale.edu/tp/cas\">
-                    <cas:authenticationFailure>Some Error Text</cas:authenticationFailure>
-                  </cas:serviceResponse>"
-      response = CASClient::ValidationResponse.new(raw_text)
-      
-      any_instance_of(CASClient::Client, :request_cas_response => response)
-      stub(CASClient::Frameworks::Rails::Filter).unauthorized!{"bogusresponse"}
-      
-      controller = controller_with_session(topic,mock_request)
-      CASClient::Frameworks::Rails::Filter.filter(controller)
-     end.equals(false)
-  end
-  
-  context "no new service ticket but with last service ticket" do
-     should("return failure from filter") do
-      setup { Hash.new }
-      mock_request = ActionController::Request.new({})
-      mock(mock_request).post? {true}
-
-      stub(CASClient::Frameworks::Rails::Filter).unauthorized!{"bogusresponse"}
-      
-      controller = controller_with_session(topic,mock_request)
-      stub(controller).params {{}}
-      CASClient::Frameworks::Rails::Filter.filter(controller)
-     end.equals(false)
-  end
-  
-  context "no new service ticket sent through gateway, gatewaying off" do
-     should("return failure from filter") do
-      setup { Hash.new }
-      mock_request = ActionController::Request.new({})
-      mock(mock_request).post? {true}
-
-      stub(CASClient::Frameworks::Rails::Filter).unauthorized!{"bogusresponse"}
-      
-      CASClient::Frameworks::Rails::Filter.config[:use_gatewaying] = false 
-      controller = controller_with_session(topic,mock_request)
-      controller.session[:cas_sent_to_gateway] = true
-      stub(controller).params {{}}
-      CASClient::Frameworks::Rails::Filter.filter(controller)
-     end.equals(false)
-  end
-  
-  context "no new service ticket sent through gateway, gatewaying on" do
-     should("return failure from filter") do
-      setup { Hash.new }
-      mock_request = ActionController::Request.new({})
-      mock(mock_request).post? {true}
- 
-      CASClient::Frameworks::Rails::Filter.config[:use_gatewaying] = true 
-      controller = controller_with_session(topic,mock_request)
-      controller.session[:cas_sent_to_gateway] = true
-      stub(controller).params {{}}
-      CASClient::Frameworks::Rails::Filter.filter(controller)
-     end.equals(true)
-  end
-  
-  context "new service ticket with no PGT" do
-     should("return failure from filter") do
-      setup { Hash.new }
-      mock_request = ActionController::Request.new({})
-      mock(mock_request).post? {true}
-      
-      raw_text = "<cas:serviceResponse xmlns:cas=\"http://www.yale.edu/tp/cas\">
-                    <cas:authenticationSuccess>
-                      <cas:user>rich.yarger@vibes.com</cas:user>
-                      <cas:proxyGrantingTicket>PGTIOU-1308586001r29DC1F852C95930FE6694C1EFC64232A3359798893BC0B</cas:proxyGrantingTicket>
-                    </cas:authenticationSuccess>
-                  </cas:serviceResponse>"
-      response = CASClient::ValidationResponse.new(raw_text)
-      
-      any_instance_of(CASClient::Client, :request_cas_response => response)
-      any_instance_of(CASClient::Client, :retrieve_proxy_granting_ticket => lambda{raise CASClient::CASException})
-      
-      controller = controller_with_session(topic,mock_request)
-      CASClient::Frameworks::Rails::Filter.filter(controller)
-     end.raises(CASClient::CASException)
-  end
-  
-  context "new service ticket, but cannot connect to CASServer" do
-     should("return failure from filter") do
-      setup { Hash.new }
-      mock_request = ActionController::Request.new({})
-      mock(mock_request).post? {true}
-      
-      any_instance_of(CASClient::Client, :request_cas_response => lambda{raise "Some exception"})
-      
-      controller = controller_with_session(topic,mock_request)
-      CASClient::Frameworks::Rails::Filter.filter(controller)
-     end.raises(RuntimeError)
-  end
-  
-  context "reuse service ticket successfully" do
-     should("return successfully from filter") do
-      setup { Hash.new }
-      mock_request = ActionController::Request.new({})
-      mock(mock_request).post? {true}
-      
-      mock_client = CASClient::Client.new()
-      mock(mock_client).request_cas_response().never
-      mock(mock_client).retrieve_proxy_granting_ticket().never
-      CASClient::Frameworks::Rails::Filter.send(:class_variable_set, :@@client, mock_client)
-      
-      topic[:cas_last_valid_ticket] = 'bogusticket'
-      topic[:cas_last_valid_ticket_service] = 'bogusurl'
-      controller = controller_with_session(topic,mock_request)
-      CASClient::Frameworks::Rails::Filter.filter(controller)
-     end.equals(true)
-  end
-end