ruby_workspace_manager 0.6.5 → 0.6.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 115ec9332203fbf44622ec26f179450eb6dcabce1bb9ad7a523bd6cd470b7cdd
-  data.tar.gz: 4d0c0fc8898f786091a86634408b018a236bcfcb772589b30e917bc5d6ece7c0
+  metadata.gz: 37763589fe851ae20d97ffdb9f44a5d4a67ffd90d9629f474eaa44a9840d3b50
+  data.tar.gz: 82f8a67c8bc0b27b9543dff8dd83957c02b8c91e071d9b14c8f5d286007a3398
 SHA512:
-  metadata.gz: b0a671c6a7b4e2a66f6120f7a2c635e52e2c9715312fe2b576a298a89878be4ee66f38758e3cbeb1fd865e7c5083ffd10e936d1041fabc10125e807e218b7947
-  data.tar.gz: a787011658b8f986c0b2353fffc97938978113cfd9e549f6d6a8287034a5ae575456661507dde36a4a01e7fc05957bcedb8db381bdc4ef5acb2f925782d874a0
+  metadata.gz: f93674a08b41f77222a254d557ae4186a51b9ede26026fe6e6e967277a161ecdcd99c4f61bab9d03ec5597f9d66707e93efb319dab5b6c90bc3ebb24f4dd73ed
+  data.tar.gz: a275f438dd04b589f763ee122bce26a5be3035e0c1c64a1099863c8b9dcb3184337f0e9195b889d46df11a328b30de3de621b45243f142e1ab6d552b00d812f8

data/lib/rwm/affected_detector.rb

@@ -24,7 +24,9 @@ module Rwm
       @graph = graph
       @committed_only = committed_only
       @base_branch = base_branch || detect_base_branch
-      validate_base_branch! if base_branch
+      # Validate the *resolved* base, auto-detected or explicit. An unreachable base
+      # must fail loudly rather than silently report "nothing affected" (false-green CI).
+      validate_base_branch!
     end
 
     # Returns packages directly changed + their transitive dependents
@@ -91,10 +93,21 @@ module Rwm
     def detect_changed_files
       files = Set.new
 
-      # 1. Committed changes: base branch vs HEAD
+      # 1. Committed changes: base branch vs HEAD. A failure here means we cannot
+      # compare against the base (e.g. a shallow clone whose merge-base is below the
+      # fetched boundary). That must be loud — a silent empty result false-greens CI.
       Rwm.debug("affected: git diff --name-only #{base_branch}...HEAD")
-      committed, _, status = Open3.capture3("git", "-C", workspace.root, "diff", "--name-only", "#{base_branch}...HEAD")
-      committed.lines.each { |l| files << l.chomp } if status.success?
+      committed, committed_err, status = Open3.capture3("git", "-C", workspace.root, "diff", "--name-only", "#{base_branch}...HEAD")
+      unless status.success?
+        raise Rwm::InvalidBaseRefError.new(
+          base_branch,
+          reason: "Could not compute changes against base '#{base_branch}': " \
+                  "git diff #{base_branch}...HEAD failed (#{committed_err.strip}). " \
+                  "If this is a shallow clone, fetch more history " \
+                  "(e.g. `git fetch origin #{base_branch} --unshallow`) or pass a valid --base."
+        )
+      end
+      committed.lines.each { |l| files << l.chomp }
 
       unless @committed_only
         # 2. Staged changes (not yet committed)

data/lib/rwm/errors.rb

@@ -42,8 +42,8 @@ module Rwm
   class BootstrapError < Error; end
 
   class InvalidBaseRefError < Error
-    def initialize(ref)
-      super("Base ref '#{ref}' does not exist. Check the branch name or pass a valid --base ref.")
+    def initialize(ref, reason: nil)
+      super(reason || "Base ref '#{ref}' does not exist. Check the branch name or pass a valid --base ref.")
     end
   end
 

data/lib/rwm/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rwm
-  VERSION = "0.6.5"
+  VERSION = "0.6.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby_workspace_manager
 version: !ruby/object:Gem::Version
-  version: 0.6.5
+  version: 0.6.6
 platform: ruby
 authors:
 - Siddharth Bhatt
@@ -85,7 +85,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.6
+rubygems_version: 4.0.12
 specification_version: 4
 summary: Ruby Workspace Manager — an Nx-like monorepo tool for Ruby
 test_files: []