ruby_warning_filter 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 821c2df551dbf8fdcd0ba9889fbe8716606626d4
-  data.tar.gz: 2b06bcb3f1d649eef059437075db368da6678e7d
+  metadata.gz: c91d9f4a9c50812b5453fea598148a4671e1e3c0
+  data.tar.gz: f2e129ea8ece436be6c218072feef11a9c3a08de
 SHA512:
-  metadata.gz: 695653150630dc7307f548f6c031e8fbc898ff24c918788b928628e8e99bcf9a39ce0243abbe8baaf2cc1bb2f57c77c8b2d208e3c583ffc4c55a7f96ab4645e7
-  data.tar.gz: 6df030eafa9370d022744a44e50537ca5e4814aea2568306f498812936a4cee935ddcea5759114ff350befbc3e4bcfc711c68e6eaa98f4686ba8a5155a49fb04
+  metadata.gz: 73abc3ab4af12b573a56272af381b5cf1f6d7bd44473730978ada189914da8614522938cdcb3625019bbfc7e5bf04d2c7e658bd0a4fc2bd3de9fd6e793b97b53
+  data.tar.gz: 4080f1ce3435991cfac80045efc007552adb497445350ce01442ec7886d0f58a095727772a17917f66a8475ddfe2e44b46fa09b4e73c80471ab8be007cbf4a01

data/Gemfile

@@ -2,3 +2,4 @@ source "https://rubygems.org"
 
 gem "rake", "~> 10.0"
 gem "minitest", "~> 5.0"
+gem "benchmark-ips"

data/Manifest.txt

@@ -4,4 +4,5 @@ Rakefile
 Readme.md
 lib/ruby_warning_filter.rb
 ruby_warning_filter.gemspec
+test/bench.rb
 test/ruby_warnings_filter_test.rb

data/Readme.md

@@ -24,6 +24,8 @@ When running your app or tests you should see only relevant warnings. Now, go fi
 
 ## Feedback
 
+The filter works by proxying all writes to stderr. It has been running for a while in many of my work projects with good results. However, it is probably not comprehensive. Please, report any warnings that it misses or swallows by error.
+
 [![Build Status](https://travis-ci.org/semaperepelitsa/ruby_warning_filter.svg?branch=master)](https://travis-ci.org/semaperepelitsa/ruby_warning_filter)
 
-The filter works by proxying all writes to stderr. It has been running for a while in many of my work projects with good results. However, it is probably not comprehensive. Please, report any warnings that it misses or swallows by error.
+The gem is tested against Ruby 2.0, 2.1, 2.2.

data/lib/ruby_warning_filter.rb

@@ -1,4 +1,5 @@
-require 'delegate'
+require "delegate"
+require "set"
 
 # Filter IO from Ruby warnings that come out of external gems.
 # There is no other way currently to filter out Ruby warnings other than hijacking stderr.
@@ -22,9 +23,16 @@ class RubyWarningFilter < DelegateClass(IO)
 
   def initialize(io, ignore_path: Gem.path)
     super(io)
+
     @ruby_warnings = 0
     @ignored = false
-    @ignore_path = ignore_path
+    @ignore_path = ignore_path.to_set
+
+    # Gem path can contain symlinks.
+    # Some warnings use real path instead of symlinks so we need to ignore both.
+    ignore_path.each do |a|
+      @ignore_path << File.realpath(a) if File.exist?(a)
+    end
   end
 
   def write(line)
@@ -72,10 +80,6 @@ class RubyWarningFilter < DelegateClass(IO)
     line.start_with?("\tfrom")
   end
 
-  def whitespace?(line)
-    line =~ /^\s*$/
-  end
-
   def eval_redefined?(line)
     line =~ /\(eval\):\d+: warning: previous definition of .+ was here/
   end

data/ruby_warning_filter.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name    = "ruby_warning_filter"
-  gem.version = "1.0.0"
+  gem.version = "1.0.1"
   gem.summary = "Hassle-free Ruby warnings"
   gem.license = "MIT"
   gem.author  = "Semyon Perepelitsa"

data/test/bench.rb

@@ -0,0 +1,32 @@
+require "bundler/setup"
+require_relative "../lib/ruby_warning_filter"
+require "benchmark/ips"
+
+file = File.new("/dev/null", "w")
+filter = RubyWarningFilter.new(file, ignore_path: ["/path/to/gems"])
+
+def write_errors(io)
+  10.times do
+    io.write("/path/to/gems/file.rb:297: warning: instance variable @object not initialized\n")
+  end
+
+  10.times do |i|
+    io.write("\tfrom /something/foo/bar:#{i}:in  `<main>'")
+  end
+
+  10.times do
+    io.write("(eval):1: warning: previous definition of foo was here")
+  end
+end
+
+Benchmark.ips do |x|
+  x.report "plain File" do
+    write_errors(file)
+  end
+
+  x.report "RubyWarningFilter" do
+    write_errors(filter)
+  end
+end
+
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby_warning_filter
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Semyon Perepelitsa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-04 00:00:00.000000000 Z
+date: 2015-05-18 00:00:00.000000000 Z
 dependencies: []
 description: 
 email: sema@sema.in
@@ -22,6 +22,7 @@ files:
 - Readme.md
 - lib/ruby_warning_filter.rb
 - ruby_warning_filter.gemspec
+- test/bench.rb
 - test/ruby_warnings_filter_test.rb
 homepage: https://github.com/semaperepelitsa/ruby_warning_filter
 licenses:
@@ -48,4 +49,5 @@ signing_key:
 specification_version: 4
 summary: Hassle-free Ruby warnings
 test_files:
+- test/bench.rb
 - test/ruby_warnings_filter_test.rb