ruby_spriter 0.6.6 → 0.6.7.1

data/spec/ruby_spriter/processor_spec.rb

@@ -204,6 +204,356 @@ RSpec.describe RubySpriter::Processor do
     end
   end
 
+  describe '--extract validation' do
+    let(:temp_image) { File.join(Dir.mktmpdir, 'test.png') }
+
+    before do
+      FileUtils.touch(temp_image)
+
+      allow_any_instance_of(RubySpriter::DependencyChecker).to receive(:check_all).and_return({
+        ffmpeg: { available: true },
+        ffprobe: { available: true },
+        imagemagick: { available: true },
+        gimp: { available: true }
+      })
+    end
+
+    after do
+      FileUtils.rm_f(temp_image)
+    end
+
+    describe 'format validation' do
+      it 'raises error for invalid extract format (non-numeric)' do
+        expect {
+          described_class.new(image: temp_image, extract: '1,a,3')
+        }.to raise_error(RubySpriter::ValidationError, /Invalid --extract format/)
+      end
+
+      it 'raises error for invalid extract format (empty)' do
+        expect {
+          described_class.new(image: temp_image, extract: '')
+        }.to raise_error(RubySpriter::ValidationError, /Invalid --extract format/)
+      end
+
+      it 'raises error for invalid extract format (spaces)' do
+        expect {
+          described_class.new(image: temp_image, extract: '1, 2, 3')
+        }.to raise_error(RubySpriter::ValidationError, /Invalid --extract format/)
+      end
+
+      it 'accepts valid comma-separated frame numbers' do
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return({
+          columns: 4,
+          rows: 4,
+          frames: 16
+        })
+
+        expect {
+          described_class.new(image: temp_image, extract: '1,2,4,5,8')
+        }.not_to raise_error
+      end
+    end
+
+    describe 'minimum frames validation' do
+      it 'raises error when less than 2 frames requested' do
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return({
+          columns: 4,
+          rows: 4,
+          frames: 16
+        })
+
+        expect {
+          described_class.new(image: temp_image, extract: '1')
+        }.to raise_error(RubySpriter::ValidationError, /--extract requires at least 2 frames/)
+      end
+
+      it 'allows exactly 2 frames' do
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return({
+          columns: 4,
+          rows: 4,
+          frames: 16
+        })
+
+        expect {
+          described_class.new(image: temp_image, extract: '1,2')
+        }.not_to raise_error
+      end
+    end
+
+    describe 'frame number validation' do
+      it 'raises error when frame number is 0' do
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return({
+          columns: 4,
+          rows: 4,
+          frames: 16
+        })
+
+        expect {
+          described_class.new(image: temp_image, extract: '0,1,2')
+        }.to raise_error(RubySpriter::ValidationError, /Frame numbers must be 1-indexed/)
+      end
+
+      it 'raises error when frame number is negative' do
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return({
+          columns: 4,
+          rows: 4,
+          frames: 16
+        })
+
+        expect {
+          described_class.new(image: temp_image, extract: '1,-2,3')
+        }.to raise_error(RubySpriter::ValidationError, /Frame numbers must be 1-indexed/)
+      end
+
+      it 'allows duplicate frame numbers' do
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return({
+          columns: 4,
+          rows: 4,
+          frames: 16
+        })
+
+        expect {
+          described_class.new(image: temp_image, extract: '1,1,2,2,3,3')
+        }.not_to raise_error
+      end
+    end
+
+    describe 'metadata requirement' do
+      it 'raises error when image has no metadata' do
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return(nil)
+
+        expect {
+          described_class.new(image: temp_image, extract: '1,2,3')
+        }.to raise_error(RubySpriter::ValidationError, /Image has no metadata.*Cannot extract frames/)
+      end
+    end
+
+    describe 'out of bounds validation' do
+      before do
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return({
+          columns: 4,
+          rows: 4,
+          frames: 16
+        })
+      end
+
+      it 'raises error when frame number exceeds total frames' do
+        expect {
+          described_class.new(image: temp_image, extract: '1,2,17')
+        }.to raise_error(RubySpriter::ValidationError, /Frame 17 is out of bounds.*only has 16 frames/)
+      end
+
+      it 'allows frame number equal to total frames' do
+        expect {
+          described_class.new(image: temp_image, extract: '1,2,16')
+        }.not_to raise_error
+      end
+
+      it 'raises error for multiple out of bounds frames' do
+        expect {
+          described_class.new(image: temp_image, extract: '1,20,25')
+        }.to raise_error(RubySpriter::ValidationError, /Frame 20 is out of bounds/)
+      end
+    end
+
+    describe '--columns default' do
+      before do
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return({
+          columns: 4,
+          rows: 4,
+          frames: 16
+        })
+      end
+
+      it 'defaults to 4 columns when not specified' do
+        processor = described_class.new(image: temp_image, extract: '1,2,3,4')
+        expect(processor.instance_variable_get(:@options)[:columns]).to eq(4)
+      end
+
+      it 'uses specified columns when provided' do
+        processor = described_class.new(image: temp_image, extract: '1,2,3', columns: 3)
+        expect(processor.instance_variable_get(:@options)[:columns]).to eq(3)
+      end
+    end
+  end
+
+  describe '--add-meta validation' do
+    let(:temp_image) { File.join(Dir.mktmpdir, 'test.png') }
+
+    before do
+      FileUtils.touch(temp_image)
+
+      allow_any_instance_of(RubySpriter::DependencyChecker).to receive(:check_all).and_return({
+        ffmpeg: { available: true },
+        ffprobe: { available: true },
+        imagemagick: { available: true },
+        gimp: { available: true }
+      })
+    end
+
+    after do
+      FileUtils.rm_f(temp_image)
+    end
+
+    describe 'format validation' do
+      it 'raises error for invalid format (missing colon)' do
+        expect {
+          described_class.new(image: temp_image, add_meta: '44')
+        }.to raise_error(RubySpriter::ValidationError, /Invalid --add-meta format/)
+      end
+
+      it 'raises error for invalid format (non-numeric rows)' do
+        expect {
+          described_class.new(image: temp_image, add_meta: 'a:4')
+        }.to raise_error(RubySpriter::ValidationError, /Invalid --add-meta format/)
+      end
+
+      it 'raises error for invalid format (non-numeric columns)' do
+        expect {
+          described_class.new(image: temp_image, add_meta: '4:b')
+        }.to raise_error(RubySpriter::ValidationError, /Invalid --add-meta format/)
+      end
+
+      it 'accepts valid R:C format' do
+        # Mock ImageMagick identify for dimension validation
+        allow(Open3).to receive(:capture3).with(/identify/).and_return(
+          ["800x800\n", '', instance_double(Process::Status, success?: true)]
+        )
+
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return(nil)
+
+        expect {
+          described_class.new(image: temp_image, add_meta: '4:4')
+        }.not_to raise_error
+      end
+    end
+
+    describe 'range validation' do
+      it 'raises error when rows is below minimum (0)' do
+        expect {
+          described_class.new(image: temp_image, add_meta: '0:4')
+        }.to raise_error(RubySpriter::ValidationError, /rows must be between 1 and 99/)
+      end
+
+      it 'raises error when columns is below minimum (0)' do
+        expect {
+          described_class.new(image: temp_image, add_meta: '4:0')
+        }.to raise_error(RubySpriter::ValidationError, /columns must be between 1 and 99/)
+      end
+
+      it 'raises error when rows exceeds maximum (100)' do
+        expect {
+          described_class.new(image: temp_image, add_meta: '100:4')
+        }.to raise_error(RubySpriter::ValidationError, /rows must be between 1 and 99/)
+      end
+
+      it 'raises error when total frames exceeds 999' do
+        expect {
+          described_class.new(image: temp_image, add_meta: '20:50')
+        }.to raise_error(RubySpriter::ValidationError, /Total frames \(1000\) must be less than 1000/)
+      end
+
+      it 'allows maximum valid frames (999)' do
+        # Mock ImageMagick identify - 3700x2700 divides evenly by 27 rows x 37 columns (100x100 per frame)
+        allow(Open3).to receive(:capture3).with(/identify/).and_return(
+          ["3700x2700\n", '', instance_double(Process::Status, success?: true)]
+        )
+
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return(nil)
+
+        expect {
+          described_class.new(image: temp_image, add_meta: '27:37')
+        }.not_to raise_error
+      end
+    end
+
+    describe 'existing metadata handling' do
+      it 'raises error when image already has metadata' do
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return({
+          columns: 4,
+          rows: 4,
+          frames: 16
+        })
+
+        expect {
+          described_class.new(image: temp_image, add_meta: '4:4')
+        }.to raise_error(RubySpriter::ValidationError, /Image already has spritesheet metadata.*Use --overwrite-meta/)
+      end
+
+      it 'allows replacing metadata with --overwrite-meta' do
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return({
+          columns: 4,
+          rows: 4,
+          frames: 16
+        })
+
+        # Mock ImageMagick identify
+        allow(Open3).to receive(:capture3).with(/identify/).and_return(
+          ["800x800\n", '', instance_double(Process::Status, success?: true)]
+        )
+
+        expect {
+          described_class.new(image: temp_image, add_meta: '8:8', overwrite_meta: true)
+        }.not_to raise_error
+      end
+    end
+
+    describe 'dimension validation' do
+      before do
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return(nil)
+      end
+
+      it 'raises error when image dimensions do not divide evenly' do
+        # Mock ImageMagick identify - 800x600 doesn't divide by 3x3
+        allow(Open3).to receive(:capture3).with(/identify/).and_return(
+          ["800x600\n", '', instance_double(Process::Status, success?: true)]
+        )
+
+        expect {
+          described_class.new(image: temp_image, add_meta: '3:3')
+        }.to raise_error(RubySpriter::ValidationError, /Image dimensions \(800x600\) must divide evenly by grid \(3x3\)/)
+      end
+
+      it 'allows dimensions that divide evenly' do
+        # Mock ImageMagick identify - 800x800 divides by 4x4
+        allow(Open3).to receive(:capture3).with(/identify/).and_return(
+          ["800x800\n", '', instance_double(Process::Status, success?: true)]
+        )
+
+        expect {
+          described_class.new(image: temp_image, add_meta: '4:4')
+        }.not_to raise_error
+      end
+    end
+
+    describe 'frame count handling' do
+      before do
+        allow(RubySpriter::MetadataManager).to receive(:read).with(temp_image).and_return(nil)
+        allow(Open3).to receive(:capture3).with(/identify/).and_return(
+          ["800x800\n", '', instance_double(Process::Status, success?: true)]
+        )
+      end
+
+      it 'calculates frame count from rows * columns by default' do
+        processor = described_class.new(image: temp_image, add_meta: '4:4')
+        # Frame count should be 16 (4x4)
+        # We'll verify this in the workflow implementation
+        expect(processor.instance_variable_get(:@options)[:add_meta]).to eq('4:4')
+      end
+
+      it 'allows custom frame count with --frames for partial grids' do
+        processor = described_class.new(image: temp_image, add_meta: '4:4', frame_count: 14)
+        expect(processor.instance_variable_get(:@options)[:frame_count]).to eq(14)
+      end
+
+      it 'raises error when custom frame count exceeds grid size' do
+        expect {
+          described_class.new(image: temp_image, add_meta: '4:4', frame_count: 20)
+        }.to raise_error(RubySpriter::ValidationError, /Frame count \(20\) exceeds grid size \(16\)/)
+      end
+    end
+  end
+
   describe '--split metadata priority logic' do
     let(:temp_dir) { Dir.mktmpdir('test_split_') }
     let(:image_file) { File.join(temp_dir, 'spritesheet.png') }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby_spriter
 version: !ruby/object:Gem::Version
-  version: 0.6.6
+  version: 0.6.7.1
 platform: ruby
 authors:
 - scooter-indie
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-10-24 00:00:00.000000000 Z
+date: 2025-10-25 00:00:00.000000000 Z
 dependencies: []
 description: |
   Ruby Spriter is a cross-platform tool for creating spritesheets from video files
@@ -28,7 +28,9 @@ files:
 - README.md
 - bin/ruby_spriter
 - lib/ruby_spriter.rb
+- lib/ruby_spriter/batch_processor.rb
 - lib/ruby_spriter/cli.rb
+- lib/ruby_spriter/compression_manager.rb
 - lib/ruby_spriter/consolidator.rb
 - lib/ruby_spriter/dependency_checker.rb
 - lib/ruby_spriter/gimp_processor.rb
@@ -48,7 +50,9 @@ files:
 - spec/fixtures/spritesheet_6x2.png
 - spec/fixtures/spritesheet_with_metadata.png
 - spec/fixtures/test_video.mp4
+- spec/ruby_spriter/batch_processor_spec.rb
 - spec/ruby_spriter/cli_spec.rb
+- spec/ruby_spriter/compression_manager_spec.rb
 - spec/ruby_spriter/consolidator_spec.rb
 - spec/ruby_spriter/dependency_checker_spec.rb
 - spec/ruby_spriter/gimp_processor_spec.rb