ruby_smb 3.2.8 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e4ddd94d3c783b3091a37c946c5069da85350c23294b33ddabcdc0476f828ec4
-  data.tar.gz: 990ad64d98bd60dd957c1b8b6fcf1abdbd6e8a52d408e0e6c03d3694354cb4ad
+  metadata.gz: 2f696c845250348795f67d3d5b163c65b432acdbcd01bc86d0a6cd81ddcbfc67
+  data.tar.gz: b43dcb4fa6ff4497e61329b8b5a17049a6b445fcdf5c3df61dc380960ea02b9c
 SHA512:
-  metadata.gz: bc7b1921009d55e8263ecfe3aa282bd4df35636a5055f5126ffa1866ed8140283bbfa14f341a4d791e30a7f51e0df631676ef211961c9712e457e0939983a6c7
-  data.tar.gz: 11982c6c2b2fb653756140c7024ccff301c72ee9b5ac44f85a5071f1d2a27dbdcf31b5936bc3ea646ef7219e3c917b5466ec3e6b26bbba116fc7552169244a4a
+  metadata.gz: 8368cf1844e47161a57051d7b8dfa807b665c898153636b1baedb2211acd4685ef67c5ba167581ce84a9ec7c8c17e812d1f876bb70f34b647bb075bb94861349
+  data.tar.gz: 3b33a185fb3b981147b005e13793aa1f8a09e11c2e5e0dc9b75469ef980ec019bc2dd5e9bef187910f9b5be012d7ca710799b45aa0bdf79547ae3d48de8e22e7

data/lib/ruby_smb/smb2/tree.rb

@@ -85,6 +85,7 @@ module RubySMB
       # @raise [RubySMB::Error::InvalidPacket] if the response is not a QueryDirectoryResponse packet
       def list(directory: nil, pattern: '*', type: RubySMB::Fscc::FileInformation::FileIdFullDirectoryInformation)
         create_response = open_directory(directory: directory)
+        opened_directory = RubySMB::SMB2::File.new(tree: self, response: create_response, name: directory)
         file_id         = create_response.file_id
 
         directory_request                         = RubySMB::SMB2::Packet::QueryDirectoryRequest.new
@@ -127,8 +128,9 @@ module RubySMB
           # Reset the message id so the client can update appropriately.
           directory_request.smb2_header.message_id = 0
         end
-
         files
+      ensure
+        opened_directory.close if opened_directory
       end
 
       # 'Opens' a directory file on the remote end, using a CreateRequest. This

data/lib/ruby_smb/version.rb

@@ -1,3 +1,3 @@
 module RubySMB
-  VERSION = '3.2.8'.freeze
+  VERSION = '3.3.0'.freeze
 end

data/spec/lib/ruby_smb/dcerpc/response_spec.rb

@@ -131,7 +131,7 @@ RSpec.describe RubySMB::Dcerpc::Response do
   end
 
   describe '#stub_length' do
-    let(:stub_length) { rand(0xFF) }
+    let(:stub_length) { rand(1..0xFF) }
     before :example do
       packet.stub = 'A' * stub_length
     end
@@ -142,7 +142,7 @@ RSpec.describe RubySMB::Dcerpc::Response do
 
     context 'with auth verifier' do
       it 'returns the correct stub length' do
-        auth_size = rand(0xFF)
+        auth_size = rand(1..0xFF)
         packet.pdu_header.auth_length = auth_size
         packet.auth_value = 'B' * auth_size
         expect(packet.stub_length).to eq(stub_length + packet.auth_pad.num_bytes)
@@ -152,8 +152,8 @@ RSpec.describe RubySMB::Dcerpc::Response do
 
   describe '#read' do
     let(:response) { described_class.new }
-    let(:auth_size) { rand(0xFF) }
-    let(:stub_size) { rand(0xFF) }
+    let(:auth_size) { rand(1..0xFF) }
+    let(:stub_size) { rand(1..0xFF) }
     before :example do
       response.pdu_header.auth_length = auth_size
       response.stub = 'A' * stub_size
@@ -176,5 +176,3 @@ RSpec.describe RubySMB::Dcerpc::Response do
     expect(described_class.read(binary)).to eq(packet)
   end
 end
-
-

data/spec/lib/ruby_smb/smb2/tree_spec.rb

@@ -166,10 +166,14 @@ RSpec.describe RubySMB::SMB2::Tree do
     let(:create_res) { double('create response') }
     let(:query_dir_req) { RubySMB::SMB2::Packet::QueryDirectoryRequest.new }
     let(:query_dir_res) { RubySMB::SMB2::Packet::QueryDirectoryResponse.new }
+    let(:open_dir) { instance_double(RubySMB::SMB2::File) }
 
     before :example do
       allow(tree).to receive(:open_directory).and_return(create_res)
       allow(create_res).to receive(:file_id)
+      allow(RubySMB::SMB2::File).to receive(:new).and_return(open_dir)
+      allow(open_dir).to receive(:close)
+      allow(create_res).to receive(:file_attributes)
       allow(RubySMB::SMB2::Packet::QueryDirectoryRequest).to receive(:new).and_return(query_dir_req)
       allow(client).to receive(:send_recv)
       allow(RubySMB::SMB2::Packet::QueryDirectoryResponse).to receive(:read).and_return(query_dir_res)
@@ -180,6 +184,7 @@ RSpec.describe RubySMB::SMB2::Tree do
       dir = '/dir'
       expect(tree).to receive(:open_directory).with(directory: dir).and_return(create_res)
       tree.list(directory: dir)
+      expect(open_dir).to have_received(:close)
     end
 
     it 'uses the File ID from the create response' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby_smb
 version: !ruby/object:Gem::Version
-  version: 3.2.8
+  version: 3.3.0
 platform: ruby
 authors:
 - Metasploit Hackers
@@ -38,7 +38,7 @@ cert_chain:
   DgscAao7wB3xW2BWEp1KnaDWkf1x9ttgoBEYyuYwU7uatB67kBQG1PKvLt79wHvz
   Dxs+KOjGbBRfMnPgVGYkORKVrZIwlaboHbDKxcVW5xv+oZc7KYXWGg==
   -----END CERTIFICATE-----
-date: 2023-11-13 00:00:00.000000000 Z
+date: 2023-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redcarpet