ruby_smb 2.0.2 → 3.0.0

data/spec/lib/ruby_smb/dcerpc/wkssvc/netr_wksta_get_info_response_spec.rb

@@ -0,0 +1,410 @@
+RSpec.describe RubySMB::Dcerpc::Wkssvc::WkstaInfo102 do
+  subject(:packet) { described_class.new }
+
+  it { is_expected.to respond_to :wki102_platform_id }
+  it { is_expected.to respond_to :wki102_computername }
+  it { is_expected.to respond_to :wki102_langroup }
+  it { is_expected.to respond_to :wki102_ver_major }
+  it { is_expected.to respond_to :wki102_ver_minor }
+  it { is_expected.to respond_to :wki102_lanroot }
+  it { is_expected.to respond_to :wki102_logged_on_users }
+
+  it 'is little endian' do
+    expect(described_class.fields.instance_variable_get(:@hints)[:endian]).to eq :little
+  end
+  it 'it is a Ndr::NdrStruct' do
+    expect(described_class).to be < RubySMB::Dcerpc::Ndr::NdrStruct
+  end
+  describe '#wki102_platform_id' do
+    it 'is a NdrUint32 structure' do
+      expect(packet.wki102_platform_id).to be_a RubySMB::Dcerpc::Ndr::NdrUint32
+    end
+  end
+  describe '#wki102_computername' do
+    it 'is a Ndr::NdrWideStringzPtr' do
+      expect(packet.wki102_computername).to be_a(RubySMB::Dcerpc::Ndr::NdrWideStringzPtr)
+    end
+  end
+  describe '#wki102_langroup' do
+    it 'is a Ndr::NdrWideStringzPtr' do
+      expect(packet.wki102_langroup).to be_a(RubySMB::Dcerpc::Ndr::NdrWideStringzPtr)
+    end
+  end
+  describe '#wki102_ver_major' do
+    it 'is a NdrUint32 structure' do
+      expect(packet.wki102_ver_major).to be_a RubySMB::Dcerpc::Ndr::NdrUint32
+    end
+  end
+  describe '#wki102_ver_minor' do
+    it 'is a NdrUint32 structure' do
+      expect(packet.wki102_ver_minor).to be_a RubySMB::Dcerpc::Ndr::NdrUint32
+    end
+  end
+  describe '#wki102_lanroot' do
+    it 'is a Ndr::NdrWideStringzPtr' do
+      expect(packet.wki102_lanroot).to be_a(RubySMB::Dcerpc::Ndr::NdrWideStringzPtr)
+    end
+  end
+  describe '#wki102_logged_on_users' do
+    it 'is a NdrUint32 structure' do
+      expect(packet.wki102_logged_on_users).to be_a RubySMB::Dcerpc::Ndr::NdrUint32
+    end
+  end
+  it 'reads itself' do
+    new_class = described_class.new(
+      wki102_platform_id: 500,
+      wki102_computername: 'MYCOMPUTER',
+      wki102_langroup: 'MYDOMAIN',
+      wki102_ver_major: 6,
+      wki102_ver_minor: 2,
+      wki102_lanroot: 'MYLANROOT',
+      wki102_logged_on_users: 4,
+    )
+    expect(packet.read(new_class.to_binary_s)).to eq(
+      {
+        wki102_platform_id: 500,
+        wki102_computername: 'MYCOMPUTER'.encode('utf-16le'),
+        wki102_langroup: 'MYDOMAIN'.encode('utf-16le'),
+        wki102_ver_major: 6,
+        wki102_ver_minor: 2,
+        wki102_lanroot: 'MYLANROOT'.encode('utf-16le'),
+        wki102_logged_on_users: 4,
+      }
+    )
+  end
+end
+
+RSpec.describe RubySMB::Dcerpc::Wkssvc::PwkstaInfo102 do
+  subject(:packet) { described_class.new }
+
+  it 'is a WkstaInfo102' do
+    expect(packet).to be_a(RubySMB::Dcerpc::Wkssvc::WkstaInfo102)
+  end
+  it 'is a NDR Pointer' do
+    expect(described_class).to be_a(RubySMB::Dcerpc::Ndr::PointerClassPlugin)
+  end
+  it 'reads itself' do
+    new_class = described_class.new(
+      wki102_platform_id: 500,
+      wki102_computername: 'MYCOMPUTER',
+      wki102_langroup: 'MYDOMAIN',
+      wki102_ver_major: 6,
+      wki102_ver_minor: 2,
+      wki102_lanroot: 'MYLANROOT',
+      wki102_logged_on_users: 4,
+    )
+    expect(packet.read(new_class.to_binary_s)).to eq(
+      {
+        wki102_platform_id: 500,
+        wki102_computername: 'MYCOMPUTER'.encode('utf-16le'),
+        wki102_langroup: 'MYDOMAIN'.encode('utf-16le'),
+        wki102_ver_major: 6,
+        wki102_ver_minor: 2,
+        wki102_lanroot: 'MYLANROOT'.encode('utf-16le'),
+        wki102_logged_on_users: 4,
+      }
+    )
+  end
+end
+
+RSpec.describe RubySMB::Dcerpc::Wkssvc::WkstaInfo101 do
+  subject(:packet) { described_class.new }
+
+  it { is_expected.to respond_to :wki101_platform_id }
+  it { is_expected.to respond_to :wki101_computername }
+  it { is_expected.to respond_to :wki101_langroup }
+  it { is_expected.to respond_to :wki101_ver_major }
+  it { is_expected.to respond_to :wki101_ver_minor }
+  it { is_expected.to respond_to :wki101_lanroot }
+
+  it 'is little endian' do
+    expect(described_class.fields.instance_variable_get(:@hints)[:endian]).to eq :little
+  end
+  it 'it is a Ndr::NdrStruct' do
+    expect(described_class).to be < RubySMB::Dcerpc::Ndr::NdrStruct
+  end
+  describe '#wki101_platform_id' do
+    it 'is a NdrUint32 structure' do
+      expect(packet.wki101_platform_id).to be_a RubySMB::Dcerpc::Ndr::NdrUint32
+    end
+  end
+  describe '#wki101_computername' do
+    it 'is a Ndr::NdrWideStringzPtr' do
+      expect(packet.wki101_computername).to be_a(RubySMB::Dcerpc::Ndr::NdrWideStringzPtr)
+    end
+  end
+  describe '#wki101_langroup' do
+    it 'is a Ndr::NdrWideStringzPtr' do
+      expect(packet.wki101_langroup).to be_a(RubySMB::Dcerpc::Ndr::NdrWideStringzPtr)
+    end
+  end
+  describe '#wki101_ver_major' do
+    it 'is a NdrUint32 structure' do
+      expect(packet.wki101_ver_major).to be_a RubySMB::Dcerpc::Ndr::NdrUint32
+    end
+  end
+  describe '#wki101_ver_minor' do
+    it 'is a NdrUint32 structure' do
+      expect(packet.wki101_ver_minor).to be_a RubySMB::Dcerpc::Ndr::NdrUint32
+    end
+  end
+  describe '#wki101_lanroot' do
+    it 'is a Ndr::NdrWideStringzPtr' do
+      expect(packet.wki101_lanroot).to be_a(RubySMB::Dcerpc::Ndr::NdrWideStringzPtr)
+    end
+  end
+  it 'reads itself' do
+    new_class = described_class.new(
+      wki101_platform_id: 500,
+      wki101_computername: 'MYCOMPUTER',
+      wki101_langroup: 'MYDOMAIN',
+      wki101_ver_major: 6,
+      wki101_ver_minor: 2,
+      wki101_lanroot: 'MYLANROOT'
+    )
+    expect(packet.read(new_class.to_binary_s)).to eq(
+      {
+        wki101_platform_id: 500,
+        wki101_computername: 'MYCOMPUTER'.encode('utf-16le'),
+        wki101_langroup: 'MYDOMAIN'.encode('utf-16le'),
+        wki101_ver_major: 6,
+        wki101_ver_minor: 2,
+        wki101_lanroot: 'MYLANROOT'.encode('utf-16le')
+      }
+    )
+  end
+end
+
+RSpec.describe RubySMB::Dcerpc::Wkssvc::PwkstaInfo101 do
+  subject(:packet) { described_class.new }
+
+  it 'is a WkstaInfo101' do
+    expect(packet).to be_a(RubySMB::Dcerpc::Wkssvc::WkstaInfo101)
+  end
+  it 'is a NDR Pointer' do
+    expect(described_class).to be_a(RubySMB::Dcerpc::Ndr::PointerClassPlugin)
+  end
+  it 'reads itself' do
+    new_class = described_class.new(
+      wki101_platform_id: 500,
+      wki101_computername: 'MYCOMPUTER',
+      wki101_langroup: 'MYDOMAIN',
+      wki101_ver_major: 6,
+      wki101_ver_minor: 2,
+      wki101_lanroot: 'MYLANROOT'
+    )
+    expect(packet.read(new_class.to_binary_s)).to eq(
+      {
+        wki101_platform_id: 500,
+        wki101_computername: 'MYCOMPUTER'.encode('utf-16le'),
+        wki101_langroup: 'MYDOMAIN'.encode('utf-16le'),
+        wki101_ver_major: 6,
+        wki101_ver_minor: 2,
+        wki101_lanroot: 'MYLANROOT'.encode('utf-16le')
+      }
+    )
+  end
+end
+
+RSpec.describe RubySMB::Dcerpc::Wkssvc::WkstaInfo100 do
+  subject(:packet) { described_class.new }
+
+  it { is_expected.to respond_to :wki100_platform_id }
+  it { is_expected.to respond_to :wki100_computername }
+  it { is_expected.to respond_to :wki100_langroup }
+  it { is_expected.to respond_to :wki100_ver_major }
+  it { is_expected.to respond_to :wki100_ver_minor }
+
+  it 'is little endian' do
+    expect(described_class.fields.instance_variable_get(:@hints)[:endian]).to eq :little
+  end
+  it 'it is a Ndr::NdrStruct' do
+    expect(described_class).to be < RubySMB::Dcerpc::Ndr::NdrStruct
+  end
+  describe '#wki100_platform_id' do
+    it 'is a NdrUint32 structure' do
+      expect(packet.wki100_platform_id).to be_a RubySMB::Dcerpc::Ndr::NdrUint32
+    end
+  end
+  describe '#wki100_computername' do
+    it 'is a Ndr::NdrWideStringzPtr' do
+      expect(packet.wki100_computername).to be_a(RubySMB::Dcerpc::Ndr::NdrWideStringzPtr)
+    end
+  end
+  describe '#wki100_langroup' do
+    it 'is a Ndr::NdrWideStringzPtr' do
+      expect(packet.wki100_langroup).to be_a(RubySMB::Dcerpc::Ndr::NdrWideStringzPtr)
+    end
+  end
+  describe '#wki100_ver_major' do
+    it 'is a NdrUint32 structure' do
+      expect(packet.wki100_ver_major).to be_a RubySMB::Dcerpc::Ndr::NdrUint32
+    end
+  end
+  describe '#wki100_ver_minor' do
+    it 'is a NdrUint32 structure' do
+      expect(packet.wki100_ver_minor).to be_a RubySMB::Dcerpc::Ndr::NdrUint32
+    end
+  end
+
+  it 'reads itself' do
+    new_class = described_class.new(
+      wki100_platform_id: 500,
+      wki100_computername: 'MYCOMPUTER',
+      wki100_langroup: 'MYDOMAIN',
+      wki100_ver_major: 6,
+      wki100_ver_minor: 2
+    )
+    expect(packet.read(new_class.to_binary_s)).to eq(
+      {
+        wki100_platform_id: 500,
+        wki100_computername: 'MYCOMPUTER'.encode('utf-16le'),
+        wki100_langroup: 'MYDOMAIN'.encode('utf-16le'),
+        wki100_ver_major: 6,
+        wki100_ver_minor: 2
+      }
+    )
+  end
+end
+
+RSpec.describe RubySMB::Dcerpc::Wkssvc::PwkstaInfo100 do
+  subject(:packet) { described_class.new }
+
+  it 'is a WkstaInfo100' do
+    expect(packet).to be_a(RubySMB::Dcerpc::Wkssvc::WkstaInfo100)
+  end
+  it 'is a NDR Pointer' do
+    expect(described_class).to be_a(RubySMB::Dcerpc::Ndr::PointerClassPlugin)
+  end
+  it 'reads itself' do
+    new_class = described_class.new(
+      wki100_platform_id: 500,
+      wki100_computername: 'MYCOMPUTER',
+      wki100_langroup: 'MYDOMAIN',
+      wki100_ver_major: 6,
+      wki100_ver_minor: 2
+    )
+    expect(packet.read(new_class.to_binary_s)).to eq(
+      {
+        wki100_platform_id: 500,
+        wki100_computername: 'MYCOMPUTER'.encode('utf-16le'),
+        wki100_langroup: 'MYDOMAIN'.encode('utf-16le'),
+        wki100_ver_major: 6,
+        wki100_ver_minor: 2
+      }
+    )
+  end
+end
+
+RSpec.describe RubySMB::Dcerpc::Wkssvc::LpwkstaInfo do
+  subject(:packet) { described_class.new }
+
+  it { is_expected.to respond_to :level }
+  it { is_expected.to respond_to :info }
+
+  it 'is little endian' do
+    expect(described_class.fields.instance_variable_get(:@hints)[:endian]).to eq :little
+  end
+  it 'it is a Ndr::NdrStruct' do
+    expect(described_class).to be < RubySMB::Dcerpc::Ndr::NdrStruct
+  end
+  describe '#level' do
+    it 'is a NdrUint32 structure' do
+      expect(packet.level).to be_a RubySMB::Dcerpc::Ndr::NdrUint32
+    end
+  end
+  describe '#info' do
+    it 'is a BinData:Choice structure' do
+      expect(packet.info).to be_a BinData::Choice
+    end
+    it 'selects a structure according to :level value' do
+      packet.level = RubySMB::Dcerpc::Wkssvc::WKSTA_INFO_100
+      expect(packet.info.send(:current_choice)).to be_a(RubySMB::Dcerpc::Wkssvc::WkstaInfo100)
+    end
+  end
+  it 'reads itself' do
+    new_class = described_class.new(
+      level: RubySMB::Dcerpc::Wkssvc::WKSTA_INFO_100,
+      info: {
+        wki100_platform_id: 500,
+        wki100_computername: 'MYCOMPUTER',
+        wki100_langroup: 'MYDOMAIN',
+        wki100_ver_major: 6,
+        wki100_ver_minor: 2
+      }
+    )
+    expect(packet.read(new_class.to_binary_s)).to eq(
+      {
+        level: RubySMB::Dcerpc::Wkssvc::WKSTA_INFO_100,
+        info: {
+          wki100_platform_id: 500,
+          wki100_computername: 'MYCOMPUTER'.encode('utf-16le'),
+          wki100_langroup: 'MYDOMAIN'.encode('utf-16le'),
+          wki100_ver_major: 6,
+          wki100_ver_minor: 2
+        }
+      }
+    )
+  end
+end
+
+RSpec.describe RubySMB::Dcerpc::Wkssvc::NetrWkstaGetInfoResponse do
+  subject(:packet) { described_class.new }
+
+  it { is_expected.to respond_to :wksta_info }
+  it { is_expected.to respond_to :error_status }
+  it { is_expected.to respond_to :opnum }
+
+  it 'is little endian' do
+    expect(described_class.fields.instance_variable_get(:@hints)[:endian]).to eq :little
+  end
+  it 'is a BinData::Record' do
+    expect(packet).to be_a(BinData::Record)
+  end
+  describe '#wksta_info' do
+    it 'is a LpwkstaInfo structure' do
+      expect(packet.wksta_info).to be_a RubySMB::Dcerpc::Wkssvc::LpwkstaInfo
+    end
+  end
+  describe '#error_status' do
+    it 'is a NdrUint32 structure' do
+      expect(packet.error_status).to be_a RubySMB::Dcerpc::Ndr::NdrUint32
+    end
+  end
+  describe '#initialize_instance' do
+    it 'sets #opnum to NETR_WKSTA_GET_INFO constant' do
+      expect(packet.opnum).to eq(RubySMB::Dcerpc::Wkssvc::NETR_WKSTA_GET_INFO)
+    end
+  end
+  it 'reads itself' do
+    new_class = described_class.new(
+      wksta_info: {
+        level: RubySMB::Dcerpc::Wkssvc::WKSTA_INFO_100,
+        info: {
+          wki100_platform_id: 500,
+          wki100_computername: 'MYCOMPUTER',
+          wki100_langroup: 'MYDOMAIN',
+          wki100_ver_major: 6,
+          wki100_ver_minor: 2
+        }
+      },
+      error_status: 0
+    )
+    expect(packet.read(new_class.to_binary_s)).to eq(
+      {
+        wksta_info: {
+          level: RubySMB::Dcerpc::Wkssvc::WKSTA_INFO_100,
+          info: {
+            wki100_platform_id: 500,
+            wki100_computername: 'MYCOMPUTER'.encode('utf-16le'),
+            wki100_langroup: 'MYDOMAIN'.encode('utf-16le'),
+            wki100_ver_major: 6,
+            wki100_ver_minor: 2
+          }
+        },
+        error_status: 0
+      }
+    )
+  end
+end
+

data/spec/lib/ruby_smb/dcerpc/wkssvc_spec.rb

@@ -0,0 +1,70 @@
+RSpec.describe RubySMB::Dcerpc::Wkssvc do
+  let(:wkssvc) do
+    RubySMB::SMB1::Pipe.new(
+      tree: double('Tree'),
+      response: RubySMB::SMB1::Packet::NtCreateAndxResponse.new,
+      name: 'wkssvc'
+    )
+  end
+
+  describe '#netr_wksta_get_info' do
+    let(:wkst_netr_wksta_get_info_request) { double('NetrWkstaGetInfoRequest') }
+    let(:response) { double('Response') }
+    let(:wkst_netr_wksta_get_info_response) { double('NetrWkstaGetInfoResponse') }
+    let(:info) { double('info') }
+    before :example do
+      allow(described_class::NetrWkstaGetInfoRequest).to receive(:new).and_return(wkst_netr_wksta_get_info_request)
+      allow(wkssvc).to receive(:dcerpc_request).and_return(response)
+      allow(described_class::NetrWkstaGetInfoResponse).to receive(:read).and_return(wkst_netr_wksta_get_info_response)
+      allow(wkst_netr_wksta_get_info_response).to receive(:error_status).and_return(WindowsError::Win32::ERROR_SUCCESS)
+      allow(wkst_netr_wksta_get_info_response).to receive_message_chain(:wksta_info, :info => info)
+    end
+
+    it 'sets the request with the expected values' do
+      wkssvc.netr_wksta_get_info
+      expect(described_class::NetrWkstaGetInfoRequest).to have_received(:new).with(
+        server_name: "\x00",
+        level: described_class::WKSTA_INFO_100
+      )
+    end
+    it 'send the expected request structure' do
+      wkssvc.netr_wksta_get_info
+      expect(wkssvc).to have_received(:dcerpc_request).with(wkst_netr_wksta_get_info_request)
+    end
+    context 'when an IOError occurs while parsing the response' do
+      it 'raises a RubySMB::Dcerpc::Error::InvalidPacket' do
+        allow(described_class::NetrWkstaGetInfoResponse).to receive(:read).and_raise(IOError)
+        expect { wkssvc.netr_wksta_get_info }.to raise_error(RubySMB::Dcerpc::Error::InvalidPacket)
+      end
+    end
+    context 'when the response error status is not WindowsError::Win32::ERROR_SUCCESS' do
+      it 'raises a RubySMB::Dcerpc::Error::WinregError' do
+        allow(wkst_netr_wksta_get_info_response).to receive(:error_status).and_return(WindowsError::Win32::ERROR_INVALID_DATA)
+        expect { wkssvc.netr_wksta_get_info }.to raise_error(RubySMB::Dcerpc::Error::WkssvcError)
+      end
+    end
+    it 'returns the expected handler' do
+      expect(wkssvc.netr_wksta_get_info).to eq(info)
+    end
+    context 'with a real binary stream' do
+      it 'returns the expected value' do
+        raw_response =
+          "d\x00\x00\x00\x00\x00\x02\x00\xF4\x01\x00\x00\x04\x00\x02\x00\b"\
+          "\x00\x02\x00\x06\x00\x00\x00\x02\x00\x00\x00\x0F\x00\x00\x00\x00"\
+          "\x00\x00\x00\x0F\x00\x00\x00W\x00I\x00N\x00-\x00A\x00B\x00C\x00D"\
+          "\x00E\x00F\x00C\x007\x006\x008\x00\x00\x00\x00\x00\x06\x00\x00"\
+          "\x00\x00\x00\x00\x00\x06\x00\x00\x00M\x00Y\x00L\x00A\x00B\x00\x00"\
+          "\x00\x00\x00\x00\x00"
+        allow(wkssvc).to receive(:dcerpc_request).and_return(raw_response)
+        allow(described_class::NetrWkstaGetInfoResponse).to receive(:read).and_call_original
+        expect(wkssvc.netr_wksta_get_info).to eq({
+          wki100_platform_id: 500,
+          wki100_computername: "WIN-ABCDEFC768".encode('utf-16le'),
+          wki100_langroup: "MYLAB".encode('utf-16le'),
+          wki100_ver_major: 6,
+          wki100_ver_minor: 2
+        })
+      end
+    end
+  end
+end

data/spec/lib/ruby_smb/dispatcher/socket_spec.rb

@@ -102,26 +102,26 @@ RSpec.describe RubySMB::Dispatcher::Socket do
       end
 
       it 'reads the number of bytes specified in the nbss header' do
-        packet_length = 10
-        session_header.packet_length = packet_length
+        stream_protocol_length = 10
+        session_header.stream_protocol_length = stream_protocol_length
         allow(RubySMB::Nbss::SessionHeader).to receive(:read).and_return(session_header)
         expect(response_socket).to receive(:read).with(4).and_return(session_header)
-        expect(response_socket).to receive(:read).with(packet_length).and_return('A' * packet_length)
+        expect(response_socket).to receive(:read).with(stream_protocol_length).and_return('A' * stream_protocol_length)
         smb_socket.recv_packet
       end
 
       context 'when the socket does not return everything the first time' do
         it 'calls #read several times until everything is returned' do
-          packet_length = 67
+          stream_protocol_length = 67
           returned_length = 10
-          session_header.packet_length = packet_length
+          session_header.stream_protocol_length = stream_protocol_length
           allow(RubySMB::Nbss::SessionHeader).to receive(:read).and_return(session_header)
 
           expect(response_socket).to receive(:read).with(4).and_return(session_header)
           loop do
-            expect(response_socket).to receive(:read).with(packet_length).and_return('A' * returned_length).once
-            packet_length -= returned_length
-            break if packet_length <= 0
+            expect(response_socket).to receive(:read).with(stream_protocol_length).and_return('A' * returned_length).once
+            stream_protocol_length -= returned_length
+            break if stream_protocol_length <= 0
           end
           smb_socket.recv_packet
         end
@@ -134,7 +134,7 @@ RSpec.describe RubySMB::Dispatcher::Socket do
 
         context 'when the SMB packet is empty' do
           it 'returns the nbss header only' do
-            session_header.packet_length = 0
+            session_header.stream_protocol_length = 0
             allow(RubySMB::Nbss::SessionHeader).to receive(:read).and_return(session_header)
             expect(smb_socket.recv_packet(full_response: true)).to eq(session_header.to_binary_s)
           end
@@ -148,7 +148,7 @@ RSpec.describe RubySMB::Dispatcher::Socket do
 
         context 'when the SMB packet is empty' do
           it 'returns an empty string' do
-            session_header.packet_length = 0
+            session_header.stream_protocol_length = 0
             allow(RubySMB::Nbss::SessionHeader).to receive(:read).and_return(session_header)
             expect(smb_socket.recv_packet(full_response: false)).to eq('')
           end

data/spec/lib/ruby_smb/error_spec.rb

@@ -9,16 +9,45 @@ RSpec.describe RubySMB::Error::InvalidPacket do
   end
 
   context 'with a Hash' do
-    it 'outputs the expected error message' do
-      ex = described_class.new(
+    let(:ex) do
+      described_class.new(
         expected_proto:  RubySMB::SMB1::SMB_PROTOCOL_ID,
         expected_cmd:    RubySMB::SMB1::Packet::NegotiateResponseExtended::COMMAND,
         expected_custom: "extended_security=1",
-        received_proto:  RubySMB::SMB2::SMB2_PROTOCOL_ID,
-        received_cmd:    RubySMB::SMB2::Packet::NegotiateResponse::COMMAND,
+        packet:          packet,
         received_custom: "extended_security=0"
       )
-      expect(ex.to_s).to eq('Expecting SMB1 protocol with command=114 (extended_security=1), got SMB2 protocol with command=0 (extended_security=0)')
+    end
+
+    context 'with an SMB2 packet' do
+      let(:packet) { RubySMB::SMB2::Packet::NegotiateResponse.new }
+
+      it 'outputs the expected error message' do
+        expect(ex.to_s).to eq('Expecting SMB1 protocol with command=114 (extended_security=1), got SMB2 protocol with command=0 (extended_security=0), Status: (0x00000000) STATUS_SUCCESS: The operation completed successfully.')
+      end
+    end
+
+    context 'with an SMB1 packet' do
+      let(:packet) { RubySMB::SMB1::Packet::ReadAndxRequest.new }
+
+      it 'outputs the expected error message' do
+        expect(ex.to_s).to eq('Expecting SMB1 protocol with command=114 (extended_security=1), got SMB1 protocol with command=46 (extended_security=0), Status: (0x00000000) STATUS_SUCCESS: The operation completed successfully.')
+      end
+    end
+
+    context 'without packet' do
+      let(:ex) do
+        described_class.new(
+          expected_proto:  RubySMB::SMB1::SMB_PROTOCOL_ID,
+          expected_cmd:    RubySMB::SMB1::Packet::NegotiateResponseExtended::COMMAND,
+          expected_custom: "extended_security=1",
+          received_custom: "extended_security=0"
+        )
+      end
+
+      it 'outputs the expected error message' do
+        expect(ex.to_s).to eq('Expecting SMB1 protocol with command=114 (extended_security=1), got ??? protocol with command=??? (extended_security=0)')
+      end
     end
   end
 

data/spec/lib/ruby_smb/field/string16_spec.rb

@@ -0,0 +1,22 @@
+RSpec.describe RubySMB::Field::String16 do
+  subject(:field) { described_class.new }
+
+  it 'is a BinData::String' do
+    expect(field).to be_a BinData::String
+  end
+
+  it 'converts to utf-16le when assigning a String' do
+    expect(field.assign('Test'.encode('ASCII-8BIT')).encoding).to be Encoding::UTF_16LE
+  end
+
+  it 'makes sure snapshot returns a utf-16le string' do
+    field.new('Test'.encode('ASCII-8BIT'))
+    expect(field.snapshot.encoding).to be Encoding::UTF_16LE
+  end
+
+  it 'makes sure read operation returns a utf-16le string' do
+    field.read('Test'.encode('ASCII-8BIT'))
+    expect(field.snapshot.encoding).to be Encoding::UTF_16LE
+  end
+
+end

data/spec/lib/ruby_smb/field/stringz16_spec.rb

@@ -44,5 +44,17 @@ RSpec.describe RubySMB::Field::Stringz16 do
       io = StringIO.new("A\x00B\x00C\x00D\x00")
       expect { stringz16.read(io) }.to raise_error(EOFError)
     end
+
+    it 'trims the string to #max_length and makes sure it ends with a null terminator' do
+      io = StringIO.new("A\x00B\x00C\x00D\x00")
+      str = described_class.new(max_length: 6)
+      expect(str.read(io).to_binary_s).to eq("A\x00B\x00\x00\x00".b)
+    end
+
+    it 'raises an exception when #max_length is not a multiple of two' do
+      io = StringIO.new("A\x00B\x00C\x00D\x00")
+      str = described_class.new(max_length: 5)
+      expect { str.read(io) }.to raise_error(ArgumentError)
+    end
   end
 end

data/spec/lib/ruby_smb/generic_packet_spec.rb

@@ -88,6 +88,13 @@ RSpec.describe RubySMB::GenericPacket do
         packet = RubySMB::SMB2::Packet::NegotiateResponse.read(smb2_error_packet.to_binary_s)
         expect(packet.original_command).to eq RubySMB::SMB2::Packet::NegotiateResponse::COMMAND
       end
+
+      context 'when the server returns an SMB1 error packet' do
+        let(:smb1_error_packet) { RubySMB::SMB1::Packet::EmptyPacket.new }
+        it 'returns the empty packet instead of the asked for class' do
+          expect(RubySMB::SMB2::Packet::NegotiateResponse.read(smb1_error_packet.to_binary_s)).to be_a RubySMB::SMB1::Packet::EmptyPacket
+        end
+      end
     end
   end
 

data/spec/lib/ruby_smb/gss/provider/ntlm/account_spec.rb

@@ -0,0 +1,32 @@
+RSpec.describe RubySMB::Gss::Provider::NTLM::Account do
+  let(:username) { 'RubySMB' }
+  let(:password) { 'password' }
+  let(:domain) { 'WORKGROUP' }
+  subject(:account) { RubySMB::Gss::Provider::NTLM::Account.new(username, password, domain) }
+
+  it { is_expected.to respond_to :username }
+  it { is_expected.to respond_to :password }
+  it { is_expected.to respond_to :domain }
+
+  it 'sets the username correct' do
+    expect(account.username).to eq username
+  end
+
+  it 'sets the password correctly' do
+    expect(account.password).to eq password
+  end
+
+  it 'sets the domain correctly' do
+    expect(account.domain).to eq domain
+  end
+
+  describe '#to_s' do
+    it 'converts to a string' do
+      expect(account.to_s).to be_a String
+    end
+
+    it 'formats the username and domain correctly' do
+      expect(account.to_s).to eq "#{domain}\\#{username}"
+    end
+  end
+end