ruby_smb 2.0.12 → 3.0.2

data/spec/lib/ruby_smb/server/session_spec.rb

@@ -0,0 +1,38 @@
+RSpec.describe RubySMB::Server::Session do
+  let(:user_id) { 'WORKGROUP\RubySMB' }
+  subject(:session) { described_class.new(rand(0xffffffff), user_id: user_id) }
+
+  it { is_expected.to respond_to :id }
+  it { is_expected.to respond_to :key }
+  it { is_expected.to respond_to :signing_required }
+  it { is_expected.to respond_to :tree_connect_table }
+  it { is_expected.to respond_to :creation_time }
+
+  describe '#initialize' do
+    it 'starts with no signing required' do
+      expect(session.signing_required).to be_falsey
+    end
+
+    it 'starts with no tree connections' do
+      expect(session.tree_connect_table).to be_empty
+    end
+
+    it 'starts in the in progress state' do
+      expect(session.state).to be :in_progress
+    end
+  end
+
+  describe '#is_anonymous' do
+    it 'is false' do
+      expect(session.is_anonymous).to be_falsey
+    end
+
+    context 'when the identity is set to anonymous' do
+      let(:user_id) { RubySMB::Gss::Provider::IDENTITY_ANONYMOUS }
+
+      it 'is true' do
+        expect(session.is_anonymous).to be_truthy
+      end
+    end
+  end
+end

data/spec/lib/ruby_smb/server/share/provider/disk_spec.rb

@@ -0,0 +1,61 @@
+RSpec.describe RubySMB::Server::Share::Provider::Disk do
+  let(:name) { 'share' }
+  let(:path) { Dir.getwd }
+  subject(:share_provider) { described_class.new(name, path) }
+
+  it { is_expected.to respond_to :name }
+  it { is_expected.to respond_to :path }
+  it { is_expected.to respond_to :type }
+
+  describe '#TYPE' do
+    it 'is TYPE_DISK' do
+      expect(described_class::TYPE).to eq RubySMB::Server::Share::TYPE_DISK
+    end
+  end
+
+  describe '#initialize' do
+    it 'sets the name' do
+      expect(share_provider.name).to eq name
+    end
+
+    it 'sets the path' do
+      expect(share_provider.path).to be_a Pathname
+      expect(share_provider.path).to eq Pathname.new(path)
+    end
+
+    it 'sets the type correctly' do
+      expect(share_provider.type).to eq RubySMB::Server::Share::TYPE_DISK
+    end
+
+    it 'raises an ArgumentError for an invalid path' do
+      # __FILE__ is not a directory so it's invalid
+      expect { described_class.new(name, __FILE__) }.to raise_error(ArgumentError)
+    end
+  end
+end
+
+RSpec.describe RubySMB::Server::Share::Provider::Disk::Processor do
+  let(:session) { RubySMB::Server::Session.new(rand(0xffffffff)) }
+  let(:share_provider) { RubySMB::Server::Share::Provider::Disk.new('share', Dir.getwd) }
+  subject(:share_processor) { described_class.new(share_provider, nil, session) }
+
+  it { is_expected.to respond_to :provider }
+
+  describe '#maximal_access' do
+    # no path specified should be the root of the share
+    context 'with no path specified' do
+      let(:maximal_access) { share_processor.maximal_access }
+      it 'is a FileAccessMask' do
+        expect(maximal_access).to be_a RubySMB::SMB2::BitField::FileAccessMask
+      end
+
+      it 'marks the data as readable' do
+        expect(maximal_access.read_data).to eq 1
+      end
+
+      it 'marks the data attributes as readable' do
+        expect(maximal_access.read_attr).to eq 1
+      end
+    end
+  end
+end

data/spec/lib/ruby_smb/server/share/provider/pipe_spec.rb

@@ -0,0 +1,31 @@
+RSpec.describe RubySMB::Server::Share::Provider::Pipe do
+  let(:name) { 'share' }
+  subject(:share_provider) { described_class.new(name) }
+
+  it { is_expected.to respond_to :name }
+  it { is_expected.to respond_to :type }
+
+  describe '#TYPE' do
+    it 'is TYPE_PIPE' do
+      expect(described_class::TYPE).to eq RubySMB::Server::Share::TYPE_PIPE
+    end
+  end
+
+  describe '#initialize' do
+    it 'sets the name' do
+      expect(share_provider.name).to eq name
+    end
+
+    it 'sets the type correctly' do
+      expect(share_provider.type).to eq RubySMB::Server::Share::TYPE_PIPE
+    end
+  end
+end
+
+RSpec.describe RubySMB::Server::Share::Provider::Pipe::Processor do
+  let(:session) { RubySMB::Server::Session.new(rand(0xffffffff)) }
+  let(:share_provider) { RubySMB::Server::Share::Provider::Pipe.new('share') }
+  subject(:share_processor) { described_class.new(share_provider, nil, session) }
+
+  it { is_expected.to respond_to :provider }
+end

data/spec/lib/ruby_smb/server/share/provider_spec.rb

@@ -0,0 +1,13 @@
+RSpec.describe RubySMB::Server::Share::Provider::Base do
+  let(:name) { 'share' }
+  subject(:share_provider) { described_class.new(name) }
+
+  it { is_expected.to respond_to :name }
+  it { is_expected.to respond_to :type }
+
+  describe '#initialize' do
+    it 'sets the name' do
+      expect(share_provider.name).to eq name
+    end
+  end
+end

data/spec/lib/ruby_smb/smb1/pipe_spec.rb

@@ -140,45 +140,26 @@ RSpec.describe RubySMB::SMB1::Pipe do
       expect(pipe.size_on_disk).to eq(nt_create_andx_response.parameter_block.allocation_size)
     end
 
-    context 'with \'srvsvc\' filename' do
-      it 'extends Srvsvc class' do
-        pipe = described_class.new(tree: tree, response: nt_create_andx_response, name: 'srvsvc')
-        expect(pipe.respond_to?(:net_share_enum_all)).to be true
-      end
-    end
-
-    context 'with \'\\srvsvc\' filename' do
-      it 'extends Srvsvc class' do
-        pipe = described_class.new(tree: tree, response: nt_create_andx_response, name: '\\srvsvc')
-        expect(pipe.respond_to?(:net_share_enum_all)).to be true
-      end
-    end
-
-    context 'with \'winreg\' filename' do
-      it 'extends Winreg class' do
-        pipe = described_class.new(tree: tree, response: nt_create_andx_response, name: 'winreg')
-        expect(pipe.respond_to?(:has_registry_key?)).to be true
-      end
-    end
-
-    context 'with \'\\winreg\' filename' do
-      it 'extends Winreg class' do
-        pipe = described_class.new(tree: tree, response: nt_create_andx_response, name: '\\winreg')
-        expect(pipe.respond_to?(:has_registry_key?)).to be true
-      end
-    end
-
-    context 'with \'svcctl\' filename' do
-      it 'extends svcctl class' do
-        pipe = described_class.new(tree: tree, response: nt_create_andx_response, name: 'svcctl')
-        expect(pipe.respond_to?(:query_service_config)).to be true
+    {
+      netlogon: RubySMB::Dcerpc::Netlogon,
+      srvsvc: RubySMB::Dcerpc::Srvsvc,
+      svcctl: RubySMB::Dcerpc::Svcctl,
+      winreg: RubySMB::Dcerpc::Winreg,
+      samr: RubySMB::Dcerpc::Samr,
+      wkssvc: RubySMB::Dcerpc::Wkssvc
+    }.each do |endpoint, klass|
+      context "with \'#{endpoint}\' filename" do
+        it "extends #{klass} class" do
+          pipe = described_class.new(tree: tree, response: nt_create_andx_response, name: endpoint.to_s)
+          expect(pipe).to be_a klass
+        end
       end
-    end
 
-    context 'with \'\\svcctl\' filename' do
-      it 'extends svcctl class' do
-        pipe = described_class.new(tree: tree, response: nt_create_andx_response, name: '\\svcctl')
-        expect(pipe.respond_to?(:query_service_config)).to be true
+      context "with \'\\#{endpoint}\' filename" do
+        it "extends #{klass} class" do
+          pipe = described_class.new(tree: tree, response: nt_create_andx_response, name: "\\#{endpoint.to_s}")
+          expect(pipe).to be_a klass
+        end
       end
     end
   end

data/spec/lib/ruby_smb/smb2/bit_field/header_flags_spec.rb

@@ -44,8 +44,14 @@ RSpec.describe RubySMB::SMB2::BitField::Smb2HeaderFlags do
   end
 
   describe '#reserved3' do
-    it 'should be a 4-bit field per the SMB spec' do
-      expect(flags.reserved3).to be_a BinData::Bit4
+    it 'should be a 1-bit field per the SMB spec' do
+      expect(flags.reserved3).to be_a BinData::Bit1
+    end
+  end
+
+  describe '#priority' do
+    it 'should be a 3-bit field per the SMB spec' do
+      expect(flags.priority).to be_a BinData::Bit3
     end
   end
 

data/spec/lib/ruby_smb/smb2/{create_context_spec.rb → create_context/create_context_request_spec.rb}

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-RSpec.describe RubySMB::SMB2::CreateContext do
+RSpec.describe RubySMB::SMB2::CreateContext::CreateContextRequest do
   subject(:struct) { described_class.new }
 
   it { is_expected.to respond_to :next_offset }

data/spec/lib/ruby_smb/smb2/packet/create_request_spec.rb

@@ -80,22 +80,22 @@ RSpec.describe RubySMB::SMB2::Packet::CreateRequest do
     expect(packet.name_offset).to eq packet.name.abs_offset
   end
 
-  it 'tracks the offset to #context in #context_offset' do
-    expect(packet.context_offset).to eq packet.context.abs_offset
+  it 'tracks the offset to #context in #contexts_offset' do
+    expect(packet.contexts_offset).to eq packet.contexts.abs_offset
   end
 
   it 'tracks the length of #name in #name_length' do
     expect(packet.name_length).to eq packet.name.length
   end
 
-  it 'tracks the length of #context in #context_length' do
-    expect(packet.context_length).to eq packet.context.do_num_bytes
+  it 'tracks the length of #context in #contexts_length' do
+    expect(packet.contexts_length).to eq packet.contexts.do_num_bytes
   end
 
   describe '#name' do
     it 'encodes any input into UTF-16LE' do
       packet.name = 'Hello'
-      expect(packet.name.to_binary_s).to eq "H\x00e\x00l\x00l\x00o\x00"
+      expect(packet.name.to_binary_s { |name| name.abs_offset = 0; name.write_now! }).to eq "H\x00e\x00l\x00l\x00o\x00"
     end
   end
 end

data/spec/lib/ruby_smb/smb2/packet/create_response_spec.rb

@@ -54,11 +54,15 @@ RSpec.describe RubySMB::SMB2::Packet::CreateResponse do
     expect(packet.file_id).to be_a RubySMB::Field::Smb2Fileid
   end
 
-  it 'tracks the offset to #context in #context_offset' do
-    expect(packet.context_offset).to eq packet.context.abs_offset
-  end
+  describe '#contexts' do
+    # with no context, the offset and length should be 0
+    # see: https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-smb2/d166aa9e-0b53-410e-b35e-3933d8131927
+    it 'should have the contexts_offset set to 0' do
+      expect(packet.contexts_offset).to eq 0
+    end
 
-  it 'tracks the length of #context in #context_length' do
-    expect(packet.context_length).to eq packet.context.do_num_bytes
+    it 'should have the contexts_length set to ' do
+      expect(packet.contexts_length).to eq 0
+    end
   end
 end

data/spec/lib/ruby_smb/smb2/packet/query_directory_response_spec.rb

@@ -30,8 +30,9 @@ RSpec.describe RubySMB::SMB2::Packet::QueryDirectoryResponse do
     expect(packet.structure_size).to eq 9
   end
 
-  it 'has an offset pointer to the buffer field' do
-    expect(packet.buffer_offset).to eq packet.buffer.abs_offset
+  it 'has an offset pointer of 0 for an empty buffer field' do
+    expect(packet.buffer).to be_empty
+    expect(packet.buffer_offset).to eq 0
   end
 
   it 'has a length value for the buffer field' do

data/spec/lib/ruby_smb/smb2/pipe_spec.rb

@@ -146,24 +146,26 @@ RSpec.describe RubySMB::SMB2::Pipe do
       expect(pipe.size_on_disk).to eq(create_response.allocation_size)
     end
 
-    context 'with \'srvsvc\' filename' do
-      it 'extends Srvsvc class' do
-        pipe = described_class.new(tree: tree, response: create_response, name: 'srvsvc')
-        expect(pipe.respond_to?(:net_share_enum_all)).to be true
-      end
-    end
-
-    context 'with \'winreg\' filename' do
-      it 'extends Winreg class' do
-        pipe = described_class.new(tree: tree, response: create_response, name: 'winreg')
-        expect(pipe.respond_to?(:has_registry_key?)).to be true
+    {
+      netlogon: RubySMB::Dcerpc::Netlogon,
+      srvsvc: RubySMB::Dcerpc::Srvsvc,
+      svcctl: RubySMB::Dcerpc::Svcctl,
+      winreg: RubySMB::Dcerpc::Winreg,
+      samr: RubySMB::Dcerpc::Samr,
+      wkssvc: RubySMB::Dcerpc::Wkssvc
+    }.each do |endpoint, klass|
+      context "with \'#{endpoint}\' filename" do
+        it "extends #{klass} class" do
+          pipe = described_class.new(tree: tree, response: create_response, name: endpoint.to_s)
+          expect(pipe).to be_a klass
+        end
       end
-    end
 
-    context 'with \'svcctl\' filename' do
-      it 'extends svcctl class' do
-        pipe = described_class.new(tree: tree, response: create_response, name: 'svcctl')
-        expect(pipe.respond_to?(:query_service_config)).to be true
+      context "with \'\\#{endpoint}\' filename" do
+        it "extends #{klass} class" do
+          pipe = described_class.new(tree: tree, response: create_response, name: "\\#{endpoint.to_s}")
+          expect(pipe).to be_a klass
+        end
       end
     end
   end

data/spec/support/bin_helper.rb

@@ -0,0 +1,9 @@
+class String
+  def hexlify
+    self.b.bytes.map {|c| "%02x" % c.ord}.join
+  end
+
+  def unhexlify
+    self.chars.each_slice(2).map {|c| c.join.to_i(16).chr}.join
+  end
+end