ruby_raider 4.1.0 → 4.2.0

data/spec/utilities/schedules/spawn_spec.rb

@@ -0,0 +1,104 @@
+# frozen_string_literal: true
+
+require 'tmpdir'
+require_relative '../../../lib/utilities/schedules/spawn'
+
+RSpec.describe RubyRaider::Schedules::Spawn do # rubocop:disable RSpec/FilePath
+  let(:dir) { File.realpath(Dir.mktmpdir('schedules-spawn')) }
+  let(:ready) { File.join(dir, 'ready') }
+  let(:got) { File.join(dir, 'got') }
+  # Counts the INTs it gets (TERM counts 100), then exits 0
+  let(:child) do
+    "n = 0; trap('INT') { n += 1 }; trap('TERM') { n += 100 }; File.write(#{ready.inspect}, ''); " \
+      "sleep 1.5; File.write(#{got.inspect}, n.to_s)"
+  end
+
+  after { FileUtils.rm_rf(dir) }
+
+  def signal_when_ready(*signals)
+    Thread.new do
+      sleep 0.05 until File.exist?(ready)
+      signals.each { |signal| Process.kill(signal, Process.pid) }
+    end
+  end
+
+  it 'runs without a shell and returns the exit status, not stopped' do
+    result = described_class.call({ 'X' => '; exit 7' }, [RbConfig.ruby, '-e', 'exit(ENV["X"] == "; exit 7" ? 5 : 6)'], dir)
+
+    expect(result).to eq([5, false])
+  end
+
+  it 'unsets a variable given as nil' do
+    ENV['RAIDER_SPAWN_SPEC'] = 'inherited'
+    result = described_class.call({ 'RAIDER_SPAWN_SPEC' => nil }, [RbConfig.ruby, '-e', 'exit(ENV.key?("RAIDER_SPAWN_SPEC") ? 1 : 0)'], dir)
+
+    expect(result.first).to eq(0)
+  ensure
+    ENV.delete('RAIDER_SPAWN_SPEC')
+  end
+
+  describe 'stopping', skip: Gem.win_platform? do
+    it 'passes TERM then INT on as one INT when the INT could not have reached the child' do
+      signal_when_ready('TERM', 'INT')
+
+      result = described_class.call({}, [RbConfig.ruby, '-e', child], dir, forward_int: true)
+
+      expect([result, File.read(got)]).to eq([[0, true], '1'])
+    end
+
+    it 'does not pass on an INT that the terminal already sent to the child' do
+      signal_when_ready('INT')
+
+      result = described_class.call({}, [RbConfig.ruby, '-e', child], dir, forward_int: false)
+
+      expect([result, File.read(got)]).to eq([[0, true], '0'])
+    end
+
+    it 'passes TERM on as one INT even when INTs are not forwarded' do
+      signal_when_ready('TERM')
+
+      result = described_class.call({}, [RbConfig.ruby, '-e', child], dir, forward_int: false)
+
+      expect([result, File.read(got)]).to eq([[0, true], '1'])
+    end
+
+    it 'sends no second INT for a TERM after a terminal Ctrl-C' do
+      signal_when_ready('INT', 'TERM')
+
+      result = described_class.call({}, [RbConfig.ruby, '-e', child], dir, forward_int: false)
+
+      expect([result, File.read(got)]).to eq([[0, true], '0'])
+    end
+
+    it 'passes on a stop that came before the child existed, once it does, whatever forward_int says' do
+      started = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+      state = { pid: nil, stopped: true, interrupted: false }
+
+      code = described_class.run({}, [RbConfig.ruby, '-e', 'sleep 5'], dir, state, false)
+
+      expect([code, state[:interrupted], Process.clock_gettime(Process::CLOCK_MONOTONIC) - started < 4]).to eq([nil, true, true])
+    end
+
+    it 'forgets the pid once the child is reaped, so a late signal reaches no other process' do
+      state = { pid: nil, stopped: false, interrupted: false }
+      described_class.run({}, [RbConfig.ruby, '-e', 'exit 0'], dir, state, true)
+      described_class.stop(state, 'TERM', true)
+
+      expect(state).to eq(pid: nil, stopped: true, interrupted: false)
+    end
+
+    it 'restores the previous handlers' do
+      previous = trap('INT', 'IGNORE')
+      described_class.call({}, [RbConfig.ruby, '-e', 'exit 0'], dir)
+
+      expect(trap('INT', previous)).to eq('IGNORE')
+    end
+  end
+
+  it 'returns no exit status with one line on stderr when the command is not found' do
+    result = nil
+
+    expect { result = described_class.call({}, ['raider-no-such-command'], dir) }.to output(/Could not start raider-no-such-command/).to_stderr
+    expect(result).to eq([nil, false])
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby_raider
 version: !ruby/object:Gem::Version
-  version: 4.1.0
+  version: 4.2.0
 platform: ruby
 authors:
 - Agustin Pequeno
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-11-10 00:00:00.000000000 Z
+date: 2026-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler-audit
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.11.0
+- !ruby/object:Gem::Dependency
+  name: rspec-retry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -260,8 +274,8 @@ files:
 - assets/ruby_raider_logo.svg
 - bin/raider
 - bin/release
-- lib/commands/flow_commands.rb
 - lib/commands/scaffolding_commands.rb
+- lib/commands/schedule_commands.rb
 - lib/commands/utility_commands.rb
 - lib/generators/automation/automation_generator.rb
 - lib/generators/automation/templates/account.tt
@@ -306,8 +320,6 @@ files:
 - lib/generators/templates/common/reek.tt
 - lib/generators/templates/common/rspec.tt
 - lib/generators/templates/common/rubocop.tt
-- lib/generators/templates/flows/flow_helper.tt
-- lib/generators/templates/flows/run.tt
 - lib/generators/templates/helpers/appium_helper.tt
 - lib/generators/templates/helpers/driver_helper.tt
 - lib/generators/templates/helpers/gesture_helper.tt
@@ -342,9 +354,11 @@ files:
 - lib/ruby_raider/runtime/matchers/presence.rb
 - lib/ruby_raider/runtime/matchers/retrying_block.rb
 - lib/ruby_raider/runtime/observer.rb
+- lib/ruby_raider/runtime/retry_reset.rb
 - lib/ruby_raider/runtime/role_finder.rb
 - lib/ruby_raider/runtime/rspec.rb
 - lib/ruby_raider/runtime/selectors.rb
+- lib/ruby_raider/runtime/show_browser.rb
 - lib/ruby_raider/runtime/strict.rb
 - lib/ruby_raider/runtime/wait.rb
 - lib/scaffolding/name_normalizer.rb
@@ -355,28 +369,41 @@ files:
 - lib/scaffolding/templates/page_object.tt
 - lib/scaffolding/templates/spec.tt
 - lib/utilities/desktop_downloader.rb
-- lib/utilities/flows/next_run.rb
-- lib/utilities/flows/notifier.rb
-- lib/utilities/flows/os/command_runner.rb
-- lib/utilities/flows/os/cron.rb
-- lib/utilities/flows/os/launchd.rb
-- lib/utilities/flows/os/linux.rb
-- lib/utilities/flows/os/systemd.rb
-- lib/utilities/flows/os/task_scheduler.rb
-- lib/utilities/flows/project.rb
-- lib/utilities/flows/run_log.rb
-- lib/utilities/flows/runner.rb
-- lib/utilities/flows/schedule.rb
-- lib/utilities/flows/schedule_store.rb
-- lib/utilities/flows/scheduler.rb
 - lib/utilities/logger.rb
 - lib/utilities/logo.rb
+- lib/utilities/schedules/adapter.rb
+- lib/utilities/schedules/base.rb
+- lib/utilities/schedules/kind.rb
+- lib/utilities/schedules/legacy.rb
+- lib/utilities/schedules/legacy_stub.rb
+- lib/utilities/schedules/next_run.rb
+- lib/utilities/schedules/notifier.rb
+- lib/utilities/schedules/os/command_runner.rb
+- lib/utilities/schedules/os/cron.rb
+- lib/utilities/schedules/os/launchd.rb
+- lib/utilities/schedules/os/linux.rb
+- lib/utilities/schedules/os/systemd.rb
+- lib/utilities/schedules/os/task_scheduler.rb
+- lib/utilities/schedules/os_enumerator.rb
+- lib/utilities/schedules/project.rb
+- lib/utilities/schedules/rule.rb
+- lib/utilities/schedules/run_lock.rb
+- lib/utilities/schedules/run_log.rb
+- lib/utilities/schedules/run_report.rb
+- lib/utilities/schedules/run_wrapper.rb
+- lib/utilities/schedules/schedule.rb
+- lib/utilities/schedules/schedule_store.rb
+- lib/utilities/schedules/scheduler.rb
+- lib/utilities/schedules/scheduler_steps.rb
+- lib/utilities/schedules/selection.rb
+- lib/utilities/schedules/spawn.rb
+- lib/utilities/schedules/store.rb
 - lib/utilities/utilities.rb
 - lib/version
 - plugins.yml
 - ruby_raider.gemspec
-- sig/commands/flow_commands.rbs
 - sig/commands/scaffolding_commands.rbs
+- sig/commands/schedule_commands.rbs
 - sig/commands/utility_commands.rbs
 - sig/generators/automation/automation_generator.rbs
 - sig/generators/common_generator.rbs
@@ -408,42 +435,56 @@ files:
 - sig/ruby_raider/runtime/matchers/presence.rbs
 - sig/ruby_raider/runtime/matchers/retrying_block.rbs
 - sig/ruby_raider/runtime/observer.rbs
+- sig/ruby_raider/runtime/retry_reset.rbs
 - sig/ruby_raider/runtime/role_finder.rbs
 - sig/ruby_raider/runtime/selectors.rbs
+- sig/ruby_raider/runtime/show_browser.rbs
 - sig/ruby_raider/runtime/strict.rbs
 - sig/ruby_raider/runtime/wait.rbs
 - sig/scaffolding/name_normalizer.rbs
 - sig/scaffolding/project_detector.rbs
 - sig/scaffolding/scaffolding.rbs
 - sig/utilities/desktop_downloader.rbs
-- sig/utilities/flows/next_run.rbs
-- sig/utilities/flows/notifier.rbs
-- sig/utilities/flows/os/command_runner.rbs
-- sig/utilities/flows/os/cron.rbs
-- sig/utilities/flows/os/launchd.rbs
-- sig/utilities/flows/os/linux.rbs
-- sig/utilities/flows/os/systemd.rbs
-- sig/utilities/flows/os/task_scheduler.rbs
-- sig/utilities/flows/project.rbs
-- sig/utilities/flows/run_log.rbs
-- sig/utilities/flows/runner.rbs
-- sig/utilities/flows/schedule.rbs
-- sig/utilities/flows/schedule_store.rbs
-- sig/utilities/flows/scheduler.rbs
 - sig/utilities/logger.rbs
 - sig/utilities/logo.rbs
+- sig/utilities/schedules/adapter.rbs
+- sig/utilities/schedules/base.rbs
+- sig/utilities/schedules/kind.rbs
+- sig/utilities/schedules/legacy.rbs
+- sig/utilities/schedules/legacy_stub.rbs
+- sig/utilities/schedules/next_run.rbs
+- sig/utilities/schedules/notifier.rbs
+- sig/utilities/schedules/os/command_runner.rbs
+- sig/utilities/schedules/os/cron.rbs
+- sig/utilities/schedules/os/launchd.rbs
+- sig/utilities/schedules/os/linux.rbs
+- sig/utilities/schedules/os/systemd.rbs
+- sig/utilities/schedules/os/task_scheduler.rbs
+- sig/utilities/schedules/os_enumerator.rbs
+- sig/utilities/schedules/project.rbs
+- sig/utilities/schedules/rule.rbs
+- sig/utilities/schedules/run_lock.rbs
+- sig/utilities/schedules/run_log.rbs
+- sig/utilities/schedules/run_report.rbs
+- sig/utilities/schedules/run_wrapper.rbs
+- sig/utilities/schedules/schedule.rbs
+- sig/utilities/schedules/schedule_store.rbs
+- sig/utilities/schedules/scheduler.rbs
+- sig/utilities/schedules/scheduler_steps.rbs
+- sig/utilities/schedules/selection.rbs
+- sig/utilities/schedules/spawn.rbs
+- sig/utilities/schedules/store.rbs
 - sig/utilities/utilities.rbs
 - sig/vendor/selenium_webdriver.rbs
 - sig/vendor/thor.rbs
 - sig/vendor/tty_prompt.rbs
-- spec/commands/flow_commands_spec.rb
 - spec/commands/raider_commands_spec.rb
 - spec/commands/scaffolding_commands_spec.rb
+- spec/commands/schedule_commands_spec.rb
 - spec/commands/utility_commands_spec.rb
 - spec/generators/fixtures/templates/test.tt
 - spec/generators/fixtures/templates/test_partial.tt
 - spec/generators/fixtures/video_helper_stubs/selenium-webdriver.rb
-- spec/generators/flow_helper_spec.rb
 - spec/generators/gesture_helper_spec.rb
 - spec/generators/network_helper_spec.rb
 - spec/generators/screenshot_helper_spec.rb
@@ -468,9 +509,6 @@ files:
 - spec/integration/content/test_content_spec.rb
 - spec/integration/end_to_end_features_spec.rb
 - spec/integration/end_to_end_spec.rb
-- spec/integration/flows/flow_project.rb
-- spec/integration/flows/run_command_spec.rb
-- spec/integration/flows/run_lifecycle_spec.rb
 - spec/integration/frozen_string_literal_matcher.rb
 - spec/integration/generators/automation_generator_spec.rb
 - spec/integration/generators/axe_addon_spec.rb
@@ -512,9 +550,12 @@ files:
 - spec/runtime/matchers/presence_spec.rb
 - spec/runtime/matchers/retrying_block_spec.rb
 - spec/runtime/observer_spec.rb
+- spec/runtime/retry_reset_spec.rb
 - spec/runtime/role_finder_spec.rb
 - spec/runtime/role_query_spec.rb
 - spec/runtime/selectors_spec.rb
+- spec/runtime/show_browser_project_spec.rb
+- spec/runtime/show_browser_spec.rb
 - spec/runtime/strict_spec.rb
 - spec/runtime/support/browser.rb
 - spec/runtime/support/fake_bridge.rb
@@ -526,21 +567,33 @@ files:
 - spec/system/support/system_test_helper.rb
 - spec/utilities/desktop_downloader_spec.rb
 - spec/utilities/ffmpeg_spec.rb
-- spec/utilities/flows/next_run_spec.rb
-- spec/utilities/flows/notifier_spec.rb
-- spec/utilities/flows/os/command_runner_spec.rb
-- spec/utilities/flows/os/cron_spec.rb
-- spec/utilities/flows/os/launchd_spec.rb
-- spec/utilities/flows/os/linux_spec.rb
-- spec/utilities/flows/os/systemd_spec.rb
-- spec/utilities/flows/os/task_scheduler_spec.rb
-- spec/utilities/flows/project_spec.rb
-- spec/utilities/flows/run_log_spec.rb
-- spec/utilities/flows/runner_spec.rb
-- spec/utilities/flows/schedule_spec.rb
-- spec/utilities/flows/schedule_store_spec.rb
-- spec/utilities/flows/scheduler_spec.rb
 - spec/utilities/headless_config_spec.rb
+- spec/utilities/schedules/kind_spec.rb
+- spec/utilities/schedules/legacy_spec.rb
+- spec/utilities/schedules/legacy_stub_spec.rb
+- spec/utilities/schedules/next_run_spec.rb
+- spec/utilities/schedules/notifier_spec.rb
+- spec/utilities/schedules/os/command_runner_spec.rb
+- spec/utilities/schedules/os/cron_spec.rb
+- spec/utilities/schedules/os/launchd_spec.rb
+- spec/utilities/schedules/os/linux_spec.rb
+- spec/utilities/schedules/os/list_ids_spec.rb
+- spec/utilities/schedules/os/systemd_spec.rb
+- spec/utilities/schedules/os/task_scheduler_spec.rb
+- spec/utilities/schedules/os_entry_spec.rb
+- spec/utilities/schedules/os_enumerator_spec.rb
+- spec/utilities/schedules/project_spec.rb
+- spec/utilities/schedules/run_lock_spec.rb
+- spec/utilities/schedules/run_log_spec.rb
+- spec/utilities/schedules/run_report_spec.rb
+- spec/utilities/schedules/run_wrapper_integration_spec.rb
+- spec/utilities/schedules/run_wrapper_spec.rb
+- spec/utilities/schedules/schedule_spec.rb
+- spec/utilities/schedules/schedule_store_spec.rb
+- spec/utilities/schedules/scheduler_launchd_spec.rb
+- spec/utilities/schedules/scheduler_spec.rb
+- spec/utilities/schedules/selection_spec.rb
+- spec/utilities/schedules/spawn_spec.rb
 - spec/utilities/trace_command_spec.rb
 - spec/utilities/utilities_spec.rb
 - spec/utilities/video_command_spec.rb

data/lib/commands/flow_commands.rb

@@ -1,104 +0,0 @@
-# frozen_string_literal: true
-
-require 'thor'
-require 'json'
-require_relative '../utilities/flows/runner'
-require_relative '../utilities/flows/scheduler'
-
-# raider flow: recordings without assertions that run on their own.
-class FlowCommands < Thor
-  def self.exit_on_failure? = true
-
-  class_option :project, type: :string, desc: 'The project folder (default: the current folder)'
-
-  desc 'init', 'Adds flows/flow_helper.rb and the .gitignore lines to a Selenium web project'
-
-  def init
-    code = project.init
-    exit(code) unless code.zero?
-  rescue RubyRaider::Flows::Error => e
-    stop(e)
-  end
-
-  # `run` is a Thor reserved word, so the method has another name
-  desc 'run NAME', 'Runs flows/NAME_flow.rb headless with its own results folder and run log'
-  option :headed, type: :boolean, desc: 'Show the browser'
-  option :retries, type: :numeric, default: 0, desc: 'Re-run the whole flow up to N times (0-3), 30 s apart'
-  option :input, type: :array, desc: 'Flow inputs as name=value (read with flow_input)'
-  option :trigger, type: :string, default: 'manual', desc: 'manual, schedule or desktop'
-  option :notify, type: :boolean, desc: 'Show a desktop notification when the flow fails'
-
-  def run_flow(name)
-    runner = RubyRaider::Flows::Runner.new(project)
-    exit(runner.run(name, headed: options[:headed], retries: options[:retries], inputs: options[:input],
-                          trigger: options[:trigger], notify: options[:notify] || false))
-  rescue RubyRaider::Flows::Error => e
-    stop(e)
-  end
-
-  map 'run' => :run_flow
-
-  desc 'list', 'Lists the flows with their last result'
-  option :json, type: :boolean, desc: 'Print JSON for the desktop app'
-
-  def list
-    summaries = RubyRaider::Flows::RunLog.summaries(project)
-    return puts(JSON.generate(summaries)) if options[:json]
-    return puts('No flows yet: write one in flows/<name>_flow.rb') if summaries.empty?
-
-    summaries.each { |flow| puts(list_line(flow)) }
-  rescue RubyRaider::Flows::Error => e
-    stop(e)
-  end
-
-  desc 'schedule NAME', 'Runs a flow on a schedule with the OS scheduler'
-  option :every, type: :string, desc: 'hour, day, weekday or week'
-  option :at, type: :string, desc: 'HH:MM (24h, local time); for every hour :MM'
-  option :on, type: :string, desc: 'mon to sun, for every week'
-  option :retries, type: :numeric, default: 0, desc: 'Re-run the whole flow up to N times (0-3)'
-  option :input, type: :array, desc: 'Flow inputs as name=value'
-  option :notify, type: :boolean, desc: 'Show a desktop notification when a scheduled run fails'
-
-  def schedule(name)
-    scheduler.schedule(name, every: options[:every], at: options[:at], on: options[:on], retries: options[:retries],
-                             inputs: options[:input] || [], notify: options[:notify] || false)
-  rescue RubyRaider::Flows::Error => e
-    stop(e)
-  end
-
-  desc 'unschedule NAME', 'Removes the schedule of a flow'
-
-  def unschedule(name)
-    scheduler.unschedule(name)
-  rescue RubyRaider::Flows::Error => e
-    stop(e)
-  end
-
-  desc 'schedules', 'Lists the scheduled flows with their next run and last result'
-  option :json, type: :boolean, desc: 'Print JSON for the desktop app'
-
-  def schedules
-    scheduler.schedules(json: options[:json] || false)
-  rescue RubyRaider::Flows::Error => e
-    stop(e)
-  end
-
-  no_commands do
-    def project
-      RubyRaider::Flows::Project.new(options[:project] || Dir.pwd)
-    end
-
-    def scheduler = RubyRaider::Flows::Scheduler.new(project)
-
-    def list_line(flow)
-      last = flow['last']
-      result = last ? RubyRaider::Flows.printable("#{last['status']}  #{last['finished_at']}") : 'never run'
-      "#{flow['name'].ljust(30)}  #{result}"
-    end
-
-    def stop(error)
-      warn(error.message)
-      exit(error.exit_code)
-    end
-  end
-end

data/lib/generators/templates/flows/flow_helper.tt

@@ -1,42 +0,0 @@
-# frozen_string_literal: true
-
-# Every flow (flows/<name>_flow.rb) requires this file. A flow is an RSpec file without assertions:
-# it completes when every step ran. Run one with `raider flow run <name>`, or `bundle exec rspec flows/<name>_flow.rb`.
-# Generated by `raider flow init`.
-
-require_relative 'support/run'
-
-# Before the driver starts: take the flow's lock, pick its results folder, load .raider/flows/env, go headless.
-# The report goes to this run's folder even when start! refuses the run, so a flow never cleans raider-results.
-begin
-  RaiderFlows::Run.start!
-ensure
-  RaiderFlows::Run.configure_reporter
-end
-
-require_relative '../helpers/spec_helper'
-
-# Helpers available inside a flow.
-module FlowHelper
-  # A value passed with `raider flow run <name> --input name=value`, or the recorded default.
-  def flow_input(name, default = nil)
-    key = name.to_s
-    raise ArgumentError, "invalid flow input name #{key.inspect}" unless RaiderFlows::Run::INPUT.match?(key)
-
-    ENV.fetch("RAIDER_INPUT_#{key.upcase}", default)
-  end
-end
-
-# Again now that spec_helper is surely loaded
-RaiderFlows::Run.configure_reporter
-
-RSpec.configure do |config|
-  config.include(FlowHelper)
-  # Flows don't touch spec/examples.txt, so `rspec --only-failures` stays about tests
-  config.example_status_persistence_file_path = nil
-  # A flow is not idempotent mid-way: never re-run it from step 1 inside one run (raider flow run --retries re-runs it whole)
-  config.default_retry_count = 0 if config.respond_to?(:default_retry_count=)
-  config.define_derived_metadata(file_path: %r{/flows/[^/]+_flow\.rb\z}) { |metadata| metadata[:flow] = true }
-  # Runs after spec_helper's hooks started the browser: a failure before this is a setup error, not a step
-  config.append_before(:each) { RaiderFlows::Run.steps_started! }
-end