ruby_raider 3.12.0 → 3.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3dd26171963a22a6a95ac06de57c7baf3e462a8d0d71049b88b99d40552c94c0
-  data.tar.gz: 9826176205e621abddb2ddd583aa3bdee28eacd3c5e7d00a606bda9b2ba443e1
+  metadata.gz: e1312bb43aceb9be9a70d5e3d09e6694d901f6b5dc3ec80f27b6973de6c8d60c
+  data.tar.gz: ad4e86e9f7dd6bbbacac033fe48f18a93d6397040ab29490d0add8456f6ad2cc
 SHA512:
-  metadata.gz: 3f0b129f291c538614a488c47f3ce71971f24060b60719203df43a2a19cc82309141cc846c867b644bb54832e9bbee2390fee04c2bb1db7bcec0c1f200d3eecb
-  data.tar.gz: 2d5e307edb7b5fdc1fbb0f1c0a1c830c6489fd8c7a11b3c08827fb3df9c49e7f1e23493a9165f23a5b2cbd7cd465913486fe174c79b7668731b7e5c7359e3e49
+  metadata.gz: b913021e191c5ff9fddc114590bc7b6a4a1b0e340a0fb2257da5477c2e3344dcd73088ea1cbac4eb1b28953b7bc3c250d56c648f15e85977088b8d96d3ddbc2b
+  data.tar.gz: c1d12da3f4447bbabecc6638895129dc0dd9d23dc08389a8b9d6ee9077c3936855b28746b9a6d9d049b3ced2c2e296462154c88e1845d6357078bb41ab8f75f6

data/.ruby-version

@@ -1 +1 @@
-3.4.1
+3.4.12

data/lib/generators/automation/templates/page.tt

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 <%- if web? && examples? -%>
 require_relative '../components/header'
 <%- end -%>
@@ -12,9 +14,12 @@ class Page
 <%- if wait_helper? -%>
   include WaitHelper
 <%- end -%>
-<%=- partial('initialize_selector', trim: false) -%>
-<%=- partial('visit_method', trim: false) -%>
-<%=- partial('url_methods', trim: false) -%>
+<%- if cross_platform? || wait_helper? -%>
+
+<%- end -%>
+<%= partial('initialize_selector') -%>
+<%= partial('visit_method') -%>
+<%= partial('url_methods') -%>
 
   def to_s
     self.class.to_s.sub('Page', ' Page')

data/lib/generators/automation/templates/partials/initialize_selector.tt

@@ -1,13 +1,13 @@
-<% if watir? %>
+<%- if watir? -%>
   attr_reader :browser
 
   def initialize(browser)
     @browser = browser
   end
-<% else %>
+<%- else -%>
   attr_reader :driver
 
   def initialize(driver)
     @driver = driver
   end
-<% end %>
+<%- end -%>

data/lib/generators/automation/templates/partials/url_methods.tt

@@ -1,4 +1,5 @@
-<% if web? %>
+<%- if web? -%>
+
   def full_url(*page)
     "#{base_url}#{url(*page)}"
   end
@@ -10,4 +11,4 @@
   def url(_page)
     raise 'Url must be defined on child pages'
   end
-<% end %>
+<%- end -%>

data/lib/generators/automation/templates/partials/visit_method.tt

@@ -1,11 +1,11 @@
-<% if web? %>
-<% if selenium_based? %>
+<%- if selenium_based? -%>
+
   def visit(*page)
     @driver.navigate.to full_url(page.first)
   end
-<% else %>
+<%- elsif watir? -%>
+
   def visit(*page)
     @browser.goto full_url(page.first)
   end
-<% end %>
-<% end %>
+<%- end -%>

data/lib/generators/cucumber/cucumber_generator.rb

@@ -53,6 +53,6 @@ class CucumberGenerator < Generator
   end
 
   def template_name
-    @template_name ||= (@_initializer.first & %w[android ios cross_platform]).empty? ? 'login' : 'home'
+    @template_name ||= mobile? ? 'home' : 'login'
   end
 end

data/lib/generators/cucumber/templates/env.tt

@@ -1,7 +1,7 @@
 <%- if selenium_based? -%>
-  <%= partial('selenium_env') -%>
+<%= partial('selenium_env') -%>
 <%- elsif mobile? -%>
-  <%= partial('appium_env') -%>
+<%= partial('appium_env') -%>
 <%- else -%>
-  <%= partial('watir_env') -%>
+<%= partial('watir_env') -%>
 <%- end -%>

data/lib/generators/cucumber/templates/steps.tt

@@ -1,5 +1,5 @@
 <%- if web? -%>
-<%= partial('web_steps', strip: true) -%>
+<%= partial('web_steps', strip: true) %>
 <%- else -%>
-<%= partial('mobile_steps', strip: true) -%>
+<%= partial('mobile_steps', strip: true) %>
 <%- end -%>

data/lib/generators/cucumber/templates/user_factory.tt

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'model_factory'
 
 class UserFactory < ModelFactory

data/lib/generators/cucumber/templates/world.tt

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 <%- if watir? -%>
-<%=- partial('watir_world', strip: true) -%>
+<%= partial('watir_world', strip: true) %>
 <%- else -%>
-<%=- partial('driver_world', strip: true) -%>
-<%- end -%>
+<%= partial('driver_world', strip: true) %>
+<%- end -%>

data/lib/generators/generator.rb

@@ -23,37 +23,36 @@ class Generator < Thor::Group
   end
 
   def cucumber?
-    args.include?('cucumber')
+    framework == 'cucumber'
   end
 
   # The framework is cross platform when it supports Android and iOS
   def cross_platform?
-    args.include?('cross_platform')
+    automation == 'cross_platform'
   end
 
   def mobile?
-    (args & %w[android ios cross_platform]).count.positive?
+    %w[android ios cross_platform].include?(automation)
   end
 
   def single_platform?
-    (args & %w[android ios]).count.positive?
+    %w[android ios].include?(automation)
   end
 
   def ios?
-    args.include?('ios')
+    automation == 'ios'
   end
 
   def android?
-    args.include?('android')
+    automation == 'android'
   end
 
   def rspec?
-    args.include?('rspec')
+    framework == 'rspec'
   end
 
-  # Only the options after automation, framework and name, so a project named "azure" is not Azure CI
   def azure?
-    args.drop(3).include?('azure')
+    options_after_name.include?('azure')
   end
 
   def github_ci?
@@ -76,7 +75,7 @@ class Generator < Thor::Group
 
   # False for `raider new -p examples:false`: an empty skeleton without the example pages, tests and wiring
   def examples?
-    !args.drop(3).include?('no_examples')
+    !options_after_name.include?('no_examples')
   end
 
   def web?
@@ -84,7 +83,7 @@ class Generator < Thor::Group
   end
 
   def axe_addon?
-    args.include?('axe_addon')
+    options_after_name.include?('axe_addon')
   end
 
   def selenium_based?
@@ -98,6 +97,11 @@ class Generator < Thor::Group
 
   private
 
+  # Option flags only: everything after automation, framework and name
+  def options_after_name
+    args.drop(3)
+  end
+
   def _initializer
     @_initializer ||= super
   end

data/lib/generators/rspec/templates/accessibility_spec.tt

@@ -4,18 +4,18 @@ require_relative '../helpers/spec_helper'
 
 describe 'Accessibility' do
   before do
-    <% if watir? -%>
-browser.goto 'https://raider-test-site.onrender.com/'
-    <% else -%>
-driver.get 'https://raider-test-site.onrender.com/'
-    <% end -%>
+<%- if watir? -%>
+    browser.goto 'https://raider-test-site.onrender.com/'
+<%- else -%>
+    driver.get 'https://raider-test-site.onrender.com/'
+<%- end -%>
   end
 
   it 'has no accessibility violations on the page' do
-    <% if watir? -%>
-expect(browser.driver).to be_axe_clean
-    <% else -%>
-expect(driver).to be_axe_clean
-    <% end -%>
+<%- if watir? -%>
+    expect(browser.driver).to be_axe_clean
+<%- else -%>
+    expect(driver).to be_axe_clean
+<%- end -%>
   end
 end

data/lib/generators/rspec/templates/spec.tt

@@ -63,6 +63,8 @@ describe 'Account', :logged_in do
 end
 # rubocop:enable RSpec/MultipleDescribes
 <%- else -%>
+# frozen_string_literal: true
+
 <% if cross_platform? -%>
 require_relative '../helpers/appium_helper'
 <%- end -%>
@@ -72,7 +74,6 @@ require_relative '../page_objects/pages/pdp'
 
 class PdpSpec
   describe 'PDP' do
-
     let(:home_page) { Home.new(driver) }
     let(:pdp_page) { Pdp.new(driver) }
 

data/lib/generators/templates/common/gemfile.tt

@@ -1,32 +1,32 @@
 source 'https://rubygems.org'
 
 gem 'activesupport'
-<% if mobile? %>
-gem 'appium_lib'
+<%- if mobile? -%>
 gem 'appium_console'
-<% end %>
+gem 'appium_lib'
+<%- end -%>
 <%- if axe_addon? -%>
 gem 'axe-core-rspec'
 gem 'axe-core-selenium'
 <%- end -%>
+<%- if cucumber? -%>
+gem 'cucumber'
+<%- end -%>
 gem 'parallel_split_test'
 gem 'parallel_tests'
+gem 'raider_reporter', '~> 0.10'
 gem 'rake'
 gem 'reek'
-gem 'raider_reporter', '~> 0.10'
+gem 'rspec'
 <%- if rspec? -%>
 gem 'rspec-retry'
 <%- end -%>
-gem '<%= framework %>'
-<%- if cucumber? -%>
-gem 'rspec'
-<%- end -%>
 gem 'rubocop'
 <%- if rspec? -%>
 gem 'rubocop-rspec'
 <%- end -%>
 gem 'ruby_raider', '<%= ruby_raider_version_requirement %>'
-<%- if selenium_based? %>
+<%- if selenium_based? -%>
 gem 'selenium-webdriver'
 <%- end -%>
 <%- if watir? -%>

data/lib/generators/templates/helpers/appium_helper.tt

@@ -1,27 +1,29 @@
+# frozen_string_literal: true
+
 module AppiumHelper
   def element(opts = {})
-     return driver.find_element(strategy(opts) => selector(opts)) if opts[os]
+    return driver.find_element(strategy(opts) => selector(opts)) if opts[os]
 
-     driver.find_element(opts)
+    driver.find_element(opts)
   end
 
   def elements(opts = {})
-     return driver.find_elements(strategy(opts) => selector(opts)) if opts[os]
+    return driver.find_elements(strategy(opts) => selector(opts)) if opts[os]
 
-     driver.find_elements(opts)
-   end
+    driver.find_elements(opts)
+  end
 
- def os
-   driver.appium_device
- end
+  def os
+    driver.appium_device
+  end
 
- private
+  private
 
- def strategy(opts)
-   opts[os].keys.first
- end
+  def strategy(opts)
+    opts[os].keys.first
+  end
 
- def selector(opts)
-   opts[os][strategy(opts)]
- end
+  def selector(opts)
+    opts[os][strategy(opts)]
+  end
 end

data/lib/generators/templates/helpers/browser_helper.tt

@@ -6,7 +6,6 @@ require 'watir'
 require_relative 'video_helper'
 
 module BrowserHelper
-
   def browser(*args)
     @browser ||= create_browser(*args)
   end
@@ -23,7 +22,7 @@ module BrowserHelper
     args = args.empty? ? config['browser_arguments'][browser_name] : args
     args += ['--headless'] if (ENV['HEADLESS'] || config['headless']) && !args.include?('--headless')
     capitalized = browser_name == 'ie' ? browser_name.upcase : browser_name.capitalize
-    browser_options = "Selenium::WebDriver::#{capitalized}::Options".constantize.new(args:)
+    browser_options = "Selenium::WebDriver::#{capitalized}::Options".constantize.new(args: args)
     arguments = { options: browser_options }
     listener = VideoHelper.listener
     arguments[:listener] = listener if listener

data/lib/generators/templates/helpers/partials/appium_driver.tt

@@ -32,7 +32,7 @@
   end
 <%- end -%>
 
-<%= partial('browserstack_config', strip: true) %>
+  <%= partial('browserstack_config', strip: true) %>
 
   def configure_driver
     if browserstack?

data/lib/generators/templates/helpers/session_state.tt

@@ -17,7 +17,7 @@ require 'yaml'
 class SessionState
   FORMAT = 1
   DEFAULT_MAX_AGE = 3600
-  NAME_PATTERN = /\A[a-z0-9_-]+\z/.freeze
+  NAME_PATTERN = Regexp.new('\A[a-z0-9_-]+\z').freeze
   DIR = File.join('.raider', 'auth')
   READ_STORAGE = 'return Object.assign({}, window[arguments[0]]);'
   WRITE_STORAGE = 'var s = window[arguments[0]]; s.clear(); var d = arguments[1]; ' \

data/lib/generators/templates/helpers/spec_helper.tt

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-<%- if axe_addon? %>
+<%- if axe_addon? -%>
 require 'axe-rspec'
 <%- end -%>
 require 'rspec'

data/lib/ruby_raider.rb

@@ -52,12 +52,19 @@ module RubyRaider
     map 'u' => 'utility'
 
     no_tasks do
-      # -p values arrive as strings; only examples:false turns the example tests off
+      # -p values arrive as strings; examples must be true or false, in any case
       def generate_from_parameters(params)
-        params[:examples] = params[:examples].to_s.downcase != 'false' if params.key?(:examples)
+        params[:examples] = parse_examples(params[:examples]) if params.key?(:examples)
         InvokeGenerators.generate_framework(params)
       end
 
+      def parse_examples(value)
+        normalised = value.to_s.downcase
+        return normalised == 'true' if %w[true false].include?(normalised)
+
+        raise Thor::Error, "Invalid examples #{value.to_s.inspect}. Allowed values: true, false"
+      end
+
       def merge_flags(params)
         params[:accessibility] = true if options[:accessibility]
       end

data/lib/version

@@ -1 +1 @@
-3.12.0
+3.12.1

data/sig/generators/generator.rbs

@@ -29,5 +29,7 @@ class Generator < Thor::Group
 
   private
 
+  def options_after_name: () -> Array[untyped]
+
   def _initializer: () -> Array[untyped]
 end

data/sig/ruby_raider.rbs

@@ -8,6 +8,7 @@ module RubyRaider
 
     private
 
+    def parse_examples: (untyped value) -> bool
     def generate_from_parameters: (Hash[Symbol, untyped] params) -> void
     def merge_flags: (Hash[Symbol, untyped] params) -> void
   end

data/spec/commands/raider_commands_spec.rb

@@ -33,7 +33,31 @@ RSpec.describe RubyRaider::Raider do # rubocop:disable RSpec/FilePath
         expect(InvokeGenerators).to have_received(:generate_framework).with(hash_excluding(:examples))
       end
 
-      it 'keeps the examples for any value other than false' do
+      it 'accepts examples:FALSE in any case as false' do
+        allow(InvokeGenerators).to receive(:generate_framework)
+
+        described_class.new.invoke(:new, nil, %w[my_project -p framework:rspec automation:selenium examples:FALSE])
+
+        expect(InvokeGenerators).to have_received(:generate_framework).with(hash_including(examples: false))
+      end
+
+      it 'accepts examples:True in any case as true' do
+        allow(InvokeGenerators).to receive(:generate_framework)
+
+        described_class.new.invoke(:new, nil, %w[my_project -p framework:rspec automation:selenium examples:True])
+
+        expect(InvokeGenerators).to have_received(:generate_framework).with(hash_including(examples: true))
+      end
+
+      it 'rejects any other examples value before generating' do
+        allow(InvokeGenerators).to receive(:generate_framework)
+
+        expect { described_class.new.invoke(:new, nil, %w[my_project -p framework:rspec automation:selenium examples:no]) }
+          .to raise_error(Thor::Error, 'Invalid examples "no". Allowed values: true, false')
+        expect(InvokeGenerators).not_to have_received(:generate_framework)
+      end
+
+      it 'keeps the examples for true' do
         allow(InvokeGenerators).to receive(:generate_framework)
 
         described_class.new.invoke(:new, nil, %w[my_project -p framework:rspec automation:selenium examples:true])

data/spec/fixtures/watir_master/cucumber_watir/features/step_definitions/login_steps.rb.snapshot

@@ -21,4 +21,4 @@ Then("I'm logged in") do
   account_page = Account.new(browser)
   account_page.visit
   expect(account_page.header.customer_name).to eq "Welcome back #{@user['name']}"
-end
+end

data/spec/fixtures/watir_master/cucumber_watir/page_objects/abstract/page.rb.snapshot

@@ -1,20 +1,18 @@
+# frozen_string_literal: true
+
 require_relative '../components/header'
 
 class Page
-
   attr_reader :browser
 
   def initialize(browser)
     @browser = browser
   end
 
-
   def visit(*page)
     @browser.goto full_url(page.first)
   end
 
-
-
   def full_url(*page)
     "#{base_url}#{url(*page)}"
   end

data/spec/fixtures/watir_master/rspec_watir/page_objects/abstract/page.rb.snapshot

@@ -1,20 +1,18 @@
+# frozen_string_literal: true
+
 require_relative '../components/header'
 
 class Page
-
   attr_reader :browser
 
   def initialize(browser)
     @browser = browser
   end
 
-
   def visit(*page)
     @browser.goto full_url(page.first)
   end
 
-
-
   def full_url(*page)
     "#{base_url}#{url(*page)}"
   end

data/spec/integration/content/content_helper.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative '../spec_helper'
+require_relative '../frozen_string_literal_matcher'
 
 module ContentHelper
   def read_generated(project, relative_path)
@@ -12,11 +13,6 @@ module ContentHelper
   end
 end
 
-RSpec::Matchers.define :have_frozen_string_literal do
-  match { |content| content.include?('# frozen_string_literal: true') }
-  failure_message { 'expected file to contain frozen_string_literal magic comment' }
-end
-
 RSpec::Matchers.define :have_valid_ruby_syntax do
   match do |content|
     RubyVM::InstructionSequence.compile(content)

data/spec/integration/content/rubocop_content_spec.rb

@@ -0,0 +1,87 @@
+# frozen_string_literal: true
+
+require 'json'
+require 'rubocop'
+require 'stringio'
+require 'tmpdir'
+require_relative 'content_helper'
+
+RUBOCOP_WEB_AUTOMATIONS = %w[selenium watir].freeze
+
+# Every generated project must pass the RuboCop it ships: its own .rubocop.yml, run in-process with
+# this gem's bundle. The project is linted from a copy outside this repo, so RuboCop resolves the
+# target Ruby the way a user's fresh project does (no TargetRubyVersion, so its 2.7 default) instead
+# of picking up this repo's .ruby-version or gemspec. The end-to-end spec repeats the check with the
+# project's own resolved gems.
+describe 'Generated projects pass their own RuboCop' do
+  def rubocop_report(project_name)
+    Dir.mktmpdir('raider_rubocop') do |tmp|
+      dir = File.join(tmp, File.basename(project_name))
+      FileUtils.cp_r(project_name, dir)
+      with_project_root(dir) { yield lint(dir), target_ruby(dir) }
+    end
+  end
+
+  def with_project_root(dir)
+    RuboCop::ConfigFinder.project_root = dir
+    yield
+  ensure
+    RuboCop::ConfigFinder.project_root = nil
+  end
+
+  def target_ruby(dir)
+    RuboCop::TargetRuby.new(RuboCop::ConfigLoader.configuration_from_file(File.join(dir, '.rubocop.yml'))).version
+  end
+
+  def lint(dir)
+    report, exit_code = capture_rubocop_json(['--config', File.join(dir, '.rubocop.yml'), '--cache', 'false',
+                                              '--format', 'json', dir])
+    offenses = report.fetch('files').flat_map do |file|
+      path = file.fetch('path').delete_prefix("#{dir}/")
+      file.fetch('offenses').map do |offense|
+        "#{path}:#{offense.dig('location', 'line')}: #{offense.fetch('cop_name')}: #{offense.fetch('message')}"
+      end
+    end
+    { offenses: offenses, inspected: report.fetch('summary').fetch('inspected_file_count'), exit_code: exit_code }
+  end
+
+  def capture_rubocop_json(args)
+    original = $stdout
+    $stdout = StringIO.new
+    exit_code = RuboCop::CLI.new.run(args)
+    [JSON.parse($stdout.string), exit_code]
+  ensure
+    $stdout = original
+  end
+
+  def expect_no_offenses(project_name)
+    expect(File).to exist(File.join(project_name, '.rubocop.yml'))
+    rubocop_report(project_name) do |summary, target|
+      offenses = summary.fetch(:offenses)
+      expect(target).to eq(RuboCop::TargetRuby::DEFAULT_VERSION)
+      expect(summary.fetch(:inspected)).to be_positive, "#{project_name}: RuboCop inspected no files"
+      expect(offenses).to be_empty, "#{project_name} has #{offenses.size} RuboCop offenses:\n#{offenses.join("\n")}"
+      expect(summary.fetch(:exit_code)).to eq(0)
+    end
+  end
+
+  FRAMEWORKS.each do |framework|
+    AUTOMATION_TYPES.each do |automation|
+      { 'with examples' => true, 'without examples' => false }.each do |label, examples|
+        it "has no offenses for #{framework} and #{automation} (#{label})" do
+          expect_no_offenses(ensure_project(framework:, automation:, examples:))
+        end
+      end
+    end
+
+    RUBOCOP_WEB_AUTOMATIONS.each do |automation|
+      it "has no offenses for #{framework} and #{automation} with accessibility" do
+        name = "rubocop_axe_#{framework}_#{automation}"
+        InvokeGenerators.generate_framework(automation:, framework:, name:, accessibility: true)
+        expect_no_offenses(name)
+      ensure
+        FileUtils.rm_rf(name)
+      end
+    end
+  end
+end

data/spec/integration/content/syntax_validation_spec.rb

@@ -2,66 +2,46 @@
 
 require_relative 'content_helper'
 
-SYNTAX_WEB_AUTOMATIONS = %w[selenium watir].freeze
-SYNTAX_ALL_FRAMEWORKS = %w[cucumber rspec].freeze
+SYNTAX_MOBILE_AUTOMATIONS = %w[android ios cross_platform].freeze
 
+# Projects are generated by spec_helper's before(:all), so the file list is read inside the
+# examples (after generation), never when this file loads.
 describe 'Ruby syntax validation' do
-  SYNTAX_ALL_FRAMEWORKS.each do |framework|
-    SYNTAX_WEB_AUTOMATIONS.each do |automation|
-      context "with #{framework} and #{automation}" do
-        project_name = "#{framework}_#{automation}"
-
-        Dir.glob("#{project_name}/**/*.rb").each do |file|
-          relative = file.sub("#{project_name}/", '')
-
-          it "#{relative} has valid Ruby syntax" do
-            content = File.read(file)
-            expect(content).to have_valid_ruby_syntax
-          end
-
-          it "#{relative} has frozen_string_literal" do
-            content = File.read(file)
-            expect(content).to have_frozen_string_literal
-          end
-        end
+  def generated_ruby_files(project_name)
+    Dir.glob('**/*.rb', base: project_name).sort
+  end
 
-        login_reuse_files = %w[helpers/session_state.rb]
-        login_reuse_files += if framework == 'rspec'
-                               %w[helpers/spec_helper.rb]
-                             else
-                               %w[features/support/env.rb features/step_definitions/login_steps.rb]
-                             end
-        # The glob above runs at load time, before the projects exist, so new helpers are listed here.
-        login_reuse_files += %w[helpers/wait_helper.rb helpers/raider_element.rb] if automation == 'selenium'
+  def syntax_error_for(content)
+    RubyVM::InstructionSequence.compile(content)
+    nil
+  rescue SyntaxError => e
+    e.message
+  end
 
-        login_reuse_files.each do |relative|
-          it "#{relative} is generated as valid Ruby with frozen_string_literal" do
-            content = File.read(File.join(project_name, relative))
-            expect(content).to have_valid_ruby_syntax
-            expect(content).to have_frozen_string_literal
+  FRAMEWORKS.each do |framework|
+    AUTOMATION_TYPES.each do |automation|
+      { 'with examples' => true, 'without examples' => false }.each do |label, examples|
+        it "generates only valid Ruby with frozen_string_literal for #{framework} and #{automation} (#{label})" do
+          project_name = ensure_project(framework:, automation:, examples:)
+          files = generated_ruby_files(project_name)
+
+          expect(files).not_to be_empty
+          aggregate_failures do
+            files.each do |relative|
+              content = File.read(File.join(project_name, relative))
+              expect(syntax_error_for(content)).to be_nil, "#{project_name}/#{relative} has a syntax error"
+              expect(content).to have_frozen_string_literal, "#{project_name}/#{relative} lacks frozen_string_literal"
+            end
           end
         end
       end
     end
 
-    # Mobile projects get the mobile branch of the wait helper templates.
-    %w[android ios cross_platform].each do |automation|
-      context "with #{framework} and #{automation}" do
-        project_name = "#{framework}_#{automation}"
-
-        %w[helpers/wait_helper.rb helpers/raider_element.rb].each do |relative|
-          it "#{relative} is generated as valid Ruby with frozen_string_literal" do
-            content = File.read(File.join(project_name, relative))
-            expect(content).to have_valid_ruby_syntax
-            expect(content).to have_frozen_string_literal
-          end
-        end
-
-        it 'helpers/wait_helper.rb has the mobile gestures and no web-only methods' do
-          content = File.read(File.join(project_name, 'helpers/wait_helper.rb'))
-          expect(content).to include("'mobile: swipeGesture'").and include('def scroll_to(')
-          expect(content).not_to include('def drag_and_drop(')
-        end
+    SYNTAX_MOBILE_AUTOMATIONS.each do |automation|
+      it "#{framework}_#{automation} wait_helper has the mobile gestures and no web-only methods" do
+        content = File.read(File.join(ensure_project(framework:, automation:), 'helpers/wait_helper.rb'))
+        expect(content).to include("'mobile: swipeGesture'").and include('def scroll_to(')
+        expect(content).not_to include('def drag_and_drop(')
       end
     end
   end

data/spec/integration/content/test_content_spec.rb

@@ -212,10 +212,13 @@ describe 'Example tests on the wait helper' do
   end
 end
 
-# The Watir output must stay as master generated it (1274a66); the snapshots in
+# The Watir output must stay as master generated it (1274a66), plus the 3.12.1 lint fixes; the snapshots in
 # spec/fixtures/watir_master were generated from that commit's lib.
 # To regenerate: `git archive 1274a66 lib` into a scratch dir, generate rspec and cucumber Watir projects there,
-# then apply only the Readme deprecation-line delta (the `> **Deprecated:**` line under the heading block).
+# then apply only the Readme deprecation-line delta (the `> **Deprecated:**` line under the heading block) and
+# the 3.12.1 changes: RuboCop lint fixes (page.rb loses its extra blank lines, login_steps.rb ends with a newline)
+# plus the frozen_string_literal comments the syntax spec requires (Style/FrozenStringLiteralComment is disabled
+# in the generated .rubocop.yml, so RuboCop does not ask for them) on the Watir page, world and user_factory files.
 describe 'Watir example output' do
   snapshots = File.expand_path('../../fixtures/watir_master', __dir__)
 

data/spec/integration/end_to_end_spec.rb

@@ -265,11 +265,30 @@ describe 'End-to-End Project Generation and Execution' do
     FileUtils.rm_f(File.join(project, 'features/step_definitions/reporter_failure_steps.rb'))
   end
 
+  # Runs the project's own RuboCop with the gems its bundle resolved (newer than this gem's dev bundle).
+  # It runs from a copy outside this repo, as a user's project would: inside it RuboCop would also read
+  # this repo's .rubocop.yml, gemspec and .ruby-version.
+  def expect_project_rubocop_clean(project)
+    skip 'Bundle install failed' unless bundle_install(project)
+
+    Dir.mktmpdir('raider_rubocop') do |tmp|
+      copy = File.join(tmp, project)
+      FileUtils.cp_r(project, copy)
+      puts run_in_project(copy, 'bundle exec rubocop -V', timeout: 60)[:stdout]
+      result = run_in_project(copy, 'bundle exec rubocop --cache false', timeout: 180)
+      expect(result[:exit_code]).to eq(0), "STDOUT: #{result[:stdout]}\nSTDERR: #{result[:stderr]}"
+    end
+  end
+
   # Test Web Frameworks (these can run without external services)
   context 'Web Automation Frameworks' do
     describe 'Selenium + RSpec' do
       include_examples 'executable rspec project', 'rspec_selenium'
 
+      it 'passes its own RuboCop with its bundled gems', :slow do
+        expect_project_rubocop_clean('rspec_selenium')
+      end
+
       it 'saves the login once and reuses it', :aggregate_failures, :slow do
         skip 'Bundle install failed' unless bundle_install('rspec_selenium')
 
@@ -300,6 +319,10 @@ describe 'End-to-End Project Generation and Execution' do
 
     describe 'Selenium + Cucumber' do
       include_examples 'executable cucumber project', 'cucumber_selenium'
+
+      it 'passes its own RuboCop with its bundled gems', :slow do
+        expect_project_rubocop_clean('cucumber_selenium')
+      end
     end
 
     describe 'Watir + Cucumber' do

data/spec/integration/frozen_string_literal_matcher.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'rspec/expectations'
+
+# Ruby only reads the magic comment in the comment block before the first line of code. Ruby would
+# accept it indented, but the generated project's RuboCop (Layout/CommentIndentation) would not.
+RSpec::Matchers.define :have_frozen_string_literal do
+  match do |content|
+    leading_comments = content.lines.take_while { |line| line.strip.empty? || line.start_with?('#') }
+    leading_comments.any? { |line| line.chomp == '# frozen_string_literal: true' }
+  end
+  failure_message { 'expected an unindented frozen_string_literal magic comment before the first line of code' }
+end

data/spec/integration/generators/invoke_generators_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'fileutils'
+require 'tmpdir'
 require 'open3'
 require_relative '../spec_helper'
 
@@ -120,3 +121,62 @@ describe 'Projects named like a generator option' do
     expect(File.read('selenium/page_objects/abstract/page.rb')).not_to include('find_element')
   end
 end
+
+describe 'Option-named projects generate what a neutral name generates' do
+  option_names = %w[ios android cucumber rspec cross_platform axe_addon selenium watir no_examples azure]
+  option_sets = [
+    { automation: 'selenium', framework: 'rspec' },
+    { automation: 'selenium', framework: 'cucumber', accessibility: true },
+    { automation: 'selenium', framework: 'rspec', examples: false, ci: 'azure' },
+    { automation: 'watir', framework: 'cucumber' },
+    { automation: 'ios', framework: 'rspec' },
+    { automation: 'android', framework: 'cucumber' },
+    { automation: 'cross_platform', framework: 'rspec' }
+  ].freeze
+
+  def quietly
+    result = nil
+    expect { result = yield }.to output.to_stdout
+    result
+  end
+
+  def snapshot(name, options)
+    Dir.mktmpdir do |dir|
+      Dir.chdir(dir) do
+        InvokeGenerators.generate_framework(options.merge(name:))
+        Dir.glob("#{name}/**/*", File::FNM_DOTMATCH).select { |f| File.file?(f) }
+           .to_h { |f| [f.delete_prefix("#{name}/"), File.read(f)] }
+      end
+    end
+  end
+
+  option_sets.each do |options|
+    context "with #{options}" do
+      let(:neutral) { quietly { snapshot('demo', options) } }
+
+      option_names.each do |name|
+        it "generates the same files for a project named #{name}" do
+          actual = quietly { snapshot(name, options) }
+          expect(actual.keys.sort).to eq(neutral.keys.sort)
+          expect(actual).to eq(neutral)
+        end
+      end
+    end
+  end
+end
+
+describe 'raider new -p examples: validation' do
+  after { FileUtils.rm_rf(%w[bad_examples]) }
+
+  let(:root) { File.expand_path('../../..', __dir__) }
+
+  it 'rejects an unknown value, names the allowed values and generates nothing' do
+    Dir.mktmpdir do |dir|
+      _out, err, status = Open3.capture3('ruby', "#{root}/bin/raider", 'new', 'x', '-p',
+                                         'framework:rspec', 'automation:selenium', 'examples:no', chdir: dir)
+      expect(status.exitstatus).to eq(1)
+      expect(err).to include('Invalid examples "no". Allowed values: true, false')
+      expect(File).not_to exist(File.join(dir, 'x'))
+    end
+  end
+end

data/spec/integration/scaffolding_e2e_spec.rb

@@ -4,13 +4,9 @@ require 'fileutils'
 require 'pathname'
 require_relative '../../lib/commands/scaffolding_commands'
 require_relative '../../lib/scaffolding/scaffolding'
+require_relative 'frozen_string_literal_matcher'
 
 # Custom matchers (defined inline to avoid pulling in integration spec_helper)
-RSpec::Matchers.define :have_frozen_string_literal do
-  match { |content| content.include?('# frozen_string_literal: true') }
-  failure_message { 'expected file to contain frozen_string_literal magic comment' }
-end
-
 RSpec::Matchers.define :have_valid_ruby_syntax do
   match do |content|
     RubyVM::InstructionSequence.compile(content)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby_raider
 version: !ruby/object:Gem::Version
-  version: 3.12.0
+  version: 3.12.1
 platform: ruby
 authors:
 - Agustin Pequeno
@@ -368,10 +368,12 @@ files:
 - spec/integration/content/page_content_spec.rb
 - spec/integration/content/readme_content_spec.rb
 - spec/integration/content/rspec_reporter_content_spec.rb
+- spec/integration/content/rubocop_content_spec.rb
 - spec/integration/content/syntax_validation_spec.rb
 - spec/integration/content/test_content_spec.rb
 - spec/integration/end_to_end_features_spec.rb
 - spec/integration/end_to_end_spec.rb
+- spec/integration/frozen_string_literal_matcher.rb
 - spec/integration/generators/automation_generator_spec.rb
 - spec/integration/generators/axe_addon_spec.rb
 - spec/integration/generators/azure_generator_spec.rb