ruby_raider 2.0.0 → 3.0.0

data/spec/scaffolding/name_normalizer_spec.rb

@@ -0,0 +1,113 @@
+# frozen_string_literal: true
+
+require_relative '../../lib/scaffolding/name_normalizer'
+
+RSpec.describe NameNormalizer do
+  describe '.normalize' do
+    it 'strips _page suffix' do
+      expect(described_class.normalize('login_page')).to eq('login')
+    end
+
+    it 'strips _spec suffix' do
+      expect(described_class.normalize('login_spec')).to eq('login')
+    end
+
+    it 'strips _steps suffix' do
+      expect(described_class.normalize('login_steps')).to eq('login')
+    end
+
+    it 'strips _helper suffix' do
+      expect(described_class.normalize('login_helper')).to eq('login')
+    end
+
+    it 'converts CamelCase to snake_case' do
+      expect(described_class.normalize('LoginPage')).to eq('login')
+    end
+
+    it 'handles CamelCase without suffix' do
+      expect(described_class.normalize('Dashboard')).to eq('dashboard')
+    end
+
+    it 'preserves nested paths' do
+      expect(described_class.normalize('admin/users')).to eq('admin/users')
+    end
+
+    it 'handles CamelCase nested paths' do
+      expect(described_class.normalize('Admin::UsersPage')).to eq('admin/users')
+    end
+
+    it 'leaves clean names unchanged' do
+      expect(described_class.normalize('login')).to eq('login')
+    end
+  end
+
+  describe '.to_class_name' do
+    it 'converts snake_case to CamelCase' do
+      expect(described_class.to_class_name('login')).to eq('Login')
+    end
+
+    it 'handles underscored names' do
+      expect(described_class.to_class_name('user_profile')).to eq('UserProfile')
+    end
+
+    it 'strips suffixes before converting' do
+      expect(described_class.to_class_name('login_page')).to eq('Login')
+    end
+
+    it 'handles nested names with modules' do
+      expect(described_class.to_class_name('admin/users')).to eq('Admin::Users')
+    end
+
+    it 'appends optional suffix' do
+      expect(described_class.to_class_name('login', 'Page')).to eq('LoginPage')
+    end
+  end
+
+  describe '.to_page_class' do
+    it 'converts to page class name' do
+      expect(described_class.to_page_class('login')).to eq('LoginPage')
+    end
+
+    it 'does not double the Page suffix' do
+      expect(described_class.to_page_class('login_page')).to eq('LoginPage')
+    end
+
+    it 'handles CamelCase input' do
+      expect(described_class.to_page_class('LoginPage')).to eq('LoginPage')
+    end
+  end
+
+  describe '.nested?' do
+    it 'returns true for nested paths' do
+      expect(described_class.nested?('admin/users')).to be true
+    end
+
+    it 'returns false for simple names' do
+      expect(described_class.nested?('login')).to be false
+    end
+  end
+
+  describe '.module_parts' do
+    it 'returns module path for nested names' do
+      expect(described_class.module_parts('admin/users')).to eq(['Admin'])
+    end
+
+    it 'returns empty for simple names' do
+      expect(described_class.module_parts('login')).to eq([])
+    end
+
+    it 'handles deep nesting' do
+      expect(described_class.module_parts('admin/settings/users')).to eq(%w[Admin Settings])
+    end
+  end
+
+  describe '.leaf_name' do
+    it 'returns last segment of nested path' do
+      expect(described_class.leaf_name('admin/users')).to eq('users')
+    end
+
+    it 'returns name itself for simple names' do
+      expect(described_class.leaf_name('login')).to eq('login')
+    end
+  end
+end

data/spec/scaffolding/page_introspector_spec.rb

@@ -0,0 +1,82 @@
+# frozen_string_literal: true
+
+require 'fileutils'
+require_relative '../../lib/scaffolding/page_introspector'
+
+RSpec.describe PageIntrospector do
+  subject(:introspector) { described_class.new(page_file) }
+
+  let(:tmp_dir) { 'tmp_introspector_test' }
+  let(:page_file) { "#{tmp_dir}/login_page.rb" }
+
+  before do
+    FileUtils.mkdir_p(tmp_dir)
+    File.write(page_file, <<~RUBY)
+      class LoginPage < Page
+        def url(_page)
+          '/login'
+        end
+
+        def login(username, password)
+          username_field.send_keys username
+          password_field.send_keys password
+          login_button.click
+        end
+
+        def welcome_message
+          driver.find_element(css: '.welcome').text
+        end
+
+        private
+
+        def username_field
+          driver.find_element(id: 'username')
+        end
+
+        def password_field
+          driver.find_element(id: 'password')
+        end
+
+        def login_button
+          driver.find_element(id: 'login-btn')
+        end
+      end
+    RUBY
+  end
+
+  after do
+    FileUtils.rm_rf(tmp_dir)
+  end
+
+  it 'extracts class name' do
+    expect(introspector.class_name).to eq('LoginPage')
+  end
+
+  it 'extracts public methods' do
+    method_names = introspector.methods.map { |m| m[:name] }
+    expect(method_names).to include('login')
+    expect(method_names).to include('welcome_message')
+  end
+
+  it 'skips url method' do
+    method_names = introspector.methods.map { |m| m[:name] }
+    expect(method_names).not_to include('url')
+  end
+
+  it 'skips private methods' do
+    method_names = introspector.methods.map { |m| m[:name] }
+    expect(method_names).not_to include('username_field')
+    expect(method_names).not_to include('password_field')
+    expect(method_names).not_to include('login_button')
+  end
+
+  it 'extracts method parameters' do
+    login_method = introspector.methods.find { |m| m[:name] == 'login' }
+    expect(login_method[:params]).to eq(%w[username password])
+  end
+
+  it 'handles methods with no parameters' do
+    welcome = introspector.methods.find { |m| m[:name] == 'welcome_message' }
+    expect(welcome[:params]).to eq([])
+  end
+end

data/spec/scaffolding/scaffold_project_detector_spec.rb

@@ -0,0 +1,104 @@
+# frozen_string_literal: true
+
+require 'fileutils'
+require_relative '../../lib/scaffolding/project_detector'
+
+RSpec.describe ScaffoldProjectDetector do
+  let(:tmp_dir) { 'tmp_project_detector_test' }
+
+  before do
+    FileUtils.mkdir_p(tmp_dir)
+    Dir.chdir(tmp_dir)
+  end
+
+  after do
+    Dir.chdir('..')
+    FileUtils.rm_rf(tmp_dir)
+  end
+
+  context 'with selenium project' do
+    before do
+      File.write('Gemfile', "gem 'rspec'\ngem 'selenium-webdriver'\n")
+      FileUtils.mkdir_p('spec')
+    end
+
+    it 'detects selenium automation' do
+      expect(described_class.detect_automation).to eq('selenium')
+    end
+
+    it 'detects rspec framework' do
+      expect(described_class.detect_framework).to eq('rspec')
+    end
+
+    it 'reports selenium?' do
+      expect(described_class.selenium?).to be true
+    end
+
+    it 'reports not capybara?' do
+      expect(described_class.capybara?).to be false
+    end
+  end
+
+  context 'with capybara project' do
+    before do
+      File.write('Gemfile', "gem 'capybara'\ngem 'cucumber'\n")
+      FileUtils.mkdir_p('features')
+    end
+
+    it 'detects capybara automation' do
+      expect(described_class.detect_automation).to eq('capybara')
+    end
+
+    it 'detects cucumber framework' do
+      expect(described_class.detect_framework).to eq('cucumber')
+    end
+
+    it 'reports capybara?' do
+      expect(described_class.capybara?).to be true
+    end
+  end
+
+  context 'with watir project' do
+    before do
+      File.write('Gemfile', "gem 'watir'\ngem 'minitest'\n")
+      FileUtils.mkdir_p('test')
+    end
+
+    it 'detects watir automation' do
+      expect(described_class.detect_automation).to eq('watir')
+    end
+
+    it 'detects minitest framework' do
+      expect(described_class.detect_framework).to eq('minitest')
+    end
+
+    it 'reports watir?' do
+      expect(described_class.watir?).to be true
+    end
+  end
+
+  context 'with no Gemfile' do
+    it 'defaults to selenium' do
+      expect(described_class.detect_automation).to eq('selenium')
+    end
+
+    it 'defaults to rspec' do
+      expect(described_class.detect_framework).to eq('rspec')
+    end
+  end
+
+  describe '.detect' do
+    before do
+      File.write('Gemfile', "gem 'selenium-webdriver'\ngem 'rspec'\n")
+      FileUtils.mkdir_p('spec')
+    end
+
+    it 'returns full detection hash' do
+      result = described_class.detect
+      expect(result[:automation]).to eq('selenium')
+      expect(result[:framework]).to eq('rspec')
+      expect(result[:has_spec]).to be true
+      expect(result[:has_features]).to be false
+    end
+  end
+end

data/spec/scaffolding/scaffolding_features_spec.rb

@@ -0,0 +1,311 @@
+# frozen_string_literal: true
+
+require 'fileutils'
+require 'pathname'
+require_relative '../../lib/commands/scaffolding_commands'
+require_relative '../../lib/scaffolding/scaffolding'
+
+RSpec.describe 'Scaffolding features' do
+  let(:scaffold) { ScaffoldingCommands }
+  let(:tmp_dir) { 'tmp_scaffold_features_test' }
+
+  before do
+    FileUtils.mkdir_p("#{tmp_dir}/page_objects/pages")
+    FileUtils.mkdir_p("#{tmp_dir}/page_objects/abstract")
+    FileUtils.mkdir_p("#{tmp_dir}/page_objects/components")
+    FileUtils.mkdir_p("#{tmp_dir}/spec")
+    FileUtils.mkdir_p("#{tmp_dir}/helpers")
+    FileUtils.mkdir_p("#{tmp_dir}/config")
+    FileUtils.mkdir_p("#{tmp_dir}/models/data")
+
+    File.write("#{tmp_dir}/Gemfile", "gem 'rspec'\ngem 'selenium-webdriver'\n")
+    File.write("#{tmp_dir}/config/config.yml", "browser: chrome\nurl: http://localhost:3000\n")
+    File.write("#{tmp_dir}/page_objects/abstract/page.rb", "class Page; end\n")
+    File.write("#{tmp_dir}/page_objects/abstract/component.rb", "class Component; end\n")
+
+    Dir.chdir(tmp_dir)
+  end
+
+  after do
+    Dir.chdir('..')
+    FileUtils.rm_rf(tmp_dir)
+  end
+
+  # --- Feature 7: Better name handling ---
+
+  describe 'name normalization' do
+    it 'strips _page suffix from page names' do
+      scaffold.new.invoke(:page, nil, %w[login_page])
+      expect(Pathname.new('page_objects/pages/login.rb')).to be_file
+    end
+
+    it 'handles CamelCase input' do
+      scaffold.new.invoke(:page, nil, %w[UserProfile])
+      expect(Pathname.new('page_objects/pages/user_profile.rb')).to be_file
+    end
+
+    it 'handles CamelCase with Page suffix' do
+      scaffold.new.invoke(:page, nil, %w[LoginPage])
+      expect(Pathname.new('page_objects/pages/login.rb')).to be_file
+    end
+  end
+
+  # --- Feature 6: Dry run ---
+
+  describe 'dry run' do
+    it 'does not create files with --dry-run' do
+      expect do
+        scaffold.new.invoke(:page, nil, %w[checkout --dry-run])
+      end.to output(/checkout/).to_stdout
+
+      expect(Pathname.new('page_objects/pages/checkout.rb')).not_to be_file
+    end
+
+    it 'shows planned file path' do
+      expect do
+        scaffold.new.invoke(:spec, nil, %w[checkout --dry-run])
+      end.to output(/checkout/).to_stdout
+    end
+  end
+
+  # --- Feature 8: Component scaffolding ---
+
+  describe 'component scaffolding' do
+    it 'creates a component file' do
+      scaffold.new.invoke(:component, nil, %w[sidebar])
+      expect(Pathname.new('page_objects/components/sidebar.rb')).to be_file
+    end
+
+    it 'component inherits from Component' do
+      scaffold.new.invoke(:component, nil, %w[sidebar])
+      content = File.read('page_objects/components/sidebar.rb')
+      expect(content).to include('class Sidebar < Component')
+    end
+
+    it 'component has frozen_string_literal' do
+      scaffold.new.invoke(:component, nil, %w[sidebar])
+      content = File.read('page_objects/components/sidebar.rb')
+      expect(content).to include('# frozen_string_literal: true')
+    end
+
+    it 'deletes a component' do
+      scaffold.new.invoke(:component, nil, %w[sidebar])
+      scaffold.new.invoke(:component, nil, %w[sidebar --delete])
+      expect(Pathname.new('page_objects/components/sidebar.rb')).not_to be_file
+    end
+  end
+
+  # --- Feature 10: Config-aware templates ---
+
+  describe 'config-aware templates' do
+    it 'page object includes url method when config has url' do
+      scaffold.new.invoke(:page, nil, %w[checkout])
+      content = File.read('page_objects/pages/checkout.rb')
+      expect(content).to include('def url(_page)')
+    end
+
+    it 'page object includes selenium-specific comments' do
+      scaffold.new.invoke(:page, nil, %w[checkout])
+      content = File.read('page_objects/pages/checkout.rb')
+      expect(content).to include('driver.find_element')
+    end
+
+    it 'spec includes let for page with driver' do
+      scaffold.new.invoke(:spec, nil, %w[checkout])
+      content = File.read('spec/checkout_page_spec.rb')
+      expect(content).to include('CheckoutPage.new(driver)')
+    end
+  end
+
+  # --- Feature 9: Relationships ---
+
+  describe 'relationships (--uses)' do
+    before do
+      File.write('page_objects/pages/login.rb', "class LoginPage < Page; end\n")
+    end
+
+    it 'adds require_relative for dependent pages' do
+      scaffold.new.invoke(:page, nil, %w[dashboard --uses login])
+      content = File.read('page_objects/pages/dashboard.rb')
+      expect(content).to include("require_relative 'login'")
+    end
+
+    it 'adds uses to spec as let declarations' do
+      scaffold.new.invoke(:spec, nil, %w[dashboard --uses login])
+      content = File.read('spec/dashboard_page_spec.rb')
+      expect(content).to include('LoginPage')
+    end
+  end
+
+  # --- Feature 1: Batch scaffold ---
+
+  describe 'batch scaffolding' do
+    it 'generates multiple scaffolds' do
+      scaffold.new.invoke(:scaffold, nil, %w[login dashboard])
+      expect(Pathname.new('page_objects/pages/login.rb')).to be_file
+      expect(Pathname.new('page_objects/pages/dashboard.rb')).to be_file
+      expect(Pathname.new('spec/login_page_spec.rb')).to be_file
+      expect(Pathname.new('spec/dashboard_page_spec.rb')).to be_file
+    end
+  end
+
+  # --- Feature 1: Selective --with ---
+
+  describe 'selective scaffolding (--with)' do
+    it 'generates only selected components' do
+      scaffold.new.invoke(:scaffold, nil, %w[checkout --with page])
+      expect(Pathname.new('page_objects/pages/checkout.rb')).to be_file
+      expect(Pathname.new('spec/checkout_page_spec.rb')).not_to be_file
+    end
+
+    it 'generates page and helper with --with' do
+      scaffold.new.invoke(:scaffold, nil, %w[checkout --with page helper])
+      expect(Pathname.new('page_objects/pages/checkout.rb')).to be_file
+      expect(Pathname.new('helpers/checkout_helper.rb')).to be_file
+    end
+
+    it 'generates model data with --with model' do
+      scaffold.new.invoke(:scaffold, nil, %w[user --with model])
+      expect(Pathname.new('models/data/user.yml')).to be_file
+    end
+  end
+
+  # --- Feature 5: CRUD ---
+
+  describe 'CRUD scaffolding' do
+    it 'generates CRUD pages' do
+      scaffold.new.invoke(:scaffold, nil, %w[user --crud])
+      %w[user_list user_create user_detail user_edit].each do |page|
+        expect(Pathname.new("page_objects/pages/#{page}.rb")).to be_file
+      end
+    end
+
+    it 'generates CRUD specs' do
+      scaffold.new.invoke(:scaffold, nil, %w[user --crud])
+      %w[user_list user_create user_detail user_edit].each do |page|
+        expect(Pathname.new("spec/#{page}_page_spec.rb")).to be_file
+      end
+    end
+
+    it 'generates model data file' do
+      scaffold.new.invoke(:scaffold, nil, %w[user --crud])
+      expect(Pathname.new('models/data/user.yml')).to be_file
+    end
+
+    it 'model data has expected structure' do
+      scaffold.new.invoke(:scaffold, nil, %w[user --crud])
+      content = File.read('models/data/user.yml')
+      expect(content).to include('default:')
+      expect(content).to include('valid:')
+      expect(content).to include('invalid:')
+    end
+  end
+
+  # --- Feature: Destroy command ---
+
+  describe 'destroy command' do
+    it 'removes page and spec files' do
+      scaffold.new.invoke(:scaffold, nil, %w[login])
+      expect(Pathname.new('page_objects/pages/login.rb')).to be_file
+      expect(Pathname.new('spec/login_page_spec.rb')).to be_file
+
+      scaffold.new.invoke(:destroy, nil, %w[login])
+      expect(Pathname.new('page_objects/pages/login.rb')).not_to be_file
+      expect(Pathname.new('spec/login_page_spec.rb')).not_to be_file
+    end
+
+    it 'removes only specified components with --with' do # rubocop:disable RSpec/MultipleExpectations
+      scaffold.new.invoke(:scaffold, nil, %w[checkout --with page spec helper])
+      expect(Pathname.new('page_objects/pages/checkout.rb')).to be_file
+      expect(Pathname.new('spec/checkout_page_spec.rb')).to be_file
+      expect(Pathname.new('helpers/checkout_helper.rb')).to be_file
+
+      scaffold.new.invoke(:destroy, nil, %w[checkout --with page helper])
+      expect(Pathname.new('page_objects/pages/checkout.rb')).not_to be_file
+      expect(Pathname.new('helpers/checkout_helper.rb')).not_to be_file
+      expect(Pathname.new('spec/checkout_page_spec.rb')).to be_file
+    end
+
+    it 'destroys multiple names at once' do
+      scaffold.new.invoke(:scaffold, nil, %w[login dashboard])
+      scaffold.new.invoke(:destroy, nil, %w[login dashboard])
+      expect(Pathname.new('page_objects/pages/login.rb')).not_to be_file
+      expect(Pathname.new('page_objects/pages/dashboard.rb')).not_to be_file
+    end
+  end
+
+  # --- Feature: Template overrides ---
+
+  describe 'template overrides' do
+    before do
+      FileUtils.mkdir_p('.ruby_raider/templates')
+    end
+
+    after do
+      FileUtils.rm_rf('.ruby_raider')
+    end
+
+    it 'uses override template when present' do
+      File.write('.ruby_raider/templates/page_object.tt', <<~ERB)
+        # Custom page for <%= class_name %>
+        class <%= page_class_name %> < Page
+          # CUSTOM OVERRIDE
+        end
+      ERB
+
+      Scaffolding.new(%w[widget]).generate_page
+      content = File.read('page_objects/pages/widget.rb')
+      expect(content).to include('CUSTOM OVERRIDE')
+      expect(content).to include('class WidgetPage < Page')
+    end
+
+    it 'falls back to default template when no override exists' do
+      Scaffolding.new(%w[gadget]).generate_page
+      content = File.read('page_objects/pages/gadget.rb')
+      expect(content).not_to include('CUSTOM OVERRIDE')
+      expect(content).to include('class GadgetPage < Page')
+    end
+  end
+
+  # --- Feature 3: Spec from page ---
+
+  describe 'spec from page (--from)' do
+    before do
+      File.write('page_objects/pages/login.rb', <<~RUBY)
+        class LoginPage < Page
+          def login(username, password)
+            username_field.send_keys username
+          end
+
+          def welcome_message
+            driver.find_element(css: '.welcome').text
+          end
+
+          private
+
+          def username_field
+            driver.find_element(id: 'username')
+          end
+        end
+      RUBY
+    end
+
+    it 'generates spec with method stubs' do
+      scaffold.new.invoke(:spec, nil, %w[login --from page_objects/pages/login.rb])
+      expect(Pathname.new('spec/login_spec.rb')).to be_file
+    end
+
+    it 'spec includes describe blocks for each public method' do
+      scaffold.new.invoke(:spec, nil, %w[login --from page_objects/pages/login.rb])
+      content = File.read('spec/login_spec.rb')
+      expect(content).to include("describe '#login'")
+      expect(content).to include("describe '#welcome_message'")
+    end
+
+    it 'spec does not include private methods' do
+      scaffold.new.invoke(:spec, nil, %w[login --from page_objects/pages/login.rb])
+      content = File.read('spec/login_spec.rb')
+      expect(content).not_to include('username_field')
+    end
+  end
+end