ruby_rabbitmq_janus 3.0.0.pre.358 → 3.0.0.pre.385

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d71f0e648c88b66a515f531f9363854ac8bfe3219412ab6c25dbbad0e35c49ae
-  data.tar.gz: f6188b1fff85bd230cc0d44356c879388eb32d809e70a26248c00261e5ff23de
+  metadata.gz: 4f2ca0d58fac3e63edecd2943918395a4fe895899fe50ebbe98404fab974f8a2
+  data.tar.gz: 18f8ef959a17619e9b2dedd2ca65f6ad407312230128ff5b7444d992ce78e381
 SHA512:
-  metadata.gz: ea2469541044db09a0b6fdfb34371f81cd441b7e2a8e566876628a88a2742b8be18e5af996eef47df3adf9d2a8076a5c562a0e4116a3b0a9bae2dc5b185133b7
-  data.tar.gz: b611d921872a181c05d4da95f7dddc75f032842fa48ba3435bba379465267b8e3674b99d84149e577d9252665156115bf9f0ba6894e0c091920542248aef4279
+  metadata.gz: 80b1d227f402bcb6df27f30e6e6ccf5f87e5dfc614dade152986f8ab5c146450cb4a7876eee551ebbce28dc9bcdd771e6746936a9f3dd4e4f76a30966106b313
+  data.tar.gz: fb2d220836e330d50c26b89fdfcb7cb393e10fd7d2e9c5cd8c54e0b3d79c1b95fce1da43a70db7e9ffeaea14b47a97201fe2128c8b6cfdd636ea145d6c25bd68

data/Rakefile

@@ -4,8 +4,7 @@ require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 
 # Exclude all spec with type :thread
-RSpec::Core::RakeTask.new(:spec) do |_t|
-end
+RSpec::Core::RakeTask.new(:spec)
 
 # Exclude all spec with type :thread
 RSpec::Core::RakeTask.new(:classic) do |t|

data/lib/generators/ruby_rabbitmq_janus/migration_generator.rb

@@ -16,11 +16,13 @@ module RubyRabbitmqJanus
 
         source_root File.expand_path('templates', __dir__)
 
+        # Prepare files for migration.
         def install
           migration_template 'migration.rb',
                              'db/migrate/create_ruby_rabbitmq_janus_tables.rb'
         end
 
+        # Determines the version number of the next migration.
         def self.next_migration_number(dirname)
           ActiveRecord::Generators::Base.next_migration_number(dirname)
         end

data/lib/rrj/errors/error.rb

@@ -20,7 +20,7 @@ module RubyRabbitmqJanus
 
       def write_error(message, level = :unknown)
         if defined?(::Log)
-          ::Log.send(level.class.eql?(Symbol) ? level : int_to_level(level),
+          ::Log.send(level.instance_of?(Symbol) ? level : int_to_level(level),
                      message)
         else
           p "#{level}, #{message}"

data/lib/rrj/janus/responses/admin.rb

@@ -7,55 +7,59 @@ module RubyRabbitmqJanus
       #
       # @see Example request response https://janus.conf.meetecho.com/docs/admin.html
       class Admin < Standard
-        # List of sessions running in Janus Instance.
-        #
-        # @return [Array] List of sessions
+        # @return [Array] List of sessions running in Janus Instance.
         def sessions
           read_data(__method__.to_s)
         end
 
-        # List of handles running in one session in Janus Instance.
-        #
-        # @return [Array] List of handles
+        # @return [Array] List of handles running
+        #   in one session in Janus Instance.
         def handles
           read_data(__method__.to_s)
         end
 
-        # Info to session or handle in Janus Instance
-        #
-        # @return [Hash] Information to session/handle
+        # @return [Hash] Information to session/handle in Janus Instance.
         def info
           read_data(__method__.to_s)
         end
 
+        # @return [Boolean] Information status to debug  mode for libnice.
         def libnice_debug
           read_data(__method__.to_s)
         end
 
+        # @return [Boolean] Information status to debug mode
+        #   in Janus Intance on the fly.
         def locking_debug
           read_data(__method__.to_s)
         end
 
+        # @return [Boolean] Information about color in log messages.
         def log_colors
           read_data(__method__.to_s)
         end
 
+        # @return [Integer] Level to debug mode to Janus Instance.
         def level
           read_data(__method__.to_s)
         end
 
+        # @return [Boolean] Status to timestampping for log messages.
         def log_timestamps
           read_data(__method__.to_s)
         end
 
+        # @return [Integer] Level to max nack queue configured.
         def max_nack_queue
           read_data(__method__.to_s)
         end
 
+        # @return [Integer] No-media timer property.
         def no_media_timer
           read_data(__method__.to_s)
         end
 
+        # @return [Integer] Timeout for session.
         def timeout
           read_data(__method__.to_s)
         end

data/lib/rrj/janus/responses/error.rb

@@ -143,11 +143,9 @@ module RubyRabbitmqJanus
 
         def respond_to_missing?(name, include_private); end
 
-        # rubocop:disable Style/MethodMissingSuper
         def method_missing(_method, request)
           default_error(request)
         end
-        # rubocop:enable Style/MethodMissingSuper
 
         def default_error(request)
           raise RubyRabbitmqJanus::Errors::Janus::Responses::Nok, request

data/lib/rrj/janus/responses/rspec.rb

@@ -7,6 +7,8 @@ module RubyRabbitmqJanus
     module Responses
       # Response for RSpec initializer
       class RSpec
+        # Constructor to RSpec response.
+        # Create a fake response for testing library.
         def initialize(type)
           path = RubyRabbitmqJanus::Tools::Config.instance.rspec_response
           @json = File.join(Dir.pwd,

data/lib/rrj/janus/responses/standard.rb

@@ -18,6 +18,7 @@ module RubyRabbitmqJanus
           data_id
         end
 
+        # Read value created by janus for session/handle message
         def sender
           raise_data
 

data/lib/rrj/janus/transactions/handle.rb

@@ -70,11 +70,13 @@ module RubyRabbitmqJanus
           @handle = send_a_message_exclusive { msg }
         end
 
+        # rubocop:disable Style/ExplicitBlockArgument
         def send_a_message_exclusive
           Janus::Responses::Standard.new(read_response_exclusive do
             yield
           end).sender
         end
+        # rubocop:enable Style/ExplicitBlockArgument
 
         def read_response_exclusive
           chan = rabbit.channel

data/lib/rrj/janus/transactions/rspec.rb

@@ -4,6 +4,8 @@ module RubyRabbitmqJanus
   module Janus
     module Transactions
       # Transaction for RSpec initializer
+      # @!attribute [r] response
+      #     Given a Janus response
       class RSpec
         attr_reader :response
 

data/lib/rrj/janus/transactions/session.rb

@@ -28,6 +28,7 @@ module RubyRabbitmqJanus
           end
         end
 
+        # Publish a message to "standard" RabbitMQ queue.
         def publish_message(type, options = {})
           msg = Janus::Messages::Standard.new(type, opts.merge!(options))
           response = read_response(publisher.publish(msg))

data/lib/rrj/models/active_record.rb

@@ -31,9 +31,12 @@ module RubyRabbitmqJanus
       # @param attributes [Array] List to attribute to delete in document
       #
       # @return [Hash] Current model
+      #
+      # rubocop:disable Style/HashTransformValues
       def unset(attributes)
         Hash[attributes.map { |key, _value| [key, nil] }]
       end
+      # rubocop:enable Style/HashTransformValues
     end
   end
 end

data/lib/rrj/process/concurrency.rb

@@ -27,13 +27,18 @@ module RubyRabbitmqJanus
         def initialize_thread
           @rabbit.transaction_long { transaction_running }
         rescue Interrupt
+          ::Log.warn "This process has been interupted #{class_name}"
           ::Log.warn \
-            "Close a connection with RabbitMQ instance for #{self.class.name}"
+            "Close a connection with RabbitMQ instance for #{class_name}"
           @rabbit.close
         end
 
         def info_thread
-          "Create an thread -- #{self.class.name}"
+          "Create an thread -- #{class_name}"
+        end
+
+        def class_name
+          self.class.name
         end
       end
     end

data/lib/rrj/process/thread_runner_concern.rb

@@ -31,7 +31,7 @@ module RubyRabbitmqJanus
           #
           # @return [Thread] It's a thread who listen queue and execute action
           def run(&block)
-            raise_nil_block unless block_given?
+            raise_nil_block unless block
 
             @thread.join
             Thread.new do

data/lib/rrj/rabbit/base_event.rb

@@ -10,9 +10,9 @@ module RubyRabbitmqJanus
     # # Parent class for all publisher
     # This element send and read a message in rabbitmq Queue
     #
-    # @!attribute [r] response
+    # @!attribute [r] responses
     #   @return [RubyRabbitmqJanus::Janus::Responses::Response]
-    #     Given a Janus response
+    #     Given an array of Janus response
     #
     # @abstract Publish message in RabbitMQ
     class BaseEvent

data/lib/rrj/rabbit/connect.rb

@@ -14,10 +14,17 @@ module RubyRabbitmqJanus
       end
 
       # Create an transaction with rabbitmq and close after response is received
-      def transaction_short
-        raise Errors::Rabbit::Connect::MissingAction unless block_given?
+      def transaction_short(&block)
+        raise Errors::Rabbit::Connect::MissingAction unless block
+
+        response = nil
 
-        response = transaction_long { yield }
+        Timeout.timeout(5) do
+          response = transaction_long(&block)
+        end
+      rescue Timeout::Error
+        ::Log.error 'The "Short transaction" have raised Timeout exception.'
+      ensure
         close
         response
       end
@@ -30,6 +37,8 @@ module RubyRabbitmqJanus
           start
           yield
         end
+      rescue Timeout::Error
+        ::Log.error 'The "Long transaction" have raised Timeout exception.'
       end
 
       # Opening a connection with RabbitMQ
@@ -50,7 +59,15 @@ module RubyRabbitmqJanus
       private
 
       def bunny_conf
-        Tools::Config.instance.server_settings.merge(connection_timeout: 5)
+        Tools::Config.instance.server_settings.merge(bunny_conf_static)
+      end
+
+      def bunny_conf_static
+        {
+          connection_timeout: 5,
+          connection_name: "[#{rand(999)}] backend",
+          recover_from_connection_close: false
+        }
       end
     end
   end

data/lib/rrj/rabbit/listener/base.rb

@@ -36,7 +36,7 @@ module RubyRabbitmqJanus
         end
 
         def opts_subs
-          { block: false, manual_ack: true, arguments: { 'x-priority': 2 } }
+          { block: false, manual_ack: false, arguments: { 'x-priority': 2 } }
         end
 
         def info_subscribe(info, _prop, payload)
@@ -51,6 +51,22 @@ module RubyRabbitmqJanus
           raise Errors::Rabbit::Listener::ResponseEmpty, response \
             if response.to_hash.size.zero?
         end
+
+        def subscribe_queue
+          rabbit.prefetch(1)
+          reply.bind(binding).subscribe(opts_subs) do |info, prop, payload|
+            info_subscribe(info, prop, payload)
+            synchronize_response(payload)
+          end
+        end
+
+        def synchronize_response(payload)
+          lock.synchronize do
+            response = response_class(payload)
+            responses.push(response)
+          end
+          semaphore.signal
+        end
       end
     end
   end

data/lib/rrj/rabbit/listener/from.rb

@@ -15,21 +15,8 @@ module RubyRabbitmqJanus
           rabbit.queue(Tools::Config.instance.queue_from)
         end
 
-        def subscribe_queue
-          rabbit.prefetch(1)
-          reply.bind(binding).subscribe(opts_subs) do |info, prop, payload|
-            info_subscribe(info, prop, payload)
-            synchronize_response(info, payload)
-          end
-        end
-
-        def synchronize_response(info, payload)
-          lock.synchronize do
-            response = Janus::Responses::Event.new(JSON.parse(payload))
-            responses.push(response)
-          end
-          rabbit.acknowledge(info.delivery_tag, false)
-          semaphore.signal
+        def response_class(payload)
+          Janus::Responses::Event.new(JSON.parse(payload))
         end
       end
     end

data/lib/rrj/rabbit/listener/from_admin.rb

@@ -15,21 +15,8 @@ module RubyRabbitmqJanus
           rabbit.queue(Tools::Config.instance.queue_admin_from)
         end
 
-        def subscribe_queue
-          rabbit.prefetch(1)
-          reply.bind(binding).subscribe(opts_subs) do |info, prop, payload|
-            info_subscribe(info, prop, payload)
-            synchronize_response(info, payload)
-          end
-        end
-
-        def synchronize_response(info, payload)
-          lock.synchronize do
-            response = Janus::Responses::Admin.new(JSON.parse(payload))
-            responses.push(response)
-          end
-          rabbit.acknowledge(info.delivery_tag, false)
-          semaphore.signal
+        def response_class(payload)
+          Janus::Responses::Admin.new(JSON.parse(payload))
         end
       end
     end

data/lib/rrj/rabbit/publisher/non_exclusive.rb

@@ -17,9 +17,12 @@ module RubyRabbitmqJanus
         # Send an message to queue
         #
         # @param [String] request JSON request sending to rabbitmq queue
+        #
+        # rubocop:disable Lint/UselessMethodDefinition
         def publish(request)
           super(request)
         end
+        # rubocop:enable Lint/UselessMethodDefinition
       end
     end
   end

data/lib/rrj/rspec.rb

@@ -9,20 +9,25 @@ module RubyRabbitmqJanus
   #
   # Initializer to use with RSpec execution
   class RRJRSpec < RRJTaskAdmin
+    # rubocop:disable Lint/MissingSuper
     def initialize
       RubyRabbitmqJanus::Tools::Config.instance
     end
+    # rubocop:enable Lint/MissingSuper
 
+    # @see RubyRabbitmqJanus::RRJ::session_endpoint_public
     def session_endpoint_public(_options)
       yield(RubyRabbitmqJanus::Janus::Transactions::RSpec.new)
     end
 
+    # @see RubyRabbitmqJanus::RRJ::session_endpoint_private
     def handle_endpoint_public(_options)
       transaction = RubyRabbitmqJanus::Janus::Transactions::RSpec.new
       yield(transaction)
       transaction.response
     end
 
+    # @see RubyRabbitmqJanus::RRJAdmin::admin_endpoint
     def admin_endpoint(_options)
       yield(RubyRabbitmqJanus::Janus::Transactions::RSpec.new)
     end

data/lib/rrj/task.rb

@@ -9,10 +9,12 @@ module RubyRabbitmqJanus
   #
   # This class is used with rake task.
   class RRJTask < RRJ
+    # rubocop:disable Lint/MissingSuper
     def initialize
       Tools::Config.instance
       Tools::Requests.instance
     end
+    # rubocop:enable Lint/MissingSuper
 
     # Create a transaction between Apps and Janus in queue private
     #

data/lib/rrj/tools/gem/config/gem.rb

@@ -12,7 +12,7 @@ module RubyRabbitmqJanus
     module ConfigGem
       # @return [Boolean] Read option file for a janus cluster section
       def cluster
-        @options['gem']['cluster']['enabled'].to_s.match?('true') ? true : false
+        @options['gem']['cluster']['enabled'].to_s.match?('true')
       end
 
       # @return [Symbol] read configuration for log level used in this gem

data/lib/rrj/tools/gem/logger.rb

@@ -41,7 +41,6 @@ module RubyRabbitmqJanus
       # Choose type logger used in application instance
       def self.initialize_logger
         case @config.log_type
-        when :stdout  then logger_stdout
         when :file    then logger_file
         when :remote  then logger_remote
         else
@@ -51,7 +50,7 @@ module RubyRabbitmqJanus
 
       # Configure logger with output SDTOUT
       def self.logger_stdout
-        ::Logger.new(STDOUT)
+        ::Logger.new($stdout)
       end
 
       # Configure logger with output file